Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

2021-08-16 Thread David Blaikie via cfe-commits 
Ah, thanks for the details!

On Mon, Aug 16, 2021 at 1:26 PM Kostya Kortchinsky 
wrote:

> Apologies.
> As explained in another thread, this was a mistake of mine as I reverted 2
> CLs instead of 1 (mine).
> This was resolved with the original author.
> My own CL ended up breaking some 32-bit builders.
>
> On Mon, Aug 16, 2021 at 1:22 PM David Blaikie  wrote:
>
>> Please include in the commit message a reason for a revert.
>>
>> On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>>
>>> Author: Kostya Kortchinsky
>>> Date: 2021-08-16T11:13:05-07:00
>>> New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384
>>>
>>> URL:
>>> https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384
>>> DIFF:
>>> https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384.diff
>>>
>>> LOG: Revert "[NFC] Fix typos"
>>>
>>> This reverts commit b7425e956be60a73004d7ae5bb37da85872c29fb.
>>>
>>> Added:
>>>
>>>
>>> Modified:
>>> clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>>> clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>>> compiler-rt/test/profile/Linux/instrprof-cs.c
>>> llvm/include/llvm/Transforms/Instrumentation.h
>>> llvm/lib/ProfileData/SampleProfReader.cpp
>>>
>>> Removed:
>>>
>>>
>>>
>>>
>>> 
>>> diff  --git
>>> a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>>> b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>>> index a13de306eac84..175dfcef0df45 100644
>>> --- a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>>> +++ b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>>> @@ -6,7 +6,7 @@
>>>  //
>>>
>>>  
>>> //===--===//
>>>  //
>>> -//  This file defines a CheckObjCInstMethSignature, a flow-insensitive
>>> check
>>> +//  This file defines a CheckObjCInstMethSignature, a flow-insenstive
>>> check
>>>  //  that determines if an Objective-C class interface incorrectly
>>> redefines
>>>  //  the method signature in a subclass.
>>>  //
>>>
>>> diff  --git a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>>> b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>>> index dcca8be55e337..90c5583d89691 100644
>>> --- a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>>> +++ b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>>> @@ -6,7 +6,7 @@
>>>  //
>>>
>>>  
>>> //===--===//
>>>  //
>>> -//  This file defines a CheckNSError, a flow-insensitive check
>>> +//  This file defines a CheckNSError, a flow-insenstive check
>>>  //  that determines if an Objective-C class interface correctly returns
>>>  //  a non-void return type.
>>>  //
>>>
>>> diff  --git a/compiler-rt/test/profile/Linux/instrprof-cs.c
>>> b/compiler-rt/test/profile/Linux/instrprof-cs.c
>>> index 0ad6f0350c560..d825525a532db 100644
>>> --- a/compiler-rt/test/profile/Linux/instrprof-cs.c
>>> +++ b/compiler-rt/test/profile/Linux/instrprof-cs.c
>>> @@ -8,7 +8,7 @@
>>>  // RUN: %clang_profgen=%t.profraw -o %t.gen.cis -O2 %s
>>>  // RUN: %run %t.gen.cis
>>>  // RUN: llvm-profdata merge -o %t.cis.profdata %t.profraw
>>> -// Check context insensitive profile
>>> +// Check context insenstive profile
>>>  // RUN: %clang_profuse=%t.cis.profdata  -O2 -emit-llvm -S %s -o - |
>>> FileCheck %s --check-prefix=CIS
>>>  int g1 = 1;
>>>  int volatile g2 = 2;
>>>
>>> diff  --git a/llvm/include/llvm/Transforms/Instrumentation.h
>>> b/llvm/include/llvm/Transforms/Instrumentation.h
>>> index 0c822999aecf3..03108bacb0da5 100644
>>> --- a/llvm/include/llvm/Transforms/Instrumentation.h
>>> +++ b/llvm/include/llvm/Transforms/Instrumentation.h
>>> @@ -78,7 +78,7 @@ struct GCOVOptions {
>>>  ModulePass *createGCOVProfilerPass(const GCOVOptions  =
>>> GCOVOptions::getDefault());
>>>
>>> -// PGO Instrumention. Parameter IsCS indicates if this is the context
>>> sensitive
>>> +// PGO Instrumention. Parameter IsCS indicates if this is the context
>>> senstive
>>>  // instrumentation.
>>>  ModulePass *createPGOInstrumentationGenLegacyPass(bool IsCS = false);
>>>  ModulePass *
>>> @@ -138,7 +138,7 @@ struct InstrProfOptions {
>>>  };
>>>
>>>  /// Insert frontend instrumentation based profiling. Parameter IsCS
>>> indicates if
>>> -// this is the context sensitive instrumentation.
>>> +// this is the context senstive instrumentation.
>>>  ModulePass *createInstrProfilingLegacyPass(
>>>  const InstrProfOptions  = InstrProfOptions(), bool IsCS =
>>> false);
>>>
>>>
>>> diff  --git a/llvm/lib/ProfileData/SampleProfReader.cpp
>>> b/llvm/lib/ProfileData/SampleProfReader.cpp
>>> index a801ca1ef36d7..6058eddb13dc7 100644
>>> --- a/llvm/lib/ProfileData/SampleProfReader.cpp
>>> +++

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

2021-08-16 Thread Kostya Kortchinsky via cfe-commits 
Apologies.
As explained in another thread, this was a mistake of mine as I reverted 2
CLs instead of 1 (mine).
This was resolved with the original author.
My own CL ended up breaking some 32-bit builders.

On Mon, Aug 16, 2021 at 1:22 PM David Blaikie  wrote:

> Please include in the commit message a reason for a revert.
>
> On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>>
>> Author: Kostya Kortchinsky
>> Date: 2021-08-16T11:13:05-07:00
>> New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384
>>
>> URL:
>> https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384
>> DIFF:
>> https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384.diff
>>
>> LOG: Revert "[NFC] Fix typos"
>>
>> This reverts commit b7425e956be60a73004d7ae5bb37da85872c29fb.
>>
>> Added:
>>
>>
>> Modified:
>> clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>> clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>> compiler-rt/test/profile/Linux/instrprof-cs.c
>> llvm/include/llvm/Transforms/Instrumentation.h
>> llvm/lib/ProfileData/SampleProfReader.cpp
>>
>> Removed:
>>
>>
>>
>>
>> 
>> diff  --git
>> a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>> b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>> index a13de306eac84..175dfcef0df45 100644
>> --- a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>> +++ b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
>> @@ -6,7 +6,7 @@
>>  //
>>
>>  
>> //===--===//
>>  //
>> -//  This file defines a CheckObjCInstMethSignature, a flow-insensitive
>> check
>> +//  This file defines a CheckObjCInstMethSignature, a flow-insenstive
>> check
>>  //  that determines if an Objective-C class interface incorrectly
>> redefines
>>  //  the method signature in a subclass.
>>  //
>>
>> diff  --git a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>> b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>> index dcca8be55e337..90c5583d89691 100644
>> --- a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>> +++ b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
>> @@ -6,7 +6,7 @@
>>  //
>>
>>  
>> //===--===//
>>  //
>> -//  This file defines a CheckNSError, a flow-insensitive check
>> +//  This file defines a CheckNSError, a flow-insenstive check
>>  //  that determines if an Objective-C class interface correctly returns
>>  //  a non-void return type.
>>  //
>>
>> diff  --git a/compiler-rt/test/profile/Linux/instrprof-cs.c
>> b/compiler-rt/test/profile/Linux/instrprof-cs.c
>> index 0ad6f0350c560..d825525a532db 100644
>> --- a/compiler-rt/test/profile/Linux/instrprof-cs.c
>> +++ b/compiler-rt/test/profile/Linux/instrprof-cs.c
>> @@ -8,7 +8,7 @@
>>  // RUN: %clang_profgen=%t.profraw -o %t.gen.cis -O2 %s
>>  // RUN: %run %t.gen.cis
>>  // RUN: llvm-profdata merge -o %t.cis.profdata %t.profraw
>> -// Check context insensitive profile
>> +// Check context insenstive profile
>>  // RUN: %clang_profuse=%t.cis.profdata  -O2 -emit-llvm -S %s -o - |
>> FileCheck %s --check-prefix=CIS
>>  int g1 = 1;
>>  int volatile g2 = 2;
>>
>> diff  --git a/llvm/include/llvm/Transforms/Instrumentation.h
>> b/llvm/include/llvm/Transforms/Instrumentation.h
>> index 0c822999aecf3..03108bacb0da5 100644
>> --- a/llvm/include/llvm/Transforms/Instrumentation.h
>> +++ b/llvm/include/llvm/Transforms/Instrumentation.h
>> @@ -78,7 +78,7 @@ struct GCOVOptions {
>>  ModulePass *createGCOVProfilerPass(const GCOVOptions  =
>> GCOVOptions::getDefault());
>>
>> -// PGO Instrumention. Parameter IsCS indicates if this is the context
>> sensitive
>> +// PGO Instrumention. Parameter IsCS indicates if this is the context
>> senstive
>>  // instrumentation.
>>  ModulePass *createPGOInstrumentationGenLegacyPass(bool IsCS = false);
>>  ModulePass *
>> @@ -138,7 +138,7 @@ struct InstrProfOptions {
>>  };
>>
>>  /// Insert frontend instrumentation based profiling. Parameter IsCS
>> indicates if
>> -// this is the context sensitive instrumentation.
>> +// this is the context senstive instrumentation.
>>  ModulePass *createInstrProfilingLegacyPass(
>>  const InstrProfOptions  = InstrProfOptions(), bool IsCS =
>> false);
>>
>>
>> diff  --git a/llvm/lib/ProfileData/SampleProfReader.cpp
>> b/llvm/lib/ProfileData/SampleProfReader.cpp
>> index a801ca1ef36d7..6058eddb13dc7 100644
>> --- a/llvm/lib/ProfileData/SampleProfReader.cpp
>> +++ b/llvm/lib/ProfileData/SampleProfReader.cpp
>> @@ -53,7 +53,7 @@ using namespace sampleprof;
>>  // For ext-binary format profiles, the flag is set in the summary.
>>  static cl::opt ProfileIsFSDisciminator(
>>  "profile-isfs", cl::Hidden,

Re: [clang] 80ed75e - Revert "[NFC] Fix typos"

2021-08-16 Thread David Blaikie via cfe-commits 
Please include in the commit message a reason for a revert.

On Mon, Aug 16, 2021 at 11:14 AM Kostya Kortchinsky via cfe-commits <
cfe-commits@lists.llvm.org> wrote:

>
> Author: Kostya Kortchinsky
> Date: 2021-08-16T11:13:05-07:00
> New Revision: 80ed75e7fb45f9f5fc84ca7cbe258be036015384
>
> URL:
> https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384
> DIFF:
> https://github.com/llvm/llvm-project/commit/80ed75e7fb45f9f5fc84ca7cbe258be036015384.diff
>
> LOG: Revert "[NFC] Fix typos"
>
> This reverts commit b7425e956be60a73004d7ae5bb37da85872c29fb.
>
> Added:
>
>
> Modified:
> clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
> clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
> compiler-rt/test/profile/Linux/instrprof-cs.c
> llvm/include/llvm/Transforms/Instrumentation.h
> llvm/lib/ProfileData/SampleProfReader.cpp
>
> Removed:
>
>
>
>
> 
> diff  --git
> a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
> b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
> index a13de306eac84..175dfcef0df45 100644
> --- a/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
> +++ b/clang/lib/StaticAnalyzer/Checkers/CheckObjCInstMethSignature.cpp
> @@ -6,7 +6,7 @@
>  //
>
>  
> //===--===//
>  //
> -//  This file defines a CheckObjCInstMethSignature, a flow-insensitive
> check
> +//  This file defines a CheckObjCInstMethSignature, a flow-insenstive
> check
>  //  that determines if an Objective-C class interface incorrectly
> redefines
>  //  the method signature in a subclass.
>  //
>
> diff  --git a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
> b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
> index dcca8be55e337..90c5583d89691 100644
> --- a/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
> +++ b/clang/lib/StaticAnalyzer/Checkers/NSErrorChecker.cpp
> @@ -6,7 +6,7 @@
>  //
>
>  
> //===--===//
>  //
> -//  This file defines a CheckNSError, a flow-insensitive check
> +//  This file defines a CheckNSError, a flow-insenstive check
>  //  that determines if an Objective-C class interface correctly returns
>  //  a non-void return type.
>  //
>
> diff  --git a/compiler-rt/test/profile/Linux/instrprof-cs.c
> b/compiler-rt/test/profile/Linux/instrprof-cs.c
> index 0ad6f0350c560..d825525a532db 100644
> --- a/compiler-rt/test/profile/Linux/instrprof-cs.c
> +++ b/compiler-rt/test/profile/Linux/instrprof-cs.c
> @@ -8,7 +8,7 @@
>  // RUN: %clang_profgen=%t.profraw -o %t.gen.cis -O2 %s
>  // RUN: %run %t.gen.cis
>  // RUN: llvm-profdata merge -o %t.cis.profdata %t.profraw
> -// Check context insensitive profile
> +// Check context insenstive profile
>  // RUN: %clang_profuse=%t.cis.profdata  -O2 -emit-llvm -S %s -o - |
> FileCheck %s --check-prefix=CIS
>  int g1 = 1;
>  int volatile g2 = 2;
>
> diff  --git a/llvm/include/llvm/Transforms/Instrumentation.h
> b/llvm/include/llvm/Transforms/Instrumentation.h
> index 0c822999aecf3..03108bacb0da5 100644
> --- a/llvm/include/llvm/Transforms/Instrumentation.h
> +++ b/llvm/include/llvm/Transforms/Instrumentation.h
> @@ -78,7 +78,7 @@ struct GCOVOptions {
>  ModulePass *createGCOVProfilerPass(const GCOVOptions  =
> GCOVOptions::getDefault());
>
> -// PGO Instrumention. Parameter IsCS indicates if this is the context
> sensitive
> +// PGO Instrumention. Parameter IsCS indicates if this is the context
> senstive
>  // instrumentation.
>  ModulePass *createPGOInstrumentationGenLegacyPass(bool IsCS = false);
>  ModulePass *
> @@ -138,7 +138,7 @@ struct InstrProfOptions {
>  };
>
>  /// Insert frontend instrumentation based profiling. Parameter IsCS
> indicates if
> -// this is the context sensitive instrumentation.
> +// this is the context senstive instrumentation.
>  ModulePass *createInstrProfilingLegacyPass(
>  const InstrProfOptions  = InstrProfOptions(), bool IsCS =
> false);
>
>
> diff  --git a/llvm/lib/ProfileData/SampleProfReader.cpp
> b/llvm/lib/ProfileData/SampleProfReader.cpp
> index a801ca1ef36d7..6058eddb13dc7 100644
> --- a/llvm/lib/ProfileData/SampleProfReader.cpp
> +++ b/llvm/lib/ProfileData/SampleProfReader.cpp
> @@ -53,7 +53,7 @@ using namespace sampleprof;
>  // For ext-binary format profiles, the flag is set in the summary.
>  static cl::opt ProfileIsFSDisciminator(
>  "profile-isfs", cl::Hidden, cl::init(false),
> -cl::desc("Profile uses flow sensitive discriminators"));
> +cl::desc("Profile uses flow senstive discriminators"));
>
>  /// Dump the function profile for \p FName.
>  ///
>
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>