Re: r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89
Sorry, but my patch is not reverted, and as for now it only reads: Failing Tests (2): LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.ll LLVM :: CodeGen/AMDGPU/mubuf-legalize-operands.mir So I'm considering it was a side-effect of some other test. On 09/05/2018 10:00 PM, Galina Kistanova wrote: Hello Diogo, This commit added couple of broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win . . . Failing Tests (5): Clang :: Headers/arm-fp16-header.c Clang :: Headers/arm-neon-header.c . . . Please have a look? The builder was already red and did not send notifications on this. Thanks Galina On Wed, Sep 5, 2018 at 7:59 AM Diogo N. Sampaio via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: dnsampaio Date: Wed Sep 5 07:56:21 2018 New Revision: 341475 URL: http://llvm.org/viewvc/llvm-project?rev=341475=rev Log: Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89 Summary: The inline attribute is not valid for C standard 89. Replace the argument in the generation of header files with __inline, as well adding tests for both header files. Reviewers: pbarrio, SjoerdMeijer, javed.absar, t.p.northover Subscribers: t.p.northover, kristof.beyls, chrib, cfe-commits Differential Revision: https://reviews.llvm.org/D51683 test/Headers/arm-fp16-header.c test/Headers/arm-neon-header.c utils/TableGen/NeonEmitter.cpp Added: cfe/trunk/test/Headers/arm-fp16-header.c Modified: cfe/trunk/test/Headers/arm-neon-header.c cfe/trunk/utils/TableGen/NeonEmitter.cpp Added: cfe/trunk/test/Headers/arm-fp16-header.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-fp16-header.c?rev=341475=auto == --- cfe/trunk/test/Headers/arm-fp16-header.c (added) +++ cfe/trunk/test/Headers/arm-fp16-header.c Wed Sep 5 07:56:21 2018 @@ -0,0 +1,19 @@ +// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s + +// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s + +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s + +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s + +#include Modified: cfe/trunk/test/Headers/arm-neon-header.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-neon-header.c?rev=341475=341474=341475=diff == --- cfe/trunk/test/Headers/arm-neon-header.c (original) +++ cfe/trunk/test/Headers/arm-neon-header.c Wed Sep 5 07:56:21 2018 @@ -2,4 +2,23 @@ // RUN: %clang_cc1 -triple thumbv7-apple-darwin10 -target-cpu cortex-a8 -fsyntax-only -fno-lax-vector-conversions -ffreestanding %s // RUN: %clang_cc1 -x c++ -triple thumbv7-apple-darwin10 -target-cpu cortex-a8 -fsyntax-only -Wvector-conversions -ffreestanding %s +// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s + +// RUN: %clang -fsyntax-only -ffreestanding --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s +// RUN: %clang -fsyntax-only -Wall -Werror
Re: r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89
On Wed, Sep 05, 2018 at 02:56:21PM -, Diogo N. Sampaio via cfe-commits wrote: > Author: dnsampaio > Date: Wed Sep 5 07:56:21 2018 > New Revision: 341475 > > URL: http://llvm.org/viewvc/llvm-project?rev=341475=rev > Log: > Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89 As I wrote on the differential, this is just wrong. __inline is *not* a keyword. Joerg ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: r341475 - Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89
Hello Diogo, This commit added couple of broken tests to one of our builders: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win . . . Failing Tests (5): Clang :: Headers/arm-fp16-header.c Clang :: Headers/arm-neon-header.c . . . Please have a look? The builder was already red and did not send notifications on this. Thanks Galina On Wed, Sep 5, 2018 at 7:59 AM Diogo N. Sampaio via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dnsampaio > Date: Wed Sep 5 07:56:21 2018 > New Revision: 341475 > > URL: http://llvm.org/viewvc/llvm-project?rev=341475=rev > Log: > Fix arm_neon.h and arm_fp16.h generation for compiling with std=c89 > > > Summary: > The inline attribute is not valid for C standard 89. Replace the argument > in the generation of header files with __inline, as well adding tests for > both header files. > > Reviewers: pbarrio, SjoerdMeijer, javed.absar, t.p.northover > > Subscribers: t.p.northover, kristof.beyls, chrib, cfe-commits > > Differential Revision: https://reviews.llvm.org/D51683 > > test/Headers/arm-fp16-header.c > test/Headers/arm-neon-header.c > utils/TableGen/NeonEmitter.cpp > > Added: > cfe/trunk/test/Headers/arm-fp16-header.c > Modified: > cfe/trunk/test/Headers/arm-neon-header.c > cfe/trunk/utils/TableGen/NeonEmitter.cpp > > Added: cfe/trunk/test/Headers/arm-fp16-header.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-fp16-header.c?rev=341475=auto > > == > --- cfe/trunk/test/Headers/arm-fp16-header.c (added) > +++ cfe/trunk/test/Headers/arm-fp16-header.c Wed Sep 5 07:56:21 2018 > @@ -0,0 +1,19 @@ > +// RUN: %clang -fsyntax-only -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s > + > +// RUN: %clang -fsyntax-only -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s > + > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s > + > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++98 -xc++ %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++11 -xc++ %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++14 -xc++ %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c++17 -xc++ %s > + > +#include > > Modified: cfe/trunk/test/Headers/arm-neon-header.c > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/arm-neon-header.c?rev=341475=341474=341475=diff > > == > --- cfe/trunk/test/Headers/arm-neon-header.c (original) > +++ cfe/trunk/test/Headers/arm-neon-header.c Wed Sep 5 07:56:21 2018 > @@ -2,4 +2,23 @@ > // RUN: %clang_cc1 -triple thumbv7-apple-darwin10 -target-cpu cortex-a8 > -fsyntax-only -fno-lax-vector-conversions -ffreestanding %s > // RUN: %clang_cc1 -x c++ -triple thumbv7-apple-darwin10 -target-cpu > cortex-a8 -fsyntax-only -Wvector-conversions -ffreestanding %s > > +// RUN: %clang -fsyntax-only -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-arm-none-eabi -march=armv8.2-a+fp16 -std=c11 -xc %s > + > +// RUN: %clang -fsyntax-only -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c89 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding > --target=aarch64-armeb-none-eabi -march=armv8.2-a+fp16 -std=c99 -xc %s > +// RUN: %clang -fsyntax-only -Wall -Werror -ffreestanding >
