Re: clang-format: Fix deref treated as binary op in throw
Thx. Submitted as r308185. On Mon, Jul 17, 2017 at 4:28 PM Erik Uhlmann <euhlm...@vmware.com> wrote: > I don’t have commit access, so I’d need you to check it in. Thanks for > your help! > > > > *From: *Manuel Klimek <kli...@google.com> > *Date: *Monday, July 17, 2017 at 03:31 > *To: *Erik Uhlmann <euhlm...@vmware.com>, "cfe-commits@lists.llvm.org" < > cfe-commits@lists.llvm.org> > *Subject: *Re: clang-format: Fix deref treated as binary op in throw > > > > LG, thanks for the patch. For next time, it helps to use phabricator to > make people catch patches faster :) > > > > Do you have commit access or do you need me to check it in? > > > > On Thu, Jul 6, 2017 at 6:53 PM Erik Uhlmann via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > When dereferencing a pointer in a throw statement, clang-format assigns > TT_BinaryOperator to the star token, so it gets formatted as: > > throw * x; > > With this change the above becomes > > throw *x; > > Bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665 > <https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.llvm.org_show-5Fbug.cgi-3Fid-3D33665=DwMFaQ=uilaK90D4TOVoH58JNXRgQ=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s=3S0gX68mvOabDGdTODcMBbmYJB4pHnUzRN3mNNwVGzc=> > > Attached is a patch containing the fix. > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits=DwMFaQ=uilaK90D4TOVoH58JNXRgQ=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s=TfTlgUj10Yo0COkFwEotZwRfb7Z5DnI_f8ENR3mpd3k=> > > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: clang-format: Fix deref treated as binary op in throw
I don’t have commit access, so I’d need you to check it in. Thanks for your help! From: Manuel Klimek <kli...@google.com> Date: Monday, July 17, 2017 at 03:31 To: Erik Uhlmann <euhlm...@vmware.com>, "cfe-commits@lists.llvm.org" <cfe-commits@lists.llvm.org> Subject: Re: clang-format: Fix deref treated as binary op in throw LG, thanks for the patch. For next time, it helps to use phabricator to make people catch patches faster :) Do you have commit access or do you need me to check it in? On Thu, Jul 6, 2017 at 6:53 PM Erik Uhlmann via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: When dereferencing a pointer in a throw statement, clang-format assigns TT_BinaryOperator to the star token, so it gets formatted as: throw * x; With this change the above becomes throw *x; Bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665<https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.llvm.org_show-5Fbug.cgi-3Fid-3D33665=DwMFaQ=uilaK90D4TOVoH58JNXRgQ=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s=3S0gX68mvOabDGdTODcMBbmYJB4pHnUzRN3mNNwVGzc=> Attached is a patch containing the fix. ___ cfe-commits mailing list cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Dcommits=DwMFaQ=uilaK90D4TOVoH58JNXRgQ=1oNaO28yAR9wl4tZt0TtaPSmNktwFks9KPTlhdWuPig=JCauKpC86D0ab4DIjW5ueRu088U8_cBuoizilFN8b_s=TfTlgUj10Yo0COkFwEotZwRfb7Z5DnI_f8ENR3mpd3k=> ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: clang-format: Fix deref treated as binary op in throw
LG, thanks for the patch. For next time, it helps to use phabricator to make people catch patches faster :) Do you have commit access or do you need me to check it in? On Thu, Jul 6, 2017 at 6:53 PM Erik Uhlmann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > When dereferencing a pointer in a throw statement, clang-format assigns > TT_BinaryOperator to the star token, so it gets formatted as: > > throw * x; > > With this change the above becomes > > throw *x; > > Bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665 > > Attached is a patch containing the fix. > > ___ > cfe-commits mailing list > cfe-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits > ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
clang-format: Fix deref treated as binary op in throw
When dereferencing a pointer in a throw statement, clang-format assigns TT_BinaryOperator to the star token, so it gets formatted as: throw * x; With this change the above becomes throw *x; Bug tracker: https://bugs.llvm.org/show_bug.cgi?id=33665 Attached is a patch containing the fix. 0001-Format-Fix-deref-treated-as-binary-op-in-throw.patch Description: 0001-Format-Fix-deref-treated-as-binary-op-in-throw.patch ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
