[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

2023-01-18 Thread Michael D Toguchi via Phabricator via cfe-commits
mdtoguchi added inline comments.



Comment at: clang/include/clang/Driver/Options.td:6654
+def _SLASH_fexcess_precision_EQ : CLJoined<"fexcess-precision=">,
+  Alias;
+

To expose to clang-cl, can we just make the original option a `CoreOption` 
instead of adding an alias of the same name here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141929/new/

https://reviews.llvm.org/D141929

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D145770: [clang-offload-bundler] Standardize TargetID field for bundler

2023-03-24 Thread Michael D Toguchi via Phabricator via cfe-commits
mdtoguchi added a comment.

@lamb-j - is it expected for any bundled objects created before your change 
without the explicit env field to be able to be unbundled?  Newly generated 
bundles work as expected given similar `-target` values, but older generated 
binaries fail to unbundle the target given equivalent commands.  Is it possible 
to provide the ability to do so?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145770/new/

https://reviews.llvm.org/D145770

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D119290: [Clang] Add support for -fcx-limited-range, -fcx-fortran-rules options.

2022-02-23 Thread Michael D Toguchi via Phabricator via cfe-commits
mdtoguchi added inline comments.



Comment at: clang/include/clang/Driver/Options.td:1853
+def fcx_fortran_rules : Flag<["-"], "fcx-fortran-rules">, Group;
+def fnocx_fortran_rules : Flag<["-"], "fnocx-fortran-rules">, Group;
+def cx_rangeEQ : Joined<["-"], "fcx-range=">, Group, 
Flags<[CC1Option]>,

Typical negate syntax would use `-fno-cx-*`



Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2958
   FPContract = "fast";
+  CxRangeArg = LangOptions::CX_NoNan;
   break;

Is there any need to disable any settings for `-fno-fast-math`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119290/new/

https://reviews.llvm.org/D119290

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits