Re: Coverity + Jenkins

2015-10-09 Thread Ferry Huberts 

Note that you can only submit max 3 builds per day.
I have my olsrd coverity job running on this schedule:

  H 0,12,18 * * *

On 09/10/15 10:54, Jason A. Donenfeld wrote:

Alright -- I've filtered out all the git findings. This leaves us with
a much more manageable 31 findings.



--
Ferry Huberts
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: Coverity + Jenkins

2015-10-09 Thread Jason A. Donenfeld 
Alright -- I've filtered out all the git findings. This leaves us with
a much more manageable 31 findings.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 0/4] Initial Coverity fixes

2015-10-09 Thread Jason A. Donenfeld 
Great! Thanks. Merged. We'll see what happens.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH] Makefile: fix MAKEFLAGS tests with multiple flags

2015-10-09 Thread Jason A. Donenfeld 
Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 5/8] ui-shared: fix resource leak: free allocation from cgit_currenturl

2015-10-09 Thread Jason A. Donenfeld 
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

2015-10-09 Thread Christian Hesse 
Ferry Huberts  on Fri, 2015/10/09 14:13:
> I have the experience that it sometimes misses things that are then 
> found in the next build.
> Or that it flags a whole load of lines without issues.
> It doesn't happen a lot though. Sometimes.
> 
> Let's call it temperamental...

Uh, it lives and has its own mind... :-P
-- 
main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/*Chris   get my mail address:*/=0;b=c[a++];)
putchar(b-1/(/*   gcc -o sig sig.c && ./sig*/b/42*2-3)*42);}


pgphOObw1q40N.pgp
Description: OpenPGP digital signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 4/4] ui-plain: fix resource leak: free before assigning NULL

2015-10-09 Thread Christian Hesse 
From: Christian Hesse 

Coverity-id: 13939
Signed-off-by: Christian Hesse 
---
 ui-plain.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui-plain.c b/ui-plain.c
index 4c73607..e4beb99 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -84,8 +84,10 @@ static void print_dir(const unsigned char *sha1, const char 
*base,
slash = strrchr(fullpath, '/');
if (slash)
*(slash + 1) = 0;
-   else
+   else {
+   free(fullpath);
fullpath = NULL;
+   }
html("");
cgit_plain_link("../", NULL, NULL, ctx.qry.head, ctx.qry.sha1,
fullpath);
-- 
2.6.1

___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 3/4] ui-plain: fix resource leak: free before return

2015-10-09 Thread Christian Hesse 
From: Christian Hesse 

Coverity-id: 13940
Signed-off-by: Christian Hesse 
---
 ui-plain.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui-plain.c b/ui-plain.c
index 0dd1a8b..4c73607 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -51,6 +51,7 @@ static int print_object(const unsigned char *sha1, const char 
*path)
cgit_print_http_headers();
html_raw(buf, size);
free(mimetype);
+   free(buf);
return 1;
 }
 
-- 
2.6.1

___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

[PATCH 1/4] ui-repolist: fix resource leak: free before return

2015-10-09 Thread Christian Hesse 
From: Christian Hesse 

Coverity-id: 13931
Signed-off-by: Christian Hesse 
---
 ui-repolist.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ui-repolist.c b/ui-repolist.c
index ac1b3e3..4f52e0f 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -18,8 +18,10 @@ static time_t read_agefile(char *path)
char *buf;
struct strbuf date_buf = STRBUF_INIT;
 
-   if (readfile(path, , ))
+   if (readfile(path, , )) {
+   free(buf);
return -1;
+   }
 
if (parse_date(buf, _buf) == 0)
result = strtoul(date_buf.buf, NULL, 10);
-- 
2.6.1

___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

2015-10-09 Thread Jason A. Donenfeld 
My guess is the fact that sometimes that function returned a const
values and other times an allocated value tripped it up. It's flow
graph can only be so big...
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 4/8] ui-shared: return value of cgit_currenturl is not const

2015-10-09 Thread Jason A. Donenfeld 
This is a good normalization to make. I vaguely remember when adding
this function that I was thinking, "hm, that's not right, but it's not
like we care about memory leaks anyway so...". Thanks for fixing my
laziness.

Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

2015-10-09 Thread Christian Hesse 
"Jason A. Donenfeld"  on Fri, 2015/10/09 14:03:
> No coverity-id on this commit. Did you find this one yourself?

Yes. No idea why coverity did not see this...
-- 
main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/*Chris   get my mail address:*/=0;b=c[a++];)
putchar(b-1/(/*   gcc -o sig sig.c && ./sig*/b/42*2-3)*42);}


pgphYZsvGwELP.pgp
Description: OpenPGP digital signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 8/8] ui-shared: fix resource leak: free allocation from cgit_hosturl

2015-10-09 Thread Jason A. Donenfeld 
Merged, thanks.

Also - no coverity-id on this one too.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 7/8] ui-shared: return value of cgit_hosturl is not const

2015-10-09 Thread Jason A. Donenfeld 
Again, nice normalization here. Merged, thanks.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 6/8] cmd: fix resource leak: free allocation from cgit_currenturl and fmtalloc

2015-10-09 Thread Ferry Huberts 
I have the experience that it sometimes misses things that are then 
found in the next build.

Or that it flags a whole load of lines without issues.
It doesn't happen a lot though. Sometimes.

Let's call it temperamental...


On 09/10/15 14:08, Christian Hesse wrote:

"Jason A. Donenfeld"  on Fri, 2015/10/09 14:03:

No coverity-id on this commit. Did you find this one yourself?


Yes. No idea why coverity did not see this...



___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit



--
Ferry Huberts
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/4] ui-repolist: fix resource leak: free before return

2015-10-09 Thread Jason A. Donenfeld 
Merged.
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit