Re: [PATCH 1/1] ui-log: do not print empty table rows

2016-07-12 Thread Christian Hesse 
Christian Hesse  on Thu, 2016/07/07 12:54:
> "Jason A. Donenfeld"  on Thu, 2016/07/07 12:28:
> > Hmm, so this fixes the problem with the log highlighting, but it might
> > not be a full fix:
> > 
> > https://git.zx2c4.com/systemd/log/  
> 
> I attached a screenshot from what it looks like currently.
> 
> You speak about the rows pointed to by arrows? First one is odd-nohover-odd,
> second one is even-nohover-even. As neither odd nor nohover rows are
> highlighted we have three white rows here.
> 
> As the middle row is blank anyway... We could declare that to be
> expected. :D Note that all rows containing text still have hover active.
> 
> How would you like it to look like?

Any comment on this? Did you notice my follow up patches?
-- 
main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/*Best regards my address:*/=0;b=c[a++];)
putchar(b-1/(/*Chriscc -ox -xc - && ./x*/b/42*2-3)*42);}


pgp8lPbxeApyx.pgp
Description: OpenPGP digital signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit

Re: [PATCH 1/1] ui-log: do not print empty table rows

2016-07-07 Thread Christian Hesse 
"Jason A. Donenfeld"  on Thu, 2016/07/07 12:28:
> Hmm, so this fixes the problem with the log highlighting, but it might
> not be a full fix:
> 
> https://git.zx2c4.com/systemd/log/

I attached a screenshot from what it looks like currently.

You speak about the rows pointed to by arrows? First one is odd-nohover-odd,
second one is even-nohover-even. As neither odd nor nohover rows are
highlighted we have three white rows here.

As the middle row is blank anyway... We could declare that to be expected. :D
Note that all rows containing text still have hover active.

How would you like it to look like?
-- 
main(a){char*c=/*Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/*Best regards my address:*/=0;b=c[a++];)
putchar(b-1/(/*Chriscc -ox -xc - && ./x*/b/42*2-3)*42);}


pgpR9ZuK58xsF.pgp
Description: OpenPGP digital signature
___
CGit mailing list
CGit@lists.zx2c4.com
http://lists.zx2c4.com/mailman/listinfo/cgit