Re: [Chicken-hackers] [PATCH] Make chicken-home consider CHICKEN_INSTALL_PREFIX
Hi folks, I had a look at this one, and it seems OK to me (it's certainly correct in concept, as this procedure should match whatever egg-compile.scm does) and tests fine on Linux. But, I'm not convinced the conditional path separator behaviour for Windows is necessary -- I think we can just use "/" in all cases. I'll have a go testing it on Windows later this week unless someone beats me to it (or unless you're sure the special path separator logic is necessary?). Best, Evan ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Signed-off copy of fix for #1608
Looks good, applied. Nice find, Vasilij. Evan ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Always quote symbols starting or ending with a colon to ensure readability
On Mon, May 27, 2019 at 09:28:44AM +0200, felix.winkelm...@bevuta.com wrote: > > On Sun, May 26, 2019 at 09:05:37PM +0200, felix.winkelm...@bevuta.com wrote: > > > > > > > > The attached patch ensures we write such identifiers as |:type-tests:| > > > > regardless of keyword style. This way, it can also be read by any > > > > program, even if it uses a different keyword style than the writer. > > > > > > > > > > Ugh... How ugly. Is there no way around this? The "|" are only necessary > > > in "readable" mode, right? > > > > What do you mean by readable mode? If you mean that it's only needed > > when you want to later use READ to read back the expression, then yes. > > For regular display it doesn't matter. > > Yes, write vs display, that's what I meant. Yeah, it's only necessary there. > > I don't see how it's a huge problem; one wouldn't need to write such > > symbols very often, and usually you have suffix style enabled, so the > > pipes are only unnecessary when the symbol only starts with a colon. > > When there's a colon on both ends or on the right side, you _have_ to > > pipe-quote it anyway, and we do already. > > It's not a HUGE problem, just ugly. So I understand this only applies to > |:XXX:|? > Then it is a different story... When using "suffix" kw style, it applies to |:xxx| and |:xxx:|. We currently already handle |xxx:| like that, so that won't change. Of course regular symbols without colons at the ends won't need to be quoted! So, something like SRV:send-reply will just be emitted without pipes as well. Cheers, Peter signature.asc Description: PGP signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Always quote symbols starting or ending with a colon to ensure readability
> On Sun, May 26, 2019 at 09:05:37PM +0200, felix.winkelm...@bevuta.com wrote: > > > > > > The attached patch ensures we write such identifiers as |:type-tests:| > > > regardless of keyword style. This way, it can also be read by any > > > program, even if it uses a different keyword style than the writer. > > > > > > > Ugh... How ugly. Is there no way around this? The "|" are only necessary > > in "readable" mode, right? > > What do you mean by readable mode? If you mean that it's only needed > when you want to later use READ to read back the expression, then yes. > For regular display it doesn't matter. Yes, write vs display, that's what I meant. > > I don't see how it's a huge problem; one wouldn't need to write such > symbols very often, and usually you have suffix style enabled, so the > pipes are only unnecessary when the symbol only starts with a colon. > When there's a colon on both ends or on the right side, you _have_ to > pipe-quote it anyway, and we do already. It's not a HUGE problem, just ugly. So I understand this only applies to |:XXX:|? Then it is a different story... felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
