Re: [Chicken-hackers] [PATCH] Add `module-environments' feature

2012-02-07 Thread Moritz Heidkamp
Felix  writes:
> Signed off and pushed. I fear we will end up with many arbitrary feature
> identifiers at some stage, though. Perhaps we should find a method to
> distinguish "system" features like this and avoid collisions with user-
> defined features? Any ideas?

Perhaps a `chicken-', 'core-' or maybe even a `sys##' prefix would do
the trick? I wouldn't introduce a new namespace just for that I think.

Moritz

___
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers


Re: [Chicken-hackers] [PATCH] Add `module-environments' feature

2012-02-06 Thread Felix
From: Moritz Heidkamp 
Subject: [Chicken-hackers] [PATCH] Add `module-environments' feature
Date: Sun, 05 Feb 2012 20:57:42 +0100

> Hello Chickenauts,
> 
> the attached patch merely adds a `module-environments' feature which
> indicates the availability of the new `module-environment'
> function. This feature would be very nice to have for the new
> environments egg implementation in order to be able to cond-expand to
> the old implementation for earlier Chicken versions. I somebody agrees!

Signed off and pushed. I fear we will end up with many arbitrary feature
identifiers at some stage, though. Perhaps we should find a method to
distinguish "system" features like this and avoid collisions with user-
defined features? Any ideas?


cheers,
felix

___
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers


Re: [Chicken-hackers] [PATCH] Add `module-environments' feature

2012-02-05 Thread Moritz Heidkamp
Moritz Heidkamp  writes:
> [...] I somebody agrees!
 ^ hope

___
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers


[Chicken-hackers] [PATCH] Add `module-environments' feature

2012-02-05 Thread Moritz Heidkamp
Hello Chickenauts,

the attached patch merely adds a `module-environments' feature which
indicates the availability of the new `module-environment'
function. This feature would be very nice to have for the new
environments egg implementation in order to be able to cond-expand to
the old implementation for earlier Chicken versions. I somebody agrees!

Moritz
>From 4f326e219248d4de807381af9df9edad6daedf4e Mon Sep 17 00:00:00 2001
From: Moritz Heidkamp 
Date: Sun, 5 Feb 2012 20:37:02 +0100
Subject: [PATCH] register `module-environments' feature to indicate
 availability of the `module-environment' function

---
 modules.scm |2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/modules.scm b/modules.scm
index f248890..8b048a3 100644
--- a/modules.scm
+++ b/modules.scm
@@ -882,6 +882,8 @@
 
 (##sys#register-module-alias 'r5rs 'scheme)
 
+(register-feature! 'module-environments)
+
 (define (module-environment mname #!optional (ename mname))
   (let* ((mod (##sys#find-module/import-library mname 'module-environment))
 	 (saved (module-saved-environments mod)))
-- 
1.7.9

___
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers