Re: [Chicken-hackers] Updating stability...
> The ones that depend on the Win 64 bit patch could be rewritten to apply > without it, > but it's a little hairy. Can someone vouch for the patch? Otherwise I will > probably defer those changes. I suggest to defer it. > > The patch depending on flymake/elisp could have the latter added with no > problem, > but those files aren't ever added to the manifest, so this change would have > no > effect in a distribution tarball. [I consider this change to be > user-invisible > as far as stability goes anyway, as it has no functional effect and can be > retrieved from git if someone wants it.] If people still want it in > stability, > we need to patch the manifest in master. I forgot to add them to the manifest. I'll push a patch in a minute. I don't think this stuff is needed in stability, though. > > The symbol GC patch is skipped as per C-Keen. In fact given the troubles with > symbol GC, I am fine with declaring symbol GC as WONTFIX in 4.8.0.x and > disabling the stupid test, at least until it's absolutely rock solid. Yes, that sounds good. > I want to note that although I did apply nearly everything since > Peter was kind enough to find appropriate patches, I think it is not > really necessary to put so many patches into stability, just because it > is a lot of work for everybody. (We have already hit 50, exceeding the > number of > patches in 4.7.0 - 4.7.0.6. Perhaps I wasn't very thorough in 4.7.0.x, > although > nobody really complained.) Especially more trivial stuff like comments, > reformatting and even wiki syncs to the manual -- although the intent is to > make later patching easier, many times these patches cause conflicts > themselves. > Even a patch that just removes warnings isn't really *that* important in my > opinion. I don't mind applying these, even though I don't think they are that > valuable; perhaps others disagree. I think it makes sense to be very conservative regarding the stability branch. cheers, felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
Jim Ursetto writes: > [ ... a lot ... ] I just wanted to thank you guys for going through this hassle, it's really appreciated. I will try to help in the next stabililty cycle! Moritz ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
I've backported and/or applied these to my tree, with the exception of these so far: # c2ea63b (uint64 fix) depends on 09bfacd1 (Windows 64 bit patch) c2ea63b340995b1882d9ed400db0019c1686aa11 # 67ca64e (clang warnings) depends on 09bf6acd1 (Windows 64 bit patch) 67ca64e751451880c89af7c7aa0a233ded34ed09 # 709a4ea depends on 335a0d2e23 (flymake/elisp); also files are not in manifest 709a4ea4e2fe3008c890d80a5b102bc62e9ba306 # symbol GC, instructed to skip # f97a4e630c1390372c168327ee97838f633d0eac The ones that depend on the Win 64 bit patch could be rewritten to apply without it, but it's a little hairy. Can someone vouch for the patch? Otherwise I will probably defer those changes. The patch depending on flymake/elisp could have the latter added with no problem, but those files aren't ever added to the manifest, so this change would have no effect in a distribution tarball. [I consider this change to be user-invisible as far as stability goes anyway, as it has no functional effect and can be retrieved from git if someone wants it.] If people still want it in stability, we need to patch the manifest in master. The symbol GC patch is skipped as per C-Keen. In fact given the troubles with symbol GC, I am fine with declaring symbol GC as WONTFIX in 4.8.0.x and disabling the stupid test, at least until it's absolutely rock solid. Kon's hash patches are skipped for this release but could be reexamined later if the lack of them is causing a problem. I want to note that although I did apply nearly everything since Peter was kind enough to find appropriate patches, I think it is not really necessary to put so many patches into stability, just because it is a lot of work for everybody. (We have already hit 50, exceeding the number of patches in 4.7.0 - 4.7.0.6. Perhaps I wasn't very thorough in 4.7.0.x, although nobody really complained.) Especially more trivial stuff like comments, reformatting and even wiki syncs to the manual -- although the intent is to make later patching easier, many times these patches cause conflicts themselves. Even a patch that just removes warnings isn't really *that* important in my opinion. I don't mind applying these, even though I don't think they are that valuable; perhaps others disagree. Finally, I was kind of hesitant to apply the POSIX poll() fix, since it's an intrusive change and since we already have a defense against it (ulimit), and there's not really a test suite for it I think, and it is platform-dependent. But in the end I applied it. Jim On Jan 6, 2013, at 7:00 AM, Peter Bex wrote: > Hi all, > > It'd be nice if we can make a stability release. I propose to merge the > attached list of changesets. IMO it's reasonably conservative, I avoided > adding large non-bugfix changes. > > Cheers, > Peter > -- > http://sjamaan.ath.cx > ___ > Chicken-hackers mailing list > Chicken-hackers@nongnu.org > https://lists.nongnu.org/mailman/listinfo/chicken-hackers ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
From: Peter Bex Subject: Re: [Chicken-hackers] Updating stability... Date: Sun, 6 Jan 2013 19:27:52 +0100 > On Sun, Jan 06, 2013 at 09:23:04AM -0800, Kon Lovett wrote: >> This suggestion straddles the line between bug fix & feature addition. The >> recursive data structures were not properly descended so a fix. But adds >> globals for recursion limits. >> >> [PATCH] Add recursive hash depth & length parameters. Make pair hash truley >> recursive. >> >> (Misspelled 'truly'.) >> >> These are the relevant commits: >> >> commit 70d0ff929bb88ceb916c060e047d0541a9b20788 >> commit b0f25e9750594d29810ff56b0dc583d1e83ec7ca >> commit 799b4b27a557232e6455791bdfd532f950f0fbdb > > Hi Kon, > > Thanks for your suggestion. I debated including these, but considered > against them because, as you said, it's somewhere between bugfix and > feature addition, and it's quite a number of changes. > > It's safer to exclude it. If it turns out to be a problem for people we > can include it in 4.8.0.2. What does everyone else think? Sounds ok. I would probably include it, but if we define "safe" as "not more broken than it already is", then leave it out. cheers, felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
From: Christian Kellermann Subject: Re: [Chicken-hackers] Updating stability... Date: Sun, 6 Jan 2013 14:16:15 +0100 > * Peter Bex [130106 14:06]: >> Hi all, >> >> It'd be nice if we can make a stability release. I propose to merge the >> attached list of changesets. IMO it's reasonably conservative, I avoided >> adding large non-bugfix changes. > > Please omit f97a4e630c1390372c168327ee97838f633d0eac (weak-symbol > gc) as this consistently crashes openbsd on my machine. This looks like a gcc bug to me. I just need some gdb output from Christian to verify that. cheers, felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
On Sun, Jan 06, 2013 at 09:23:04AM -0800, Kon Lovett wrote: > This suggestion straddles the line between bug fix & feature addition. The > recursive data structures were not properly descended so a fix. But adds > globals for recursion limits. > > [PATCH] Add recursive hash depth & length parameters. Make pair hash truley > recursive. > > (Misspelled 'truly'.) > > These are the relevant commits: > > commit 70d0ff929bb88ceb916c060e047d0541a9b20788 > commit b0f25e9750594d29810ff56b0dc583d1e83ec7ca > commit 799b4b27a557232e6455791bdfd532f950f0fbdb Hi Kon, Thanks for your suggestion. I debated including these, but considered against them because, as you said, it's somewhere between bugfix and feature addition, and it's quite a number of changes. It's safer to exclude it. If it turns out to be a problem for people we can include it in 4.8.0.2. What does everyone else think? Cheers, Peter -- http://sjamaan.ath.cx ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
On Sun, Jan 06, 2013 at 02:30:00PM +0100, Christian Kellermann wrote: > It crashes sometimes without the patch and always with the patch, > so wrt stability this is not an improvement. OK! Consider it removed. Any patches that should be included but weren't in the list? -- http://sjamaan.ath.cx ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
* Peter Bex [130106 14:20]: > On Sun, Jan 06, 2013 at 02:16:15PM +0100, Christian Kellermann wrote: > > * Peter Bex [130106 14:06]: > > > Hi all, > > > > > > It'd be nice if we can make a stability release. I propose to merge the > > > attached list of changesets. IMO it's reasonably conservative, I avoided > > > adding large non-bugfix changes. > > > > Please omit f97a4e630c1390372c168327ee97838f633d0eac (weak-symbol > > gc) as this consistently crashes openbsd on my machine. > > I was a little unsure about this one in the first place. However, it's > not enabled by default and it used to crash often without this patch. > Does it *not* crash on your machine without it? It crashes sometimes without the patch and always with the patch, so wrt stability this is not an improvement. -- In the world, there is nothing more submissive and weak than water. Yet for attacking that which is hard and strong, nothing can surpass it. --- Lao Tzu ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
On Sun, Jan 06, 2013 at 02:16:15PM +0100, Christian Kellermann wrote: > * Peter Bex [130106 14:06]: > > Hi all, > > > > It'd be nice if we can make a stability release. I propose to merge the > > attached list of changesets. IMO it's reasonably conservative, I avoided > > adding large non-bugfix changes. > > Please omit f97a4e630c1390372c168327ee97838f633d0eac (weak-symbol > gc) as this consistently crashes openbsd on my machine. I was a little unsure about this one in the first place. However, it's not enabled by default and it used to crash often without this patch. Does it *not* crash on your machine without it? Cheers, Peter -- http://sjamaan.ath.cx ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] Updating stability...
* Peter Bex [130106 14:06]: > Hi all, > > It'd be nice if we can make a stability release. I propose to merge the > attached list of changesets. IMO it's reasonably conservative, I avoided > adding large non-bugfix changes. Please omit f97a4e630c1390372c168327ee97838f633d0eac (weak-symbol gc) as this consistently crashes openbsd on my machine. Kind regards, Christian -- In the world, there is nothing more submissive and weak than water. Yet for attacking that which is hard and strong, nothing can surpass it. --- Lao Tzu ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
[Chicken-hackers] Updating stability...
Hi all, It'd be nice if we can make a stability release. I propose to merge the attached list of changesets. IMO it's reasonably conservative, I avoided adding large non-bugfix changes. Cheers, Peter -- http://sjamaan.ath.cx commit c2ea63b340995b1882d9ed400db0019c1686aa11 Author: felix Date: Fri Dec 28 00:13:27 2012 +0100 Corrected behaviour for "C_i_foreign_[unsigned]_integer64_argumentp" Extract floating-point values from argument and compare with MIN/MAX for the associated C type). Added limits to chicken.h, which uses stdint.h now (or inttypes.h on SunOS). Disabled compiler-test added by Peter for #955 for 32-bit platforms. Signed-off-by: Peter Bex commit 62aac3554955e36fbe31ad7b13846b712805f612 Author: Peter Bex Date: Thu Jan 3 23:02:33 2013 +0100 Update copyright year to 2013. This time I used a slightly modified version of last year's oneliner, to catch banner.scm and README as well: for i in `git grep -Il '(c) [0-9-]*, The Chicken Team'`; do sed -r 's/\(c\) (([0-9]+)-|(2012))(2012)?,/(c) \2\3-2013,/' "$i" > tmp && mv tmp "$i"; done banner.scm had to be slightly changed (spaces and commas) in order to get detected by this script. Signed-off-by: felix commit fe4c184e20d358d2c9befb20a3d53c729b58fc86 Author: Moritz Heidkamp Date: Wed Jan 2 22:02:10 2013 +0100 Fix TO argument check in subvector procedure The subvector procedure checked its TO argument as if it was inclusive. However, its default value is the passed vector's length so it must be exclusive which also corresponds with the implementation. In effect, the erroneous check prevented producing a subvector including the given vector's last element. This patch changes the TO argument check to be exclusive and adds some test cases for the subvector procedure. Signed-off-by: felix commit 67ca64e751451880c89af7c7aa0a233ded34ed09 Author: felix Date: Sat Dec 29 23:19:27 2012 +0100 From: Kon Lovett Date: Sat, 29 Dec 2012 11:41:51 -0800 Subject: stop clang warnings Signed-off-by: felix commit 8ed1ff65f31628b215b435dfd03d6f1ee3ae4b0b Author: felix Date: Sat Dec 29 23:09:15 2012 +0100 pass "-z origin" to freebsd linker only if "-deployed" is given; explained -deployed somewhat (csc help output). commit eb9c5c6a07e423381f56c38b1756127370555d3c Author: felix Date: Sat Dec 29 23:04:44 2012 +0100 disable integer64 test on 32-bit platforms commit c0be8fb56a1c2e6dc2e37a4d582c780da518 Author: Peter Bex Date: Sun Dec 23 17:51:41 2012 +0100 Add regression test for #955 commit 1117e01239b1181b0d6ee66d998eb1e83dbd8285 Author: Peter Bex Date: Sun Dec 23 17:20:49 2012 +0100 Change one of the duplicated ##sys#foreign-unsigned-integer64-argument definitions to ##sys#foreign-unsigned-integer-argument (copy/paste mistake?) commit 42c869949f893baba40c9b0d5e4832eb2004b20e Author: felix Date: Sun Dec 23 16:08:31 2012 +0100 Bugfix for foreign-argument-check routine for 64-bit unsigned longs. The function returned a raw floating-point value (coerced to C_word) instead of the original number. Reported by Kon Lovett. Signed-off-by: Peter Bex commit 4223b30426c257f3192d780b7d5e4de3a919dcfd Author: felix Date: Sun Dec 23 16:05:58 2012 +0100 trivial formatting change commit af7cc16b0f5986c758958b3b5d73885ad2f4217c Author: felix Date: Sun Dec 23 16:05:43 2012 +0100 trivial change in describe-output commit 6f95195f4840fe8e1342356b648036713a59e93e Author: felix Date: Fri Dec 21 22:53:53 2012 +0100 register feature-identifier 64bit when running on a 64-bit CPU (suggested by Kon Lovett) commit 7818de84946260fabbaffbc971ac77583832ce83 Author: felix Date: Thu Dec 13 20:27:09 2012 +0100 handle case in make-pathname when the directory-argument is #f and the file-argument begins with a path separator (reported by kon) Fixes #959 Signed-off-by: Mario Domenech Goulart commit 564285c33e7a1451084e0ba809d6efd29ae2dab1 Author: Jim Ursetto Date: Thu Dec 13 23:53:05 2012 -0600 manual: Note find-files old signature style was made invalid after 4.7.3 commit 709a4ea4e2fe3008c890d80a5b102bc62e9ba306 Author: felix Date: Thu Dec 13 20:15:06 2012 +0100 define keys only for scheme-mode commit f016cd78979654ef43d7dbd90b0e96382274a1b4 Author: felix Date: Thu Dec 13 20:14:48 2012 +0100 some comments commit 52c69531d586a39c51f3acc636596c65e181622e Author: felix Date: Tue Dec 4 19:58:56 2012 +0100 bugfix for unsigned-integer64 type check commit 0425b20986a049217c599870f7eed70c45cb3071 Author: Peter Bex Date: Wed Nov 28 23:57:10 2012 +0100 Irregex: Fixing folds on conditional begin patterns which aren't treated as searchers. This is the final fix for #686 and synchronizes with upstream version 0.9.2 (upstream changesets 01058fc79a16 and fad713187dbb) Signed-of
