Re: [Chicken-hackers] [PATCH] Some small debugger data and wire protocol improvements
> > > > There is a protocol_version test in feathers.tcl ... Is this what you mean? > > Ah, I suppose so. I couldn't find it so quickly; where is it in the C code? C_DEBUG_PROTOCOL_VERSION > What happens when the version is different? feathers aborts. felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Some small debugger data and wire protocol improvements
On Sun, Nov 25, 2018 at 07:29:57PM +0100, felix.winkelm...@bevuta.com wrote: > > > > One thing though; I think we need to add some sort of versioning support > > to the debugger protocol so when you run feathers to talk to a program > > compiled with a different version of CHICKEN, this is going to fail. > > > > I think this is a situation we ought to at least detect and warn or error > > on, so the user won't be left with confusing behaviour. This is quite > > likely when you consider the debugger can be used remotely; there is no > > guarantee that the program on the remote end is using the same version > > of the debugger protocol. > > > > There is a protocol_version test in feathers.tcl ... Is this what you mean? Ah, I suppose so. I couldn't find it so quickly; where is it in the C code? What happens when the version is different? Maybe we should simply bump that version then. Cheers, Peter signature.asc Description: PGP signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Some small debugger data and wire protocol improvements
> > One thing though; I think we need to add some sort of versioning support > to the debugger protocol so when you run feathers to talk to a program > compiled with a different version of CHICKEN, this is going to fail. > > I think this is a situation we ought to at least detect and warn or error > on, so the user won't be left with confusing behaviour. This is quite > likely when you consider the debugger can be used remotely; there is no > guarantee that the program on the remote end is using the same version > of the debugger protocol. > There is a protocol_version test in feathers.tcl ... Is this what you mean? felix ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Some small debugger data and wire protocol improvements
On Sun, Jul 22, 2018 at 11:45:17PM +1200, Evan Hanson wrote: > Hello hackers, > > Here are a few small changes to the debugging backend, to address some > snags I hit into while working on a program that uses the debugger > protocol. As the commit message says, they're intended to "simplify the > use of the debugging protocol by client applications by fixing a few > oddities that would otherwise need to be coded around on the client > side." If you have any questions, just let me know. Hi Evan, I've finally gotten around to taking a look and even though I don't know all that much about the debugger, the change looks fine. One thing though; I think we need to add some sort of versioning support to the debugger protocol so when you run feathers to talk to a program compiled with a different version of CHICKEN, this is going to fail. I think this is a situation we ought to at least detect and warn or error on, so the user won't be left with confusing behaviour. This is quite likely when you consider the debugger can be used remotely; there is no guarantee that the program on the remote end is using the same version of the debugger protocol. > I also have an accompanying patch to update the debugger-protocol egg, > which can be applied once this looks OK to you. Please do! Cheers, Peter signature.asc Description: PGP signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
Re: [Chicken-hackers] [PATCH] Some small debugger data and wire protocol improvements
On Sun, Jul 22, 2018 at 11:45:17PM +1200, Evan Hanson wrote: > Hello hackers, > > Here are a few small changes to the debugging backend, to address some > snags I hit into while working on a program that uses the debugger > protocol. As the commit message says, they're intended to "simplify the > use of the debugging protocol by client applications by fixing a few > oddities that would otherwise need to be coded around on the client > side." If you have any questions, just let me know. I'd prefer to postpone this to 5.1, let's avoid making any large changes to 5.0, OK? Cheers, Peter signature.asc Description: PGP signature ___ Chicken-hackers mailing list Chicken-hackers@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-hackers
