Re: [Chicken-hackers] [PATCH 1/1] Fix csi's "report" feature and add guard for `keyword-style' parameter

[Evan Hanson]

On 2019-06-29 12:06, Peter Bex wrote:
> We could extend this check to ensure it's one of the three recognised
> styles, but maybe that's overkill?

It looks like if you put any other keyword in there it falls back to the
portable style, so I personally think it's OK to leave it alone.

Cheers,

Evan

___
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Re: [Chicken-hackers] [PATCH 1/1] Fix csi's "report" feature and add guard for `keyword-style' parameter

[Peter Bex]

On Mon, Jun 24, 2019 at 08:17:26PM +1200, Evan Hanson wrote:
> The interpreter's "report" command (,r) was a casualty of db2608b1f,
> which causes `symbol->string' to fail when passed a keyword.

Thanks, pushed!

> Update that code to use `keyword->string' and add a guard procedure to
> the keyword-style parameter to ensure that it is always a keyword.

We could extend this check to ensure it's one of the three recognised
styles, but maybe that's overkill?

Cheers,
Peter


signature.asc
Description: PGP signature
___
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers