Re: [Chicken-users] iconv egg patch
On Sat, 7 Nov 2015 10:05:57 -0300 Hugo Arregui wrote: >> I notice the .release-info file doesn't reference old versions. Would >> you please add them? If you need an example on how to do that, take a >> look at awful's .release-info: >> https://github.com/mario-goulart/awful/blob/master/awful.release-info > > Oh, of course!, sorry for that, I just added it. No problem at all, Hugo. Thanks for fixing it. I've updated the egg index to fetch iconv from your repository. Thanks for maintaining this egg. Best wishes. Mario -- http://parenteses.org/mario ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
Hi Mario, > I notice the .release-info file doesn't reference old versions. Would > you please add them? If you need an example on how to do that, take a > look at awful's .release-info: > https://github.com/mario-goulart/awful/blob/master/awful.release-info Oh, of course!, sorry for that, I just added it. Regards, Hugo signature.asc Description: OpenPGP digital signature ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
Hello Hugo, On Wed, 19 Aug 2015 18:36:53 -0300 Hugo Arregui wrote: > The project is here[1], and the release file here[2]. I hope everything > is ok! > > [1] https://github.com/hugoArregui/iconv > [2] > https://raw.githubusercontent.com/hugoArregui/iconv/master/iconv.release-info Thank you, and apologies for taking so long to reply. I notice the .release-info file doesn't reference old versions. Would you please add them? If you need an example on how to do that, take a look at awful's .release-info: https://github.com/mario-goulart/awful/blob/master/awful.release-info Best wishes. Mario -- http://parenteses.org/mario ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
Hi, The project is here[1], and the release file here[2]. I hope everything is ok! Regards, Hugo [1] https://github.com/hugoArregui/iconv [2] https://raw.githubusercontent.com/hugoArregui/iconv/master/iconv.release-info signature.asc Description: OpenPGP digital signature ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
> You can take the svn egg repo as a base (that's where it's currently hosted). > We can give you access to it if you like, or you could import the egg into > a git or mercurial repository and we can change the URL. Thanks Peter! I imported the code into a github repository, I will let you guys know when is ready for the URL change. One question though, I found a couple of things I would like to improve: - I think the documentation is a bit misleading when it says (about iconv procedure), "The resulting string is returned (or #f if the implementation runs out of memory)." But it can actually return #f on error too (check here if you like: https://github.com/hugoArregui/iconv/blob/master/iconv.scm#L85). - The iconv procedure has an `invalid` parameter, which defaults to "?". When an invalid sequence is found, the `invalid` string is appended to the output string for each wrong byte found. Maybe this is desirable sometimes, but there is no way to actually raise an error on this case. So, I will just add an alternative, and if invalid is #f, an error will raise. However, I think raising an error on invalid input is a much saner default, but this breaks backward compatibility I would really like Alex Shinn's opinion on this one, because he has two eggs using iconv. Hope he's reading this. But anyway, my question is: both of this items are related to backwards compatibility, what do you think is the best choice here? should I just change it (if Alex Shinns and perhaps something else who is using it agrees with these changes), should I create another procedure and deprecate this one?, should we call it iconv2 and deprecate iconv?. Thanks. Regards, Hugo signature.asc Description: OpenPGP digital signature ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
On Wed, Aug 12, 2015 at 11:20:04PM -0300, Hugo Arregui wrote: > > I am afraid that the iconv egg is orphaned at the moment. Would you like > > to take care of it? > > Sure!. I cannot access the svn repo mentioned in the egg source, so I > guess I should use the result of chicken-install -r as the base, isn't that? You can take the svn egg repo as a base (that's where it's currently hosted). We can give you access to it if you like, or you could import the egg into a git or mercurial repository and we can change the URL. Cheers, Peter signature.asc Description: Digital signature ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
> I am afraid that the iconv egg is orphaned at the moment. Would you like > to take care of it? Sure!. I cannot access the svn repo mentioned in the egg source, so I guess I should use the result of chicken-install -r as the base, isn't that? Regards, Hugo signature.asc Description: OpenPGP digital signature ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
Re: [Chicken-users] iconv egg patch
Hugo Arregui writes: > Hi, > > The attached small patch get rides of this warning in the iconv egg: > > /usr/include/iconv.h:42:15: note: expected ‘char ** restrict’ but > argument is of type ‘const char **’ > > I tried to contact the author but the email addresses found both in the > egg and in the wiki are disabled, so perhaps he is here on the list. I am afraid that the iconv egg is orphaned at the moment. Would you like to take care of it? Kind regards, Christian -- May you be peaceful, may you live in safety, may you be free from suffering, and may you live with ease. ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
[Chicken-users] iconv egg patch
Hi, The attached small patch get rides of this warning in the iconv egg: /usr/include/iconv.h:42:15: note: expected ‘char ** restrict’ but argument is of type ‘const char **’ I tried to contact the author but the email addresses found both in the egg and in the wiki are disabled, so perhaps he is here on the list. Regards, Hugo 71c71 < if (iconv((iconv_t) cd, (const char* *) &src, &srclen, &dst, &left) == -1) --- > if (iconv((iconv_t) cd, (char** __restrict) &src, &srclen, &dst, &left) == -1) signature.asc Description: OpenPGP digital signature ___ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
