[chromium-dev] Question on Window's CRichEditCtrl, SetParaFormat, and IME

2009-05-12 Thread xji

I have one question might be related to MFC's CRichEditCtrl and
SetParaFormat, and I would appreciate any input.

TextField::Edit is derived from CWindowImplTextField::Edit,
CRichEditCtrl, CWinTraitskDefaultEditStyle .

Currently, in RTL UI (for example, Hebrew Chrome), the TextField::Edit
is initialized as right-aligned, but with left-to-right layout.

I am trying to initialize the layout to be right-to-left in RTL UI and
adjust the layout on the fly, which means, if the input text is a pure
LTR text, the layout will be re-set as left-to-right; when there is
RTL character in the text, the layout will be re-set to right-to-
left.  (To make it simple, I will assume the text is not an URL, which
should always have LTR directionality.)

Resetting layout can be achieved by SetParaFormt().

But there is one problem that I could not figure out:

If I type an English character 'a', the layout will be re-set to LTR.
Then, I change the IME to Hebrew and type a Hebrew character, the
layout will be re-set to RTL, and the Hebrew character is placed at
the left side of 'a'. But the IME changed back to English.

I have no idea why IME change back to English.

And looks like it does not matter whether I initialize the
TextField::Edit as LTR layout or RTL layout, after type in the first
Hebrew character following the English character, the IME always
change back to English.

And if I switch the IME to Hebrew again and type in 2nd or more Hebrew
character, the IME will stay as Hebrew.

I'd appreciate if anyone has any idea on what is going on and why.


Thanks,
Xiaomei

Reply

Forward



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] A UI crash bug report

2009-05-12 Thread 张亚霏
hi all
Every time I click the back button with Ctrl pressed, the browse will
crashed.



Best wishes.
Kimi Zhang

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Dev channel build schedule

2009-05-12 Thread Mark Larson (Google)
I'm working on documenting the normal schedule for release milestones and
how we track that in the bug tracker.
I still have some issues to work out around when a particular feature is
ready and qualified for Beta and Stable channel releases.

For the Dev channel, however, we have a well-established weekly rhythm. See
http://sites.google.com/a/chromium.org/dev/release-schedules for the
beginnings of public documentation of our schedule.

Basically:

   1. The release manager for the week cuts a dev channel build Monday
   morning (Pacific) from the LKGR at that time.
   2. Our test team does a 1-day pass on that build while we create an
   official Google Chrome release build.
   3. Any showstoppers found in testing need to be filed as Pri-0
   ReleaseBlock-Dev bugs and addressed before we release (go to step 2).
   4. Barring showstoppers in test, we run ChromeBot on Monday night.
   5. On Tuesday morning, check the ChromeBot crash rates. Goto step 3 if
   they're bad :)
   6. Sign the build and submit to QA for install and download testing.
   7. Release the build to the Dev channel Tuesday afternoon.

Things frequently get delayed by a day or two because of regressions, but
this is the basic schedule. We should generally have a Dev channel release
on Tuesday or Wednesday afternoon.

If we also have a Beta or Stable release to push (less frequent), that will
take priority in the test team's queue and will delay a Dev channel release.

--Mark

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: A UI crash bug report

2009-05-12 Thread PhistucK
Shift+Mouse Click on the back button opens a tab and closes it right away,
results in no changes whatsoever.:)

☆PhistucK

 On Mon, May 11, 2009 at 8:59 PM, 张亚霏 zhangyafeik...@gmail.com wrote:
  hi all
  Every time I click the back button with Ctrl pressed, the browse will
  crashed.


  Best wishes.
  Kimi Zhang


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: build error

2009-05-12 Thread Berend-Jan Wever

I have had this very same issue on most of my VMs. They have been
syncing and building for a while. I've cloned them, but only some were
affected. I've tried deleting parts of the source tree and resyncing,
--runhooks, rebuilding, all kinds of things. Some of them suddenly
started building again, without me being able to figure out what fixed
it. Others are still not building... Do let me know what the solution
is if you find it!

Berend-Jan SkyLined Wever (skyli...@google.com)
Security Software Engineer
Google NL B.V. Reg: C. Debussylaan 34, 15th floor 1082 MD A'dam 34198589 NL
VAT / Tax ID:- 812788515 B01





On Tue, May 12, 2009 at 09:34, Ojan Vafai o...@google.com wrote:
 OK. I've made some progress here. When I have a clean checkout, chrome.sln
 has all the dependencies correct (as shown by looking at sln_deps.py
 output). But when I open it in VS, the dependencies are wrong. Then I click
 Save all (which is enabled even though I haven't modified anything!) it
 messes with all the deps, including for example, making the mksnapshot deps
 miss v8_nosnapshot. I can fix that one case and get it to build chrome_exe,
 but the other cases are broken. I've included the sort_sln.py'ed diff below.
 The other person in this office having this problem get the same diff by
 following the steps above, so it's not just something crazy on my machine.
 Anyone have any idea why VS would modify the deps to be different than the
 checked in chrome.sln? Maybe one of the guids is invalid and it goes crazy
 or something?
 Ojan

 Index: chrome.sln
 ===
 --- chrome.sln (revision 15745)
 +++ chrome.sln (working copy)
 @@ -553,7 +553,6 @@
   ProjectSection(ProjectDependencies) = postProject
   {8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942} =
 {8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}
   {E13045CD-7E1F-4A41-9B18-8D288B2E7B41} =
 {E13045CD-7E1F-4A41-9B18-8D288B2E7B41}
 - {ED19720A-8F14-D3FC-9C6D-EEB5AE4D5BD7} =
 {ED19720A-8F14-D3FC-9C6D-EEB5AE4D5BD7}
   EndProjectSection
  EndProject
  Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = tld_cleanup,
 ..\net\tld_cleanup.vcproj, {E13045CD-7E1F-4A41-9B18-8D288B2E7B41}
 @@ -581,7 +580,6 @@
  Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = net_perftests,
 ..\net\net_perftests.vcproj, {AAC78796-B9A2-4CD9-BF89-09B03E92BF73}
   ProjectSection(ProjectDependencies) = postProject
   {1832A374-8A74-4F9E-B536-69A699B3E165} =
 {1832A374-8A74-4F9E-B536-69A699B3E165}
 - {1846F110-8263-413F-9924-36F64DD8FE41} =
 {1846F110-8263-413F-9924-36F64DD8FE41}
   {21E22961-22BF-4493-BD3A-868F93DA5179} =
 {21E22961-22BF-4493-BD3A-868F93DA5179}
   {2A70CBF0-847E-4E3A-B926-542A656DC7FE} =
 {2A70CBF0-847E-4E3A-B926-542A656DC7FE}
   {326E9795-E760-410A-B69A-3F79DB3F5243} =
 {326E9795-E760-410A-B69A-3F79DB3F5243}
 @@ -613,7 +611,7 @@
  EndProject
  Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = base_gfx,
 ..\base\base_gfx.vcproj, {A508ADD3-CECE-4E0F-8448-2F5E454DF551}
  EndProject
 -Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = debug_message,
 ..\base\debug_message.vcproj, {D6047981-23AE-4623-9373-514FDAFAE60F}
 +Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = debug_message,
 ..\base\debug_message.vcproj, {5EA782F3-E935-A2A3-A616-C6DEF4B7CE8E}
  EndProject
  Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = base_unittests,
 ..\base\base_unittests.vcproj, {27A30967-4BBA-48D1-8522-CDE95F7B1CEC}
   ProjectSection(ProjectDependencies) = postProject
 @@ -1237,7 +1235,6 @@
  EndProject
  Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = mksnapshot,
 ..\v8\tools\gyp\mksnapshot.vcproj,
 {865575D0-37E2-405E-8CBA-5F6C485B5A26}
   ProjectSection(ProjectDependencies) = postProject
 - {879286C0-3234-D14B-BB2C-32D4D1B809CE} =
 {879286C0-3234-D14B-BB2C-32D4D1B809CE}
   {EC8B7909-62AF-470D-A75D-E1D89C837142} =
 {EC8B7909-62AF-470D-A75D-E1D89C837142}
   EndProjectSection
  EndProject
 @@ -1249,7 +1246,7 @@
   {D9DDAF60-663F-49CC-90DC-3D08CC3D1B28} =
 {D9DDAF60-663F-49CC-90DC-3D08CC3D1B28}
   EndProjectSection
  EndProject
 -Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = v8_shell,
 ..\v8\tools\gyp\v8_shell.vcproj, {31182CBE-9B7D-AAF2-65EE-F4D07012F4F3}
 +Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = v8_shell,
 ..\v8\tools\gyp\v8_shell.vcproj, {2A707681-3C67-AD11-ED1F-67730944B9FD}
   ProjectSection(ProjectDependencies) = postProject
   {21E22961-22BF-4493-BD3A-868F93DA5179} =
 {21E22961-22BF-4493-BD3A-868F93DA5179}
   {EC8B7909-62AF-470D-A75D-E1D89C837142} =
 {EC8B7909-62AF-470D-A75D-E1D89C837142}
 @@ -1331,13 +1328,13 @@
   {326E9795-E760-410A-B69A-3F79DB3F5243} =
 {326E9795-E760-410A-B69A-3F79DB3F5243}
   EndProjectSection
  EndProject
 -Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = dump_cache,
 ..\net\dump_cache.vcproj, {7D1EC571-687B-5D48-E259-C5BA78E717D0}
 +Project({8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}) = dump_cache,
 ..\net\dump_cache.vcproj, {FC0E5EEA-0B43-C02A-5DEA-25C6184FF204}
   ProjectSection(ProjectDependencies) = postProject
   

[chromium-dev] Re: Question on Window's CRichEditCtrl, SetParaFormat, and IME

2009-05-12 Thread 坊野 博典

Hi Xiaomei,

Sorry for the lack of my responses.
It seems a known issue of a RichEdit control (*1), which automatically
changes its keyboard layout with the current selection.
When I create a simple MFC application which just shows a dialog
including a RICHEDIT20 control, it also changes its keyboard layout
automatically on my Vista PC.

(*1) 
http://social.msdn.microsoft.com/forums/en-US/vcgeneral/thread/b640e764-0c3c-43fc-a670-4c5e73167ce4/

I'm also trying possible solutions for this issue now.

Regards,

Hironori Bono
E-mail: hb...@chromium.org

On Tue, May 12, 2009 at 12:19 PM, xji x...@chromium.org wrote:

 I have one question might be related to MFC's CRichEditCtrl and
 SetParaFormat, and I would appreciate any input.

 TextField::Edit is derived from CWindowImplTextField::Edit,
 CRichEditCtrl, CWinTraitskDefaultEditStyle .

 Currently, in RTL UI (for example, Hebrew Chrome), the TextField::Edit
 is initialized as right-aligned, but with left-to-right layout.

 I am trying to initialize the layout to be right-to-left in RTL UI and
 adjust the layout on the fly, which means, if the input text is a pure
 LTR text, the layout will be re-set as left-to-right; when there is
 RTL character in the text, the layout will be re-set to right-to-
 left.  (To make it simple, I will assume the text is not an URL, which
 should always have LTR directionality.)

 Resetting layout can be achieved by SetParaFormt().

 But there is one problem that I could not figure out:

 If I type an English character 'a', the layout will be re-set to LTR.
 Then, I change the IME to Hebrew and type a Hebrew character, the
 layout will be re-set to RTL, and the Hebrew character is placed at
 the left side of 'a'. But the IME changed back to English.

 I have no idea why IME change back to English.

 And looks like it does not matter whether I initialize the
 TextField::Edit as LTR layout or RTL layout, after type in the first
 Hebrew character following the English character, the IME always
 change back to English.

 And if I switch the IME to Hebrew again and type in 2nd or more Hebrew
 character, the IME will stay as Hebrew.

 I'd appreciate if anyone has any idea on what is going on and why.


 Thanks,
 Xiaomei

 Reply

 Forward



 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Should the header file sentries contain double underscores?

2009-05-12 Thread Dean McNamee

Yes, this is legacy.  You'll see that new code uses (at least should
use) a single trailing underscore:

cpu.h:#ifndef BASE_CPU_H_
cpu.h:#define BASE_CPU_H_
cpu.h:#endif  // BASE_CPU_H_

It should be an easy mass replace, but it's not really more than an
ideological concern.  We've just been slowly updating guards as we
touch the files.

Thanks
-- dean

On Tue, May 12, 2009 at 1:37 PM, Glider ramosian.gli...@gmail.com wrote:

 Hi chromium-dev,

 The Chromium header files begin with a sentry section that looks like:
 #ifndef PATH_FILENAME__
 #define PATH_FILENAME__

 However, the names containing __ are reserved according to the C++
 standard and cannot be used.

 Is that a legacy in the codebase, or should it be fixed?

 WBR,
 Alexander Potapenko


 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Mike Pinkerton

Please please please no. It's the most annoying thing about #webkit
and is mostly noise with very little signal. We already have a mailing
list for all checkins and the waterfall. We don't need something
interrupting our only form of real-time communication with redundant
data.

On Tue, May 12, 2009 at 1:38 AM, Mohamed Mansour
m0.interact...@gmail.com wrote:
 I would say we do it. I would like to see statuses of checkins live.
 Instead of no sort of notifications in the build bot page other than the
 auto refresh. I personally like to learn from others on how they do their
 fixes. And it is kinda cool to see it in the channel (like most other open
 source projects) and #chromium is a development channel, so it fits its
 description.


 -- Mohamed Mansour


 On Mon, May 11, 2009 at 9:53 PM, Adam Barth aba...@chromium.org wrote:

 On Mon, May 11, 2009 at 6:49 PM, Brett Wilson bre...@chromium.org wrote:
  I think it's noise and I suspect we have even more checkin traffic than
  they do.

 We have roughly a factor of two more checkins than they do, according to:

 http://cia.vc/stats/project/Chromium
 http://cia.vc/stats/project/WebKit

 There would be about 25 minutes (on average) between messages, but of
 course clustered during US business hours.

 Adam




 




-- 
Mike Pinkerton
Mac Weenie
pinker...@google.com

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Nicolas Sylvain
On Mon, May 11, 2009 at 10:38 PM, Mohamed Mansour
m0.interact...@gmail.comwrote:

 I would say we do it. I would like to see statuses of checkins live.
 Instead of no sort of notifications in the build bot page other than the
 auto refresh. I personally like to learn from others on how they do their
 fixes


It's why we have checkin notification emails.
http://groups.google.com/group/chromium-checkins?pli=1

Nicolas

. And it is kinda cool to see it in the channel (like most other open source
 projects) and #chromium is a development channel, so it fits its
 description.


 -- Mohamed Mansour



 On Mon, May 11, 2009 at 9:53 PM, Adam Barth aba...@chromium.org wrote:


 On Mon, May 11, 2009 at 6:49 PM, Brett Wilson bre...@chromium.org
 wrote:
  I think it's noise and I suspect we have even more checkin traffic than
 they do.

 We have roughly a factor of two more checkins than they do, according to:

 http://cia.vc/stats/project/Chromium
 http://cia.vc/stats/project/WebKit

 There would be about 25 minutes (on average) between messages, but of
 course clustered during US business hours.

 Adam




 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Amanda Walker

On Tue, May 12, 2009 at 10:16 AM, Nicolas Sylvain nsylv...@chromium.org wrote:
 It's why we have checkin notification emails.
 http://groups.google.com/group/chromium-checkins?pli=1

I also like the RSS feeds, especially on a mobile device:

http://groups.google.com/group/chromium-checkins/feeds

--Amanda

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] i would like to help code chrome.. but i have some compilation issues (and unittest)

2009-05-12 Thread nakro

i use VS2008 on Vista32Sp1, and i need to change treat warnings as
errors
for 2 projects for this to even compile (i also tried setting
GYP_MSVS_VERSION=2008 to no avail)

c:\chromiumtrunk\src\third_party\WebKit\JavaScriptCore\wtf/PassRefPtr.h
(70) : error C2220: warning treated as error - no 'object' file
generated

projects:
test_shell_common.vcproj
test_worker.vcproj

the other thing, is that after i modify it the unit tests fail
[  PASSED  ] 864 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] URLFetcherBadHTTPSTest.BadHTTPSTest

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

i have the safe url set properly in my gclient file, and there are
many bugs i would love to help solve in chrome
(i am a top contrib in the help forum, so i know the bugs you have,
and also a seasoned windows programmer)

ok hope to hear anything from you guys
and btw, i love chromium! but i want to code, not just watch!

i can provide more info . if needed

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Dev channel build schedule

2009-05-12 Thread Marc-Antoine Ruel

On Tue, May 12, 2009 at 3:44 AM, Mark Larson (Google) m...@chromium.org wrote:
 The release manager for the week cuts a dev channel build Monday morning
 (Pacific) from the LKGR at that time.

To be sure, uou are referring to the continuous build, e.g.
http://build.chromium.org/buildbot/continuous/LATEST/REVISION ?
I wouldn't trust http://chromium-status.appspot.com/lkgr to split off a branch.

M-A

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Dev channel build schedule

2009-05-12 Thread Mark Larson (Google)
On Tue, May 12, 2009 at 07:48, Marc-Antoine Ruel mar...@chromium.orgwrote:

 On Tue, May 12, 2009 at 3:44 AM, Mark Larson (Google) m...@chromium.org
 wrote:
  The release manager for the week cuts a dev channel build Monday morning
  (Pacific) from the LKGR at that time.

 To be sure, uou are referring to the continuous build, e.g.
 http://build.chromium.org/buildbot/continuous/LATEST/REVISION ?


Actually, this continuous build revision. This represents the build that the
test team will download and test each day.



 I wouldn't trust http://chromium-status.appspot.com/lkgr to split off a
 branch.

 M-A


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: i would like to help code chrome.. but i have some compilation issues (and unittest)

2009-05-12 Thread Lei Zhang

On Tue, May 12, 2009 at 6:19 AM, nakro yoav.zilberb...@gmail.com wrote:
 the other thing, is that after i modify it the unit tests fail
 [  PASSED  ] 864 tests.
 [  FAILED  ] 1 test, listed below:
 [  FAILED  ] URLFetcherBadHTTPSTest.BadHTTPSTest

  1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

See http://dev.chromium.org/developers/testing under SSL tests. If you
look through the entire output, you'd see:

TEST CONFIGURATION ERROR: you need to import the test ca certificate
to your trusted roots for this test to work. For more info visit:
http://dev.chromium.org/developers/testing

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Developing Chrome using tip-of-tree WebKit

2009-05-12 Thread Darin Fisher
On Mon, May 11, 2009 at 5:44 PM, Ojan Vafai o...@chromium.org wrote:

 On Tue, May 12, 2009 at 3:16 AM, Darin Fisher da...@chromium.org wrote:

 Then, create a .gclient file like so:

 solutions = [
  { name : src,
url : http://src.chromium.org/svn/trunk/src;,
custom_deps : {
  'src/third_party/WebKit': '
 http://svn.webkit.org/repository/webkit/trunk',
  'src/third_party/WebKit/JavaScriptCore': None,
  'src/third_party/WebKit/WebCore': None,
  'src/third_party/WebKit/WebKitLibraries': None,
  'src/third_party/WebKit/WebKit/mac': None,
  'src/webkit/data/layout_tests/LayoutTests': None,


 Doesn't this keep you from being able to run the layout tests in TestShell?
 Maybe it's time someone took the effort to fix
 http://bugs.chromium.org/8765 to make this world a bit more consistent?

 Once bug 8765 gets fixed, I wonder if there's something simpler we could
 do.


Yes, this is something Dimitri is fixing.  I thought that bug was already
fixed ;-)




 It seems to me that the ideal solution would be that a default Chromium
 checkout could be used for both Chromium development and WebKit development.
 This is a lot more friendly to people who are new to the team and for people
 that need to work in both trees. As long as there is a way for people who
 are only working on Chromium to exclude the LayoutTests directory (which is
 ~90% of the WebKit checkout).

 I'm not sure I've fully thought this through, but could we change the
 default to be that src/third_party/WebKit points at
 http://svn.webkit.org/repository/webkit/trunk'? Then people who don't want
 LayoutTests, et al, can do something like the following:

 solutions = [
  { name : src,
url : http://src.chromium.org/svn/trunk/src;,
custom_deps : {
  'src/third_party/WebKit': '/trunk/deps/third_party/WebKit',
  'src/third_party/WebKit/JavaScriptCore': Var(webkit_trunk) + /
 JavaScriptCore@ + Var(webkit_revision),
  'src/third_party/WebKit/WebCore': Var(webkit_trunk) + /WebCore@ +
 Var(webkit_revision),
  'src/third_party/WebKit/WebKitLibraries': Var(webkit_trunk) + /
 WebKitLibraries@ + Var(webkit_revision),
  'src/third_party/WebKit/WebKit': Var(webkit_trunk) + /WebKit@ +
 Var(webkit_revision),
 }
  }
 ]

 Note that the Var stuff will mean that you'll pull from whatever SVN server
 / webkit revision that's specified in src/DEPS. I'm not actually sure that
 will work from the gclient file, but we should make it work if it doesn't.
 :)



I think we should optimize for the typical Chrome developer who does not
need to hack on WebKit.  Your suggested change puts the burden there instead
of on us the maintainers of the Chromium WebKit port.  It makes sense to
do a little extra work if you want to enable maintainer mode.

-Darin

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Chrome's Accelerators (alternative to IE8 Accelerators) is here

2009-05-12 Thread jack

I recently migrated the Firefox add-on, called Cleeki, into Google
Chrome. Cleeki can be used as Google Chrome's Accelerators, only
superior to IE8 accelerators. Basically you select any text to search/
share/publish on the Internet, and preview the results in the same
page instantly.

Installation guideline: http://blog.cleeki.com/?p=70
A quick overview: http://blog.cleeki.com/?p=112

Based on the discussion last week, there is a known issue in current
Chrome that the first page might not load the add-on script. Also
there is no (easy) user customization yet because of the lack of an
official user preference system. I would like to share the add-on in
this community in case it is helpful for testing any new release of
Chrome. I will actively test it in the up-to-date Chrome and report
any bugs. Any of your bug reporting is also welcome. I hope when
Chrome add-on system becomes official, this add-on will also be ready
(or almost).

Thanks for your attention and any of your comments are welcome.

-Jack

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Need help in finding a performance problem...

2009-05-12 Thread Marc-Andre Decoste
Salut again,
   I finally got it all working well on Windows (at least as far as I can
see), and the numbers seem to say that this optimization would compensate
for the slow down that was introduced when the resizer corner was enabled...

   I still have some doubts about the validity of the numbers I get on my
machine, so please try it out if you have ways to consistently get similar
profiling numbers on your machine...

   Also, please look at the code to make sure I don't do anything foolish in
there... You can find it here: http://codereview.chromium.org/108040. Note
that this still only works on Windows... I will start doing the changes to
make it also work on Mac and Linux this afternoon... Once I get my
post-lunch latté :-)

Enjoy!

BYE
MAD :-)

On Mon, May 11, 2009 at 8:44 PM, Marc-Andre Decoste m...@chromium.orgwrote:

 Feel free to ping delme/del agl if you need help on Linux.  ;)


 Will do... thanks for the offer :-)

 BYE
 MAD

 On Mon, May 11, 2009 at 8:42 PM, Evan Martin e...@chromium.org wrote:


 On Mon, May 11, 2009 at 5:40 PM, Marc-Andre Decoste m...@chromium.org
 wrote:
  However, I think that means if you leave the TransportDIB as the union
 
  of all the dirty rects, everything should Just Work.  So your change
 
  becomes sending one unioned dirty rect image of pixel data, some of
 
  which that may not have actually been drawn to, along with an array of
 
  actually dirty subrectangles within the image.
 
  This is exactly what I'm doing on Windows... The receiving side loops on
 the
  dirty sub-rectangles and get their pixels from the single btimap being
  sent... And this bitmap is only valid in the areas of the
 sub-rectangles
  passed in a vector via IPC.
  Are we saying the same thing here?

 Yes.

  P.S.: I'm still validating that it is all OK on the Windows side, just
 fixed
  what I hope was the last refresh bug with Google maps, and then, I'll
 update
  the GTK and Coco version of the painting code...

 Feel free to ping delme/del agl if you need help on Linux.  ;)

 



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Peter Kasting
On Mon, May 11, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote:

 One feature of #webkit that I find useful is that every commit is
 summarized by the CIA-bot.

 http://cia.vc/


Funny, that's a feature I find utterly useless and annoying and I hate it.
 Why do you like it?

PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: i would like to help code chrome.. but i have some compilation issues (and unittest)

2009-05-12 Thread nakro

Lei, a thousand thanx now i can finally start coding
my first fix will be simple just to see how one checks code in
but then i will fix the horrible uninstall bugs, and many others i see
repeat themselves in the
hep forum.
the adventure really begins now

once again, thanx man (or women)
nakro

On May 12, 8:20 pm, Lei Zhang thes...@chromium.org wrote:
 On Tue, May 12, 2009 at 6:19 AM, nakro yoav.zilberb...@gmail.com wrote:
  the other thing, is that after i modify it the unit tests fail
  [  PASSED  ] 864 tests.
  [  FAILED  ] 1 test, listed below:
  [  FAILED  ] URLFetcherBadHTTPSTest.BadHTTPSTest

   1 FAILED TEST
   YOU HAVE 19 DISABLED TESTS

 Seehttp://dev.chromium.org/developers/testingunder SSL tests. If you
 look through the entire output, you'd see:

 TEST CONFIGURATION ERROR: you need to import the test ca certificate
 to your trusted roots for this test to work. For more info 
 visit:http://dev.chromium.org/developers/testing
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Adam Barth

On Tue, May 12, 2009 at 11:49 AM, Peter Kasting pkast...@chromium.org wrote:
 On Mon, May 11, 2009 at 6:35 PM, Adam Barth aba...@chromium.org wrote:

 One feature of #webkit that I find useful is that every commit is
 summarized by the CIA-bot.

 http://cia.vc/

 Funny, that's a feature I find utterly useless and annoying and I hate it.
  Why do you like it?

It's clear that enough people hate it that we shouldn't use it.  To
answer your question, I find it useful for two things:

1) It helps me keep up with who's working on what because I read the
first few lines of the commit messages as they scroll by in the
channel.

2) Sometimes I'll see something interesting scroll by and I can either
investigate it or ask people in the channel about it.

Of course there are other ways of doing those things (like reading the
buildbot page or subscribing to the RSS), but I find IRC useful since
I'm half paying attention to it anyway.

Adam

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: CIA-bot on #chromium?

2009-05-12 Thread Peter Kasting
On Tue, May 12, 2009 at 1:27 PM, Adam Barth aba...@chromium.org wrote:

 Of course there are other ways of doing those things (like reading the
 buildbot page or subscribing to the RSS), but I find IRC useful since
 I'm half paying attention to it anyway.


OK, that makes some sense.  I think if IRC was the main/only mechanism we
used to communicate I'd be more interested.  As-is I get most of this
information from being CCed on all code reviews, so I know to speak up then
if I see something exciting.

PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Skia is moving

2009-05-12 Thread Stephen White
I'm in the process of updating chromium to use tip-of-tree skia, and in the
same CL, moving skia to a third_party directory, retrieved via DEPS.  What
this means for you:
1)  Any outstanding CL's in which you've added #include
skia/include/... will have to be changed to the corresponding
path in third_party/skia/include/... (be warned that the subdirectory
layout is also slightly different).
2)  Going forward, any changes to skia will have to be done via commits to
skia.googlecode.com, and then rolling DEPS in chromium (much the same as we
now do for WebKit).
3)  The new version of skia appears to render rects whose coordinates are
backwards (ie., x2  x1 or y2  y1), which were formerly culled.  There
were a couple obvious instances of this in the code which I fixed, but there
may be more.

After this change, the local skia directory will contain only .gyp files,
ext/ (chromium-specific skia utilities), and config/ (new
directory, containing SkUserConfig.h).  Everything else will live in
third_party/skia.

There were ~35 layout test failures due to minor pixel differences which I
rebaselined on Windows and Linux, and 8 genuine failures related to masks
and stroked text, which I have put in text_expectations.txt and assigned to
myself.  (There was another change which broke ~1700 tests on each platform,
but I put that change behind an #ifdef for now).

Unless I hear otherwise, I'm planning to do this Wednesday morning, 10AM EST
(7AM PST).

Stephen

-- 
All truth passes through three stages. First, it is ridiculed. Second, it is
violently opposed. Third, it is accepted as being self-evident. --
Schopenhauer

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Skia is moving

2009-05-12 Thread Adam Langley

On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.org wrote:
 Unless I hear otherwise, I'm planning to do this Wednesday morning, 10AM EST
 (7AM PST).
 Stephen

Woo! Woo!

Very glad to see Skia unforking!

(Linux folks: this unblocks me writing complex-text support)



AGL

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Skia is moving

2009-05-12 Thread Nicolas Sylvain
On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.orgwrote:

 I'm in the process of updating chromium to use tip-of-tree skia, and in the
 same CL, moving skia to a third_party directory, retrieved via DEPS.  What
 this means for you:


Hi,

Why do you want to move it to third party?

The other projects developed at google that we fetch through DEPS like
googleurl, breakpad, gtests and courgette are all living in src, not
third_party..

Nicolas


 1)  Any outstanding CL's in which you've added #include
 skia/include/... will have to be changed to the corresponding
 path in third_party/skia/include/... (be warned that the subdirectory
 layout is also slightly different).
 2)  Going forward, any changes to skia will have to be done via commits to
 skia.googlecode.com, and then rolling DEPS in chromium (much the same as
 we now do for WebKit).
 3)  The new version of skia appears to render rects whose coordinates are
 backwards (ie., x2  x1 or y2  y1), which were formerly culled.  There
 were a couple obvious instances of this in the code which I fixed, but there
 may be more.

 After this change, the local skia directory will contain only .gyp files,
 ext/ (chromium-specific skia utilities), and config/ (new
 directory, containing SkUserConfig.h).  Everything else will live in
 third_party/skia.

 There were ~35 layout test failures due to minor pixel differences which I
 rebaselined on Windows and Linux, and 8 genuine failures related to masks
 and stroked text, which I have put in text_expectations.txt and assigned to
 myself.  (There was another change which broke ~1700 tests on each platform,
 but I put that change behind an #ifdef for now).

 Unless I hear otherwise, I'm planning to do this Wednesday morning, 10AM
 EST (7AM PST).

 Stephen

 --
 All truth passes through three stages. First, it is ridiculed. Second, it
 is violently opposed. Third, it is accepted as being self-evident. --
 Schopenhauer

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Skia is moving

2009-05-12 Thread Stephen White
On Tue, May 12, 2009 at 5:48 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:



 On Tue, May 12, 2009 at 2:22 PM, Stephen White 
 senorbla...@chromium.orgwrote:

 I'm in the process of updating chromium to use tip-of-tree skia, and in
 the same CL, moving skia to a third_party directory, retrieved via DEPS.
  What this means for you:


 Hi,

 Why do you want to move it to third party?

 The other projects developed at google that we fetch through DEPS like
 googleurl, breakpad, gtests and courgette are all living in src, not
 third_party..


Good point.  I arranged it that way because I needed to keep a local skia
dir as well (for config, etc), so I modeled
it on WebKit:  webkit/ has local mods, third_party/WebKit/ has the
webkit.org repo.  Do you feel strongly about it?

Stephen

-- 
All truth passes through three stages. First, it is ridiculed. Second, it is
violently opposed. Third, it is accepted as being self-evident. --
Schopenhauer

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Skia is moving

2009-05-12 Thread Brett Wilson

On Tue, May 12, 2009 at 2:48 PM, Nicolas Sylvain nsylv...@chromium.org wrote:
 On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.org
 wrote:

 I'm in the process of updating chromium to use tip-of-tree skia, and in
 the same CL, moving skia to a third_party directory,
 retrieved via DEPS.  What this means for you:

 Hi,
 Why do you want to move it to third party?
 The other projects developed at google that we fetch through DEPS like
 googleurl, breakpad, gtests and courgette are all living in src, not
 third_party..
 Nicolas

If our repo is not the canonical representation, they should all be in
thierd party. So I think that all your examples are in the wrong
place.

Brett

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Help: WebKit builder out of diskspace

2009-05-12 Thread Jeremy Moskovich
Can anyone resolve this so we can reopen the tree?
Thanks,
Jeremy

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Help: WebKit builder out of diskspace

2009-05-12 Thread Bradley Nelson
It's my change. Fixing but I've opened the tree, as the only side effect is
output goes somewhere else temporarily (hence the disk overflow).Sorry

-BradN


On Tue, May 12, 2009 at 3:11 PM, Jeremy Moskovich jer...@chromium.orgwrote:

 Can anyone resolve this so we can reopen the tree?
 Thanks,
 Jeremy

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Skia is moving

2009-05-12 Thread Darin Fisher
On Tue, May 12, 2009 at 3:06 PM, Brett Wilson bre...@chromium.org wrote:


 On Tue, May 12, 2009 at 2:48 PM, Nicolas Sylvain nsylv...@chromium.org
 wrote:
  On Tue, May 12, 2009 at 2:22 PM, Stephen White senorbla...@chromium.org
 
  wrote:
 
  I'm in the process of updating chromium to use tip-of-tree skia, and in
  the same CL, moving skia to a third_party directory,
  retrieved via DEPS.  What this means for you:
 
  Hi,
  Why do you want to move it to third party?
  The other projects developed at google that we fetch through DEPS like
  googleurl, breakpad, gtests and courgette are all living in src, not
  third_party..
  Nicolas

 If our repo is not the canonical representation, they should all be in
 thierd party. So I think that all your examples are in the wrong
 place.

 Brett



src/courgette is the canonical representation.  we placed googleurl,
breakpad, and v8 in src and not third_party because they are developed by
our team, so we do not have licensing / copyright concerns.

the rule we have been following is to put items in third_party that do not
conform to our licensing or that are developed by another group.  i think by
this measure it is correct for googleurl, breakpad, and v8 to live in src.
 same goes for gtest.  skia seems like a borderline case to me.

the point of third_party is to make ease the job of a licensing lawyer who
has to figure out what they need to worry about.

-darin

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Skia is moving

2009-05-12 Thread Nicolas Sylvain
On Tue, May 12, 2009 at 3:05 PM, Stephen White senorbla...@chromium.orgwrote:

 On Tue, May 12, 2009 at 5:48 PM, Nicolas Sylvain nsylv...@chromium.orgwrote:



 On Tue, May 12, 2009 at 2:22 PM, Stephen White 
 senorbla...@chromium.orgwrote:

 I'm in the process of updating chromium to use tip-of-tree skia, and in
 the same CL, moving skia to a third_party directory, retrieved via DEPS.
  What this means for you:


 Hi,

 Why do you want to move it to third party?

 The other projects developed at google that we fetch through DEPS like
 googleurl, breakpad, gtests and courgette are all living in src, not
 third_party..


 Good point.  I arranged it that way because I needed to keep a local skia
 dir as well (for config, etc), so I modeled
 it on WebKit:  webkit/ has local mods, third_party/WebKit/ has the
 webkit.org repo.  Do you feel strongly about it?


Do I feel strongly ? I do believe this belongs in src/, but since the
copyright on the files says The Android Open Source Project and not
Google, then, no, I do not feel strongly about it :)

Your call.

Nicolas


 Stephen

 --
 All truth passes through three stages. First, it is ridiculed. Second, it
 is violently opposed. Third, it is accepted as being self-evident. --
 Schopenhauer

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Extensions now a bit more useful on Dev!

2009-05-12 Thread Aaron Boodman
Hello everyone,

The extensions posse would like to point out that as of today's dev channel
release (2.0.180.0), extensions are starting to be a bit more useful. We can
now put little bits of UI in the chrome of Chrome, and some of the APIs are
starting to come together.
There is still quite a ways to go, but if you're interested in building
extensions for Chrome, this might be a good time to start taking a
look. There are some docs and samples here:

http://dev.chromium.org/developers/design-documents/extensions/howto
http://dev.chromium.org/developers/design-documents/extensions/howto
http://dev.chromium.org/developers/design-documents/extensions/samples

Following in what is apparently a tradition[1], one of our samples is a
builtbot monitor. Here is what it looks like when it is running:

[image: buildbot1.png]

And when you mouseover it, it expands to give some more detail:
[image: buildbot2.png]

I have found this to be useful, but I mostly keep it installed for the
awesome swoopy animation when you mouseover. It can't be captured in still
images -- you really must install and experience it in person.


*NOTE*
*
*
If you were already playing with the extension system, there are some
breaking changes in this release:

* All APIs are now at chrome.foo.bar() instead of chromium.foo.bar().
* There were many other random renames. See the latest docs which should be
up to date.


Thanks!

- TEP


[1] https://developer.mozilla.org/en/Creating_a_Mozilla_Extension

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread Aaron Boodman

Argh, Gmail. You're not my friend anymore.

On Tue, May 12, 2009 at 5:15 PM, Aaron Boodman a...@chromium.org wrote:
 Following in what is apparently a tradition[1], one of our samples is a 
 builtbot monitor. Here is what it looks like when it is running:

http://dev.chromium.org/_/rsrc/1242158011422/developers/design-documents/extensions/samples/buildbot1.png

http://dev.chromium.org/_/rsrc/1242158011422/developers/design-documents/extensions/samples/buildbot2.png

- a

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Severity Guidelines for Security Issues

2009-05-12 Thread Adam Barth

Thanks for all your comments.  The guidelines are now posted at:

http://dev.chromium.org/developers/severity-guidelines

Adam


On Thu, May 7, 2009 at 11:41 PM, Adam Barth aba...@chromium.org wrote:
 Recently some folks have asked how we decide what severity to rate
 each security vulnerability.  Thus far, we've mostly been using an
 informal process, but it seemed like a good idea to spell out our
 policy publicly.  Below is a draft of some guidelines for assigning
 severities to security issues.  Please let me know if you have any
 feedback.  Once the draft stabilizes, we'll find a home for the
 guidelines on dev.chromium.org.

 http://docs.google.com/Doc?id=dd4p8wc4_11cxwzfqfm

 This document is heavily influenced by Mozilla's guidelines for rating
 security vulnerabilities, which you can find at
 https://wiki.mozilla.org/Security_Severity_Ratings.  The main
 difference is that the above document explains how the severity of
 security issues interacts with the sandbox.

 Thanks!
 Adam


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Should the header file sentries contain double underscores?

2009-05-12 Thread Adam Barth

We're following Google Style:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml

Adam


On Tue, May 12, 2009 at 9:29 PM, Benjamin ice...@gmail.com wrote:

 What is the point of a single trailing underscore?  Wouldn't it make
 more sense to match webkit and have no trailing underscore?

 -Benjamin Meyer

 On Tue, May 12, 2009 at 8:32 AM, Dean McNamee de...@chromium.org wrote:

 Yes, this is legacy.  You'll see that new code uses (at least should
 use) a single trailing underscore:

 cpu.h:#ifndef BASE_CPU_H_
 cpu.h:#define BASE_CPU_H_
 cpu.h:#endif  // BASE_CPU_H_

 It should be an easy mass replace, but it's not really more than an
 ideological concern.  We've just been slowly updating guards as we
 touch the files.

 Thanks
 -- dean

 On Tue, May 12, 2009 at 1:37 PM, Glider ramosian.gli...@gmail.com wrote:

 Hi chromium-dev,

 The Chromium header files begin with a sentry section that looks like:
 #ifndef PATH_FILENAME__
 #define PATH_FILENAME__

 However, the names containing __ are reserved according to the C++
 standard and cannot be used.

 Is that a legacy in the codebase, or should it be fixed?

 WBR,
 Alexander Potapenko


 


 


 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread Aaron Boodman

2009/5/12 PhistucK phist...@gmail.com:
 Note that in the Content Scripts page, there are two things to fix -
 The sample Content Script for google.com (replacing the image) does not work
 because the document.images.length is 0.
 Also, there is a mentioning in the comment of the API reference of
 chromium.self.onConnect, should be chrome.self.onConnect, no?
 Thank you for the hard work, already been experimenting.

 ☆PhistucK

Thanks, I fixed the content script documentation reference to
chromium. I don't see what you mean though about the sample content
script not working. It seems to work for me.

 -a

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread PhistucK
Oh, so sorry, when I go to google.com, it goes straight to my local domain
(still English, at least) - generally annoying. After I clicked on the link
to go to where I wanted to go in the first place, the script worked because
there is an image there. Sorry!
(Unify the structure of the main Google page in all of the locals!!! :P
Or give me an option to always always always go to google.com :()

By the way - is the Extensions system slated for the Chrome 2 release, or is
it not a requirement for it?
(Because I saw some messages, though not from officials, saying it is slated
for Chrome 3, which seems kind of far away.)
And on the same note, the Beta branch is not being merged with new features
(only really critical ones), as I noticed. Does this mean that the features
currently on the Beta branch are more or less what is to be expected from 2?

Thank you for all of the hard work.

☆PhistucK


2009/5/13 Aaron Boodman a...@chromium.org

 2009/5/12 PhistucK phist...@gmail.com:
  Note that in the Content Scripts page, there are two things to fix -
  The sample Content Script for google.com (replacing the image) does not
 work
  because the document.images.length is 0.
  Also, there is a mentioning in the comment of the API reference of
  chromium.self.onConnect, should be chrome.self.onConnect, no?
  Thank you for the hard work, already been experimenting.
 
  ☆PhistucK

 Thanks, I fixed the content script documentation reference to
 chromium. I don't see what you mean though about the sample content
 script not working. It seems to work for me.

  -a


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread Peter Kasting
2009/5/12 PhistucK phist...@gmail.com

 Or give me an option to always always always go to google.com :()


www.google.com/ncr ?

By the way - is the Extensions system slated for the Chrome 2 release, or is
 it not a requirement for it?


No


 (Because I saw some messages, though not from officials, saying it is
 slated for Chrome 3, which seems kind of far away.)


How do you know when stable versions will ship?  While it's taken a while to
ship this one, I believe our channel changer estimates about once a
quarter.


 And on the same note, the Beta branch is not being merged with new features
 (only really critical ones), as I noticed. Does this mean that the features
 currently on the Beta branch are more or less what is to be expected from 2?


Yes

PK

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



Re: [chromium-discuss] Re: [chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread Nick Baum
To expand on Peter's comment, we're more focused on specific features than
release numbers. The extension system will work its way to the stable
channel as soon as it's got enough APIs to be broadly useful.

The team is working really hard to get to that point as soon as possible;
we're excited to see it out in the wild too!

-Nick

On Tue, May 12, 2009 at 10:29 PM, Peter Kasting pkast...@chromium.orgwrote:

 2009/5/12 PhistucK phist...@gmail.com

 Or give me an option to always always always go to google.com :()


 www.google.com/ncr ?

 By the way - is the Extensions system slated for the Chrome 2 release, or
 is it not a requirement for it?


 No


 (Because I saw some messages, though not from officials, saying it is
 slated for Chrome 3, which seems kind of far away.)


 How do you know when stable versions will ship?  While it's taken a while
 to ship this one, I believe our channel changer estimates about once a
 quarter.


 And on the same note, the Beta branch is not being merged with new
 features (only really critical ones), as I noticed. Does this mean that the
 features currently on the Beta branch are more or less what is to be
 expected from 2?


 Yes

 PK

 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



Re: [chromium-discuss] Re: [chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread PhistucK
Thank you for your answers, there has been no word regarding what is slated
for what release, so I hoped you could really clear that out - and you did.
About the Chrome 3 release time, a few months are also far away for some
people ;)
And if we go by the estimation, in a year we should have something like
Chrome 5? seems kind of too quick. Is that what you meant?

OK, so now things are far more clear, thank you very much for the meaningful
answers.


☆PhistucK


On Wed, May 13, 2009 at 08:42, Nick Baum nickb...@chromium.org wrote:

 To expand on Peter's comment, we're more focused on specific features than
 release numbers. The extension system will work its way to the stable
 channel as soon as it's got enough APIs to be broadly useful.

 The team is working really hard to get to that point as soon as possible;
 we're excited to see it out in the wild too!

 -Nick

 On Tue, May 12, 2009 at 10:29 PM, Peter Kasting pkast...@chromium.orgwrote:

 2009/5/12 PhistucK phist...@gmail.com

 Or give me an option to always always always go to google.com :()


 www.google.com/ncr ?

 By the way - is the Extensions system slated for the Chrome 2 release, or
 is it not a requirement for it?


 No


 (Because I saw some messages, though not from officials, saying it is
 slated for Chrome 3, which seems kind of far away.)


 How do you know when stable versions will ship?  While it's taken a while
 to ship this one, I believe our channel changer estimates about once a
 quarter.


 And on the same note, the Beta branch is not being merged with new
 features (only really critical ones), as I noticed. Does this mean that the
 features currently on the Beta branch are more or less what is to be
 expected from 2?


 Yes

 PK

 



--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



Re: [chromium-discuss] Re: [chromium-dev] Re: Extensions now a bit more useful on Dev!

2009-05-12 Thread Nick Baum
Yeah, don't worry too much about Chrome 3 vs 5, the numbers are just a way
to keep track of releases.
As long as a year from now, you have a Chrome that has lots of cool new
features, we're doing the right thing!

-Nick

2009/5/12 PhistucK phist...@gmail.com

 Thank you for your answers, there has been no word regarding what is slated
 for what release, so I hoped you could really clear that out - and you did.
 About the Chrome 3 release time, a few months are also far away for some
 people ;)
 And if we go by the estimation, in a year we should have something like
 Chrome 5? seems kind of too quick. Is that what you meant?

 OK, so now things are far more clear, thank you very much for the
 meaningful answers.


 ☆PhistucK



 On Wed, May 13, 2009 at 08:42, Nick Baum nickb...@chromium.org wrote:

 To expand on Peter's comment, we're more focused on specific features than
 release numbers. The extension system will work its way to the stable
 channel as soon as it's got enough APIs to be broadly useful.

 The team is working really hard to get to that point as soon as possible;
 we're excited to see it out in the wild too!

 -Nick

 On Tue, May 12, 2009 at 10:29 PM, Peter Kasting pkast...@chromium.orgwrote:

 2009/5/12 PhistucK phist...@gmail.com

 Or give me an option to always always always go to google.com :()


 www.google.com/ncr ?

 By the way - is the Extensions system slated for the Chrome 2 release, or
 is it not a requirement for it?


 No


 (Because I saw some messages, though not from officials, saying it is
 slated for Chrome 3, which seems kind of far away.)


 How do you know when stable versions will ship?  While it's taken a while
 to ship this one, I believe our channel changer estimates about once a
 quarter.


 And on the same note, the Beta branch is not being merged with new
 features (only really critical ones), as I noticed. Does this mean that the
 features currently on the Beta branch are more or less what is to be
 expected from 2?


 Yes

 PK

 




--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---