[chromium-dev] Fwd: [webkit-dev] Please welcome GYP to the our dysfunctional build family
People are talking about GYP on the webkit-dev mailing list. It would be nice if we could convince the rest of WebKit to use GYP since it seems we're pretty committed at this point. Unfortunately I don't think there are any GYP experts on that list. At the moment, it'd be nice to know why we created GYP as opposed to using something else like cmake. J -- Forwarded message -- From: Brent Fulgham bfulg...@gmail.com Date: Sun, Jul 12, 2009 at 9:28 AM Subject: Re: [webkit-dev] Please welcome GYP to the our dysfunctional build family To: Jeremy Orlow jor...@chromium.org Cc: Adam Treat tr...@kde.org, Mark Mentovai m...@chromium.org, webkit-...@lists.webkit.org webkit-...@lists.webkit.org Hi, I asked some similar questions on IRC. On Friday 10 July 2009 12:23:50 am Dimitri Glazkov wrote: As you may know, we use GYP ( http://code.google.com/p/gyphttp://code.google.com/p/gyp) for generating MSVC, XCode, Scons, and even Make projects for Chromium. On Sun, Jul 12, 2009 at 5:38 AM, Adam Treat tr...@kde.orgtr...@kde.org wrote: Gyp sounds remarkably similar to CMake to me. On Jul 12, 2009, at 7:42 AM, Jeremy Orlow jor...@chromium.org wrote: From a quick glance at cmake's website, it seems that it's a build system and not a project file generator. I think it was pretty important to us to generate project files so that you can use the full power of each platform's IDE and toolchain. You might want to take a closer look! ;) CMake generates the desired build environment. So, on Windows it generates visual studio projects, on Mac OS it generates Xcode projects, and on Linux it generates Makefiles. You can override this behavior to get some other target. It can also drive the entire build, but that's not how a lot of people use it. So Cmake seems equivalent to GYP. GYP probably has unique features that make it more desireable than Cmake for one reason or another (perhaps it's easier to add new platform support or something), but at the moment those benefits are not obvious to me. I'm afraid that as far as I can tell, GYP seems like a case of NIH syndrome. -Brent --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Using Chromium Source Code?
On Thu, Jul 9, 2009 at 8:39 AM, dhhwaidhh...@gmail.com wrote: Well, the Chromium _source code_ is open source. But my guess is I don't think you can use the Chromium name nor logo in any personally distributed software. I'm not sure what you mean by this, as there are already chromium packages being distributed by groups who are not Google. They call it chromium and use the blue/silver icon. But I can't see why he'd want to reuse that name anyway if he's making such drastic changes. Besides, I don't expect that you will since you want to make your own commercial software package. On Jul 9, 6:56 am, PhistucK phist...@gmail.com wrote: Not really, the open source Chrome is Chromium for a reason, so you could use it.As far as I know, there are no closed copyrights for the Chromium logo or name. (Could be mistaking, though.) ☆PhistucK On Thu, Jul 9, 2009 at 16:46, Kruncher leaha...@gmail.com wrote: Thanks for the link of terms, and for your confirmation. From what I can see in the terms, Chromium is primarily covered by the BSD and LGPL licences, so I can't see a problem there. I guess my primary concern is with copyright if I am reworking the Chromium browser part of the project to meet my own needs. On 8 July, 03:43, Evan Martin e...@chromium.org wrote: On Tue, Jul 7, 2009 at 2:59 PM, Kruncherleaha...@gmail.com wrote: I would like to use the Chromium source code as the basis to a custom documentation viewer. The following outlines what I would like to do with the source: - Add sidebar panels to left/right of each Chromium window. - Remove unwanted features from drop-down menu buttons on main tool strip. - Remove Inspector and the various web developer and debugging tools from interface. - Replace search functionality with custom search functionality in URI address bar. - Add a custom scheme name my-scheme:something/a/b/c.html - Adjust About dialog box to reflect title of product with logo and product artwork. - Change colour scheme of the browser. Whilst the application will still be able to access the webpages from the Internet, it will be used primarily for viewing offline content. I have a couple of questions: 1. Would this be compatible with the associated open source license? 2. Could the product be distributed as a part of a commercial package? http://code.google.com/chromium/terms.htmldescribesthe licenses of the code. In general, the answer to both of your questions is yes -- applications like yours are part of our intent in releasing the code -- but you should definitely check with a lawyer before making a commercial release, and I am not a lawyer. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Fwd: [webkit-dev] Please welcome GYP to the our dysfunctional build family
Specifically, there were reasons why GYP was created instead of just using CMake. Mark Mentovai should comment. -Ben On Sun, Jul 12, 2009 at 12:30 PM, Jeremy Orlowjor...@chromium.org wrote: People are talking about GYP on the webkit-dev mailing list. It would be nice if we could convince the rest of WebKit to use GYP since it seems we're pretty committed at this point. Unfortunately I don't think there are any GYP experts on that list. At the moment, it'd be nice to know why we created GYP as opposed to using something else like cmake. J -- Forwarded message -- From: Brent Fulgham bfulg...@gmail.com Date: Sun, Jul 12, 2009 at 9:28 AM Subject: Re: [webkit-dev] Please welcome GYP to the our dysfunctional build family To: Jeremy Orlow jor...@chromium.org Cc: Adam Treat tr...@kde.org, Mark Mentovai m...@chromium.org, webkit-...@lists.webkit.org webkit-...@lists.webkit.org Hi, I asked some similar questions on IRC. On Friday 10 July 2009 12:23:50 am Dimitri Glazkov wrote: As you may know, we use GYP (http://code.google.com/p/gyp) for generating MSVC, XCode, Scons, and even Make projects for Chromium. On Sun, Jul 12, 2009 at 5:38 AM, Adam Treat tr...@kde.org wrote: Gyp sounds remarkably similar to CMake to me. On Jul 12, 2009, at 7:42 AM, Jeremy Orlow jor...@chromium.org wrote: From a quick glance at cmake's website, it seems that it's a build system and not a project file generator. I think it was pretty important to us to generate project files so that you can use the full power of each platform's IDE and toolchain. You might want to take a closer look! ;) CMake generates the desired build environment. So, on Windows it generates visual studio projects, on Mac OS it generates Xcode projects, and on Linux it generates Makefiles. You can override this behavior to get some other target. It can also drive the entire build, but that's not how a lot of people use it. So Cmake seems equivalent to GYP. GYP probably has unique features that make it more desireable than Cmake for one reason or another (perhaps it's easier to add new platform support or something), but at the moment those benefits are not obvious to me. I'm afraid that as far as I can tell, GYP seems like a case of NIH syndrome. -Brent --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Fwd: [webkit-dev] Please welcome GYP to the our dysfunctional build family
Ben Goodger (Google) wrote: Specifically, there were reasons why GYP was created instead of just using CMake. Mark Mentovai should comment. I'm not on webkit-dev, but I was on the cc list for that thread. I'm unwinding from the weekend now, but I'll subscribe and post a response later tonight or tomorrow. Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Using Chromium Source Code?
Thanks for all of your input. I have no intention of keeping the Chromium name nor logo (unless, obviously, I come across a requirement in one of the license agreements). I will be replacing that with my own logo. Thanks again! Lea Hayes On 12 July, 21:07, Evan Stade est...@chromium.org wrote: On Thu, Jul 9, 2009 at 8:39 AM, dhhwaidhh...@gmail.com wrote: Well, the Chromium _source code_ is open source. But my guess is I don't think you can use the Chromium name nor logo in any personally distributed software. I'm not sure what you mean by this, as there are already chromium packages being distributed by groups who are not Google. They call it chromium and use the blue/silver icon. But I can't see why he'd want to reuse that name anyway if he's making such drastic changes. Besides, I don't expect that you will since you want to make your own commercial software package. On Jul 9, 6:56 am, PhistucK phist...@gmail.com wrote: Not really, the open source Chrome is Chromium for a reason, so you could use it.As far as I know, there are no closed copyrights for the Chromium logo or name. (Could be mistaking, though.) ☆PhistucK On Thu, Jul 9, 2009 at 16:46, Kruncher leaha...@gmail.com wrote: Thanks for the link of terms, and for your confirmation. From what I can see in the terms, Chromium is primarily covered by the BSD and LGPL licences, so I can't see a problem there. I guess my primary concern is with copyright if I am reworking the Chromium browser part of the project to meet my own needs. On 8 July, 03:43, Evan Martin e...@chromium.org wrote: On Tue, Jul 7, 2009 at 2:59 PM, Kruncherleaha...@gmail.com wrote: I would like to use the Chromium source code as the basis to a custom documentation viewer. The following outlines what I would like to do with the source: - Add sidebar panels to left/right of each Chromium window. - Remove unwanted features from drop-down menu buttons on main tool strip. - Remove Inspector and the various web developer and debugging tools from interface. - Replace search functionality with custom search functionality in URI address bar. - Add a custom scheme name my-scheme:something/a/b/c.html - Adjust About dialog box to reflect title of product with logo and product artwork. - Change colour scheme of the browser. Whilst the application will still be able to access the webpages from the Internet, it will be used primarily for viewing offline content. I have a couple of questions: 1. Would this be compatible with the associated open source license? 2. Could the product be distributed as a part of a commercial package? http://code.google.com/chromium/terms.htmldescribesthelicenses of the code. In general, the answer to both of your questions is yes -- applications like yours are part of our intent in releasing the code -- but you should definitely check with a lawyer before making a commercial release, and I am not a lawyer. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Compile base_unittests fails
Does anyone help me ? How do you compile it with success? chrome[24-18:18:48]/home/chrome/src/basehammer base_unittests scons: Reading SConscript files ... scons: done reading SConscript files. scons: Building targets ... Extracting last change to /home/chrome/src/sconsbuild/Debug/obj/ _global_intermediate/build/LASTCHANGE Compiling /home/chrome/src/sconsbuild/Debug/obj/base/third_party/ dmg_fp/dtoa.o Compiling /home/chrome/src/sconsbuild/Debug/obj/base/third_party/ xdg_mime/xdgmimemagic.o Compiling /home/chrome/src/sconsbuild/Debug/obj/base/third_party/ xdg_mime/xdgmimeparent.o cc1plus: warnings being treated as errors third_party/dmg_fp/dtoa.cc: In function 'void dmg_fp::hexnan (dmg_fp::U*, const char**)': third_party/dmg_fp/dtoa.cc:1558: warning: array subscript has type 'char' third_party/dmg_fp/dtoa.cc: In function 'double dmg_fp::strtod(const char*, char**)': third_party/dmg_fp/dtoa.cc:3282: warning: converting to 'ULong' from 'double' third_party/dmg_fp/dtoa.cc: In function 'char* dmg_fp::dtoa(double, int, int, int*, int*, char**)': third_party/dmg_fp/dtoa.cc:3836: warning: converting to 'long int' from 'double' scons: *** [/home/chrome/src/sconsbuild/Debug/obj/base/third_party/ dmg_fp/dtoa.o] Error 1 scons: building terminated because of errors. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Compile base_unittests fails
On Sun, Jul 12, 2009 at 8:38 PM, empriserxueyunl...@gmail.com wrote: third_party/dmg_fp/dtoa.cc: In function 'void dmg_fp::hexnan (dmg_fp::U*, const char**)': third_party/dmg_fp/dtoa.cc:1558: warning: array subscript has type 'char' The line in question is: if (!hexdig['0']) So yes, the warning is correct. What compiler are you using? I am curious why this hasn't affected us already. It looks like we've already patched around some warnings in this code, so maybe we need to do more of that. http://src.chromium.org/viewvc/chrome/trunk/src/base/third_party/dmg_fp/README.chromium (BTW, I also looked into whether our copy of this file is old, but we match the newest version linked from the author's home page.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Compile base_unittests fails
Thanks, my gcc version is out. I need update it. chrome[24-18:18:59]/home/chrome/src/basegcc --version gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-44) Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. On Jul 13, 1:18 pm, Evan Martin e...@chromium.org wrote: On Sun, Jul 12, 2009 at 8:38 PM, empriserxueyunl...@gmail.com wrote: third_party/dmg_fp/dtoa.cc: In function 'void dmg_fp::hexnan (dmg_fp::U*, const char**)': third_party/dmg_fp/dtoa.cc:1558: warning: array subscript has type 'char' The line in question is: if (!hexdig['0']) So yes, the warning is correct. What compiler are you using? I am curious why this hasn't affected us already. It looks like we've already patched around some warnings in this code, so maybe we need to do more of that.http://src.chromium.org/viewvc/chrome/trunk/src/base/third_party/dmg_... (BTW, I also looked into whether our copy of this file is old, but we match the newest version linked from the author's home page.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
