Re: [chromium-dev] layout-test outputs and spell-checker
Hi Jeremy, et al, Sorry for my super-slow update. To investigate this issue deeply, this problem may be caused by font-smoothing since I can get the correct output when I execute 'defaults -currentHost write -g AppleFontSmoothing -int 0' on my mac book and disable font-smoothing. (I usually set this value to 2 medium - best for plat panel.) If I recall correctly, test_shell used to call SetDefaultsToLayoutTestValues() via DefTestShellPlatformDelegate::SelectUnifiedTheme() to disable the font-smoothing while layout tests as WebKit DumpRenderTree does. Nevertheless, the current test_shell doesn't seems to call the function any longer. So, I'm wondering whether or not this is an intentional change. (It may be a good idea to keep disabling such tests and send the review request for this change.) Best regards, Hironori Bono E-mail: hb...@chromium.org 2009/12/17 Hironori Bono (坊野 博典) hb...@chromium.org: Hi Jeremy, Thank you for your quick response. To check the source of the expected image, I notice it comes from the WebKit tree (i.e. third_party/WebKit/LayoutTests/platform/mac/editing/selection/unrendered-002-expected.png). So, I would like to run WebKit layout tests, see its output images, and investigate the font used by WebKit layout test. By the way, I'm using Leopard (10.5.8 Build 9L31a) but its locale is Japanese. :) Regards, Hironori Bono E-mail: hb...@chromium.org 2009/12/16 Jeremy Moskovich jer...@chromium.org: Hi Horonori, Thanks for taking a look at this!! What kinds of differences are you seeing without the new spellchecker class? The only notable difference seems to be that the fonts are slightly different vs. the expected output. Where is the expected output coming from? What OS version are you running this on? btw. The scrollbar diffs are to expected as we draw scrollbars differently in Chrome than Safari does. Best regards, Jeremy 2009/12/16 Hironori Bono (坊野 博典) hb...@chromium.org Greetings chromium-developers, Sorry for my beginner's question in advance. To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I have implemented a MockSpellcheck class (*3), which is a mock implementation of our spell-checker used for layout tests. Even though this change can fix most layout-test failures listed in Issue 23497, there are a layout test that fails on an unknown reason, editing/selection/unrendered-002.html. To run such tests on my Mac, our test_shell outputs very similar images as the expected one but actually different ones as shown in the attached pictures. Would it be possible to give me your thoughts about why our test_shell cannot create the expected image for this case? (*1) http://crbug.com/11577 (*2) http://crbug.com/23497 (*3) http://codereview.chromium.org/493003/show Best regards, Hironori Bono E-mail: hb...@chromium.org -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
[+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio FLAKY_Popuphttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/FLAKY_Popup FAQ: http://dev.chromium.org/developers/try-server-usage -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio FLAKY_Popuphttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/FLAKY_Popup FAQ: http://dev.chromium.org/developers/try-server-usage -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing
Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
Clobber Done. On Thu, Jan 21, 2010 at 9:44 AM, Thomas Van Lenten thoma...@chromium.orgwrote: DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio FLAKY_Popuphttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/FLAKY_Popup FAQ: http://dev.chromium.org/developers/try-server-usage -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email
Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
With regards to BookmarkContextMenuTest.DeleteURL, I filed http://crbug.com/32784. Glen, you should make sure this bug is triaged accordingly since flaky crashers can't be tolerated. M-A On Thu, Jan 21, 2010 at 9:45 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: Clobber Done. On Thu, Jan 21, 2010 at 9:44 AM, Thomas Van Lenten thoma...@chromium.orgwrote: DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel mar...@chromium.orgwrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.orgwrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED *If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM.* Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 'pinkerton: appmode' try job svnkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell/logs/stdio update scripts stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_1/logs/stdio taskkill stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/shell_2/logs/stdio update patchhttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/patch stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/gclient/logs/stdio compile stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/compile/logs/stdio Start Crash Handler stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/Start%20Crash%20Handler/logs/stdio check deps stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/check%20deps/logs/stdio ipc_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ipc_tests/logs/stdio installer_util_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/installer_util_unittests/logs/stdio sync_unit_tests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/sync_unit_tests/logs/stdio unit_tests did not complete failed 2 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/stdio PersistIDsTesthttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/PersistIDsTest TestDownloadFilenamehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/unit_tests/logs/TestDownloadFilename app_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/app_unittests/logs/stdio ui_tests 27 disabled 38 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/stdio FLAKY_LocationReplacehttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/ui_tests/logs/FLAKY_LocationReplace test_shell_tests 2 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/test_shell_tests/logs/stdio webkit_unit_tests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/webkit_unit_tests/logs/stdio base_unittests 1 disabled 2 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/base_unittests/logs/stdio net_unittests 7 disabled 7 flaky stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/net_unittests/logs/stdio googleurl_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/googleurl_unittests/logs/stdio media_unittests 1 disabled stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/media_unittests/logs/stdio printing_unittests stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/printing_unittests/logs/stdio browser_tests 1001 flaky failed 1 stdiohttp://build.chromium.org/buildbot/try-server/builders/win/builds/15281/steps/browser_tests/logs/stdio
Re: [chromium-dev] Re: try failure for 'pinkerton: appmode' try job on win @ r36656
BookmarkContextMenuTest.DeleteURL is not listed on the flakiness dashboard. BookmarkContextMenuTest relies indirectly on string ids as well. The clobber should have fixed it. Is there no way we can make the test harnesses fail early on if the ids change but everything isn't recompiled? -Scott On Thu, Jan 21, 2010 at 7:25 AM, Marc-Antoine Ruel mar...@chromium.org wrote: With regards to BookmarkContextMenuTest.DeleteURL, I filed http://crbug.com/32784. Glen, you should make sure this bug is triaged accordingly since flaky crashers can't be tolerated. M-A On Thu, Jan 21, 2010 at 9:45 AM, Marc-Antoine Ruel mar...@chromium.org wrote: Clobber Done. On Thu, Jan 21, 2010 at 9:44 AM, Thomas Van Lenten thoma...@chromium.org wrote: DownloadFilename is a strings error, the bot needs a clobber. We had this on the main waterfall yesterday morning also and the few that saw it got fixed by a clobber. TVL On Thu, Jan 21, 2010 at 9:36 AM, Marc-Antoine Ruel mar...@chromium.org wrote: [+chromium-dev and sheriffs] These are flaky tests. It is disturbing since there is a crash in a really normal UI workflow (bookmarks) Whoever knows about these tests should work on fixing these or putting these as flaky (except the last one since it's a crasher): - DownloadManagerTest.TestDownloadFilename - BookmarkCodecTest.PersistIDsTest - BookmarkContextMenuTest.DeleteURL M-A On Wed, Jan 20, 2010 at 5:16 PM, Mike Pinkerton pinker...@chromium.org wrote: I don't see how these tests could fail with my (effectively) mac-only change. On Wed, Jan 20, 2010 at 5:14 PM, tryser...@chromium.org wrote: http://build.chromium.org/buildbot/try-server/ TRY FAILED If you think the try slave is broken (it happens!), please REPLY to this email, don't ask on irc, mailing list or IM. Thanks! http://build.chromium.org/buildbot/try-server/builders/win/builds/15281 win Build 15281 'pinkerton: appmode' try job svnkill stdio update scripts stdio taskkill stdio update patch stdio compile stdio Start Crash Handler stdio check deps stdio ipc_tests stdio installer_util_unittests stdio sync_unit_tests 1 disabled stdio unit_tests did not complete failed 2 stdio PersistIDsTest TestDownloadFilename app_unittests 1 disabled stdio ui_tests 27 disabled 38 flaky failed 1 stdio FLAKY_LocationReplace test_shell_tests 2 disabled stdio webkit_unit_tests stdio base_unittests 1 disabled 2 flaky stdio net_unittests 7 disabled 7 flaky stdio googleurl_unittests stdio media_unittests 1 disabled stdio printing_unittests stdio browser_tests 1001 flaky failed 1 stdio FLAKY_Popup FAQ: http://dev.chromium.org/developers/try-server-usage -- Mike Pinkerton Mac Weenie pinker...@google.com -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Chromium Mac Builder, revision 36760
Automatically closing tree for compile on Chromium Mac Builder http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20Builder/builds/9732 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Mac%20Builder --= Automatically closing tree for compile on Chromium Mac Builder =-- Revision: 36757, 36758, 36760 Blame list: a...@chromium.org,c...@chromium.org,stuartmor...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Mac10.5 Tests (dbg)(1), revision 36771
Automatically closing tree for unit_tests on Mac10.5 Tests (dbg)(1) http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests%20%28dbg%29%281%29/builds/11603 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests%20%28dbg%29%281%29 --= Automatically closing tree for unit_tests on Mac10.5 Tests (dbg)(1) =-- Revision: 36770, 36771 Blame list: rvar...@google.com,zelid...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Modules Vista, revision 36785
Automatically closing tree for net_unittests on Modules Vista http://build.chromium.org/buildbot/waterfall/builders/Modules%20Vista/builds/22744 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20Vista --= Automatically closing tree for net_unittests on Modules Vista =-- Revision: 36785 Blame list: cbent...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Modules XP, revision 36800
Automatically closing tree for net_unittests on Modules XP http://build.chromium.org/buildbot/waterfall/builders/Modules%20XP/builds/22178 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Modules%20XP --= Automatically closing tree for net_unittests on Modules XP =-- Revision: 36800 Blame list: aka...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Linux Perf (2), revision 36824
Automatically closing tree for compile on Linux Perf (2) http://build.chromium.org/buildbot/waterfall/builders/Linux%20Perf%20%282%29/builds/318 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Perf%20%282%29 --= Automatically closing tree for compile on Linux Perf (2) =-- Revision: 36819, 36820, 36824 Blame list: ajw...@chromium.org,mbel...@chromium.org,osh...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Webkit (dbg)(1), revision 36838
Automatically closing tree for test_shell_tests on Webkit (dbg)(1) http://build.chromium.org/buildbot/waterfall/builders/Webkit%20%28dbg%29%281%29/builds/14976 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20%28dbg%29%281%29 --= Automatically closing tree for test_shell_tests on Webkit (dbg)(1) =-- Revision: 36837, 36838 Blame list: t...@chromium.org,willc...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Webkit Builder, revision 36844
Automatically closing tree for update on Webkit Builder http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Builder/builds/23028 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Webkit%20Builder --= Automatically closing tree for update on Webkit Builder =-- Revision: 36844 Blame list: dpra...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] buildbot failure in Chromium on Vista Tests (dbg)(1), revision 36849
Automatically closing tree for unit_tests on Vista Tests (dbg)(1) http://build.chromium.org/buildbot/waterfall/builders/Vista%20Tests%20%28dbg%29%281%29/builds/18377 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Vista%20Tests%20%28dbg%29%281%29 --= Automatically closing tree for unit_tests on Vista Tests (dbg)(1) =-- Revision: 36849 Blame list: t...@chromium.org Buildbot waterfall: http://build.chromium.org/ -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
