[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux
We build on a recent Fedora and Ubuntu in an attempt to find compile errors between gcc versions, but the bots frequently are red. Still suspect we should turn off -Werror unless gcc_version == known_version_used_by_developers http://build.chromium.org/buildbot/waterfall.fyi/waterfall?builder=Chromium%20Linux%20(Jaunty)&builder=Chromium%20Linux%20(Fedora%2011,%20dbg) On Thu, Jul 30, 2009 at 1:19 PM, Dan Kegel wrote: > That's the third such cl I've seen. Conclusion: tiny fixes like that should > be committed as tbr to avoid duplication of effort. > > On Jul 30, 2009 12:44 PM, "Wan-Teh Chang" wrote: > > On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares wrote: > > >> Hi, > > I'm running... > > Thanks a lot for the patch. I think your patch is correct. > I will convert it to a changelist and ask jshin to review it. > > Wan-Teh > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux
That's the third such cl I've seen. Conclusion: tiny fixes like that should be committed as tbr to avoid duplication of effort. On Jul 30, 2009 12:44 PM, "Wan-Teh Chang" wrote: On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares wrote: > > > Hi, > > I'm running... Thanks a lot for the patch. I think your patch is correct. I will convert it to a changelist and ask jshin to review it. Wan-Teh --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-de... --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux
On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares wrote: > > > Hi, > > I'm running Debian, with GCC 4.3.3 and am current getting a > compilation error while compiling Chromium: > > cc1plus: warnings being treated as errors > chromium/src/net/base/net_util.cc: In function > 'bool::IsIDNComponentSafe(const char16*, int, const > std::wstring&)': > chromium/src/net/base/net_util.cc:641: error: suggest parentheses > around assignment used as truth value > scons: *** [chromium/src/sconsbuild/Release/obj/net/base/net_util.o] > Error 1 > > The code in question was introduced at revision 21963. The obvious > patch (below) fixes the issue for me. > However, without understanding the code, I can't be sure the typo as > actually to change "=" to "==". > Since we return 'safe', I assumed that the assignment was what was > intended. Thanks a lot for the patch. I think your patch is correct. I will convert it to a changelist and ask jshin to review it. Wan-Teh --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
