Thanks for spotting this! Figures it happened in one of the files I didn't write a unit test for :) Fix is up for review: http://codereview.chromium.org/155703
Andrew On Fri, Jul 17, 2009 at 10:19 AM, Jeremy Orlow <jor...@chromium.org> wrote: > Hi ffmpeg, :-) > Chromium doesn't accept patches like this. It's possible some kind soul > will go ahead and patch this into their client and get it reviewed and > committed for you, but the way things usually work is described here: > > http://dev.chromium.org/developers/contributing-code > > J > > > On Fri, Jul 17, 2009 at 12:53 AM, avcoder <ffm...@gmail.com> wrote: > >> Dear: >> >> As subject! >> >> The following patch fixed the bug: >> >> Index: ffmpeg_audio_decoder.cc >> =================================================================== >> --- ffmpeg_audio_decoder.cc (revision 20937) >> +++ ffmpeg_audio_decoder.cc (working copy) >> @@ -108,6 +108,7 @@ >> // If we have decoded something, enqueue the result. >> if (output_buffer_size) { >> DataBuffer* result_buffer = new DataBuffer(output_buffer_size); >> + result_buffer->SetDataSize(output_buffer_size); >> uint8* data = result_buffer->GetWritableData(); >> memcpy(data, output_buffer, output_buffer_size); >> >> -- >> >> ----------------------------------------------------------------------------------------- >> My key fingerprint: d1:03:f5:32:26:ff:d7:3c:e4:42:e3:51:ec:92:78:b2 >> Inspired by http://www.nextplayer.net. Your potential. Our passion. >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
