Hi Elliot, Thank you for your response and analysis. My UI test just calls the SimulateOSKeyPress() function to send a keyboard event to a test page which contains a onkeydown event handler, and GetActiveTabTitle() to retrieve the tab name. Anyway, I'm going to divide this change into a code change and a test. When I confirm the test works on a try bot, I will send another review request.
Regards, Hironori Bono E-mail: hb...@chromium.org 2009/3/27 Elliot Glaysher <e...@google.com>: > I am not sure you can write a normal UI test that uses SimulateOS*. (I > know you can't do mouse clicks). This is because the windows screen > needs to be unlocked for those commands to work so it will appear to > pass locally but not on the buildbot. > > Perhaps this test should be in interactive_ui_tests, which is set up > for tests that simulate OS events? > > -- Elliot > > On Thursday, March 26, 2009, Hironori Bono (坊野 博典) <hb...@chromium.org> wrote: >> >> Chromium-developers, >> >> Sorry for my stupid question. >> I'm writing a fix for Issue 2215 and its UI test to verify a DOM event >> sent when we press a VK_MENU key, which is uploaded into Rietveld >> (*1). Even though this UI test works fine on my PCs, it always fails >> on a try bot. >> >> (*1) http://codereview.chromium.org/42500/show >> >> To analyze the failure log listed below, it seems a DOM event is not >> sent to my onkeydown handler even when I send a keyboard event with a >> WindowProxy::SimulateOSKeyPress() call. >> Would it be possible to give me any hints why my UI test fails on a try bot? >> >> [----------] 1 test from InputTest >> [ RUN ] InputTest.ModifierKeys >> ..\..\browser\input_uitest.cc(46): error: Value of: GetActiveTabTitle() >> Actual: L"KeyCode Test" >> Expected: L"SUCCEEDED" >> ..\..\browser\input_uitest.cc(46): error: Value of: GetActiveTabTitle() >> Actual: L"KeyCode Test" >> Expected: L"SUCCEEDED" >> ..\..\browser\input_uitest.cc(46): error: Value of: GetActiveTabTitle() >> Actual: L"KeyCode Test" >> Expected: L"SUCCEEDED" >> [ FAILED ] InputTest.ModifierKeys (61250 ms) >> [----------] 1 test from InputTest (61250 ms total) >> >> Regards, >> >> Hironori Bono >> E-mail: hb...@chromium.org >> >> ---------- Forwarded message ---------- >> From: <a...@chromium.org> >> Date: Wed, Mar 25, 2009 at 10:31 PM >> Subject: Re: A quick fix for Issue 2215.... >> To: hb...@chromium.org >> Cc: chromium-revi...@googlegroups.com >> >> >> With changes, lgtm. >> >> I don't know UI tests well, and don't know why this might fail. You >> might want to ask the list for their thoughts. >> >> >> http://codereview.chromium.org/42500/diff/28/2017 >> File chrome/browser/input_unittest.cc (right): >> >> http://codereview.chromium.org/42500/diff/28/2017#newcode1 >> Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights >> reserved. >> Fix the copyright date; 2009. >> >> http://codereview.chromium.org/42500/diff/28/2017#newcode1 >> Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights >> reserved. >> This file has a bad name. UI tests are named xxx_uitest.cc; see the >> vcproj to see examples. >> >> http://codereview.chromium.org/42500 >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
