[chromium-dev] Re: Can't edit others' codereviews?
Intentional but I have a TODO in the Chromium branch of Rietveld to update this. I just synced ~60 changes from trunk to our branch, and now we get a close button to the left of each issue. Since everyone with a @chromium account could edit an issue, I thought it was too easy to accidentally close others' issues. So I disabled the give-every-chromium-user-full-access change. We can get rid of the close button to the left of issues in our branch, or with a little bit of work only show it for your issues. I didn't have time to do this so I just removed the full access for everyone for now. What is the preferred behavior? Whoever feels strongly about this can reply to this thread or to me and I can implement the popular option. I don't feel strongly about any of the options. On Sat, Aug 15, 2009 at 2:24 PM, Peter Kasting wrote: > I noticed yesterday and today the codereviews I'm looking at sent by other > people) no longer give me the option to "Edit". Is this an intentional > change? Now I can't assign reviewers when appropriate. > PK > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
`git cl patch` reuses existing issues, so when landing stuff for other people, I used to edit the issue on codereview to add "Patch by someone+usuallytru...@example.org" before landing. So for me editing other people's issues is useful. On Sat, Aug 15, 2009 at 11:22 PM, John Abd-El-Malek wrote: > Intentional but I have a TODO in the Chromium branch of Rietveld to update > this. I just synced ~60 changes from trunk to our branch, and now we get a > close button to the left of each issue. Since everyone with a @chromium > account could edit an issue, I thought it was too easy to accidentally close > others' issues. So I disabled the give-every-chromium-user-full-access > change. > We can get rid of the close button to the left of issues in our branch, or > with a little bit of work only show it for your issues. I didn't have time > to do this so I just removed the full access for everyone for now. > What is the preferred behavior? Whoever feels strongly about this can reply > to this thread or to me and I can implement the popular option. I don't > feel strongly about any of the options. > > On Sat, Aug 15, 2009 at 2:24 PM, Peter Kasting wrote: >> >> I noticed yesterday and today the codereviews I'm looking at sent by other >> people) no longer give me the option to "Edit". Is this an intentional >> change? Now I can't assign reviewers when appropriate. >> PK >> > > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
On Sat, Aug 15, 2009 at 11:22 PM, John Abd-El-Malek wrote: > What is the preferred behavior? > I really need the ability to edit others' issues, including closing them. I don't really care up or down on the close button issue, but please restore my ability to edit and close others' changes. PK --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
On Sun, Aug 16, 2009 at 2:47 PM, Peter Kasting wrote: > I really need the ability to edit others' issues, including closing them. I > don't really care up or down on the close button issue, but please restore > my ability to edit and close others' changes. Yeah, I liked the feature too, for the same reason at Peter: I would frequently close contributors changes after they were committed. - a --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
John Abd-El-Malek wrote: > Intentional but I have a TODO in the Chromium branch of Rietveld to update > this. I just synced ~60 changes from trunk to our branch, and now we get a > close button to the left of each issue. Since everyone with a @chromium > account could edit an issue, I thought it was too easy to accidentally close > others' issues. So I disabled the give-every-chromium-user-full-access > change. But they're still reopenable, right? We're talking about close, not delete-there-is-no-undo? If so, it doesn't really sound like a problem to me at all. I don't think that restricting our access to edit and close issues is a reasonable solution to this. Personally, I rarely edited others' descriptions, but I frequently closed issues for others when committing their changes for them. Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
This does affect closing, adding reviewers, changing the description, and deleting-with-no-undo. Given the feedback on this thread, I'll restore almost-full functionality to all chromium accounts (except for delete, I'll make it only work for the owner since it's irreversible). On Sun, Aug 16, 2009 at 3:14 PM, Mark Mentovai wrote: > John Abd-El-Malek wrote: > > Intentional but I have a TODO in the Chromium branch of Rietveld to > update > > this. I just synced ~60 changes from trunk to our branch, and now we get > a > > close button to the left of each issue. Since everyone with a @chromium > > account could edit an issue, I thought it was too easy to accidentally > close > > others' issues. So I disabled the give-every-chromium-user-full-access > > change. > > But they're still reopenable, right? We're talking about close, not > delete-there-is-no-undo? If so, it doesn't really sound like a > problem to me at all. > > I don't think that restricting our access to edit and close issues is > a reasonable solution to this. Personally, I rarely edited others' > descriptions, but I frequently closed issues for others when > committing their changes for them. > > Mark > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
On Sat, Aug 15, 2009 at 11:44 PM, Nico Weber wrote: > `git cl patch` reuses existing issues, so when landing stuff for other > people, I used to edit the issue on codereview to add "Patch by > someone+usuallytru...@example.org" before landing. So for me editing > other people's issues is useful. $ git cl dcommit --help | grep -- -c -c CONTRIBUTOR external contributor for patch (appended to description) My typical workflow is: grep trung AUTHORS git cl dcommit -c "" I think it'd be neat to somehow use git's distinction of author vs committer such that when you patch in a cl (with "git cl patch") it plumbs the rietveld-side author info into the local git commit info and from there into the svn commit, but I think the mapping of rietveld username to AUTHORS username isn't very clear. PS: Personal OKR of responding to 100% of messages mentioning git remains green. :D --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
On Tue, Aug 18, 2009 at 5:37 AM, Evan Martin wrote: > I think it'd be neat to somehow use git's distinction of author vs > committer such that when you patch in a cl (with "git cl patch") it > plumbs the rietveld-side author info into the local git commit info > and from there into the svn commit, but I think the mapping of > rietveld username to AUTHORS username isn't very clear. In WebKit land, our tools do exactly that. There's a python script that provides the mappings: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Can't edit others' codereviews?
On Tue, Aug 18, 2009 at 5:37 AM, Evan Martin wrote: > On Sat, Aug 15, 2009 at 11:44 PM, Nico Weber wrote: > > `git cl patch` reuses existing issues, so when landing stuff for other > > people, I used to edit the issue on codereview to add "Patch by > > someone+usuallytru...@example.org " > before landing. So for me editing > > other people's issues is useful. > > $ git cl dcommit --help | grep -- -c > -c CONTRIBUTOR external contributor for patch (appended to description) > > My typical workflow is: > grep trung AUTHORS > > git cl dcommit -c "" > > I think it'd be neat to somehow use git's distinction of author vs > committer such that when you patch in a cl (with "git cl patch") it > plumbs the rietveld-side author info into the local git commit info > and from there into the svn commit, but I think the mapping of > rietveld username to AUTHORS username isn't very clear. > A little hacky, but you could reuse the url used for autocomplete in reviewers/CC boxes. i.e. http://codereview.chromium.org/account?q=Evan%20Martin returns e...@chromium.org (Evan Martin) > > PS: Personal OKR of responding to 100% of messages mentioning git > remains green. :D > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
