[chromium-dev] Re: Circular relationship in NaCl .gyp files - this is bad!
Mark, Brad: We do not want circular deps in our build system anyway, so having the hard error is desirable for us. I think I fixed the problem you complained about but there could be others. What is the best way for use to check this other than eyeballing. We will push a new nacl version into chrome later this week and I want to make sure it is "clean". Robert On Thu, Nov 5, 2009 at 8:38 PM, Mark Mentovai wrote: > Right. Xcode project objects are reference-counted, and when there's > a circular relationship, their reference counts never drop to zero and > thus can never be freed. When this happens, Xcode won't ever reload > the affected project files; the state that they were in when the cycle > was created will be the state that they're frozen in. It won't be > able to read updates in from disk, and it will notice the discrepancy > between what's in memory and what's on disk, try to save the project > again, and fail. It's a mess. Xcode is perfectly happy to let you > set up an arrangement like this, even in the absence of GYP. > > Command-Q wipes the slate clean, as Brad points out. > > This doesn't affect the buildbots because they don't run Xcode.app, > they run xcodebuild, which results in a new process and a clean slate > each time. > > Once the NaCl dependencies are cleaned up, I'll turn this into a hard > error in GYP so it shouldn't affect us in the future. (This is the > third time that it's bitten us, and the second in a month.) > > Mark > > Bradley Nelson wrote: >> Some further info on this topic: >> There are circular dependencies in nacl, but the reason this does not >> afflict the buildbots is that xcode will handle this correctly IF you CMD-Q >> out of xcode before regenerating the project file. >> We should nonetheless fix the circularity and then have gyp complain. >> -BradN >> >> On Thu, Nov 5, 2009 at 3:33 PM, Mark Mentovai wrote: >>> >>> Robert Muth wrote: >>> > I am looking into it. >>> >>> Thanks. I have a change for GYP ready to detect these cases and raise >>> an exception. Once you get your fix in, I'll check my fix into GYP so >>> that we can catch these early before they start causing problems. >>> >>> > PS: Hope we will be sitting close to each other soon. >>> >>> Definitely! > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Circular relationship in NaCl .gyp files - this is bad!
Robert, try patching http://codereview.chromium.org/373002 into your copy of GYP and see if it raises an exception. Mark Robert Muth wrote: > We do not want circular deps in our build system anyway, > so having the hard error is desirable for us. > I think I fixed the problem you complained about but there could be others. > What is the best way for use to check this other than eyeballing. > We will push a new nacl version into chrome later this week and I > want to make sure it is "clean". > > Robert > > On Thu, Nov 5, 2009 at 8:38 PM, Mark Mentovai wrote: >> Right. Xcode project objects are reference-counted, and when there's >> a circular relationship, their reference counts never drop to zero and >> thus can never be freed. When this happens, Xcode won't ever reload >> the affected project files; the state that they were in when the cycle >> was created will be the state that they're frozen in. It won't be >> able to read updates in from disk, and it will notice the discrepancy >> between what's in memory and what's on disk, try to save the project >> again, and fail. It's a mess. Xcode is perfectly happy to let you >> set up an arrangement like this, even in the absence of GYP. >> >> Command-Q wipes the slate clean, as Brad points out. >> >> This doesn't affect the buildbots because they don't run Xcode.app, >> they run xcodebuild, which results in a new process and a clean slate >> each time. >> >> Once the NaCl dependencies are cleaned up, I'll turn this into a hard >> error in GYP so it shouldn't affect us in the future. (This is the >> third time that it's bitten us, and the second in a month.) >> >> Mark >> >> Bradley Nelson wrote: >>> Some further info on this topic: >>> There are circular dependencies in nacl, but the reason this does not >>> afflict the buildbots is that xcode will handle this correctly IF you CMD-Q >>> out of xcode before regenerating the project file. >>> We should nonetheless fix the circularity and then have gyp complain. >>> -BradN >>> >>> On Thu, Nov 5, 2009 at 3:33 PM, Mark Mentovai wrote: Robert Muth wrote: > I am looking into it. Thanks. I have a change for GYP ready to detect these cases and raise an exception. Once you get your fix in, I'll check my fix into GYP so that we can catch these early before they start causing problems. > PS: Hope we will be sitting close to each other soon. Definitely! >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Circular relationship in NaCl .gyp files - this is bad!
Some further info on this topic: There are circular dependencies in nacl, but the reason this does not afflict the buildbots is that xcode will handle this correctly IF you CMD-Q out of xcode before regenerating the project file. We should nonetheless fix the circularity and then have gyp complain. -BradN On Thu, Nov 5, 2009 at 3:33 PM, Mark Mentovai wrote: > Robert Muth wrote: > > I am looking into it. > > Thanks. I have a change for GYP ready to detect these cases and raise > an exception. Once you get your fix in, I'll check my fix into GYP so > that we can catch these early before they start causing problems. > > > PS: Hope we will be sitting close to each other soon. > > Definitely! > > Mark > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
