[chromium-dev] Re: How to fix check deps failure?

[Brett Wilson]

On Mon, Mar 30, 2009 at 10:12 AM, Jian Li jia...@chromium.org wrote:
 I got another failure for checkdeps:
 ERROR in
 C:/b/slave/chromium-rel-builder/build/src\chrome\test\worker\test_webworker.cc
 Illegal include: webkit/tools/test_shell/test_webworker_helper.h
     Because of -webkit from chrome's include_rules.
 Should I relocate test_worker project from chrome\test\worker to
 webkit\tools\test_worker? Thanks.

We already have webkit/tools/test (it just has the reference build in
it). How about putting it there?

Brett

--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---

[chromium-dev] Re: How to fix check deps failure?

[Jian Li]

I see what you mean. I know how to get this fixed. Thanks.

On Sun, Mar 29, 2009 at 8:48 PM, Brett Wilson bre...@chromium.org wrote:

 On Sun, Mar 29, 2009 at 8:44 PM, Jian Li jia...@chromium.org wrote:
  I got the following check deps failure with try job in Linux:
  ERROR in
  /b/slave/linux/build/src/webkit/tools/test_shell/test_webworker_helper.h
  Illegal include: chrome/test/worker/test_worker_main.h
  Because of no rule applying
  Anyone knows how to fix this? Thanks.

 The fix is to not include that file. You can't have webkit depend on
 chrome, which is what the checkdeps program is verifying. The
 dependencies must go only from Chrome to WebKit.

 I hope it's easy for you to fix. Let me know if you have any questions.

 Brett


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---