[chromium-dev] Re: LayoutTest unexpected success
Right now there's a bunch of unexpected passing media layout tests, but they should start failing again as soon as the WebKit builder bot is clobbered (we're temporarily expecting them to fail until we sort out some issues). Andrew On Tue, Jul 14, 2009 at 5:50 PM, Drew Wilson wrote: > > > On Tue, Jul 14, 2009 at 5:48 PM, Drew Wilson wrote: > >> I would actually have expected the normal (non-worker) MessagePort tests >> to pass/not-crash, as I don't think that jam has gotten far enough into the >> implementation to break the non-cross-process versions :) >> I have a work item on my plate to review all of the message port tests, as >> even the non-passing ones should run without crashing. I'll try to get to it >> later this week or early next week. >> >> -atw >> >> On Tue, Jul 14, 2009 at 1:28 PM, Michael Nordman wrote: >> >>> I'd leave decisions about the worker related message port tests for drew >>> and dimich... the feature isn't fully functional yet in chrome (even if they >>> don't crash and happen to pass and such). >>> I've been unable to dup the LayoutTests/fast/events/mouseover-mouseout2.html >>> failure locally and have no clue why it started failing yesterday >>> afternoon... ditto with the embed-display-none.html test. >>> >>> >>> On Tue, Jul 14, 2009 at 1:06 PM, Amanda Walker wrote: >>> And as soon as I took them out, they started failing again. We're reverting. --Amanda On Tue, Jul 14, 2009 at 12:08 PM, Amanda Walker wrote: > On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlow wrote: >> I think we should re-enable them ASAP unless there's some good reason why >> you want to wait. > > They've been stable and passing all morning, so that works for me. > > --Amanda > >>> >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
On Tue, Jul 14, 2009 at 5:48 PM, Drew Wilson wrote: > I would actually have expected the normal (non-worker) MessagePort tests to > pass/not-crash, as I don't think that jam has gotten far enough into the > implementation to break the non-cross-process versions :) > I have a work item on my plate to review all of the message port tests, as > even the non-passing ones should run without crashing. I'll try to get to it > later this week or early next week. > > -atw > > On Tue, Jul 14, 2009 at 1:28 PM, Michael Nordman wrote: > >> I'd leave decisions about the worker related message port tests for drew >> and dimich... the feature isn't fully functional yet in chrome (even if they >> don't crash and happen to pass and such). >> I've been unable to dup the LayoutTests/fast/events/mouseover-mouseout2.html >> failure locally and have no clue why it started failing yesterday >> afternoon... ditto with the embed-display-none.html test. >> >> >> On Tue, Jul 14, 2009 at 1:06 PM, Amanda Walker wrote: >> >>> >>> And as soon as I took them out, they started failing again. We're >>> reverting. >>> >>> --Amanda >>> >>> >>> On Tue, Jul 14, 2009 at 12:08 PM, Amanda Walker >>> wrote: >>> > On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlow >>> wrote: >>> >> I think we should re-enable them ASAP unless there's some good reason >>> why >>> >> you want to wait. >>> > >>> > They've been stable and passing all morning, so that works for me. >>> > >>> > --Amanda >>> > >>> >>> >>> >>> >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
On Tue, Jul 14, 2009 at 1:28 PM, Michael Nordman wrote: > I'd leave decisions about the worker related message port tests for drew and > dimich... the feature isn't fully functional yet in chrome (even if they > don't crash and happen to pass and such). Seems like we should turn the test on so we know if it regresses. :) Adam --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
I'd leave decisions about the worker related message port tests for drew and dimich... the feature isn't fully functional yet in chrome (even if they don't crash and happen to pass and such). I've been unable to dup the LayoutTests/fast/events/mouseover-mouseout2.html failure locally and have no clue why it started failing yesterday afternoon... ditto with the embed-display-none.html test. On Tue, Jul 14, 2009 at 1:06 PM, Amanda Walker wrote: > > And as soon as I took them out, they started failing again. We're > reverting. > > --Amanda > > > On Tue, Jul 14, 2009 at 12:08 PM, Amanda Walker > wrote: > > On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlow > wrote: > >> I think we should re-enable them ASAP unless there's some good reason > why > >> you want to wait. > > > > They've been stable and passing all morning, so that works for me. > > > > --Amanda > > > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
And as soon as I took them out, they started failing again. We're reverting. --Amanda On Tue, Jul 14, 2009 at 12:08 PM, Amanda Walker wrote: > On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlow wrote: >> I think we should re-enable them ASAP unless there's some good reason why >> you want to wait. > > They've been stable and passing all morning, so that works for me. > > --Amanda > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
On Tue, Jul 14, 2009 at 12:05 PM, Jeremy Orlow wrote: > I think we should re-enable them ASAP unless there's some good reason why > you want to wait. They've been stable and passing all morning, so that works for me. --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
I think we should re-enable them ASAP unless there's some good reason why you want to wait. J On Tue, Jul 14, 2009 at 6:32 AM, Mohamed Mansour wrote: > Lets wait a bit before re-enabling tests, but they seem to act happy, > unlike last night. If no one re-enables them, I can do it when I get home > around 6 EST. > -- Mohamed Mansour > > > > On Tue, Jul 14, 2009 at 8:24 AM, Amanda Walker wrote: > >> >> On Tue, Jul 14, 2009 at 3:38 AM, Adam Barth wrote: >> > Expected to crash, but passed (9): >> > LayoutTests/fast/dom/offset-parent-positioned-and-inline.html >> > LayoutTests/fast/events/message-channel-gc-2.html >> > LayoutTests/fast/events/message-channel-gc-4.html >> > >> LayoutTests/fast/events/message-channel-listener-circular-ownership.html >> > >> LayoutTests/fast/events/message-port-constructor-for-deleted-document.html >> > LayoutTests/fast/events/message-port-deleted-frame.html >> > LayoutTests/fast/events/mouseover-mouseout2.html >> > LayoutTests/fast/images/favicon-as-image.html >> > LayoutTests/fast/images/pdf-as-background.html >> >> These started failing late yesterday afternoon--I'd double check to >> make sure they're actually happy again before re-enabling them. >> >> --Amanda >> >> >> > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
Lets wait a bit before re-enabling tests, but they seem to act happy, unlike last night. If no one re-enables them, I can do it when I get home around 6 EST. -- Mohamed Mansour On Tue, Jul 14, 2009 at 8:24 AM, Amanda Walker wrote: > > On Tue, Jul 14, 2009 at 3:38 AM, Adam Barth wrote: > > Expected to crash, but passed (9): > > LayoutTests/fast/dom/offset-parent-positioned-and-inline.html > > LayoutTests/fast/events/message-channel-gc-2.html > > LayoutTests/fast/events/message-channel-gc-4.html > > LayoutTests/fast/events/message-channel-listener-circular-ownership.html > > > LayoutTests/fast/events/message-port-constructor-for-deleted-document.html > > LayoutTests/fast/events/message-port-deleted-frame.html > > LayoutTests/fast/events/mouseover-mouseout2.html > > LayoutTests/fast/images/favicon-as-image.html > > LayoutTests/fast/images/pdf-as-background.html > > These started failing late yesterday afternoon--I'd double check to > make sure they're actually happy again before re-enabling them. > > --Amanda > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
On Tue, Jul 14, 2009 at 3:38 AM, Adam Barth wrote: > Expected to crash, but passed (9): > LayoutTests/fast/dom/offset-parent-positioned-and-inline.html > LayoutTests/fast/events/message-channel-gc-2.html > LayoutTests/fast/events/message-channel-gc-4.html > LayoutTests/fast/events/message-channel-listener-circular-ownership.html > LayoutTests/fast/events/message-port-constructor-for-deleted-document.html > LayoutTests/fast/events/message-port-deleted-frame.html > LayoutTests/fast/events/mouseover-mouseout2.html > LayoutTests/fast/images/favicon-as-image.html > LayoutTests/fast/images/pdf-as-background.html These started failing late yesterday afternoon--I'd double check to make sure they're actually happy again before re-enabling them. --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
On Tue, Jul 14, 2009 at 3:40 AM, Adam Barth wrote: > Wow, there are even more on Mac: > Expected to fail, but passed (39) If some of those are plugin related, it's because I didn't remember last night that the --enable-plugins flag I checked in didn't affect test shell, so many plugin tests should have suddenly started passing. I'll go take a look at those. --Amanda --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: LayoutTest unexpected success
Wow, there are even more on Mac: Expected to fail, but passed (39) Adam On Tue, Jul 14, 2009 at 12:38 AM, Adam Barth wrote: > Looking at the buildbot, there are a bunch of LayoutTests that are > supposed to fail, timeout, or crash, but which actually pass. We > should update our test expectations / close the cooresponding bugs. > I'll do this tomorrow afternoon if no one beats me to it. > > Enjoy: > > Expected to fail, but passed (26): > LayoutTests/accessibility/non-native-image-crash.html > LayoutTests/fast/dynamic/flash-replacement-test.html > LayoutTests/fast/loader/loadInProgress.html > LayoutTests/http/tests/security/xssAuditor/base-href-control-char.html > LayoutTests/http/tests/security/xssAuditor/base-href-safe3.html > LayoutTests/http/tests/security/xssAuditor/base-href-scheme-relative.html > LayoutTests/http/tests/security/xssAuditor/base-href.html > LayoutTests/http/tests/security/xssAuditor/embed-tag-control-char.html > LayoutTests/http/tests/security/xssAuditor/embed-tag.html > LayoutTests/http/tests/security/xssAuditor/inline-event-HTML-entities.html > LayoutTests/http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char.html > LayoutTests/http/tests/security/xssAuditor/javascript-link-HTML-entities-named.html > LayoutTests/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char.html > LayoutTests/http/tests/security/xssAuditor/javascript-link-HTML-entities.html > LayoutTests/http/tests/security/xssAuditor/javascript-link-control-char.html > LayoutTests/http/tests/security/xssAuditor/javascript-link.html > LayoutTests/http/tests/security/xssAuditor/link-onclick-entities.html > LayoutTests/http/tests/security/xssAuditor/object-embed-tag-control-char.html > LayoutTests/http/tests/security/xssAuditor/object-embed-tag.html > LayoutTests/http/tests/security/xssAuditor/object-tag.html > LayoutTests/http/tests/security/xssAuditor/script-tag-entities.html > LayoutTests/http/tests/security/xssAuditor/script-tag-src-redirect-safe.html > LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-double-quote.html > LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-entities.html > LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-no-quote.html > LayoutTests/plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html > > Expected to timeout, but passed (1): > LayoutTests/fast/dom/frame-loading-via-document-write.html > > Expected to crash, but passed (9): > LayoutTests/fast/dom/offset-parent-positioned-and-inline.html > LayoutTests/fast/events/message-channel-gc-2.html > LayoutTests/fast/events/message-channel-gc-4.html > LayoutTests/fast/events/message-channel-listener-circular-ownership.html > LayoutTests/fast/events/message-port-constructor-for-deleted-document.html > LayoutTests/fast/events/message-port-deleted-frame.html > LayoutTests/fast/events/mouseover-mouseout2.html > LayoutTests/fast/images/favicon-as-image.html > LayoutTests/fast/images/pdf-as-background.html > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
