[chromium-dev] Re: Mac Debug is hosed, needs an owner
I've tracked this down to WebKit r47270, which we picked up in our merge at r23446. It looks like there's a fix for our specific case upstream at r47333, but I believe that function still contains bugs. I'm going to talk to Simon, the author of the relevant WebKit patches, about that. I can own this if I can have the WebKit sheriff's assistance. The easiest thing to do here is probably to move up to r47333 or higher of WebKit, but the canary shows that will bring us some test failures. Mark Mike Pinkerton wrote: Over the weekend, we developed an assert loading any page, even the NTP ASSERTION FAILED: m_clients.contains(renderer) (/Users/pinkerton/src/chromium/src/webkit/../third_party/WebKit/WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize)) Discussions in IRC this morning have linked it to WebKit merge r23527. This appears to only hit Mac debug, but it makes it impossible to do any work with a trunk debug build. I think we should hold the tree closed until we can get this resolved. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac Debug is hosed, needs an owner
This should be fixed at our r23546. Mark I wrote: I've tracked this down to WebKit r47270, which we picked up in our merge at r23446. It looks like there's a fix for our specific case upstream at r47333, but I believe that function still contains bugs. I'm going to talk to Simon, the author of the relevant WebKit patches, about that. I can own this if I can have the WebKit sheriff's assistance. The easiest thing to do here is probably to move up to r47333 or higher of WebKit, but the canary shows that will bring us some test failures. Mark Mike Pinkerton wrote: Over the weekend, we developed an assert loading any page, even the NTP ASSERTION FAILED: m_clients.contains(renderer) (/Users/pinkerton/src/chromium/src/webkit/../third_party/WebKit/WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize)) Discussions in IRC this morning have linked it to WebKit merge r23527. This appears to only hit Mac debug, but it makes it impossible to do any work with a trunk debug build. I think we should hold the tree closed until we can get this resolved. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Mac Debug is hosed, needs an owner
Thanks, Mark. On Mon, Aug 17, 2009 at 10:27 AM, Mark Mentovai m...@chromium.org wrote: This should be fixed at our r23546. Mark I wrote: I've tracked this down to WebKit r47270, which we picked up in our merge at r23446. It looks like there's a fix for our specific case upstream at r47333, but I believe that function still contains bugs. I'm going to talk to Simon, the author of the relevant WebKit patches, about that. I can own this if I can have the WebKit sheriff's assistance. The easiest thing to do here is probably to move up to r47333 or higher of WebKit, but the canary shows that will bring us some test failures. Mark Mike Pinkerton wrote: Over the weekend, we developed an assert loading any page, even the NTP ASSERTION FAILED: m_clients.contains(renderer) (/Users/pinkerton/src/chromium/src/webkit/../third_party/WebKit/WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize)) Discussions in IRC this morning have linked it to WebKit merge r23527. This appears to only hit Mac debug, but it makes it impossible to do any work with a trunk debug build. I think we should hold the tree closed until we can get this resolved. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
