[chromium-dev] Re: Working on privacy blacklists, collision warning
Awesome, thanks for the continued progress and updates! CCing Brian and Linus FYI. -Nick On Mon, Nov 30, 2009 at 12:05 PM, Paweł Hajdan Jr. wrote: > Some progress report on that: now BlacklistManager is integrated with > Profile (each Profile has its BlacklistManager). > > Things remaining to be done (can be in parallel): > - validating the privacy blacklists on extension install (quite easy) > - pausing the user-initiated requests until the blacklist is ready (quite > hard, and will probably require a little refactoring of > ResourceDispatcherHost) > > Short story: you can install a privacy blacklist in an extension, but you > can't be sure when it starts to be effective (pausing requests in RDH will > fix that). > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Working on privacy blacklists, collision warning
Some progress report on that: now BlacklistManager is integrated with Profile (each Profile has its BlacklistManager). Things remaining to be done (can be in parallel): - validating the privacy blacklists on extension install (quite easy) - pausing the user-initiated requests until the blacklist is ready (quite hard, and will probably require a little refactoring of ResourceDispatcherHost) Short story: you can install a privacy blacklist in an extension, but you can't be sure when it starts to be effective (pausing requests in RDH will fix that). -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Re: Working on privacy blacklists, collision warning
Great, thanks for the update. -Nick On Wed, Nov 4, 2009 at 10:58 AM, Paweł Hajdan Jr. wrote: > On Thu, Oct 29, 2009 at 21:50, Paweł Hajdan Jr. > wrote: > >> - make ExtensionsService a BlacklistPathProvider and write a test which >> loads an extension and verifies that BlacklistManager notices that (I'm >> working on it now) >> > > This is done. To clarify: you can't yet load an extension in the browser > and see the effects of the blacklist. The test I wrote so far is using > BlacklistManager manually. The "full scenario" will be available only after > integrating BM with Profile and ChromeURLRequestContext. > > I'm now fixing some threading issues in BlacklistManager (switching to > ChromeThread), and then will continue with the rest: > > >> - verify that blacklists are valid (the format is correct) when validating >> an extension (and update unit tests) >> - use BlacklistManager in ChromeURLRequestContext, pausing requests until >> the blacklist has loaded and write an integration test >> > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Working on privacy blacklists, collision warning
On Thu, Oct 29, 2009 at 21:50, Paweł Hajdan Jr. wrote: > - make ExtensionsService a BlacklistPathProvider and write a test which > loads an extension and verifies that BlacklistManager notices that (I'm > working on it now) > This is done. To clarify: you can't yet load an extension in the browser and see the effects of the blacklist. The test I wrote so far is using BlacklistManager manually. The "full scenario" will be available only after integrating BM with Profile and ChromeURLRequestContext. I'm now fixing some threading issues in BlacklistManager (switching to ChromeThread), and then will continue with the rest: > - verify that blacklists are valid (the format is correct) when validating > an extension (and update unit tests) > - use BlacklistManager in ChromeURLRequestContext, pausing requests until > the blacklist has loaded and write an integration test > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Working on privacy blacklists, collision warning
Sounds good. Thanks for the continued progress on this! -Nick On Thu, Oct 29, 2009 at 1:50 PM, Paweł Hajdan Jr. wrote: > I landed the patch, and now the code in browser/privacy_blacklist should be > quite stable (at least the interfaces). > > There's still a lot of work to do, but here's my plan for now: > > - make ExtensionsService a BlacklistPathProvider and write a test which > loads an extension and verifies that BlacklistManager notices that (I'm > working on it now) > - verify that blacklists are valid (the format is correct) when validating > an extension (and update unit tests) > - use BlacklistManager in ChromeURLRequestContext, pausing requests until > the blacklist has loaded and write an integration test > > > On Mon, Oct 26, 2009 at 09:05, Paweł Hajdan Jr. > wrote: > >> Please don't make non-trivial changes to chrome/browser/privacy_blacklists >> if possible. I have a big change which I'll be soon (today) submitting for >> review. It will be needed to integrate privacy blacklists with extensions. > > > --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: Working on privacy blacklists, collision warning
I landed the patch, and now the code in browser/privacy_blacklist should be quite stable (at least the interfaces). There's still a lot of work to do, but here's my plan for now: - make ExtensionsService a BlacklistPathProvider and write a test which loads an extension and verifies that BlacklistManager notices that (I'm working on it now) - verify that blacklists are valid (the format is correct) when validating an extension (and update unit tests) - use BlacklistManager in ChromeURLRequestContext, pausing requests until the blacklist has loaded and write an integration test On Mon, Oct 26, 2009 at 09:05, Paweł Hajdan Jr. wrote: > Please don't make non-trivial changes to chrome/browser/privacy_blacklists > if possible. I have a big change which I'll be soon (today) submitting for > review. It will be needed to integrate privacy blacklists with extensions. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
