[chromium-dev] Re: adding libraries to gyp
Hi Evan, I'll take a look. Once we switched completely the msvs_guid's can go away (it will generate stable but random ones). -BradN On Tue, Apr 28, 2009 at 12:31 PM, Evan Martin e...@chromium.org wrote: In http://codereview.chromium.org/99132 , I split one library into two. This worked fine up until the Windows build, which only uses gyp halfway, got the change to use the split library but didn't get the change to fix consumers of the library. :( Is there any reasonable way to work through this? It appears I need to do chrome.sln surgery to make this work, and that involves adding a ton to the project, etc. Should I just wait for gyp to go through Windows before doing this? (Once we're using gyp everywhere, can we just make up new guids for the msvs_guid field in the gyp file?) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: adding libraries to gyp
For reference, here was the failure: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/4079/steps/compile/logs/stdio_html It needed to depend on this new main lib from gtest. On Tue, Apr 28, 2009 at 12:34 PM, Bradley Nelson bradnel...@google.com wrote: Hi Evan, I'll take a look. Once we switched completely the msvs_guid's can go away (it will generate stable but random ones). -BradN On Tue, Apr 28, 2009 at 12:31 PM, Evan Martin e...@chromium.org wrote: In http://codereview.chromium.org/99132 , I split one library into two. This worked fine up until the Windows build, which only uses gyp halfway, got the change to use the split library but didn't get the change to fix consumers of the library. :( Is there any reasonable way to work through this? It appears I need to do chrome.sln surgery to make this work, and that involves adding a ton to the project, etc. Should I just wait for gyp to go through Windows before doing this? (Once we're using gyp everywhere, can we just make up new guids for the msvs_guid field in the gyp file?) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: adding libraries to gyp
It's not urgent at all. On Tue, Apr 28, 2009 at 1:06 PM, Bradley Nelson bradnel...@google.com wrote: Hi Evan, I'm doing a similar change now to migrate v8.gyp from temp_gyp to src/v8. Once I get that working I'll see if I can get this change working. If it isn't urgent, it might be easier to wait until after at least webkit is switched (hopefully tonight at 6). -BradN On Tue, Apr 28, 2009 at 12:36 PM, Evan Martin e...@chromium.org wrote: For reference, here was the failure: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/4079/steps/compile/logs/stdio_html It needed to depend on this new main lib from gtest. On Tue, Apr 28, 2009 at 12:34 PM, Bradley Nelson bradnel...@google.com wrote: Hi Evan, I'll take a look. Once we switched completely the msvs_guid's can go away (it will generate stable but random ones). -BradN On Tue, Apr 28, 2009 at 12:31 PM, Evan Martin e...@chromium.org wrote: In http://codereview.chromium.org/99132 , I split one library into two. This worked fine up until the Windows build, which only uses gyp halfway, got the change to use the split library but didn't get the change to fix consumers of the library. :( Is there any reasonable way to work through this? It appears I need to do chrome.sln surgery to make this work, and that involves adding a ton to the project, etc. Should I just wait for gyp to go through Windows before doing this? (Once we're using gyp everywhere, can we just make up new guids for the msvs_guid field in the gyp file?) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
