[chromium-dev] Re: git users and svn:eol-style
I believe git-svn is incapable of handling svn properties. I usually do a follow-up TBR CL using svn to set properties, which is annoying. git-cl relies on git-svn to do the actual committing, so I think we'd be patching up git-svn to support properties. On Thu, Oct 29, 2009 at 5:13 PM, John Abd-El-Malek j...@chromium.org wrote: Per the Chromium style guide ( http://dev.chromium.org/developers/coding-style), we require all new files to have the svn:eol-style property set. We even have a presubmit check for it in case you don't configure Subversion to automatically add them per the above previous link. git users seem to not have such a presubmit check, so nothing reminds them to add them. Can the git-cl script be modified to do this, and if not quickly, can git users please try to remember and follow this? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: git users and svn:eol-style
On Thu, Oct 29, 2009 at 5:13 PM, John Abd-El-Malek j...@chromium.org wrote: Per the Chromium style guide (http://dev.chromium.org/developers/coding-style), we require all new files to have the svn:eol-style property set. We even have a presubmit check for it in case you don't configure Subversion to automatically add them per the above previous link. git users seem to not have such a presubmit check, This is because eol-style is an SVN-specific concept, so there's no real way to check it client-side. The proper place to enforce this is the server. *shrug* so nothing reminds them to add them. Can the git-cl script be modified to do this, and if not quickly, can git users please try to remember and follow this? If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the right thing as well. (I just tested it on a local svn repo to be sure.) --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: git users and svn:eol-style
On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the right thing as well. (I just tested it on a local svn repo to be sure.) BTW, it looks like Yaar helpfully added this to the commit instructions a month ago! http://code.google.com/p/chromium/wiki/UsingGit#Committing --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: git users and svn:eol-style
On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin e...@chromium.org wrote: On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the right thing as well. (I just tested it on a local svn repo to be sure.) BTW, it looks like Yaar helpfully added this to the commit instructions a month ago! http://code.google.com/p/chromium/wiki/UsingGit#Committing Hah! It's now been reworded and bolded to in an attempt to force more people (like myself) to do it. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: git users and svn:eol-style
On Thu, Oct 29, 2009 at 5:31 PM, Evan Martin e...@chromium.org wrote: On Thu, Oct 29, 2009 at 5:28 PM, Evan Martin e...@chromium.org wrote: If you add the junk to your ~/.subversion/config that's specified on this page http://dev.chromium.org/developers/coding-style then git will do the right thing as well. (I just tested it on a local svn repo to be sure.) BTW, it looks like Yaar helpfully added this to the commit instructions a month ago! http://code.google.com/p/chromium/wiki/UsingGit#Committing Nice, so all new users will have it set. Existing users: please please set this. Otherwise you punt the work onto svn users when they next modify the file. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
