[chromium-dev] Re: gyp Make breakage workaround

2009-07-30 Thread Evan Martin

Sorry for the trouble, everyone.  I believe this is fixed in r22105
(which is the DEPS change to pick up the gyp fix).

On Fri, Jul 24, 2009 at 7:10 PM, Andrew Scherkusscher...@chromium.org wrote:
 In command form:
 cd /path/to/chrome/src
 ./tools/gyp/gyp_chromium build/all.gyp

 On Fri, Jul 24, 2009 at 6:54 PM, Albert J. Wong (王重傑) ajw...@chromium.org
 wrote:

 It seems like there's some bad interaction between gclient and gyp's make
 build generator that got uncovered when the gyp DEPS were rolled to r555.
  The effect is the top-level make file ends up having src/ prepended to
 the paths for all the sub-makefiles.  A simple work around is to run gyp by
 manually from the src directory.
 Note that the directory is important, as is *not* running it via gclient
 runhooks.

 The specific bug seems to be as follows:
   1) gyp was switched to using relative path generation on linux.
   2) gclient invokes up from one level above src
   3) The relative paths that are inserted into the root Makefile are
 mistakenly made relative off of the directory that gyp was invoked in.
 We could probably unroll the DEPS to fix it, but since it's friday night,
 and this wasn't the only change included in the gyp update, publishing a
 workaround seemed safer.
 -Albert




 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---



[chromium-dev] Re: gyp Make breakage workaround

2009-07-24 Thread Andrew Scherkus
In command form:
cd /path/to/chrome/src
./tools/gyp/gyp_chromium build/all.gyp

On Fri, Jul 24, 2009 at 6:54 PM, Albert J. Wong (王重傑)
ajw...@chromium.orgwrote:

 It seems like there's some bad interaction between gclient and gyp's make
 build generator that got uncovered when the gyp DEPS were rolled to r555.
  The effect is the top-level make file ends up having src/ prepended to
 the paths for all the sub-makefiles.  A simple work around is to run gyp by
 manually from the src directory.
 Note that the directory is important, as is *not* running it via gclient
 runhooks.

 The specific bug seems to be as follows:
   1) gyp was switched to using relative path generation on linux.
   2) gclient invokes up from one level above src
   3) The relative paths that are inserted into the root Makefile are
 mistakenly made relative off of the directory that gyp was invoked in.

 We could probably unroll the DEPS to fix it, but since it's friday night,
 and this wasn't the only change included in the gyp update, publishing a
 workaround seemed safer.

 -Albert


 


--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev
-~--~~~~--~~--~--~---