[chromium-dev] Re: unforking: 20% perf hit for international page cycler expected soon
The suggestions on that code review are good: we ought to measure how many fonts normal users see, and then pick the cache tuning parameter accordingly. Adam Barth is a good person to ask about how to do this, since he seems to be measuring all sorts of things. On Fri, May 1, 2009 at 3:07 PM, David Levin le...@chromium.org wrote: One of the few remaining forks is in WebCore/platform/graphics/FontCache.cpp (https://bugs.webkit.org/show_bug.cgi?id=21451). I'll be checking in a change to remove this fork and as such we should expect ~20% perf hit for the international page cycler. The internatonal page cycler test intentionally uses more fonts than users are likely to use, so the perf hit isn't something that users would notice in browsing scenarios. Dave PS Here's the code review url: http://codereview.chromium.org/100276 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: unforking: 20% perf hit for international page cycler expected soon
2009/5/1 Evan Martin e...@chromium.org The suggestions on that code review are good: we ought to measure how many fonts normal users see, and then pick the cache tuning parameter accordingly. Adam Barth is a good person to ask about how to do this, since he seems to be measuring all sorts of things. That'll be great. As discussed in another thread a while ago, we may also consider adding (replacing existing ones with) new intl page cycler tests for a 'monolingual' (well, not really) user (e.g. 70?% of Japanese pages + 30% English pages.). 7:3 split is arbitrary. Maybe, one cycler with 100% Japanese(or C or K) pages and the second with 70% Hebrew (or Arabic) + 30% English and the third with 40% Hindi + 60% English work. (Russian and Greek wouldn't be different from English/German/French, etc). Jungshik On Fri, May 1, 2009 at 3:07 PM, David Levin le...@chromium.org wrote: One of the few remaining forks is in WebCore/platform/graphics/FontCache.cpp (https://bugs.webkit.org/show_bug.cgi?id=21451). I'll be checking in a change to remove this fork and as such we should expect ~20% perf hit for the international page cycler. The internatonal page cycler test intentionally uses more fonts than users are likely to use, so the perf hit isn't something that users would notice in browsing scenarios. Dave PS Here's the code review url: http://codereview.chromium.org/100276 --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
[chromium-dev] Re: unforking: 20% perf hit for international page cycler expected soon
On Sat, May 2, 2009 at 6:09 AM, Evan Martin e...@chromium.org wrote: The suggestions on that code review are good: we ought to measure how many fonts normal users see, and then pick the cache tuning parameter accordingly. Adam Barth is a good person to ask about how to do this, since he seems to be measuring all sorts of things. I think the correct answer is # of fonts used per some unit of time. The total number of fonts will monotonically increase over time. Instead, we want to know how many fonts we should keep in the cache, which is temporal. Brett --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~--~~~~--~~--~--~---
