Re: [chromium-dev] Splitting apart chrome.gyp
That might be worth considering. The reason they're gypi's instead of regular gyp files is because xcode presents only whole gyp's to the developer. Putting them in gypi's was a compromise which keep the final xcodeproj in one piece. If we move the gypi's to subdirectories, paths in them will still be relative to src/chrome, which might be confusing. I would prefer if gypi's didn't have this behavior, and plan to fix it: http://code.google.com/p/gyp/issues/detail?id=116 In the meantime, does moving them still make sense? Or shall I wait under after? -BradN On Wed, Nov 18, 2009 at 9:34 PM, Darin Fisher da...@chromium.org wrote: Sounds like a good change, but did you consider putting these gypi files in the subdirectories? chrome/renderer/renderer.gypi, etc. seems like it would be nice. -Darin On Wed, Nov 18, 2009 at 7:02 PM, Bradley Nelson bradnel...@google.comwrote: Hello All, I've just landed a change which splits src/chrome/chrome.gyp in to several pieces: chrome.gyp chrome_browser.gypi (browser) chrome_common.gypi (common) chrome_debugger.gypi (debugger) chrome_plugin.gypi (plugin) chrome_renderer.gypi (renderer) chrome_tests.gypi (almost all tests) You can treat these additional gypi's as if they were a part of chrome.gyp, everything is still relative to src/chrome. I'm not wedded to this division, but I've tried to carve off large enough chunks to reduce the contention on chrome.gyp. Because these are all gypi includes, nothing should change in the layout of the project files. -BradN -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Splitting apart chrome.gyp
It's been brought to my attention that this change might cause merge pain for folks trying to pull their changes into the M4 branch. I can wait to do this until a later date, or I suppose bring the change over to M4? Anybody feel super strongly? -BradN On Thu, Nov 19, 2009 at 9:57 AM, Bradley Nelson bradnel...@google.comwrote: That might be worth considering. The reason they're gypi's instead of regular gyp files is because xcode presents only whole gyp's to the developer. Putting them in gypi's was a compromise which keep the final xcodeproj in one piece. If we move the gypi's to subdirectories, paths in them will still be relative to src/chrome, which might be confusing. I would prefer if gypi's didn't have this behavior, and plan to fix it: http://code.google.com/p/gyp/issues/detail?id=116 In the meantime, does moving them still make sense? Or shall I wait under after? -BradN On Wed, Nov 18, 2009 at 9:34 PM, Darin Fisher da...@chromium.org wrote: Sounds like a good change, but did you consider putting these gypi files in the subdirectories? chrome/renderer/renderer.gypi, etc. seems like it would be nice. -Darin On Wed, Nov 18, 2009 at 7:02 PM, Bradley Nelson bradnel...@google.comwrote: Hello All, I've just landed a change which splits src/chrome/chrome.gyp in to several pieces: chrome.gyp chrome_browser.gypi (browser) chrome_common.gypi (common) chrome_debugger.gypi (debugger) chrome_plugin.gypi (plugin) chrome_renderer.gypi (renderer) chrome_tests.gypi (almost all tests) You can treat these additional gypi's as if they were a part of chrome.gyp, everything is still relative to src/chrome. I'm not wedded to this division, but I've tried to carve off large enough chunks to reduce the contention on chrome.gyp. Because these are all gypi includes, nothing should change in the layout of the project files. -BradN -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Splitting apart chrome.gyp
I've talked it over with laforge. I'm gonna revert this for now, until m4 is out of the way. We'll try it again in ~2 weeks. Maybe I'll get those includes done the right way in gyp in the meantime. -BradN On Thu, Nov 19, 2009 at 10:02 AM, Bradley Nelson bradnel...@google.comwrote: It's been brought to my attention that this change might cause merge pain for folks trying to pull their changes into the M4 branch. I can wait to do this until a later date, or I suppose bring the change over to M4? Anybody feel super strongly? -BradN On Thu, Nov 19, 2009 at 9:57 AM, Bradley Nelson bradnel...@google.comwrote: That might be worth considering. The reason they're gypi's instead of regular gyp files is because xcode presents only whole gyp's to the developer. Putting them in gypi's was a compromise which keep the final xcodeproj in one piece. If we move the gypi's to subdirectories, paths in them will still be relative to src/chrome, which might be confusing. I would prefer if gypi's didn't have this behavior, and plan to fix it: http://code.google.com/p/gyp/issues/detail?id=116 In the meantime, does moving them still make sense? Or shall I wait under after? -BradN On Wed, Nov 18, 2009 at 9:34 PM, Darin Fisher da...@chromium.org wrote: Sounds like a good change, but did you consider putting these gypi files in the subdirectories? chrome/renderer/renderer.gypi, etc. seems like it would be nice. -Darin On Wed, Nov 18, 2009 at 7:02 PM, Bradley Nelson bradnel...@google.comwrote: Hello All, I've just landed a change which splits src/chrome/chrome.gyp in to several pieces: chrome.gyp chrome_browser.gypi (browser) chrome_common.gypi (common) chrome_debugger.gypi (debugger) chrome_plugin.gypi (plugin) chrome_renderer.gypi (renderer) chrome_tests.gypi (almost all tests) You can treat these additional gypi's as if they were a part of chrome.gyp, everything is still relative to src/chrome. I'm not wedded to this division, but I've tried to carve off large enough chunks to reduce the contention on chrome.gyp. Because these are all gypi includes, nothing should change in the layout of the project files. -BradN -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] Splitting apart chrome.gyp
Bradley Nelson wrote: If we move the gypi's to subdirectories, paths in them will still be relative to src/chrome, which might be confusing. I would prefer if gypi's didn't have this behavior, and plan to fix it: http://code.google.com/p/gyp/issues/detail?id=116 That bug only refers to the 'includes' section of a .gypi file in a different directory than its including .gyp file. I don't think that's relevant here. Path reparenting means that paths in a .gypi file should be treated as relative to that .gypi file, not the including .gyp. (With the exception of paths in 'includes', apparently, which is GYP bug 116.) Anything that's in input.py's path_sections or any value associated with a *_dir, *_file, or *_path key or their plural forms, should currently be subject to reparenting. We currently rely on this behavior in build/common.gypi. As an example, at one point in that file, I set a variable named 'strip_from_xcode_path' to 'mac/strip_from_xcode' and then use that variable in an action. Only build/mac/strip_from_xcode exists in our repository, but the path is adjusted properly for each .gyp file that common.gypi is included into. 'sources' is in path_sections, but you'll need to take care with regular expressions for 'sources/': those aren't (and can't be) path sections, and you might need to adjust the patterns to take this into account. Path reparenting has nothing to do with Julie. Mark -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] Splitting apart chrome.gyp
Hello All, I've just landed a change which splits src/chrome/chrome.gyp in to several pieces: chrome.gyp chrome_browser.gypi (browser) chrome_common.gypi (common) chrome_debugger.gypi (debugger) chrome_plugin.gypi (plugin) chrome_renderer.gypi (renderer) chrome_tests.gypi (almost all tests) You can treat these additional gypi's as if they were a part of chrome.gyp, everything is still relative to src/chrome. I'm not wedded to this division, but I've tried to carve off large enough chunks to reduce the contention on chrome.gyp. Because these are all gypi includes, nothing should change in the layout of the project files. -BradN -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
