Re: [chromium-dev] svn question about line-endings
On Fri, Jan 8, 2010 at 10:25 AM, Alok Priyadarshi wrote: > Yes thats what I did to fix line-endings: svn pset svn:eol-style LF. > > But this CL contains other changes as well in addition to fixing > line-endings. Should I do them in separate CLs? > Yes, I would do them in separate CLs, since not only is it clearer, but I think it'll make your trybot problems go away. You don't need review on the change that just sets the eol-style prop; just go ahead and commit it directly (assuming the tree is open). PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
Re: [chromium-dev] svn question about line-endings
On Thu, Jan 7, 2010 at 7:42 PM, alokp wrote: > SVN Gurus, > > I have a question about my CL - http://codereview.chromium.org/527016/show > . > Mac and Linux trybots are failing at the patch stage due to line > endings. The files in my cl were originally submitted with wrong line- > endings. My CL fixes the line-endings and now patch is failing on mac > and linux. If I submit the CL, will it break "gclient sync" and hence > build too? What do you mean by "fixes the line endings"? What you want to do is svn pset svn:eol-style LF on all those files. Do that as a standalone change. Then after that you shouldn't have problems. PK -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
[chromium-dev] svn question about line-endings
SVN Gurus, I have a question about my CL - http://codereview.chromium.org/527016/show. Mac and Linux trybots are failing at the patch stage due to line endings. The files in my cl were originally submitted with wrong line- endings. My CL fixes the line-endings and now patch is failing on mac and linux. If I submit the CL, will it break "gclient sync" and hence build too? Thanks, Alok PS: I am not concerned about the cl not compiling because the gyp files is not hooked yet. -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
