Re: [chromium-dev] Waiting for things in ResourceDispatcherHost

[Paweł Hajdan Jr .]

On Tue, Dec 1, 2009 at 09:09, Darin Fisher  wrote:

> It might help the discussion if you could toss out a proposal for what you
> think might work.
>

My initial idea is an object (ResourceQueue? ResourceWaitQueue?) that the
RDH will ask before starting an URLRequest (similar to how it currently asks
UserScriptListener). If the new object says "yes", RDH will start the
request immediately. Otherwise the queue object will wait until all
interested parties are ready and then start the request (and probably notify
RDH, similarly to UserScriptListener).

The queue object will know what to wait for and which objects to ask (for
example, BlacklistManager object and
BLACKLIST_MANAGER_BLACKLIST_READ_FINISHED notification on the IO thread).

Two main problems I currently see:
- does it generally make sense?
- I don't quite like the names. The object I'm talking about isn't really a
queue (there is no order). It just manager waiting for parties interested in
resource requests. If you have a better idea for the name, that would be
great.

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev

Re: [chromium-dev] Waiting for things in ResourceDispatcherHost

[Darin Fisher]

A cleaner more generalized solutions sounds excellent to me.  Adapting
consumers to that incrementally is a plus if you can do it.

It might help the discussion if you could toss out a proposal for what you
think might work.

-Darin


On Mon, Nov 30, 2009 at 1:59 PM, Paweł Hajdan Jr.
wrote:

> Currently we don't start the request in ResourceDispatcherHost until the
> user script is ready (or not needed). UserScriptListener handles that. We
> also wait for SafeBrowsing, Plugins, etc. We're going to wait for
> PrivacyBlacklists.
>
> I was thinking about refactoring RDH so that it would be easy to pause
> requests (or not start them) until something is ready. For some things we
> can just pause requests (like SafeBrowsing), for some we can't even start a
> request (like Privacy Blacklist, which can block sending the referrer, User
> Agent, cookies, etc or just cancel the entire request).
>
> How would you recommend doing that? I think I wouldn't switch all existing
> things to it immediately (it's a complex piece of code). I'd probably start
> with UserScriptListener just to try it, and then Privacy Blacklists. What do
> you think?
>
> --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
http://groups.google.com/group/chromium-dev