Re: [chrony-dev] O_NOFOLLOW undeclared

2021-02-16 Thread Marius Rohde



Am 16.02.2021 um 14:07 schrieb Miroslav Lichvar:

On Tue, Feb 16, 2021 at 11:45:37AM +0100, Marius Rohde wrote:

Hello dev team,

I tried to compile chrony 4.0 on an old system with glibc before 2.12 and
got following error:

"O_NOFOLLOW undeclared" in "util.c" function "UTI_OpenFile" line 1240

To build util.c I had to add "#define _GNU_SOURCE" like discussed here:
https://github.com/neovim/neovim/issues/4042


Do you disable the IPv6 support, or does the configure script not
enable _GNU_SOURCE for "struct in6_pktinfo"?


IPv6 was not disabled. The script has not enabled _GNU_SOURCE.



It would be very nice if you could check for side effects and make it
compilable on systems with an old glibc out of the box again.


I've pushed a fix. Please try the latest git and see if it works for
you.

Thanks,



Thx a lot... the patch works for me.

Best regards


smime.p7s
Description: S/MIME cryptographic signature


[chrony-dev] O_NOFOLLOW undeclared

2021-02-16 Thread Marius Rohde

Hello dev team,

I tried to compile chrony 4.0 on an old system with glibc before 2.12 
and got following error:


"O_NOFOLLOW undeclared" in "util.c" function "UTI_OpenFile" line 1240

To build util.c I had to add "#define _GNU_SOURCE" like discussed here:
https://github.com/neovim/neovim/issues/4042

It would be very nice if you could check for side effects and make it 
compilable on systems with an old glibc out of the box again.


Thx in advance.

With kind regards
Marius Rohde

MEINBERG Funkuhren GmbH & Co. KG
Lange Wand 9
D-31812 Bad Pyrmont, Germany

Amtsgericht Hannover 17HRA 100322
Geschäftsführer: Günter Meinberg, Werner Meinberg, Andre Hartmann, Heiko 
Gerstung

Internet: www.meinberg.de / www.meinbergglobal.com / www.meinberg.academy


smime.p7s
Description: S/MIME cryptographic signature


Re: [chrony-dev] O_NOFOLLOW undeclared

2021-02-16 Thread Miroslav Lichvar
On Tue, Feb 16, 2021 at 11:45:37AM +0100, Marius Rohde wrote:
> Hello dev team,
> 
> I tried to compile chrony 4.0 on an old system with glibc before 2.12 and
> got following error:
> 
> "O_NOFOLLOW undeclared" in "util.c" function "UTI_OpenFile" line 1240
> 
> To build util.c I had to add "#define _GNU_SOURCE" like discussed here:
> https://github.com/neovim/neovim/issues/4042

Do you disable the IPv6 support, or does the configure script not
enable _GNU_SOURCE for "struct in6_pktinfo"?
> 
> It would be very nice if you could check for side effects and make it
> compilable on systems with an old glibc out of the box again.

I've pushed a fix. Please try the latest git and see if it works for
you.

Thanks,

-- 
Miroslav Lichvar


-- 
To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with "unsubscribe" 
in the subject.
For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the 
subject.
Trouble?  Email listmas...@chrony.tuxfamily.org.



[chrony-dev] [GIT] chrony/chrony.git branch master updated. 4.0-37-gf650b8c

2021-02-16 Thread git
This is an automated email from git. It was generated because a ref
change was pushed to the "chrony/chrony.git" repository.

The branch, master has been updated
   via  f650b8c5153440aa7a7e256c832fa30df894bdb2 (commit)
  from  ae2e0318d1b18534061706fe51528be1f484594c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -
commit f650b8c5153440aa7a7e256c832fa30df894bdb2
Author: Miroslav Lichvar 
Date:   Tue Feb 16 13:54:42 2021 +0100

configure: check for O_NOFOLLOW flag

If the O_NOFOLLOW flag used by open() is not defined, try it with
_GNU_SOURCE. This is needed with glibc-2.11 and earlier.

Reported-by: Marius Rohde 

---

Summary of changes:
 configure | 14 ++
 1 file changed, 14 insertions(+)


hooks/post-receive
-- 
chrony/chrony.git

-- 
To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with "unsubscribe" 
in the subject.
For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the 
subject.
Trouble?  Email listmas...@chrony.tuxfamily.org.