Re: [CinCVS] [Patch] Reordering cpu checks to be able to enable 3dnow or altivec

2007-01-22 Thread Alexis Ballier
> I've fixed this now, I think. Please test.

Yes, that works (at least for me :) ), thanks.


Alexis.


pgpbInivEqapD.pgp
Description: PGP signature


Re: [CinCVS] [Patch] Reordering cpu checks to be able to enable 3dnow or altivec

2007-01-21 Thread Johannes Sixt
On Wednesday 10 January 2007 08:38, Alexis Ballier wrote:
> Any news on this ?
> I was waiting for this to package a new snapshot and then have been
> quite busy :/

I've fixed this now, I think. Please test.

-- Hannes

___
Cinelerra mailing list
Cinelerra@skolelinux.no
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra


Re: [CinCVS] [Patch] Reordering cpu checks to be able to enable 3dnow or altivec

2007-01-09 Thread Alexis Ballier
Any news on this ?
I was waiting for this to package a new snapshot and then have been
quite busy :/

( I'm also waiting for bug #381 to be solved btw )


Alexis.


pgpeQYIuiPxHe.pgp
Description: PGP signature


Re: [CinCVS] [Patch] Reordering cpu checks to be able to enable 3dnow or altivec

2006-12-01 Thread Alexis Ballier

Answering to my own mail makes me feel I'm mad, but... here is some more
info

> 3dnow does not seem to change anything, but there are some comments
> saying that adding -DUSE_3DNOW makes cinelerra not compiling. I see
> this is only used in libmpeg3, I'm gonna have a look at it.

Those options seem to be dead code leftover by hv and are not working.



There are a lot of cpu optimizations that could be enabled for ffmpeg,
like 3dnow, 3dnowext, mmx, mmxext. Some are enabled, but I don't
understand why the ffmpeg configure section is before the cpu checks,
so I'm not sure which ones are enabled and which are not.


Regards,

Alexis.


pgpHLpVH4yGag.pgp
Description: PGP signature


[CinCVS] [Patch] Reordering cpu checks to be able to enable 3dnow or altivec

2006-11-17 Thread Alexis Ballier
Hi,

I had asked about this on irc some time ago, it seemed to me that the
configure script was ignoring whether we gave it --enable-3dnow or
--enable-altivec. For now, variables are set to no, regardless of what
has been passed to the configure script for those options.

Please find a patch enclosed that reorders that, removes the
variables assignments since they are defaulted to the same value with
the ac_arg_enable_macros.

This does not change the current behavior that enables mmx on any i586
or i686. That might be a good idea to let people be able to disable it
with --disable-mmx (this might be useful to make packages for binary
distros).

MMX support doesnt compile on a 64 bits amd64, it's probably nasm
specific asm.
3dnow does not seem to change anything, but there are some comments
saying that adding -DUSE_3DNOW makes cinelerra not compiling. I see
this is only used in libmpeg3, I'm gonna have a look at it.


Regards,


Alexis.
--- cinelerra-svn-checkout/configure.in	2006-10-30 00:06:29.72699 +0100
+++ cinelerra-cvs-20061116/configure.in	2006-11-16 22:41:59.180267827 +0100
@@ -289,6 +289,42 @@
 		[ enable_altivec=$enableval ],
 		[ enable_altivec=no ])
 
+enable_powerpc=no
+
+case "$target_cpu" in
+i586 | i686)
+	enable_mmx=yes
+
+	CPU_CFLAGS="-DX86_CPU $CPU_CFLAGS"
+	have_x86cpu=true
+;;
+powerpc)
+	CPU_CFLAGS="-mcpu=powerpc $CPU_CFLAGS"
+	enable_powerpc=yes
+;;
+esac
+
+if test "x$enable_mmx" = "xyes"; then
+	CPU_CFLAGS="-DHAVE_MMX -DUSE_MMX $CPU_CFLAGS" # -D_MMX_ doesn't work
+	have_asm_mmx=true
+fi
+if test "x$enable_3dnow" = "xyes"; then
+	CPU_CFLAGS="-DHAVE_3Dnow $CPU_CFLAGS" # -DUSE_3DNOW --> don't use, not compilin
+fi
+if test "x$enable_altivec" = "xyes"; then
+	CPU_CFLAGS="-maltivec -mabi=altivec $CPU_CFLAGS"
+fi
+
+AM_CONDITIONAL(USEMMX, test "x$enable_mmx" = "xyes")
+AM_CONDITIONAL(TARGET_BUILTIN_VECTOR,test "x$enable_mmx" = "xyes")
+AM_CONDITIONAL(USE3DNOW, test "x$enable_3dnow" = "xyes")
+AM_CONDITIONAL(TARGET_ARCH_POWERPC, test "x$enable_powerpc" = "xyes")
+AM_CONDITIONAL(TARGET_ALTIVEC, test "x$enable_altivec" = "xyes")
+AC_SUBST(LIBDECORE_LIBADD)
+AC_SUBST(CPU_CFLAGS)
+
+## END OF MMX / 3DNOW
+
  external ffmpeg
 AC_ARG_WITH([external-ffmpeg], AC_HELP_STRING([--with-external-ffmpeg], [use external ffmpeg library]))
 
@@ -336,46 +372,6 @@
 echo --
 # END run ffmpeg configure to generates avconfig.h
 
-enable_mmx=no
-enable_3dnow=no
-enable_powerpc=no
-enable_altivec=no
-
-case "$target_cpu" in
-i586 | i686)
-	enable_mmx=yes
-
-	CPU_CFLAGS="-DX86_CPU $CPU_CFLAGS"
-	have_x86cpu=true
-
-	if test "x$enable_mmx" = "xyes"; then
-	CPU_CFLAGS="-DHAVE_MMX -DUSE_MMX $CPU_CFLAGS" # -D_MMX_ doesn't work
-	have_asm_mmx=true
-	fi
-	if test "x$enable_3dnow" = "xyes"; then
-		CPU_CFLAGS="-DHAVE_3Dnow $CPU_CFLAGS" # -DUSE_3DNOW --> don't use, not compilin
-	fi
-;;
-powerpc)
-	CPU_CFLAGS="-mcpu=powerpc $CPU_CFLAGS"
-	if test "x$enable_altivec" = "xyes"; then
-	CPU_CFLAGS="-maltivec -mabi=altivec $CPU_CFLAGS"
-	fi
-	enable_powerpc=yes
-;;
-esac
-
-AM_CONDITIONAL(USEMMX, test "x$enable_mmx" = "xyes")
-AM_CONDITIONAL(TARGET_BUILTIN_VECTOR,test "x$enable_mmx" = "xyes")
-AM_CONDITIONAL(USE3DNOW, test "x$enable_3dnow" = "xyes")
-AM_CONDITIONAL(TARGET_ARCH_POWERPC, test "x$enable_powerpc" = "xyes")
-AM_CONDITIONAL(TARGET_ALTIVEC, test "x$enable_altivec" = "xyes")
-AC_SUBST(LIBDECORE_LIBADD)
-AC_SUBST(CPU_CFLAGS)
-
-
-## END OF MMX / 3DNOW
-
 ## XIPH
 PKG_CHECK_MODULES(libogg,ogg >= 1.1,[libogg=yes],:)
 PKG_CHECK_MODULES(libvorbis,vorbis,[libvorbis=yes],:)


pgp04HA7xRQGY.pgp
Description: PGP signature