Re: [clam-devel] Two issues found by Valgrind
Hi David, On Sun, Jul 20, 2014 at 11:39:03PM +0200, David García Garzón wrote: > Thanks a lot for the patch. [...] > I will get some spare time this week to reproduce them and apply the patch. any news on that? SVN trunk still has these bugs. Best regards, Daniel ___ clam-devel mailing list clam-devel@lists.clam-project.org http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org
Re: [clam-devel] Two issues found by Valgrind
Hi David, On Sun, Jul 20, 2014 at 11:39:03PM +0200, David García Garzón wrote: > Thanks a lot for the patch. Your account at the bug tracker should be > working, as i received a notification that you created it. It would be > nice if you file both bugs so that we can do the tracking. well, I didn't have the chance to pick a password, so I can't log in. > I will get some spare time this week to reproduce them and apply the patch. > > Please, it would be useful to us if you provide with the report a > network file or a code snippet that exposes the leak. I just loaded an mp3 into chordata. It should be obvious that there is something wrong in those lines. _spectrum has 2*mFrameSize elements but when i is 1, we store the imaginary part in spectrum[mFrameSize*2-1+1]. In changeChordIfSegmentTooSmall onsets.size() is not the number of the last segment. It is the number of the last segment plus one. So if segment == onset.size()-1, we access onsets[onset.size()] a few lines later. Daniel ___ clam-devel mailing list clam-devel@lists.clam-project.org http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org
Re: [clam-devel] Two issues found by Valgrind
Hi Daniel, Thanks a lot for the patch. Your account at the bug tracker should be working, as i received a notification that you created it. It would be nice if you file both bugs so that we can do the tracking. I will get some spare time this week to reproduce them and apply the patch. Please, it would be useful to us if you provide with the report a network file or a code snippet that exposes the leak. David. El 20/07/14 21:58, Daniel Glöckner ha escrit: > Hi, > > here are patches for two issues found by Valgrind in CLAM 1.4.0 that > are still present in SVN trunk. Both access memory past the end of > an array. The bug in FourierTransform is more severe as it writes > to the memory location and pairs imaginary and real part of unrelated > spectral components. > > Daniel > > > > ___ > clam-devel mailing list > clam-devel@lists.clam-project.org > http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org > ___ clam-devel mailing list clam-devel@lists.clam-project.org http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org
