On Sunday 01 August 2004 12:57, Nigel Horne wrote:

> I am in the throws of rewriting this code,

I was downloaded new CVS and I think that some code isn't good.

1. You are leave one % before clamav variables. It isn't multipurpose:
you can't create variables more one symbol in this case.

2. You are use putc for transfer template to sendmail. It's good for
temporaly quick solution but not for final. I think what (from my 
last version of patch - see first message in this tread)
  {
    char c, *tmpptr;
    varlen = strcspn(ptr,"\\%&"); // all used special symbols must listed (now \,%,&)
    tmpptr = ptr + varlen;
    c = *tmpptr;
    *tmpptr = '\0';
    rc = (fputs(ptr, sendmail) == EOF) ? -1 : 0;
    *tmpptr = c;
    ptr = ptr + varlen - 1;
  }
will be work more quickly - many file operations changed by one. I think what 
it is critical for heavy load servers.

-- 
Regards,
Sergey


-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
Clamav-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/clamav-devel

Reply via email to