Re: [Clamav-devel] parentheses correction in scanners.c

2006-03-30 Thread Tomasz Kojm
On Thu, 30 Mar 2006 17:35:28 +1100
Alch <[EMAIL PROTECTED]> wrote:

> Hi,
> 
> I've noticed couple of incorrect parentheses in scanners.c like:
> if((ret = cli_scandesc(desc, ctx, 0, 0, NULL) == CL_VIRUS))

I was sure most of these typos in scanners.c were fixed with the
latest update to the SFX code but somehow they were not. Corrected
again, thanks.

> Patch for scanners.c is attached, however there may be other places 
> where the same happens, I only checked scanners.c out of the whole 
> source tree.

Please report if you find more of them.

-- 
   oo. Tomasz Kojm <[EMAIL PROTECTED]>
  (\/)\. http://www.ClamAV.net/gpg/tkojm.gpg
 \..._ 0DCA5A08407D5288279DB43454822DC8985A444B
   //\   /\  Thu Mar 30 09:46:04 CEST 2006


signature.asc
Description: PGP signature
___
http://lurker.clamav.net/list/clamav-devel.html


Re: [Clamav-devel] clamav-milter logging

2006-03-30 Thread Sergey
On Friday 13 January 2006 23:05, Nigel Horne wrote:

> > Hello.
> > 
> > Which component of clamav-milter write to log
> > 
> > [49156] cur 0 new 1 nextmask 2
> > [49156] got cmd 'D' len 148
> > [49156] cur 1 new  nextmask 2004
> > [49156] got cmd 'C' len 42
> > [49156] cur 1 new 2 nextmask 2004
> > [49156] got cmd 'D' len 1
> > 
> > ?
> > 
> > I wish to forbid it, but I can not understand, how. :-(
> 
> Disable LogVerbose in clamd.conf

Hm... I run clamav-milter as

clamav-milter --config-file=/etc/clamav/clamav-milter.conf

# cat /etc/clamav/clamav-milter.conf|grep Log|grep -v "^#"
LogFile /var/log/clamav/clamav-milter.log
LogSyslog
LogVerbose
LogFacility LOG_MAIL
LogFileMaxSize 5M
LogTime

# ls -l /var/log/clamav/clamav-milter.log
-rw---  1 mail mail 6807552 Мар 30 12:32 /var/log/clamav/clamav-milter.log

Why is size of log more 5M ? I removed clamav-milter.log some minutes ago. 
And clamav-milter is crashing if log size is 2Gb.

-- 
Regards,
Sergey
___
http://lurker.clamav.net/list/clamav-devel.html


Re: [Clamav-devel] clamav-milter logging

2006-03-30 Thread Nigel Horne
On Thu, Mar 30, 2006 at 01:50:06PM +0500, Sergey wrote:
> On Friday 13 January 2006 23:05, Nigel Horne wrote:
> 
> > > Hello.
> > > 
> > > Which component of clamav-milter write to log
> > > 
> > > [49156] cur 0 new 1 nextmask 2
> > > [49156] got cmd 'D' len 148
> > > [49156] cur 1 new  nextmask 2004
> > > [49156] got cmd 'C' len 42
> > > [49156] cur 1 new 2 nextmask 2004
> > > [49156] got cmd 'D' len 1
> > > 
> > > ?
> > > 
> > > I wish to forbid it, but I can not understand, how. :-(
> > 
> > Disable LogVerbose in clamd.conf
> 
> Hm... I run clamav-milter as
> 
> clamav-milter --config-file=/etc/clamav/clamav-milter.conf
> 
> # cat /etc/clamav/clamav-milter.conf|grep Log|grep -v "^#"
> LogFile /var/log/clamav/clamav-milter.log
> LogSyslog
> LogVerbose
> LogFacility LOG_MAIL
> LogFileMaxSize 5M
> LogTime
> 
> # ls -l /var/log/clamav/clamav-milter.log
> -rw---  1 mail mail 6807552 ??? 30 12:32 /var/log/clamav/clamav-milter.log
> 
> Why is size of log more 5M ? I removed clamav-milter.log some minutes ago. 
> And clamav-milter is crashing if log size is 2Gb.

It is so big because you haven't followed my instruction to disable LogVersbose.

> 
> -- 
> Regards,
> Sergey
___
http://lurker.clamav.net/list/clamav-devel.html


Re: [Clamav-devel] clamav-milter logging

2006-03-30 Thread Sergey
On Thursday 30 March 2006 14:04, Nigel Horne wrote:

> > Why is size of log more 5M ? I removed clamav-milter.log some minutes ago. 
> > And clamav-milter is crashing if log size is 2Gb.
> 
> It is so big because you haven't followed my instruction to disable 
> LogVersbose.

I can't disable LogVersbose because I need of verbose syslog.

-- 
Regards,
Sergey
___
http://lurker.clamav.net/list/clamav-devel.html


Re: [Clamav-devel] clamav-milter logging

2006-03-30 Thread Sergey
On Thursday 30 March 2006 14:30, Sergey wrote:

> > It is so big because you haven't followed my instruction to disable 
> > LogVersbose.
> 
> I can't disable LogVersbose because I need of verbose syslog.

Can You prompt where this file is written? I have found only 
"static void logger (const char *mess)" but this function is 
caused only in case of non external mode...

-- 
Regards,
Sergey
___
http://lurker.clamav.net/list/clamav-devel.html


Re: [Clamav-devel] clamav-milter logging

2006-03-30 Thread Nigel Horne
On Thu, Mar 30, 2006 at 03:04:33PM +0500, Sergey wrote:
> On Thursday 30 March 2006 14:30, Sergey wrote:
> 
> > > It is so big because you haven't followed my instruction to disable 
> > > LogVersbose.
> > 
> > I can't disable LogVersbose because I need of verbose syslog.
> 
> Can You prompt where this file is written? I have found only 
> "static void logger (const char *mess)" but this function is 
> caused only in case of non external mode...

if(cfgopt(copt, "LogVerbose")->enabled) {
logVerbose = 1;
#if ((SENDMAIL_VERSION_A > 8) || ((SENDMAIL_VERSION_A == 8) && 
(SENDMAIL_VERSION_B >= 13)))
smfi_setdbg(6);
#endif
}

> -- 
> Regards,
> Sergey

-Nigel Horne
___
http://lurker.clamav.net/list/clamav-devel.html


Re: [Clamav-devel] clamav-milter logging

2006-03-30 Thread Sergey
On Thursday 30 March 2006 15:34, Nigel Horne wrote:

> > Can You prompt where this file is written? I have found only 
> > "static void logger (const char *mess)" but this function is 
> > caused only in case of non external mode...
> 
> if(cfgopt(copt, "LogVerbose")->enabled) {
>   logVerbose = 1;

I have found it. I have not understood communication between writing
to LogFile and a flag logVerbose. :-(

I have found only 

   if(logVerbose) syslog(...);

Or function syslog writes not only in syslog, but also in LogFile ?

-- 
Regards,
Sergey
___
http://lurker.clamav.net/list/clamav-devel.html