Re: [clamav-users] Testing for Big Endian Architectures
Thanks Scott, Sebastian, and Orion. I'll keep an eye out for the patch PR. Best, Micah Micah Snyder ClamAV Development Talos Cisco Systems, Inc. From: clamav-users on behalf of Scott Kitterman via clamav-users Sent: Saturday, January 7, 2023 10:18 PM To: ClamAV users ML Cc: Scott Kitterman Subject: Re: [clamav-users] Testing for Big Endian Architectures On January 8, 2023 5:40:55 AM UTC, Orion Poplawski wrote: >On 1/6/23 14:29, Scott Kitterman via clamav-users wrote: >> On Thursday, January 5, 2023 8:51:27 AM EST Scott Kitterman via clamav-users >> wrote: >>> We finally have Clamav 1.0.0 in Debian Unstable. >>> >>> Unfortunately, unit tests fail on all big endian archs (shown in the PowerPC >>> build log [1] - it's the same tests failing on all of them). Does upstream >>> testing include big endian? >>> >>> Does anyone have suggestions on how to fix it? I have access to hardware to >>> test fixes if there are patches. >>> >>> Scott K >>> >>> [1] >>> https://buildd.debian.org/status/fetch.php?pkg=clamav&arch=powerpc&ver=1.0. >>> 0%2Bdfsg-4&stamp=1672878929&raw=0 >> >> My Debian collaborator Sebastian Siewior confirmed there are endianness >> issues >> in libclamav/pe.c. We have a patch we're testing which we will submit >> upstream to fix this. >> >> Scott K > >There is this: https://github.com/Cisco-Talos/clamav/issues/759 which perhaps >are the same failures you are seeing? A patch would be appreciated. Likely the same. With the patch, all the unit tests pass on s390x now: https://salsa.debian.org/clamav-team/clamav/-/blob/unstable/debian/patches/libclamav-pe-Use-endian-wrapper-in-more-places.patch We will submit it more formally, but it's there if anyone wants it in the meantime. Scott K ___ Manage your clamav-users mailing list subscription / unsubscribe: https://lists.clamav.net/mailman/listinfo/clamav-users Help us build a comprehensive ClamAV guide: https://github.com/Cisco-Talos/clamav-documentation https://docs.clamav.net/#mailing-lists-and-chat ___ Manage your clamav-users mailing list subscription / unsubscribe: https://lists.clamav.net/mailman/listinfo/clamav-users Help us build a comprehensive ClamAV guide: https://github.com/Cisco-Talos/clamav-documentation https://docs.clamav.net/#mailing-lists-and-chat
Re: [clamav-users] Testing for Big Endian Architectures
On January 8, 2023 5:40:55 AM UTC, Orion Poplawski wrote: >On 1/6/23 14:29, Scott Kitterman via clamav-users wrote: >> On Thursday, January 5, 2023 8:51:27 AM EST Scott Kitterman via clamav-users >> wrote: >>> We finally have Clamav 1.0.0 in Debian Unstable. >>> >>> Unfortunately, unit tests fail on all big endian archs (shown in the PowerPC >>> build log [1] - it's the same tests failing on all of them). Does upstream >>> testing include big endian? >>> >>> Does anyone have suggestions on how to fix it? I have access to hardware to >>> test fixes if there are patches. >>> >>> Scott K >>> >>> [1] >>> https://buildd.debian.org/status/fetch.php?pkg=clamav&arch=powerpc&ver=1.0. >>> 0%2Bdfsg-4&stamp=1672878929&raw=0 >> >> My Debian collaborator Sebastian Siewior confirmed there are endianness >> issues >> in libclamav/pe.c. We have a patch we're testing which we will submit >> upstream to fix this. >> >> Scott K > >There is this: https://github.com/Cisco-Talos/clamav/issues/759 which perhaps >are the same failures you are seeing? A patch would be appreciated. Likely the same. With the patch, all the unit tests pass on s390x now: https://salsa.debian.org/clamav-team/clamav/-/blob/unstable/debian/patches/libclamav-pe-Use-endian-wrapper-in-more-places.patch We will submit it more formally, but it's there if anyone wants it in the meantime. Scott K ___ Manage your clamav-users mailing list subscription / unsubscribe: https://lists.clamav.net/mailman/listinfo/clamav-users Help us build a comprehensive ClamAV guide: https://github.com/Cisco-Talos/clamav-documentation https://docs.clamav.net/#mailing-lists-and-chat
Re: [clamav-users] Testing for Big Endian Architectures
On 1/6/23 14:29, Scott Kitterman via clamav-users wrote: On Thursday, January 5, 2023 8:51:27 AM EST Scott Kitterman via clamav-users wrote: We finally have Clamav 1.0.0 in Debian Unstable. Unfortunately, unit tests fail on all big endian archs (shown in the PowerPC build log [1] - it's the same tests failing on all of them). Does upstream testing include big endian? Does anyone have suggestions on how to fix it? I have access to hardware to test fixes if there are patches. Scott K [1] https://buildd.debian.org/status/fetch.php?pkg=clamav&arch=powerpc&ver=1.0. 0%2Bdfsg-4&stamp=1672878929&raw=0 My Debian collaborator Sebastian Siewior confirmed there are endianness issues in libclamav/pe.c. We have a patch we're testing which we will submit upstream to fix this. Scott K There is this: https://github.com/Cisco-Talos/clamav/issues/759 which perhaps are the same failures you are seeing? A patch would be appreciated. -- Orion Poplawski he/him/his - surely the least important thing about me IT Systems Manager 720-772-5637 NWRA, Boulder/CoRA Office FAX: 303-415-9702 3380 Mitchell Lane or...@nwra.com Boulder, CO 80301 https://www.nwra.com/ smime.p7s Description: S/MIME Cryptographic Signature ___ Manage your clamav-users mailing list subscription / unsubscribe: https://lists.clamav.net/mailman/listinfo/clamav-users Help us build a comprehensive ClamAV guide: https://github.com/Cisco-Talos/clamav-documentation https://docs.clamav.net/#mailing-lists-and-chat
Re: [clamav-users] Testing for Big Endian Architectures
On Thursday, January 5, 2023 8:51:27 AM EST Scott Kitterman via clamav-users wrote: > We finally have Clamav 1.0.0 in Debian Unstable. > > Unfortunately, unit tests fail on all big endian archs (shown in the PowerPC > build log [1] - it's the same tests failing on all of them). Does upstream > testing include big endian? > > Does anyone have suggestions on how to fix it? I have access to hardware to > test fixes if there are patches. > > Scott K > > [1] > https://buildd.debian.org/status/fetch.php?pkg=clamav&arch=powerpc&ver=1.0. > 0%2Bdfsg-4&stamp=1672878929&raw=0 My Debian collaborator Sebastian Siewior confirmed there are endianness issues in libclamav/pe.c. We have a patch we're testing which we will submit upstream to fix this. Scott K signature.asc Description: This is a digitally signed message part. ___ Manage your clamav-users mailing list subscription / unsubscribe: https://lists.clamav.net/mailman/listinfo/clamav-users Help us build a comprehensive ClamAV guide: https://github.com/Cisco-Talos/clamav-documentation https://docs.clamav.net/#mailing-lists-and-chat