[cp-patches] FYI: import-cacerts.sh script added
hello all,
the attached patch --already committed-- adds a batch import script to
facilitate populating a cacerts keystore.
2006-08-03 Raif S. Naffah [EMAIL PROTECTED]
* scripts/import-cacerts.sh: Batch CA certificates import script.
cheers;
rsn
Index: import-cacerts.sh
===
RCS file: import-cacerts.sh
diff -N import-cacerts.sh
--- /dev/null 1 Jan 1970 00:00:00 -
+++ import-cacerts.sh 1 Jan 1970 00:00:00 -
@@ -0,0 +1,43 @@
+#!/bin/sh
+
+function visitFile() {
+ install/bin/gkeytool \
+ -cacert \
+ -v \
+ -storepass changeit \
+ -keystore resource/java/security/cacerts.gkr \
+ -file $1
+}
+
+function visitDir() {
+ local d
+ d=$1
+ for f in $d/*
+ do
+ if [ -d $f ] ; then
+ visitDir $f
+ else
+ visitFile $f
+ fi
+ done
+}
+
+if [ $# -lt 1 ] ; then
+ echo Usage: import-cacerts DIR
+ echo Import CA trusted certificates into a 'cacerts.gkr' key store
+ echo under resource/java/security using 'changeit' as its password,
+ echo and constructing the Alias from the certificate's file name.
+ echo
+ echo DIR the 'ca-certificates' deb package installation directory
+ echo containing trusted CA certificates.
+ echo
+else
+ caDir=$1
+ if [ ! -d $caDir ] ; then
+ echo Argument MUST be a directory.
+ echo Type command with no arguments for usage string.
+ exit 1
+ fi
+ visitDir $caDir
+fi
+exit 0
Re: [cp-patches] Re: RFC: add a cacerts file under resource/java/security
hello Mark, On Thursday 03 August 2006 22:42, Mark Wielaard wrote: On Thu, 2006-08-03 at 22:32 +1000, Raif S. Naffah wrote: ... the gkeytool knows how to import _one_ certificate from such encoded files with either the -import or the -cacert commands. the latter, coupled with the import-cacerts.sh (in the scripts folder) can populate a cacerts keystore, and was part of the email you're referring to. Did we actually add such a script? I cannot find it anymore. it is there now! cheers; rsn
Re: [cp-patches] RFC: Change GtkToolkit threading
On Thu, 2006-08-03 at 13:10 -0400, Thomas Fitzsimmons wrote:
the three exit conditions are:
* There are no displayable AWT or Swing components.
* There are no native events in the native event queue.
* There are no AWT events in java EventQueues.
The first two conditions are satisfied by quitting the GTK main thread (no
native events) when there are no windows left (no displayable AWT or Swing
components). I'm wondering if we need a check for the third condition before
quitting the GTK main loop.
Right, 1) is what I just implemented. As for 2), calling gtk_main_quit()
doesn't quit immediately but rather Makes the innermost invocation of
the main loop return when it regains control. as the GTK docs say.
So I'm 95% sure that's to be interpreted as the native queue being empty
at that point.
Condition 3) Is also fulfilled. The EventDispatchThread shuts itself
down as it should, and I'm certain we don't need to check with the GTK
thread. The way I read it, the first two points relate only to the main
GTK thread, and the third point only to the EventDispatchThread.
So basically when 1) and 2) are satisfied we can shut down the GTK
thread (since the peers are disposed of at that point, the EventQueue
can't call into them and cause new native events). There's no apparent
reason why we'd need or want to shut them all down at the same time.
Once the GTK thread is shut down the EventQueue empties itself and then
shuts down. It seems to work just fine. I'm attaching a little testcase
that creates and destroys some windows and prints the number of active
threads. As expected we have two; the main GTK thread and the
EventDispatchThread.
Interestingly, the testcase shows that the 1.4 JDK revs up 6 (!)
threads by then. (But 'only' 4 on the 1.5 JDK). I dunno what it's
doing with all those extra threads. Running a botnet? :)
/Sven
import java.awt.*;
public class ThreadTest
{
public static void main(String[] args)
{
System.out.println(Thread initially active:+Thread.activeCount());
Frame f = new Frame();
f.setSize(100,100);
f.setVisible(true);
System.out.println(Active after opening window:+Thread.activeCount());
long t = System.currentTimeMillis();
System.out.println(Delaying 5s);
while( (System.currentTimeMillis() - t) 5000 )
Thread.yield();
System.out.println(Active now:+Thread.activeCount());
System.out.println(Disposing peers.);
f.dispose();
f = null;
t = System.currentTimeMillis();
System.out.println(Active now::+Thread.activeCount());
System.out.println(Waiting 5 s);
while( (System.currentTimeMillis() - t) 5000 )
Thread.yield();
f = new Frame();
f.setSize(100,100);
System.out.println(Recreating peers.);
f.setVisible(true);
System.out.println(# of active threads now:+Thread.activeCount());
System.out.println(End.);
}
}
[cp-patches] FYI: StrictMath, fixed NaN handling.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
as Sven pointed out here:
http://developer.classpath.org/pipermail/classpath-patches/2006-August/003678.html
the methods i recently implemented must return their argument if it is
NaN, instead of returning the constant Double.NaN.
I took the liberty of committing this without asking for approval, since
it's in response to a comment from Sven, trivial and backed by mauve
tests. Please start yelling if I leaned too far out of the window.
Thanks,
Carsten
2006-08-03 Carsten Neumann [EMAIL PROTECTED]
* StrictMath.java (cbrt): Return argument if it is a NaN.
(cosh): Likewise.
(expm1): Likewise.
(sinh): Likewise.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFE0kjPd4NEZjs4PvgRAloyAJ0WwV45gJtH2KCUb+vx/xcq2WXa3QCgxC08
VFC8KJvLhuly3oeZYP8TG3w=
=6v1m
-END PGP SIGNATURE-
Index: java/lang/StrictMath.java
===
RCS file: /sources/classpath/classpath/java/lang/StrictMath.java,v
retrieving revision 1.14
diff -u -r1.14 StrictMath.java
--- java/lang/StrictMath.java 3 Aug 2006 18:42:11 - 1.14
+++ java/lang/StrictMath.java 3 Aug 2006 18:47:24 -
@@ -673,7 +673,7 @@
// handle special cases
if (x != x)
- return Double.NaN;
+ return x;
if (x == Double.POSITIVE_INFINITY)
return Double.POSITIVE_INFINITY;
if (x == Double.NEGATIVE_INFINITY)
@@ -763,7 +763,7 @@
// handle special cases
if (x != x)
- return Double.NaN;
+ return x;
if (x == Double.POSITIVE_INFINITY)
return Double.POSITIVE_INFINITY;
if (x == Double.NEGATIVE_INFINITY)
@@ -947,7 +947,7 @@
// handle the special cases
if (x != x)
- return Double.NaN;
+ return x;
if (x == Double.POSITIVE_INFINITY)
return Double.POSITIVE_INFINITY;
if (x == Double.NEGATIVE_INFINITY)
@@ -1180,7 +1180,7 @@
if (h_bits = 0x7ff0L)
{
if (((h_bits 0x000fL) | (l_bits 0xL)) != 0)
- return Double.NaN; // exp(NaN) = NaN
+ return x;// exp(NaN) = NaN
else
return negative ? -1.0 : x; // exp({+-inf}) = {+inf, -1}
}
Re: [cp-patches] RFC: StrictMath.tanh implemented
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Sven,
Sven de Marothy wrote:
On Wed, 2006-08-02 at 20:27 +0200, Carsten Neumann wrote:
this adds another missing method to StrictMath, mauve test is already in.
Comments or approval, appreciated.
Seems just fine to me. Just two minor points:
(This being _strict_ math, after all. ;))
1) l_bits is unused.
thanks, for spotting this, fixed in the attached.
2) If a random NaN number is passed in, the JDK returns that number, and
not the NaN constant.
This is fixed for tanh in the attached updated version.
I'll post a seperate patch to fix this for the other methods I
implemented recently.
Thanks,
Carsten
Committed as:
2006-08-03 Carsten Neumann [EMAIL PROTECTED]
* java/lang/StrictMath.java (tanh): New method.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFE0kLGd4NEZjs4PvgRAiHUAJ9zppes1lqzMXtDNVL4uUcoTUuEXACfSRg2
OKEyntgPd0cbQsh25gOiO/M=
=4N2h
-END PGP SIGNATURE-
Index: cp/classpath/java/lang/StrictMath.java
===
--- cp.orig/classpath/java/lang/StrictMath.java 2006-08-02 19:17:29.0 +0200
+++ cp/classpath/java/lang/StrictMath.java 2006-08-03 19:53:23.0 +0200
@@ -814,6 +814,75 @@
}
/**
+ * Returns the hyperbolic tangent of codex/code, which is defined as
+ * (exp(x) - exp(-x)) / (exp(x) + exp(-x)), i.e. sinh(x) / cosh(x).
+ *
+ Special cases:
+ * ul
+ * liIf the argument is NaN, the result is NaN/li
+ * liIf the argument is positive infinity, the result is 1./li
+ * liIf the argument is negative infinity, the result is -1./li
+ * liIf the argument is zero, the result is zero./li
+ * /ul
+ *
+ * @param x the argument to emtanh/em
+ * @return the hyperbolic tagent of codex/code
+ *
+ * @since 1.5
+ */
+ public static double tanh(double x)
+ {
+// Method :
+// 0. tanh(x) is defined to be (exp(x) - exp(-x)) / (exp(x) + exp(-x))
+// 1. reduce x to non-negative by tanh(-x) = -tanh(x).
+// 2. 0 = x = 2^-55 : tanh(x) := x * (1.0 + x)
+//-t
+// 2^-55 x = 1 : tanh(x) := -; t = expm1(-2x)
+// t + 2
+// 2
+// 1 = x = 22.0 : tanh(x) := 1 - - ; t=expm1(2x)
+//t + 2
+// 22.0 x = INF : tanh(x) := 1.
+
+double t, z;
+
+long bits;
+long h_bits;
+
+// handle special cases
+if (x != x)
+ return x;
+if (x == Double.POSITIVE_INFINITY)
+ return 1.0;
+if (x == Double.NEGATIVE_INFINITY)
+ return -1.0;
+
+bits = Double.doubleToLongBits(x);
+h_bits = getHighDWord(bits) 0x7fffL; // ingnore sign
+
+if (h_bits 0x4036L) // |x| 22
+ {
+ if (h_bits 0x3c80L) // |x| 2^-55
+ return x * (1.0 + x);
+
+ if (h_bits = 0x3ff0L) // |x| = 1
+ {
+ t = expm1(2.0 * abs(x));
+ z = 1.0 - 2.0 / (t + 2.0);
+ }
+ else// |x| 1
+ {
+ t = expm1(-2.0 * abs(x));
+ z = -t / (t + 2.0);
+ }
+ }
+else// |x| = 22
+ z = 1.0;
+
+return (x = 0) ? z : -z;
+ }
+
+ /**
* Returns the lower two words of a long. This is intended to be
* used like this:
* codegetLowDWord(Double.doubleToLongBits(x))/code.
[cp-patches] Re: FYI: An example of dynamic bean output
Hi Andrew, On Sat, 2006-07-29 at 22:22 +0100, Andrew John Hughes wrote: This adds an example for printing out the info on the management beans dynamically. In the process, it also adds toString() output to the info classes so that they print out something useful, and fixes a bug in StandardMBean. Mark, another one for 0.92? OK, added to release and generics branch. Cheers, Mark
[cp-patches] FYI: BasicInternalFrameUI fix
This makes InternalFrames adjust their size to their parent's size when
in maximized mode.
2006-08-03 Roman Kennke [EMAIL PROTECTED]
PR 27637
* javax/swing/plaf/basic/BasicInternalFrameUI.java
(ComponentHandler.componentResized): Reimplemented to handle
arbitrary parents.
(InternalFramePropertyChangeHandler.propertyChange): (Un)install
component listener on changed ancestor.
(installListeners): Install componentListener.
(uninstallListeners): Uninstall componentListener.
/Roman
Index: javax/swing/plaf/basic/BasicInternalFrameUI.java
===
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicInternalFrameUI.java,v
retrieving revision 1.40
diff -u -1 -2 -r1.40 BasicInternalFrameUI.java
--- javax/swing/plaf/basic/BasicInternalFrameUI.java 25 Jul 2006 10:03:34 - 1.40
+++ javax/swing/plaf/basic/BasicInternalFrameUI.java 3 Aug 2006 20:24:43 -
@@ -450,36 +450,30 @@
}
/**
* This method is called when the JDesktopPane is resized.
*
* @param e
* The ComponentEvent fired.
*/
public void componentResized(ComponentEvent e)
{
if (frame.isMaximum())
{
- JDesktopPane pane = (JDesktopPane) e.getSource();
- Insets insets = pane.getInsets();
- Rectangle bounds = pane.getBounds();
-
- frame.setBounds(bounds.x + insets.left, bounds.y + insets.top,
- bounds.width - insets.left - insets.right,
- bounds.height - insets.top - insets.bottom);
- frame.revalidate();
- frame.repaint();
+ Container parent = frame.getParent();
+ Insets i = parent.getInsets();
+ int width = parent.getWidth() - i.left - i.right;
+ int height = parent.getHeight() - i.top - i.bottom;
+ frame.setBounds(0, 0, width, height);
}
-
- // Sun also resizes the icons. but it doesn't seem to do anything.
}
/**
* This method is called when the JDesktopPane is shown.
*
* @param e
* The ComponentEvent fired.
*/
public void componentShown(ComponentEvent e)
{
// Do nothing.
}
@@ -940,35 +934,43 @@
if (newPane != null)
{
newPane.addMouseListener(glassPaneDispatcher);
newPane.addMouseMotionListener(glassPaneDispatcher);
}
frame.revalidate();
}
else if (property.equals(JInternalFrame.IS_CLOSED_PROPERTY))
{
if (evt.getNewValue() == Boolean.TRUE)
{
+ Container parent = frame.getParent();
+ if (parent != null)
+parent.removeComponentListener(componentListener);
closeFrame(frame);
}
}
- /*
- * FIXME: need to add ancestor properties to JComponents. else if
- * (evt.getPropertyName().equals(JComponent.ANCESTOR_PROPERTY)) { if
- * (desktopPane != null)
- * desktopPane.removeComponentListener(componentListener); desktopPane =
- * frame.getDesktopPane(); if (desktopPane != null)
- * desktopPane.addComponentListener(componentListener); }
- */
+ else if (property.equals(ancestor))
+{
+ Container newParent = (Container) evt.getNewValue();
+ Container oldParent = (Container) evt.getOldValue();
+ if (newParent != null)
+{
+ newParent.addComponentListener(componentListener);
+}
+ else if (oldParent != null)
+{
+ oldParent.removeComponentListener(componentListener);
+}
+}
}
}
/**
* This helper class is the border for the JInternalFrame.
*/
class InternalFrameBorder extends AbstractBorder implements
UIResource
{
/**
* The width of the border.
*/
@@ -1249,24 +1251,30 @@
glassPaneDispatcher = createGlassPaneDispatcher();
createInternalFrameListener();
borderListener = createBorderListener(frame);
componentListener = createComponentListener();
propertyChangeListener = createPropertyChangeListener();
frame.addMouseListener(borderListener);
frame.addMouseMotionListener(borderListener);
frame.addInternalFrameListener(internalFrameListener);
frame.addPropertyChangeListener(propertyChangeListener);
frame.getRootPane().getGlassPane().addMouseListener(glassPaneDispatcher);
frame.getRootPane().getGlassPane().addMouseMotionListener(glassPaneDispatcher);
+
+Container parent = frame.getParent();
+if (parent != null)
+ {
+parent.addComponentListener(componentListener);
+ }
}
/**
* This method uninstalls the defaults for the JInternalFrame.
*/
protected void uninstallDefaults()
{
frame.setBorder(null);
Re: [cp-patches] FYI: make peer libraries versionless
Hi Tom, On Mon, 2006-07-31 at 09:52 -0400, Thomas Fitzsimmons wrote: On Fri, 2006-07-28 at 19:41 -0400, Thomas Fitzsimmons wrote: I committed this patch to make the peer libraries versionless. This is good practice for dlopen'd libraries. In the case of libjawt.so which is meant to be linked to, making it versionless gives it the SONAME of libjawt.so, which makes it binary compatible with Sun's library. 2006-07-28 Thomas Fitzsimmons [EMAIL PROTECTED] * native/jawt/Makefile.am (libjawt_la_LDFLAGS): Add -avoid-version. * native/jni/gtk-peer/Makefile.am (libgtkpeer_la_LDFLAGS): Likewise. * native/jni/midi-alsa/Makefile.am (libgjsmalsa_la_LDFLAGS): Likewise. * native/jni/midi-dssi/Makefile.am (libgjsmdssi_la_LDFLAGS): Likewise. There was no patch attached (done so now). Also, would you recommend this for the release branch? Yes, along with this one: 2006-07-31 Thomas Fitzsimmons [EMAIL PROTECTED] * native/jni/qt-peer/Makefile.am (libqtpeer_la_LDFLAGS): Add -avoid-version. OK, both added to the release and generics branch. Why do we only need this for these libraries? Would it be an idea to just do this for CLASSPATH_MODULES as defined in configure.ac or do some core native jni libs need to be versioned? Cheers, Mark
Re: [cp-patches] FYI: fix for PR Classpath/23899
Hi Raif, On Wed, 2006-08-02 at 19:54 +1000, Raif S. Naffah wrote: 2006-08-02 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23899 * java/security/SecureRandom.java (next): Call nextBytes as per specs. Thanks. Added to the release and generics branch. Cheers, Mark
[cp-patches] FYI: MetalBorders and MetalMenuBarUI
Hi,
this fumbles a bit with the way the gradient and the border is painted for JMenu
components.
Still need to find out how 'they' manage to join the painting of a JMenu with a
adjacent JToolBar ...
2006-08-04 Robert Schuster [EMAIL PROTECTED]
* javax/swing/plaf/metal/MetalMenuBarUI.java:
(update): Check size and paint smaller gradient.
* javax/swing/plaf/metal/MetalBorders.java:
(MenuBarBorder): Removed borderColor field.
(MenuBarBorder.paintBorder): Added note, fetch color from UIManager or
MetalLookAndFeel.
cya
Robert
Index: javax/swing/plaf/metal/MetalMenuBarUI.java
===
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/metal/MetalMenuBarUI.java,v
retrieving revision 1.1
diff -u -r1.1 MetalMenuBarUI.java
--- javax/swing/plaf/metal/MetalMenuBarUI.java 16 Nov 2005 15:44:05 - 1.1
+++ javax/swing/plaf/metal/MetalMenuBarUI.java 16 Jun 2006 12:54:19 -
@@ -44,6 +44,7 @@
import javax.swing.SwingConstants;
import javax.swing.UIManager;
import javax.swing.plaf.ComponentUI;
+import javax.swing.plaf.UIResource;
import javax.swing.plaf.basic.BasicMenuBarUI;
/**
@@ -75,7 +76,9 @@
*/
public void update(Graphics g, JComponent c)
{
-if (c.isOpaque() UIManager.get(MenuBar.gradient) != null)
+if (c.isOpaque()
+ UIManager.get(MenuBar.gradient) != null
+ c.getBackground() instanceof UIResource)
{
MetalUtils.paintGradient(g, 0, 0, c.getWidth(), c.getHeight(),
SwingConstants.VERTICAL, MenuBar.gradient);
signature.asc
Description: OpenPGP digital signature
Re: [cp-patches] FYI: fix for PR Classpath/28556
On Wed, 2006-08-02 at 13:25 +1000, Raif S. Naffah wrote: 2006-08-02 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/28556 * gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java (encodePrivateKey): Updated documentation to clarify that RFC-2459 states that the parameters field of the AlgorithmIdentifier element MUST be NULL if present. Amended the code to reflect the specs. (decodePrivateKey): Handle case of NULL AlgorithmIdentifier.parameters. the newly added TestOfPR28556 (in gnu.testlet.gnu.java.security.key.rsa) should now pass. I saw the bug reconfirmed. Thanks. Added to release and generics branch. Cheers, Mark
Re: [cp-patches] FYI: MetalBorders and MetalMenuBarUI
Sorry,
I attached the wrong patch. Here is the correct one.
@Mark: This is a small fix which may enter 0.92.
cya
Robert
Robert Schuster wrote:
Hi,
this fumbles a bit with the way the gradient and the border is painted for
JMenu
components.
Still need to find out how 'they' manage to join the painting of a JMenu with
a
adjacent JToolBar ...
2006-08-04 Robert Schuster [EMAIL PROTECTED]
* javax/swing/plaf/metal/MetalMenuBarUI.java:
(update): Check size and paint smaller gradient.
* javax/swing/plaf/metal/MetalBorders.java:
(MenuBarBorder): Removed borderColor field.
(MenuBarBorder.paintBorder): Added note, fetch color from UIManager or
MetalLookAndFeel.
cya
Robert
Index: javax/swing/plaf/metal/MetalBorders.java
===
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/metal/MetalBorders.java,v
retrieving revision 1.35
diff -u -r1.35 MetalBorders.java
--- javax/swing/plaf/metal/MetalBorders.java 18 May 2006 17:07:36 - 1.35
+++ javax/swing/plaf/metal/MetalBorders.java 3 Aug 2006 22:21:18 -
@@ -926,15 +926,11 @@
/** The border insets. */
protected static Insets borderInsets = new Insets(1, 0, 1, 0);
-// TODO: find where this color really comes from
-private static Color borderColor = new Color(153, 153, 153);
-
/**
* Creates a new border instance.
*/
public MenuBarBorder()
{
- // Nothing to do here.
}
/**
@@ -951,7 +947,17 @@
public void paintBorder(Component c, Graphics g, int x, int y, int w,
int h)
{
- g.setColor(borderColor);
+ // Although it is not correct to decide on the static property
+ // currentTheme which color to use the RI does it like that.
+ // The trouble is that by simply changing the current theme to
+ // e.g. DefaultMetalLookAndFeel this method will use another color
+ // although a change in painting behavior should be expected only
+ // after setting a new look and feel and updating all components.
+ if(MetalLookAndFeel.getCurrentTheme() instanceof OceanTheme)
+g.setColor(UIManager.getColor(MenuBar.borderColor));
+ else
+g.setColor(MetalLookAndFeel.getControlShadow());
+
g.drawLine(x, y + h - 1, x + w, y + h - 1);
}
Index: javax/swing/plaf/metal/MetalMenuBarUI.java
===
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/metal/MetalMenuBarUI.java,v
retrieving revision 1.2
diff -u -r1.2 MetalMenuBarUI.java
--- javax/swing/plaf/metal/MetalMenuBarUI.java 16 Jun 2006 12:54:46 - 1.2
+++ javax/swing/plaf/metal/MetalMenuBarUI.java 3 Aug 2006 22:21:18 -
@@ -1,5 +1,5 @@
/* MetalMenuBarUI.java -- MenuBar UI for the Metal LF
- Copyright (C) 2005 Free Software Foundation, Inc.
+ Copyright (C) 2005, 2006 Free Software Foundation, Inc.
This file is part of GNU Classpath.
@@ -76,12 +76,15 @@
*/
public void update(Graphics g, JComponent c)
{
+int height = c.getHeight();
if (c.isOpaque()
UIManager.get(MenuBar.gradient) != null
- c.getBackground() instanceof UIResource)
+ c.getBackground() instanceof UIResource
+ height 2)
{
-MetalUtils.paintGradient(g, 0, 0, c.getWidth(), c.getHeight(),
+MetalUtils.paintGradient(g, 0, 0, c.getWidth(), height - 2,
SwingConstants.VERTICAL, MenuBar.gradient);
+
paint(g, c);
}
else
signature.asc
Description: OpenPGP digital signature
Re: [cp-patches] FYI: StrictMath, fixed NaN handling.
Carsten == Carsten Neumann [EMAIL PROTECTED] writes: Carsten I took the liberty of committing this without asking for Carsten approval, since it's in response to a comment from Sven, Carsten trivial and backed by mauve tests. Please start yelling if I Carsten leaned too far out of the window. You're doing fine :-) Tom
Re: [cp-patches] FYI: import-cacerts.sh script added
Hi Raif, On Thu, 2006-08-03 at 23:16 +1000, Raif S. Naffah wrote: the attached patch --already committed-- adds a batch import script to facilitate populating a cacerts keystore. 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] * scripts/import-cacerts.sh: Batch CA certificates import script. I also made sure it turns up in the release dist tar ball. It won't get installed for now, but at least people will have access to it. 2006-08-03 Mark Wielaard [EMAIL PROTECTED] * scripts/Makefile.am (EXTRA_DIST): Add import-cacerts.sh. Committed, Mark diff -u -r1.2 Makefile.am --- scripts/Makefile.am 20 Dec 2004 13:47:17 - 1.2 +++ scripts/Makefile.am 3 Aug 2006 22:41:36 - @@ -1,2 +1,2 @@ -EXTRA_DIST = check_jni_methods.sh generate-locale-list.sh +EXTRA_DIST = check_jni_methods.sh generate-locale-list.sh import-cacerts.sh
Re: [cp-patches] Re: RFC: add a cacerts file under resource/java/security
Hi Raif, On Thu, 2006-08-03 at 23:21 +1000, Raif S. Naffah wrote: On Thursday 03 August 2006 22:42, Mark Wielaard wrote: On Thu, 2006-08-03 at 22:32 +1000, Raif S. Naffah wrote: ... the gkeytool knows how to import _one_ certificate from such encoded files with either the -import or the -cacert commands. the latter, coupled with the import-cacerts.sh (in the scripts folder) can populate a cacerts keystore, and was part of the email you're referring to. Did we actually add such a script? I cannot find it anymore. it is there now! Thanks. Added it to the release and generics branch since I think it is important to get distros to play with this a little and give us some feedback. Cheers, Mark
Re: [cp-patches] FYI: BasicOptionPane fix
On Tue, 2006-08-01 at 22:54 +0200, Roman Kennke wrote: I wrote a mauve test to back up my earlier patch and found that the same pattern can be applied to all visual property changes: simply call installComponents() and uninstallComponents() when any one of the visual properties changes. These last two patches fix a serious regression and are backed by a Mauve test. Please merge into the release branch. Thanks for fixing this. Both patches have been added to the release and generics branch now. Cheers, Mark
[cp-patches] FYI: DomIterator fix
Hi,
this small patchlet, suggested by Henrik Gulbrandsen, fixes another case of
PR27864.
2006-08-04 Robert Schuster [EMAIL PROTECTED]
Reported by Henrik Gulbrandsen [EMAIL PROTECTED]
Fixes PR27864.
* gnu/xml/dom/DomIterator.java:
(successor): Added if-statement.
cya
Robert
Index: gnu/xml/dom/DomIterator.java
===
RCS file: /cvsroot/classpath/classpath/gnu/xml/dom/DomIterator.java,v
retrieving revision 1.5
diff -u -r1.5 DomIterator.java
--- gnu/xml/dom/DomIterator.java 8 Jun 2006 09:36:02 - 1.5
+++ gnu/xml/dom/DomIterator.java 3 Aug 2006 23:59:25 -
@@ -253,7 +253,13 @@
{
return here.getFirstChild();
}
-
+
+// There's no way up or sideways from the root, so if we
+// couldn't move down to a child, there's nowhere to go.
+//
+if (here == root)
+ return null;
+
//
// Siblings ... if forward, we visit them, if backwards
// we visit their children first.
signature.asc
Description: OpenPGP digital signature
[cp-patches] FYI [generics] Add example badge.png file
Hi, The GNU Classpath Badge was missing on the generics branch! This fixes that grave omission :) 2006-08-03 Mark Wielaard [EMAIL PROTECTED] * examples/gnu/classpath/examples/icons/badge.png: Add file. This also makes the Free Swing demo work again. Cheers, Mark
Re: [cp-patches] FYI: JFileChooser
Hi Roman, On Wed, 2006-08-02 at 13:32 +0200, Roman Kennke wrote: This fixes the handling of special files like . and .. in JFileChooser among a couple of minor design things that I noticed while fixing this. On Wed, 2006-08-02 at 17:21 +0200, Roman Kennke wrote: This fixes the problem with the combobox as described in http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27605 and implements asynchronous loading of the directory contents. On Wed, 2006-08-02 at 23:47 +0200, Roman Kennke wrote: Another nice addition: This patch adds indentation of the labels in the combobox that is used to choose directories at the top. I implemented this by installing an IndentIcon in the cell renderer that takes another icon (the folder icon) and adds indentation to it. This fixes a bug and should therefore go into the release branch. Thanks. I am pretty conservative with respect to the release branch now, but our JFileChooser wasn't in a very good state. I tested it a bit and it is so much better than what we had that I just applied all three patches to the release and generics and branch. Cheers, Mark
[cp-testresults] Japi diffs for classpath
Japi diff jdk12 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk12-classpath.html Changes since last run: -Comparison run at Wed Aug 2 10:03:19 2006 GMT -jdk12 API scanned at 2006/08/02 05:27:32 EDT -classpath API scanned at 2006/08/02 05:51:32 EDT +Comparison run at Thu Aug 3 09:55:55 2006 GMT +jdk12 API scanned at 2006/08/03 05:21:48 EDT +classpath API scanned at 2006/08/03 05:46:24 EDT -java.awt.dnd: 98.87% good, 1.12% missing +java.awt.dnd: 99.09% good, 0.9% missing -javax.swing.plaf.basic: 99.68% good, 0.17% missing +javax.swing.plaf.basic: 99.69% good, 0.15% missing -Methods: 90 missing. +Methods: 88 missing. -method java.awt.dnd.DragSource.isDragImageSupported(): not implemented in classpath -method javax.swing.plaf.basic.BasicMenuUI.setupPostTimer(javax.swing.JMenu): not implemented in classpath Japi diff jdk13 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk13-classpath.html Changes since last run: -Comparison run at Wed Aug 2 10:05:40 2006 GMT -jdk13 API scanned at 2006/08/02 05:20:52 EDT -classpath API scanned at 2006/08/02 05:51:32 EDT +Comparison run at Thu Aug 3 09:57:42 2006 GMT +jdk13 API scanned at 2006/08/03 05:16:33 EDT +classpath API scanned at 2006/08/03 05:46:24 EDT -java.awt.dnd: 98.87% good, 1.12% missing +java.awt.dnd: 99.09% good, 0.9% missing -javax.swing.plaf.basic: 99.82% good, 0.16% missing +javax.swing.plaf.basic: 99.83% good, 0.15% missing -Methods: 96 missing. +Methods: 94 missing. -method java.awt.dnd.DragSource.isDragImageSupported(): not implemented in classpath -method javax.swing.plaf.basic.BasicMenuUI.setupPostTimer(javax.swing.JMenu): not implemented in classpath Japi diff jdk14 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk14-classpath.html Changes since last run: -Comparison run at Wed Aug 2 10:08:31 2006 GMT -jdk14 API scanned at 2006/08/02 05:11:27 EDT -classpath API scanned at 2006/08/02 05:51:32 EDT +Comparison run at Thu Aug 3 09:59:48 2006 GMT +jdk14 API scanned at 2006/08/03 05:09:05 EDT +classpath API scanned at 2006/08/03 05:46:24 EDT -java.awt.dnd: 99.01% good, 0.98% missing +java.awt.dnd: 99.21% good, 0.78% missing -javax.swing.plaf.basic: 99.82% good, 0.17% missing +javax.swing.plaf.basic: 99.83% good, 0.16% missing -Methods: 132 missing. +Methods: 130 missing. -method java.awt.dnd.DragSource.isDragImageSupported(): not implemented in classpath -method javax.swing.plaf.basic.BasicMenuUI.setupPostTimer(javax.swing.JMenu): not implemented in classpath Japi diff jdk15 vs classpath: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-jdk15-classpath.html Changes since last run: -Comparison run at Wed Aug 2 10:11:34 2006 GMT -jdk15 API scanned at 2006/08/02 05:00:27 EDT -classpath API scanned at 2006/08/02 05:51:32 EDT +Comparison run at Thu Aug 3 10:02:08 2006 GMT +jdk15 API scanned at 2006/08/03 05:00:24 EDT +classpath API scanned at 2006/08/03 05:46:24 EDT -java.lang: 94.31% good, 2.9% bad, 2.78% missing +java.lang: 94.34% good, 2.9% bad, 2.75% missing -java.awt.dnd: 97.14% good, 1.62% bad, 1.22% missing +java.awt.dnd: 97.35% good, 1.62% bad, 1.01% missing -javax.management.openmbean: 60.7% good, 39.29% missing +javax.management.openmbean: 92.39% good, 7.6% missing -javax.swing.plaf.basic: 99.61% good, 0.05% bad, 0.32% missing +javax.swing.plaf.basic: 99.62% good, 0.05% bad, 0.31% missing -Total: 92.06% good, 0.08% minor, 0.77% bad, 7.07% missing +Total: 92.17% good, 0.08% minor, 0.77% bad, 6.96% missing -Classes: 21 minor, 148 bad, 101 missing. +Classes: 21 minor, 148 bad, 95 missing. -Methods: 97 minor, 1057 bad, 361 missing. +Methods: 97 minor, 1057 bad, 358 missing. -method java.lang.StrictMath.sinh(double): missing in classpath -method java.awt.dnd.DragSource.isDragImageSupported(): not implemented in classpath -class javax.management.openmbean.InvalidOpenTypeException: missing in classpath -class javax.management.openmbean.KeyAlreadyExistsException: missing in classpath -class javax.management.openmbean.OpenMBeanAttributeInfoSupport: missing in classpath -class javax.management.openmbean.OpenMBeanConstructorInfoSupport: missing in classpath -class javax.management.openmbean.OpenMBeanInfoSupport: missing in classpath -class javax.management.openmbean.OpenMBeanOperationInfoSupport: missing in classpath -method javax.swing.plaf.basic.BasicMenuUI.setupPostTimer(javax.swing.JMenu): not implemented in classpath Japi diff classpath vs jdk15: Full results: http://www.kaffe.org/~stuart/japi/htmlout/h-classpath-jdk15.html Changes since last run: -Comparison run at Wed Aug 2 10:14:29 2006 GMT -classpath API scanned at 2006/08/02 05:51:32 EDT -jdk15 API scanned at 2006/08/02 05:00:27 EDT +Comparison run at Thu Aug 3 10:04:26 2006 GMT +classpath API scanned at 2006/08/03 05:46:24 EDT +jdk15 API scanned at 2006/08/03 05:00:24 EDT -javax.management.openmbean: 95.77% good, 4.22% bad +javax.management.openmbean: 97.19% good, 2.8% bad
[cp-testresults] FAIL: regressions for mauve-jamvm on Thu Aug 3 19:27:24 UTC 2006
Baseline from: Wed Aug 2 19:46:25 UTC 2006 Regressions: FAIL: gnu.javax.crypto.key.srp6.TestOfSRPKeyGeneration FAIL: java.awt.Canvas.PaintTest FAIL: java.lang.Thread.sleep Improvements: PASS: java.awt.Checkbox.PaintTest PASS: java.lang.StrictMath.sinh New fails: FAIL: java.awt.image.AffineTransformOp.constructors FAIL: java.awt.image.AffineTransformOp.createCompatibleDestImage FAIL: java.awt.image.AffineTransformOp.filterImage FAIL: java.awt.image.AffineTransformOp.filterRaster FAIL: java.awt.image.AffineTransformOp.getBounds2D FAIL: java.awt.image.BandCombineOp.constructors FAIL: java.awt.image.BandCombineOp.createCompatibleDestRaster FAIL: java.awt.image.BandCombineOp.filter FAIL: java.lang.StrictMath.tanh Totals: PASS: 2716 XPASS: 0 FAIL: 194 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
Re: jboss-4.0.4
Hi Robert, Putting JamVM into its own directory would be most helpful! Will save me some work for firecat;) David Fu. On 7/31/06, Robert Lougher [EMAIL PROTECTED] wrote: On 7/31/06, Christian Thalinger [EMAIL PROTECTED] wrote: On Mon, 2006-07-31 at 19:04 +0100, Robert Lougher wrote: No, but it doesn't look difficult to implement. If I understand it correctly it seems to be as simple as just prepending the value of java.endorsed.dirs to the bootpath? Well, nearly. You have to scan the directories, if any, for zip/jar files and prepend them too. Yes. I realised that each dir will contain potentially many jars, and that these are what must be prepended just after I posted. Sods law! I guess you do this in cacao and this is what lets you start up jboss. Sorry to keep on spamming, but do you look in a default location if java.endorsed.dirs is unset? The RI does, but this assumes you've got a JRE-like directory structure. Time to put jamvm into it's own directory... Rob. Thanks, Rob. TWISTI
Torturing image ops and Swing
Hello all,
anyone interested in torturing our Swing, awt.image and javax.image operations
a bit? Long text with a question buried at the end. Sorry, but I had
to get this
off my soul; feeling much better already :-)
I have just uploaded a new, completely re-written version of my image
viewer to
http://tams-www.informatik.uni-hamburg.de/personal/hendrich/niffler/index.html
Unlike the previous version with its deeply-nested popup-menu, the new version
uses a more traditional user-interface. It also adds image histogram,
EXIF support,
and basic image editing based on get/setRGB, get/setRaster, ConvolveOp, and
ShortLookupOp (ByteLookupOp would be faster, but is broken on the JDK/Linux).
Download niffler-exif.jar (or the sources and build it yourself; you
will need the
metadata-extractor library from www.drewnoakes.com for building the
exif stuff).
jamvm -Xmx300m -Xms100m niffler.Niffler
1. Select menu File Open image directory... and select a directory with
some images. This is the first challenge, because JFileChooser is still
about as user-unfriendly as possible. (I somewhat fear that many first-time
classpath users might give up after trying to use JFileChooser. This is
unfortunate, because the rest of Swing works pretty well these days.)
2. By default, Niffler also includes subdirectories in its search.
Don't select
your home directory or this can take a long time (about one minute with
jamvm+cvs in my home directory, with 93.000+ files. For some reason,
cacao 0.96 crashes after listing about 15.000 files. Smaller
directories work.)
3. Loading small to medium-sized images works fine. Navigation works fine
(type 'space' or 'n' for next image, 'p' for previous image, or
use the menu).
Zooming works fine ('f' for zoom-fit, 'g' for original-size,
etc.). Mouse dragging
works fine. The navigation tree, thumbnails preview, and histogram all work
as they should (a little slow, perhaps, but jamvm is an
interpreter, after all).
Nitpicking: the splitpane dividers look bad.
4a. Loading typical digicam images with 4+ Mpixels is somewhat slower,
but still
almost acceptable. jamvm needs about 5 seconds for a 3000x2000 JPEG for
image loading, plus about 7 seconds for calculating the histogram
(when enabled).
JDK 1.5 needs about 1.5 seconds for loading plus 0.3 secs for the
histogram.
4b. Cacao calculates the histogram much faster (almost as fast as the
JDK), but
unfortunately it leaks memory and crashes after loading a few
4+Mpixel images
(with -Xmx300m and top reporting about 320M RSS actually used.)
It seems that cacao 0.96 never garbage-collects image data?
4c. I didn't test with gcj yet, neither did I try jcvm.
---
For the following, use smaller images (800x600 or so) to avoid frustration.
5. Select Tools Sharpen Laplace 3x3. Simple convolution filter implemented
with ConvolveOp and applied to a BufferedImage TYPE_INT_RGB.
java.lang.ArrayIndexOutOfBoundsException: 3
at java.awt.image.ColorModel.getComponentSize(ColorModel.java:200)
at java.awt.image.ColorModel.coerceData(ColorModel.java:641)
at java.awt.image.DirectColorModel.coerceData(DirectColorModel.java:405)
at java.awt.image.BufferedImage.coerceData(BufferedImage.java:288)
at java.awt.image.ConvolveOp.filter(ConvolveOp.java:126)
This worked a week ago, but very slowly. Try the Tools Edges Mexican
Hat 13x13 filter, if you don't believe me. The JDK seems to include some
optimizations for such (separable?) kernels.
OK, lets try something else:
6. Select Tools Negative Image. Obvious implementation based on
LookupOp. Works. Performance is ok (1 sec for 800x600). The result is
a BufferedImage.TYPE_INT_RGB.
BUT repainting suddenly takes 3 seconds for each paintComponent,
and the application is pretty much dead. For comparison, a repaint of the
BufferedImage before the filtering took about 10 msec.
For 3000x2000 images, each repaint takes 40 seconds on my system.
Any ideas about what I am doing wrong here are HIGHLY appreciated.
Load a new image. Repainting time is back to the millisecond range.
7. Perhaps LookupOp and ConvolveOp are bad? Select Tools Rotate
image left (or right). Implemented 'by hand' via getRGB and setRGB.
Much slower than LookupOp, about 4 seconds on my system at 800x600.
But again, repainting suddenly takes many seconds.
8. What about ImageIO instead of java.awt.Toolkit? Just select
Edit Load images via ImageIO.
Loading a 800x600 JPEG takes about 200 msecs with Toolkit, and about
7 seconds with Toolkit. Loading a 3000x2000 JPEG takes 200+ seconds.
The imageio GIF reader is much faster (4 seconds at 3000x2000), but now
the conversion to BufferedImage.TYPE_INT_RGB takes 90+ seconds...
Images returned by the PNG reader render as transparent.
9. Select Help Commands... A simple JTextArea in a JScrollPanel,
Re: Torturing image ops and Swing
Hi Norman, Thanks for the detailed report! I don't have time to try this out right now, but I have a couple of comments: [EMAIL PROTECTED] wrote: 1. Select menu File Open image directory... and select a directory with some images. This is the first challenge, because JFileChooser is still about as user-unfriendly as possible. (I somewhat fear that many first-time classpath users might give up after trying to use JFileChooser. This is unfortunate, because the rest of Swing works pretty well these days.) Is this before or after Roman's JFileChooser patch (last night)? 5. Select Tools Sharpen Laplace 3x3. Simple convolution filter implemented with ConvolveOp and applied to a BufferedImage TYPE_INT_RGB. java.lang.ArrayIndexOutOfBoundsException: 3 at java.awt.image.ColorModel.getComponentSize(ColorModel.java:200) at java.awt.image.ColorModel.coerceData(ColorModel.java:641) at java.awt.image.DirectColorModel.coerceData(DirectColorModel.java:405) at java.awt.image.BufferedImage.coerceData(BufferedImage.java:288) at java.awt.image.ConvolveOp.filter(ConvolveOp.java:126) This worked a week ago, but very slowly. Try the Tools Edges Mexican Hat 13x13 filter, if you don't believe me. The JDK seems to include some optimizations for such (separable?) kernels. OK, lets try something else: I did some cleanup work on ConvolveOp not too long ago because it was broken. It works now, but slowly. There is a FIXME in the source code at the point where we need a different approach to get a speedup. If I recall correctly, for each pixel in the output raster, we do N x N lookups in the input raster where N x N is the size of the convolution filter. For 3 x 3, that will be slow (effectively reading the raster pixel by pixel 9 times). For 13 x 13, that will be unusable. 6. Select Tools Negative Image. Obvious implementation based on LookupOp. Works. Performance is ok (1 sec for 800x600). The result is a BufferedImage.TYPE_INT_RGB. BUT repainting suddenly takes 3 seconds for each paintComponent, and the application is pretty much dead. For comparison, a repaint of the BufferedImage before the filtering took about 10 msec. For 3000x2000 images, each repaint takes 40 seconds on my system. Any ideas about what I am doing wrong here are HIGHLY appreciated. Load a new image. Repainting time is back to the millisecond range. Sven will probably know the answer to this. I'm sure it has something to do with the DataBuffer implementations. The source image most likely uses some private class that implements a managed data buffer, whereas the destination image will be using the array-based DataBuffers in java.awt.image.* (which are sure to be slower). Anyway, thanks again for the detail...I'd love to spend some time on this right now, but alas I don't have any... Regards, Dave
Re: Torturing image ops and Swing
Hi Norman, anyone interested in torturing our Swing, awt.image and javax.image operations a bit? Sure. These are packages that require lots of work still. David started to write Mauve tests and fix awt.image I think. Long text with a question buried at the end. Sorry, but I had to get this off my soul; feeling much better already :-) Yeah. If you're feeling good, then you could write some bug reports, this way you make sure the headaches don't come back ;-) I have just uploaded a new, completely re-written version of my image viewer to http://tams-www.informatik.uni-hamburg.de/personal/hendrich/niffler/index.html Cool! I'll give it a try soon. 1. Select menu File Open image directory... and select a directory with some images. This is the first challenge, because JFileChooser is still about as user-unfriendly as possible. (I somewhat fear that many first-time classpath users might give up after trying to use JFileChooser. This is unfortunate, because the rest of Swing works pretty well these days.) I put some work into JFileChooser lately (in response to your bugreports as you might already know). I'd like to resolve the remaining issues. It would be helpful if you could identify more specific problems (like in your last JFileChooser bugreports) and file file bugreports. This way I can focus better on the real problems. 3. ... Nitpicking: the splitpane dividers look bad. Erm. Gotta do some work on that too. Please file a bugreport for that too. 9. Select Help Commands... A simple JTextArea in a JScrollPanel, but with about 700 lines of text. Try scrolling. Painfully slow. The vertical scrollbar only scrolls down on click event (but dragging works). Hmm. JTextArea should definitely be a little faster :-) The error might be related to the sloppy performance, since it means that it probably didn't blit while scrolling. Gotta look into it. Oh and please file a .. I repeat myself ;-) 10. Neither JOptionPane (Help About) nor JToolTip include support for HTML formatting (e.g. the histogram tooltip). Audrius told me that the HTML parser part already works for my examples, but the parser isn't used... Oh yes, we have some HTML parsing and rendering stuff in the meantime. I gotta build it into the components that ought to support this crap^H^H^H^Huseful feature. However, what should I do about the repaint performance issue? Is there an inherent reason why images of type BufferedImage.TYPE_INT_RGB render so slowly? Might be related to the fact that GTK uses ABGR for it's surfaces (at least that is what I remember, don't nail me down on that). /Roman
Re: Torturing image ops and Swing
Roman Kennke wrote: Hi Norman, anyone interested in torturing our Swing, awt.image and javax.image operations a bit? Sure. These are packages that require lots of work still. David started to write Mauve tests and fix awt.image I think. I did. I will come back to it when I can - in particular, I didn't get to the ColorModel classes yet. Also, some of the classes I fixed still need to be worked on further for performance reasons (ConvolveOp in particular, but other things too). Regards, Dave
Re: classpath-0_92-branch created
Il giorno gio, 03/08/2006 alle 01.23 +0200, Mark Wielaard ha scritto: Thanks for the reminder I have checked in the following on the trunk, release and generics branch. 2006-08-02 Mark Wielaard [EMAIL PROTECTED] * configure.ac (gconf-peer): Check for gdk-2.0. * native/jni/gconf-peer/Makefile.am (AM_LDFLAGS): Use GDK_LIBS. (AM_CFLAGS): Use GDK_CFLAGS. Cheers, Mark Great, thank you! Hopefully, I can came up with something that relax this requirement... Ciao, Mario -- Lima Software, SO.PR.IND. s.r.l. http://www.limasoftware.net/ pgp key: http://subkeys.pgp.net/ Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa è una parte del messaggio firmata digitalmente
Re: classpath-0_92-branch created
Hi Mario, On Thu, 2006-08-03 at 20:40 +0200, Mario Torre wrote: Hopefully, I can came up with something that relax this requirement... There is already a bug report for this from the Debian gcc packager. Feel free to assign it to yourself :) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28538 Although I am not sure there is much to do about it. We do need gdk_threads_enter/leave () to not interfere with the gtk-peer libraries and those functions are in the gdk-2.0 library so we will have to link against that. Cheers, Mark
Re: Torturing image ops and Swing
On Thu, 2006-08-03 at 15:59 +0200, [EMAIL PROTECTED] wrote: Hello all, anyone interested in torturing our Swing, awt.image and javax.image operations a bit? Long text with a question buried at the end. Sorry, but I had to get this off my soul; feeling much better already :-) No problem :) Anyone's who's looked at our awt.image code is probably just as frustrated. :) The way I see it, this is the last major piece of work that needs to be done for the whole Java2D bit. (or AWT as a whole even) The rest is fairly easy stuff. [Snip: How to run the program] 4a. Loading typical digicam images with 4+ Mpixels is somewhat slower, but still almost acceptable. jamvm needs about 5 seconds for a 3000x2000 JPEG for image loading, plus about 7 seconds for calculating the histogram (when enabled). JDK 1.5 needs about 1.5 seconds for loading plus 0.3 secs for the histogram. The discrepancy is rather large, since the actual loading in this case (using Toolkit.createImage) is done natively. I'm guessing most of the overhead is coming from any and all java processing we do afterwards. 4b. Cacao calculates the histogram much faster (almost as fast as the JDK), but unfortunately it leaks memory and crashes after loading a few 4+Mpixel images (with -Xmx300m and top reporting about 320M RSS actually used.) It seems that cacao 0.96 never garbage-collects image data? Well, it should. But we should check up on that. See what Herr Thalinger has to say. For the following, use smaller images (800x600 or so) to avoid frustration. 5. Select Tools Sharpen Laplace 3x3. Simple convolution filter implemented with ConvolveOp and applied to a BufferedImage TYPE_INT_RGB. java.lang.ArrayIndexOutOfBoundsException: 3 at java.awt.image.ColorModel.getComponentSize(ColorModel.java:200) at java.awt.image.ColorModel.coerceData(ColorModel.java:641) at java.awt.image.DirectColorModel.coerceData(DirectColorModel.java:405) at java.awt.image.BufferedImage.coerceData(BufferedImage.java:288) at java.awt.image.ConvolveOp.filter(ConvolveOp.java:126) Looks like a regression. Overall we're making progress on awt.image though, mainly thanks to Mr Gilbert, at the moment. This worked a week ago, but very slowly. Try the Tools Edges Mexican Hat 13x13 filter, if you don't believe me. The JDK seems to include some optimizations for such (separable?) kernels. Yes, this is one of those things which is left to do with awt.image. There's a lot of optimization that can and should be done. 6. Select Tools Negative Image. Obvious implementation based on LookupOp. Works. Performance is ok (1 sec for 800x600). The result is a BufferedImage.TYPE_INT_RGB. BUT repainting suddenly takes 3 seconds for each paintComponent, and the application is pretty much dead. For comparison, a repaint of the BufferedImage before the filtering took about 10 msec. Right. BufferedImages created with Component.createImage(int, int) are backed by a Cairo surface. Ones created directly by BufferedImage are not. Again, this is one of these things that needs to be fixed, basically so that all BufferedImages can have some native backing buffer.) For 3000x2000 images, each repaint takes 40 seconds on my system. Any ideas about what I am doing wrong here are HIGHLY appreciated. Nothing really, we're to blame here (Well, Cairo is a bit slow too. But not _that_ slow.) Since we can only draw Cairo surfaces, non-CairoSurface backed BufferedImages will draw much slower, as this requires transferring (and possibly converting all) the pixels. Load a new image. Repainting time is back to the millisecond range. Right, it's a CairoSurface-backed buffer then too. 7. Perhaps LookupOp and ConvolveOp are bad? Select Tools Rotate image left (or right). Implemented 'by hand' via getRGB and setRGB. Much slower than LookupOp, about 4 seconds on my system at 800x600. They can probably be faster, but I don't think they're the main problem if the times you're measuring also include the repaint time. But again, repainting suddenly takes many seconds. Same explanation as before. Edit Load images via ImageIO. Loading a 800x600 JPEG takes about 200 msecs with Toolkit, and about 7 seconds with Toolkit. Loading a 3000x2000 JPEG takes 200+ seconds. Too slow. The imageio GIF reader is much faster (4 seconds at 3000x2000), but now the conversion to BufferedImage.TYPE_INT_RGB takes 90+ seconds... Really? That sounds too fast, almost. How do you mean conversion? Running it through a filter, or just drawing the image returned by IIO onto the the aforementioned BufferedImagE? Images returned by the PNG reader render as transparent. 9. Select Help Commands... A simple JTextArea in a JScrollPanel, but with about 700 lines of text. Try scrolling. Painfully slow. The
[Bug classpath/28538] libgconfpeer depends on the gtk libraries
--- Comment #1 from mark at gcc dot gnu dot org 2006-08-03 18:51 --- In classpath 0.92-pre they are now only linked against gdk: 2006-08-02 Mark Wielaard [EMAIL PROTECTED] * configure.ac (gconf-peer): Check for gdk-2.0. * native/jni/gconf-peer/Makefile.am (AM_LDFLAGS): Use GDK_LIBS. (AM_CFLAGS): Use GDK_CFLAGS. I am not sure there is much more to do about it. We do need gdk_threads_enter/leave () to not interfere with the gtk-peer libraries and those functions are in the gdk-2.0 library so we will have to link against that. -- mark at gcc dot gnu dot org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever Confirmed|0 |1 Last reconfirmed|-00-00 00:00:00 |2006-08-03 18:51:04 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28538 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug classpath/28535] GConf depends on GDK Threads
--- Comment #4 from mark at gcc dot gnu dot org 2006-08-03 18:23 --- Check checked in -- mark at gcc dot gnu dot org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||FIXED Target Milestone|--- |0.92 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28535 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug classpath/28538] libgconfpeer depends on the gtk libraries
-- neugens at limasoftware dot net changed: What|Removed |Added AssignedTo|mark at gcc dot gnu dot org |neugens at limasoftware dot ||net Status|NEW |ASSIGNED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28538 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug classpath/28538] libgconfpeer depends on the gtk libraries
--- Comment #2 from neugens at limasoftware dot net 2006-08-03 19:48 --- I have assigned this bug to me (gconf related :), though as Mark said, I don't think we can do that much for it. For what I can see, the problem here is mixing threading models (java and native), this lead to problems. I'm investigating a couple of solutions, but I'm pretty sceptical that they work... -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28538 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
Re: classpath-0_92-branch created
Il giorno gio, 03/08/2006 alle 20.49 +0200, Mark Wielaard ha scritto: Although I am not sure there is much to do about it. We do need gdk_threads_enter/leave () to not interfere with the gtk-peer libraries and those functions are in the gdk-2.0 library so we will have to link against that. Cheers, Mark Done :) Ciao, Mario -- Lima Software, SO.PR.IND. s.r.l. http://www.limasoftware.net/ pgp key: http://subkeys.pgp.net/ Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa è una parte del messaggio firmata digitalmente
Re: Torturing image ops and Swing
Hello Sven, thanks for your detailed answers to my questions! New Niffler version uploaded and available right now (niffler-exif.jar and niffler-src.zip). Right. BufferedImages created with Component.createImage(int, int) are backed by a Cairo surface. Ones created directly by BufferedImage are not. Again, this is one of these things that needs to be fixed, basically so that all BufferedImages can have some native backing buffer.) Hmmm... ok. I added a special classpath workaround to Niffler that checks for java.vendor and calls ImageUtils.getCairoBackedImage( bufferedImage) before rendering when GNU something is detected. This adds another image conversion (BufferedImage drawn into an Image created by Component.createImage()), but makes the editing operations useable with jamvm. Good. 7. Perhaps LookupOp and ConvolveOp are bad? Select Tools Rotate image left (or right). Implemented 'by hand' via getRGB and setRGB. Much slower than LookupOp, about 4 seconds on my system at 800x600. They can probably be faster, but I don't think they're the main problem if the times you're measuring also include the repaint time. Nope; the times I quoted were the raw processing times, as reported by System.currentTimeMillis() before and after the operation. Repainting times are extra... Loading a 800x600 JPEG takes about 200 msecs with Toolkit, and about 7 seconds with Toolkit. Loading a 3000x2000 JPEG takes 200+ seconds. Too slow. Yep. Please excuse my typo there; the 7 and 200+ seconds are for jamvm and classpath loading a 800x600 or 3000x2000 JPEG via the imageio JPEG plugin. You can try the 10+ MPixel images from the Brussels' mort subite for yourself... The imageio GIF reader is much faster (4 seconds at 3000x2000), but now the conversion to BufferedImage.TYPE_INT_RGB takes 90+ seconds... Really? That sounds too fast, almost. How do you mean conversion? Running it through a filter, or just drawing the image returned by IIO onto the the aforementioned BufferedImagE? You consider, 4+90 seconds too fast for 3000x2000? Wait for next years' digicams and cellphone cams :-) But yes; I use the same code-path for images loaded by AWT or IIO; the ImageUtils.getBufferedImage() method creates a BufferedImage.TYPE_INT_RGB and draws the input image into that (unless the input image already is RGB). Otherwise, I would need a PixelGrabber to get at the pixels for the histogram. Images returned by the PNG reader render as transparent. 9. Select Help Commands... A simple JTextArea in a JScrollPanel, but with about 700 lines of text. Try scrolling. Painfully slow. The vertical scrollbar only scrolls down on click event (but dragging works). I'll have to check this out. drawString is fairly slow nowadays. However, drawGlyphVector (and by extension TextLayout.draw) are quite snappy, comparable to the JDK in speed. We might need to tune Swing here. Should I submit another bug for this? Once upon a time, this used to be PR24152... I guess we need some technique to include performance-related tests in Mauve for regular regression testing. Unfortunately, I don't know how to do this, because both raw system speed and user picky-ness seem to differ greatly between different systems... Perhaps even better you could use VolatileImage (== an X pixmap). These objects are slower to draw onto, but render to the screen as fast as they possibly could, really. (Assuming X is doing a good job) So if your intention is to draw-onto-bitmap-once, display-bitmap-many, then it should make things many many times faster. OK. I last tried VolatimeImage when JDK 1.4 came out, and it didn't seem like a great idea to me back then... Perhaps it's time to give VolatileImage another chance, now... Thanks, Norman
Re: Torturing image ops and Swing
On Thu, 2006-08-03 at 22:28 +0200, [EMAIL PROTECTED] wrote: Hello Sven, thanks for your detailed answers to my questions! New Niffler version uploaded and available right now (niffler-exif.jar and niffler-src.zip). Ok good. :) I added a special classpath workaround to Niffler that checks for java.vendor and calls ImageUtils.getCairoBackedImage( bufferedImage) before rendering when GNU something is detected. This adds another image conversion (BufferedImage drawn into an Image created by Component.createImage()), but makes the editing operations useable with jamvm. Good. Well, lemme just point out that Component.createImage() is basically the same thing as calling GraphicsConfiguration.createCompatibleImage() for the GraphicsConfiguration of that Component (Read: The graphicsconfiguration of your screen). So as such, it's supposed to return a BufferedImage with a pixel format best suited for fast drawing on your screen (using whatever color mode you've got set). So this will always result in faster images, regardless of Java impl. Yep. Please excuse my typo there; the 7 and 200+ seconds are for jamvm and classpath loading a 800x600 or 3000x2000 JPEG via the imageio JPEG plugin. You can try the 10+ MPixel images from the Brussels' mort subite for yourself... Yes, the existing ImageIO plugin for JPEG (Which is a generic wrapper around gdk-pixbuf that someone coded) is totaly flawed. I haven't actually looked at the code, but I think that however it's doing its job it's doing it in a horribly bad way. The plan (or my plan at least) is to just throw this out as soon as we get a real JPEG decoder. Really? That sounds too fast, almost. How do you mean conversion? Running it through a filter, or just drawing the image returned by IIO onto the the aforementioned BufferedImagE? You consider, 4+90 seconds too fast for 3000x2000? Wait for next years' digicams and cellphone cams :-) 90 seconds is very slow. But that part wasn't so unexpected to me, it's basically due to the inefficient awt.image impl we have. But 5 seconds to decode such a large GIF is pretty dang good considering that it's all done in Java. (I guess I'm particularily interested in this since I wrote the GIF decoder). [ JTextArea in a JScrollPanel with 700 lines .. ] I'll have to check this out. drawString is fairly slow nowadays. However, drawGlyphVector (and by extension TextLayout.draw) are quite snappy, comparable to the JDK in speed. We might need to tune Swing here. Should I submit another bug for this? Once upon a time, this used to be PR24152... Naw, I'll do it. I'll want to check up on where the problem is first. While drawString() is slow, I doubt a that bit it's slow enough to render the thing unusable. It's probably something else. (Basically we're talking about rendering a large string in 4 ms or .4 ms, but since I assume you're not showing all 700 at once, I doubt that's it.) I guess we need some technique to include performance-related tests in Mauve for regular regression testing. Unfortunately, I don't know how to do this, because both raw system speed and user picky-ness seem to differ greatly between different systems... I'd much rather not. Tests in general and benchmarks in particular often make people lose focus. IMHO, people will tend to fix the test but sometimes cause a worse regression in something not as well tested. With a fixed set of benchmarks people will invariably end up sacrificing speed of non-benchmarked things to improve the benchmark scores. Either that, or there's a large risk they'll start microoptimizing and trying to improve things that are already more than adequately fast while ignoring bigger problems elsewhere. Premature optimization is the root of all evil. So my opinion is that we should do benchmarking, but the way we tend to do it now; sporadically and thoroughly by the people hacking on the code and know it well, and know what to look for and what to check for. Writing a benchmark is trivial. Writing a benchmark that actually measures something meaningful is not. In short: Superficial automated benchmarks will only result in superficial automated optimizations. To give a practical example, there about a half dozen optimizations I know about which could improve the drawing performance of CairoGraphics2D for shapes. (not images) I posted the results earlier, which were that they're entirely insignificant because Cairo is so very slow. And in that case, it's not worth complicating the code at this stage for what amounts to almost nothing relatively speaking. Plus some speed losses are simply necessary. You can't expect to improve performance consistently in code as immature as most of our Java2D code. There are some fundamental design issues that need to be fixed first. /Sven
[Bug classpath/23899] SecureRandom.next should call nextBytes
--- Comment #16 from cvs-commit at developer dot classpath dot org 2006-08-03 22:19 --- Subject: Bug 23899 CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 22:18:49 Modified files: . : ChangeLog java/security : SecureRandom.java Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23899 * java/security/SecureRandom.java (next): Call nextBytes as per specs. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.301r2=1.2386.2.302 http://cvs.savannah.gnu.org/viewcvs/classpath/java/security/SecureRandom.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.14.2.7r2=1.14.2.8 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23899 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug classpath/23899] SecureRandom.next should call nextBytes
--- Comment #17 from mark at gcc dot gnu dot org 2006-08-03 22:20 --- (In reply to comment #15) will that be in the classpath merge for the GCC trunk? Yes, it is now part of 0.92-pre which will hopefully soon turn int 0.92 final and then be merged into gcc trunk. -- mark at gcc dot gnu dot org changed: What|Removed |Added Target Milestone|--- |0.92 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23899 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug classpath/23899] SecureRandom.next should call nextBytes
--- Comment #18 from cvs-commit at developer dot classpath dot org 2006-08-03 22:20 --- Subject: Bug 23899 CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 22:19:12 Modified files: . : ChangeLog java/security : SecureRandom.java Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23899 * java/security/SecureRandom.java (next): Call nextBytes as per specs. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.11r2=1.8251.2.12 http://cvs.savannah.gnu.org/viewcvs/classpath/java/security/SecureRandom.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.22r2=1.22.4.1 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23899 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug swing/28562] JOptionPane.showInputDialog
--- Comment #7 from cvs-commit at developer dot classpath dot org 2006-08-03 23:27 --- Subject: Bug 28562 CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 23:22:43 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicOptionPaneUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Cleanly reinstall components when visual property chanegs. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Uninstall and reinstall component when visual properties change. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.305r2=1.2386.2.306 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicOptionPaneUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.10.2.13r2=1.10.2.14 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28562 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug swing/28562] JOptionPane.showInputDialog
--- Comment #8 from cvs-commit at developer dot classpath dot org 2006-08-03 23:27 --- Subject: Bug 28562 CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 23:23:12 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicOptionPaneUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Cleanly reinstall components when visual property chanegs. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Uninstall and reinstall component when visual properties change. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.15r2=1.8251.2.16 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicOptionPaneUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.33r2=1.33.2.1 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28562 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug swing/28534] Regression in javax.swing.JTree
--- Comment #4 from cvs-commit at developer dot classpath dot org 2006-08-03 23:28 --- Subject: Bug 28534 CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 23:15:08 Modified files: . : ChangeLog javax/swing: JTree.java javax/swing/plaf/basic: BasicTreeUI.java Log message: 2006-07-31 Roman Kennke [EMAIL PROTECTED] PR 28534 * javax/swing/JTree.java (JTree(TreeModel)): Set cell renderer to null. * javax/swing/plaf/basic/BasicTreeUI.java (setCellRenderer): Finish editing before setting the cell renderer. Refresh the layout. Don't set the currentCellRenderer field here (that's done in updateRenderer). (updateRenderer): Handle createdRenderer field here too. Set renderer to a default handler when the current renderer in the JTree is null. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.14r2=1.8251.2.15 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JTree.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.70r2=1.70.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicTreeUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.150r2=1.150.2.1 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28534 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
[Bug swing/28534] Regression in javax.swing.JTree
--- Comment #5 from cvs-commit at developer dot classpath dot org 2006-08-03 23:28 --- Subject: Bug 28534 CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 23:14:19 Modified files: . : ChangeLog javax/swing: JTree.java javax/swing/plaf/basic: BasicTreeUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28534 * javax/swing/JTree.java (JTree(TreeModel)): Set cell renderer to null. * javax/swing/plaf/basic/BasicTreeUI.java (setCellRenderer): Finish editing before setting the cell renderer. Refresh the layout. Don't set the currentCellRenderer field here (that's done in updateRenderer). (updateRenderer): Handle createdRenderer field here too. Set renderer to a default handler when the current renderer in the JTree is null. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.304r2=1.2386.2.305 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JTree.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.8.2.21r2=1.8.2.22 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicTreeUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.6.2.21r2=1.6.2.22 -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28534 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
Re: SIGSEGV caused by libgconf-2.so.4
hello Mario,
On Friday 04 August 2006 09:32, Mario Torre wrote:
Il giorno ven, 04/08/2006 alle 09.12 +1000, Raif S. Naffah ha scritto:
i'm getting a segmentation fault caused by /usr/lib/libgconf-2.so.4
(FC5) when trying to run jamvm with Classpath (both CVS Head)...
anybody else is seeing this?
Hi!
Do you have a test case for that?
I can't see it, but maybe I'm trying with the wrong tests...
here is how i can trigger it:
import java.util.prefs.Preferences;
public class Hello {
public static final void main(String[] args) {
Preferences prefs = Preferences.systemNodeForPackage(Hello.class);
int lastSerialNumber = prefs.getInt(LAST_SERIAL_NUMBER, 0) + 1;
prefs.putInt(LAST_SERIAL_NUMBER, lastSerialNumber);
}
}
compiled with javac:
$ javac -version
Eclipse Java Compiler v_585_R31x, 3.1.2 release, Copyright IBM Corp 2000,
2006. All rights reserved.
and run with jamvm:
$ ./bin/jamvm -version
java version 1.4.2
JamVM version 1.4.4-pre
...
cheers;
rsn
pgprv0ZKkCI67.pgp
Description: PGP signature
[Bug xml/27864] Wrong number of entries returned for getElementsByTagName() in special case
--- Comment #3 from thebohemian at gmx dot net 2006-08-04 00:11 --- Fixed by: http://developer.classpath.org/pipermail/classpath-patches/2006-June/002644.html and http://developer.classpath.org/pipermail/classpath-patches/2006-August/003715.html -- thebohemian at gmx dot net changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||FIXED Target Milestone|--- |0.92 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27864 ___ Bug-classpath mailing list Bug-classpath@gnu.org http://lists.gnu.org/mailman/listinfo/bug-classpath
Re: SIGSEGV caused by libgconf-2.so.4
On Friday 04 August 2006 09:49, Raif S. Naffah wrote:
On Friday 04 August 2006 09:32, Mario Torre wrote:
Il giorno ven, 04/08/2006 alle 09.12 +1000, Raif S. Naffah ha scritto:
i'm getting a segmentation fault caused by /usr/lib/libgconf-2.so.4
(FC5) when trying to run jamvm with Classpath (both CVS Head)...
anybody else is seeing this?
Do you have a test case for that?
here is how i can trigger it:
import java.util.prefs.Preferences;
public class Hello {
public static final void main(String[] args) {
Preferences prefs = Preferences.systemNodeForPackage(Hello.class);
int lastSerialNumber = prefs.getInt(LAST_SERIAL_NUMBER, 0) + 1;
prefs.putInt(LAST_SERIAL_NUMBER, lastSerialNumber);
}
}
in addition to the above, when i configure Classpath with
--disable-default-preferences-peer, and try to run the same code (as
above) i get:
Aug 4, 2006 10:06:25 AM gnu.classpath.ServiceFactory lookupProviders
WARNING: Cannot load service provider class no, specified by
META-INF/services/java.util.prefs.PreferencesFactory in
file:/data/workspace/cvs/classpath/install/share/classpath/META-INF/services/java.util.prefs.PreferencesFactory
java.security.PrivilegedActionException: java.lang.ClassNotFoundException: no
not found in java.lang.ClassLoader$1{urls=[file:/home/raif/], parent=null}
at java.security.AccessController.doPrivileged(AccessController.java:203)
at
gnu.classpath.ServiceFactory$ServiceIterator.loadNextServiceProvider(ServiceFactory.java:463)
at
gnu.classpath.ServiceFactory$ServiceIterator.init(ServiceFactory.java:372)
at gnu.classpath.ServiceFactory.lookupProviders(ServiceFactory.java:252)
at java.util.prefs.Preferences.getFactory(Preferences.java:214)
at java.util.prefs.Preferences.systemRoot(Preferences.java:139)
at java.util.prefs.Preferences.systemNodeForPackage(Preferences.java:257)
at Hello.main(Hello.java:5)
Caused by: java.lang.ClassNotFoundException: no not found in
java.lang.ClassLoader$1{urls=[file:/home/raif/], parent=null}
at java.net.URLClassLoader.findClass(URLClassLoader.java:531)
at java.lang.ClassLoader.loadClass(ClassLoader.java:342)
at java.lang.ClassLoader$1.loadClass(ClassLoader.java:1112)
at java.lang.ClassLoader.loadClass(ClassLoader.java:294)
at
gnu.classpath.ServiceProviderLoadingAction.run(ServiceProviderLoadingAction.java:139)
at java.security.AccessController.doPrivileged(AccessController.java:195)
...7 more
which i presume is caused by no being generated in the file
java.util.prefs.PreferencesFactory under resource/META-INF/services,
instead of gnu.java.util.prefs.FileBasedFactory.
cheers;
rsn
pgpbJWpNiZJ4v.pgp
Description: PGP signature
[Bug swing/27606] No indentation of the directories in JFileChooser
--- Comment #4 from cvs-commit at developer dot classpath dot org 2006-08-04 00:45 --- Subject: Bug 27606 CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/04 00:43:45 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.307r2=1.2386.2.308 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.8.2.16r2=1.8.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.5r2=1.3.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.4r2=1.1.2.5 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.5r2=1.1.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.13r2=1.2.2.14 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.9.2.15r2=1.9.2.16 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/metal/MetalFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.8r2=1.3.2.9 --
[Bug swing/27604] JFileChooser does not handle well special paths
--- Comment #4 from cvs-commit at developer dot classpath dot org 2006-08-04 00:45 --- Subject: Bug 27604 CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/04 00:43:31 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.16r2=1.8251.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.33r2=1.33.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.10r2=1.10.10.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.4r2=1.4.4.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.4r2=1.4.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.27r2=1.27.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.59r2=1.59.2.1
[Bug swing/27604] JFileChooser does not handle well special paths
--- Comment #4 from cvs-commit at developer dot classpath dot org 2006-08-04 00:45 --- Subject: Bug 27604 CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/04 00:43:31 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.16r2=1.8251.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.33r2=1.33.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.10r2=1.10.10.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.4r2=1.4.4.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.4r2=1.4.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.27r2=1.27.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.59r2=1.59.2.1
[Bug swing/27605] Choosing a directory in the JFileChooser's JComboBox doesn't seem to do anything
--- Comment #3 from cvs-commit at developer dot classpath dot org 2006-08-04 00:45 --- Subject: Bug 27605 CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/04 00:43:45 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.307r2=1.2386.2.308 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.8.2.16r2=1.8.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.5r2=1.3.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.4r2=1.1.2.5 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.5r2=1.1.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.13r2=1.2.2.14 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.9.2.15r2=1.9.2.16 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/metal/MetalFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.8r2=1.3.2.9
[Bug swing/27605] Choosing a directory in the JFileChooser's JComboBox doesn't seem to do anything
--- Comment #3 from cvs-commit at developer dot classpath dot org 2006-08-04 00:45 --- Subject: Bug 27605 CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/04 00:43:45 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.307r2=1.2386.2.308 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.8.2.16r2=1.8.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.5r2=1.3.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.4r2=1.1.2.5 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.5r2=1.1.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.13r2=1.2.2.14 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.9.2.15r2=1.9.2.16 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/metal/MetalFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.8r2=1.3.2.9 --
Re: SIGSEGV caused by libgconf-2.so.4
Raif which i presume is caused by no being generated in the file Raif java.util.prefs.PreferencesFactory under resource/META-INF/services, Raif instead of gnu.java.util.prefs.FileBasedFactory. Try this. (untested) Tom Index: configure.ac === RCS file: /cvsroot/classpath/classpath/configure.ac,v retrieving revision 1.175 diff -u -r1.175 configure.ac --- configure.ac2 Aug 2006 19:32:45 - 1.175 +++ configure.ac4 Aug 2006 00:39:11 - @@ -89,7 +89,7 @@ AS_HELP_STRING([--enable-default-preferences-peer], [fully qualified class name of default Preferences API Backend])) DEFAULT_PREFS_PEER=$enable_default_preferences_peer -if test $DEFAULT_PREFS_PEER = ; then +if test $DEFAULT_PREFS_PEER = no || test $DEFAULT_PREFS_PEER = yes; then DEFAULT_PREFS_PEER=gnu.java.util.prefs.FileBasedFactory fi dnl AC_SUBST(DEFAULT_PREFS_PEER)
Re: SIGSEGV caused by libgconf-2.so.4
On Friday 04 August 2006 10:53, Mario Torre wrote:
Il giorno ven, 04/08/2006 alle 10.13 +1000, Raif S. Naffah ha scritto:
On Friday 04 August 2006 09:49, Raif S. Naffah wrote:
On Friday 04 August 2006 09:32, Mario Torre wrote:
Il giorno ven, 04/08/2006 alle 09.12 +1000, Raif S. Naffah ha scritto:
i'm getting a segmentation fault caused by /usr/lib/libgconf-2.so.4
(FC5) when trying to run jamvm with Classpath (both CVS Head)...
anybody else is seeing this?
Do you have a test case for that?
here is how i can trigger it:
import java.util.prefs.Preferences;
public class Hello {
public static final void main(String[] args) {
Preferences prefs = Preferences.systemNodeForPackage(Hello.class);
int lastSerialNumber = prefs.getInt(LAST_SERIAL_NUMBER, 0) + 1;
prefs.putInt(LAST_SERIAL_NUMBER, lastSerialNumber);
}
}
I can't reproduce.
Moreover, you get a warning if you put this into the default package (it
does not cause harm), but other than that, it is fine (the warning is
normal).
Anyway, Can you try the attached patch and see if it works?
i'll do that soon.
in addition to the above, when i configure Classpath with
--disable-default-preferences-peer, and try to run the same code (as
above) i get:
Well, sorry this is my fault, I hope to fix this tomorrow, as I'm not an
autoconf expert, so I have to look at it in more details (and now I
really need some sleep).
There should not be any --disable-default-preferences-peer.
The preference flags are intended to use this way:
--disable-gconf-peer: disable the gconf backend
--enable-default-preferences-peer=gnu.java.util.prefs.FileBasedFactory:
use another backend, not the default (everything that this default is,
may also not be gconf).
i'm attaching a patch that fixes this configuration issue.
This means that you can build the preference backend but with another
default, or you can totally disable the preference backend.
I guess that --disable-default-preferences-peer should not create any
key in the META-INF directory.
The correct name for this flag should really be
--with-default-preferences-peer...
The exceptions are normal, it should revert to a sane default if
everything else fails. This should be the FileBasedPreferences, can you
please confirm this? What happened after the error?
as i mentioned earlier a seg fault; i.e. the VM exists.
Sorry for the confusion, and thanks for pointing me out to this
no worries! thanks for looking into it.
cheers;
rsn
Index: configure.ac
===
RCS file: /cvsroot/classpath/classpath/configure.ac,v
retrieving revision 1.176
diff -u -r1.176 configure.ac
--- configure.ac 2 Aug 2006 23:28:12 - 1.176
+++ configure.ac 4 Aug 2006 01:00:03 -
@@ -85,13 +85,15 @@
dnl ---
dnl Default Preference Backend
dnl ---
-AC_ARG_ENABLE(default-preferences-peer,
- AS_HELP_STRING([--enable-default-preferences-peer],
- [fully qualified class name of default Preferences API Backend]))
-DEFAULT_PREFS_PEER=$enable_default_preferences_peer
-if test $DEFAULT_PREFS_PEER = ; then
- DEFAULT_PREFS_PEER=gnu.java.util.prefs.FileBasedFactory
-fi
+AC_ARG_ENABLE([default-preferences-peer],
+ [AS_HELP_STRING([--enable-default-preferences-peer],
+ [fully qualified class name of default Preferences API Backend [default=gnu.java.util.prefs.GConfBasedFactory])])],
+ [case ${enableval} in
+yes) DEFAULT_PREFS_PEER=gnu.java.util.prefs.GConfBasedFactory ;;
+no) DEFAULT_PREFS_PEER=gnu.java.util.prefs.FileBasedFactory ;;
+*) DEFAULT_PREFS_PEER=${enableval} ;;
+ esac],
+ [DEFAULT_PREFS_PEER=gnu.java.util.prefs.GConfBasedFactory])
dnl AC_SUBST(DEFAULT_PREFS_PEER)
dnl ---
Re: SIGSEGV caused by libgconf-2.so.4
hello Mario,
On Friday 04 August 2006 11:09, Raif S. Naffah wrote:
On Friday 04 August 2006 10:53, Mario Torre wrote:
Il giorno ven, 04/08/2006 alle 10.13 +1000, Raif S. Naffah ha scritto:
On Friday 04 August 2006 09:49, Raif S. Naffah wrote:
On Friday 04 August 2006 09:32, Mario Torre wrote:
Il giorno ven, 04/08/2006 alle 09.12 +1000, Raif S. Naffah ha scritto:
i'm getting a segmentation fault caused by
/usr/lib/libgconf-2.so.4 (FC5) when trying to run jamvm with
Classpath (both CVS Head)... anybody else is seeing this?
Do you have a test case for that?
here is how i can trigger it:
import java.util.prefs.Preferences;
public class Hello {
public static final void main(String[] args) {
Preferences prefs =
Preferences.systemNodeForPackage(Hello.class); int lastSerialNumber =
prefs.getInt(LAST_SERIAL_NUMBER, 0) + 1;
prefs.putInt(LAST_SERIAL_NUMBER, lastSerialNumber);
}
}
I can't reproduce.
Moreover, you get a warning if you put this into the default package (it
does not cause harm), but other than that, it is fine (the warning is
normal).
Anyway, Can you try the attached patch and see if it works?
i'll do that soon.
it does! as you mentioned, i do get the following printed to the console, but
otherwise the program functions as expected:
(process:18806): GConf-CRITICAL **: gconf_client_add_dir: assertion
`gconf_valid_key (dirname, NULL)' failed
thanks for your prompt intervention + cheers;
rsn
pgpWa6tfYw4mD.pgp
Description: PGP signature
Re: Torturing image ops and Swing
Hi Sven, As you say, if we go after too many goals, we may end accomplishing none of them, or worse complete them half way and leave users scratching their heads as to what went wrong(this leaves a really bad impression). So it is better for us to say, It maybe slow, but at least it is working and it is an equivalent to JDK 1.4(or 1.5). I think that after we achieve compatibility with ONE version of Java API, we can go after the optimizations. We can then say, We have a solid equivalent of JDK 1.4. This will be enough to gain many peoples attention. I think we should reach a consensus of SPEC compatibility vs RI compatibility, then we should write it down on the WIKI and stick to it until it is complete. That way we can all stay focused. Remember, Sun's comments about our inability to organize: For a long time Sun believed that Free Java efforts such as Kaffe/GNU Classpath were not a real threat because they were poorly organized to actually implement the entire set of class libraries (which admittedly is a huge task). But even if the class libraries were implemented in toto, there was always the fact that they couldn't possibly do SWING. - Danese Cooper, May 18, 2006 There is no perfect answer that can satisfy everyone, we just have to pick one which will work best for 80% of the situations, and labor until it is done. David Fu. On Thu, 2006-08-03 at 22:28 +0200, [EMAIL PROTECTED] wrote: Hello Sven, thanks for your detailed answers to my questions! New Niffler version uploaded and available right now (niffler-exif.jar and niffler-src.zip). Ok good. :) I added a special classpath workaround to Niffler that checks for java.vendor and calls ImageUtils.getCairoBackedImage( bufferedImage) before rendering when GNU something is detected. This adds another image conversion (BufferedImage drawn into an Image created by Component.createImage()), but makes the editing operations useable with jamvm. Good. Well, lemme just point out that Component.createImage() is basically the same thing as calling GraphicsConfiguration.createCompatibleImage() for the GraphicsConfiguration of that Component (Read: The graphicsconfiguration of your screen). So as such, it's supposed to return a BufferedImage with a pixel format best suited for fast drawing on your screen (using whatever color mode you've got set). So this will always result in faster images, regardless of Java impl. Yep. Please excuse my typo there; the 7 and 200+ seconds are for jamvm and classpath loading a 800x600 or 3000x2000 JPEG via the imageio JPEG plugin. You can try the 10+ MPixel images from the Brussels' mort subite for yourself... Yes, the existing ImageIO plugin for JPEG (Which is a generic wrapper around gdk-pixbuf that someone coded) is totaly flawed. I haven't actually looked at the code, but I think that however it's doing its job it's doing it in a horribly bad way. The plan (or my plan at least) is to just throw this out as soon as we get a real JPEG decoder. Really? That sounds too fast, almost. How do you mean conversion? Running it through a filter, or just drawing the image returned by IIO onto the the aforementioned BufferedImagE? You consider, 4+90 seconds too fast for 3000x2000? Wait for next years' digicams and cellphone cams :-) 90 seconds is very slow. But that part wasn't so unexpected to me, it's basically due to the inefficient awt.image impl we have. But 5 seconds to decode such a large GIF is pretty dang good considering that it's all done in Java. (I guess I'm particularily interested in this since I wrote the GIF decoder). [ JTextArea in a JScrollPanel with 700 lines .. ] I'll have to check this out. drawString is fairly slow nowadays. However, drawGlyphVector (and by extension TextLayout.draw) are quite snappy, comparable to the JDK in speed. We might need to tune Swing here. Should I submit another bug for this? Once upon a time, this used to be PR24152... Naw, I'll do it. I'll want to check up on where the problem is first. While drawString() is slow, I doubt a that bit it's slow enough to render the thing unusable. It's probably something else. (Basically we're talking about rendering a large string in 4 ms or .4 ms, but since I assume you're not showing all 700 at once, I doubt that's it.) I guess we need some technique to include performance-related tests in Mauve for regular regression testing. Unfortunately, I don't know how to do this, because both raw system speed and user picky-ness seem to differ greatly between different systems... I'd much rather not. Tests in general and benchmarks in particular often make people lose focus. IMHO, people will tend to fix the test but sometimes cause a worse regression in something not as well tested. With a fixed set of benchmarks people will invariably end up sacrificing speed of non-benchmarked things to improve the
[commit-cp] classpath ChangeLog gnu/java/awt/peer/gtk/Compo...
CVSROOT:/sources/classpath Module name:classpath Changes by: Sven de Marothy smarothy 06/08/03 08:08:14 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: ComponentGraphics.java GtkComponentPeer.java include: gnu_java_awt_peer_gtk_ComponentGraphics.h java/awt : Component.java native/jni/gtk-peer: gnu_java_awt_peer_gtk_ComponentGraphics.c Log message: 2006-08-03 Sven de Marothy [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/ComponentGraphics.java (grab, nativeGrab): New methods. * include/gnu_java_awt_peer_gtk_ComponentGraphics.h * native/jni/gtk-peer/gnu_java_awt_peer_gtk_ComponentGraphics.c (nativeGrab): New method. * gnu/java/awt/peer/gtk/GtkComponentPeer.java (print): Implement. * java/awt/Component.java (printAll): Should call peer print method. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8305r2=1.8306 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/awt/peer/gtk/ComponentGraphics.java?cvsroot=classpathr1=1.19r2=1.20 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/awt/peer/gtk/GtkComponentPeer.java?cvsroot=classpathr1=1.119r2=1.120 http://cvs.savannah.gnu.org/viewcvs/classpath/include/gnu_java_awt_peer_gtk_ComponentGraphics.h?cvsroot=classpathr1=1.8r2=1.9 http://cvs.savannah.gnu.org/viewcvs/classpath/java/awt/Component.java?cvsroot=classpathr1=1.141r2=1.142 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_ComponentGraphics.c?cvsroot=classpathr1=1.17r2=1.18
[commit-cp] classpath gnu/java/awt/peer/gtk/GtkCanvasPeer.j...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Roman Kennke rabbit78 06/08/03 09:54:58 Modified files: gnu/java/awt/peer/gtk: GtkCanvasPeer.java java/awt/peer : ComponentPeer.java . : ChangeLog Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28571 * gnu/java/awt/peer/gtk/GtkCanvasPeer.java (getPreferredSize): Renamed method to preferredSize(). That's the one that gets called from java.awt.*. * java/awt/peer/ComponentPeer.java (getPreferredSize): Added specnote about this method never beeing called in the RI. (getMinimumSize): Added specnote about this method never beeing called in the RI. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/awt/peer/gtk/GtkCanvasPeer.java?cvsroot=classpathr1=1.18r2=1.19 http://cvs.savannah.gnu.org/viewcvs/classpath/java/awt/peer/ComponentPeer.java?cvsroot=classpathr1=1.17r2=1.18 http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8306r2=1.8307
[commit-cp] classpath ChangeLog scripts/import-cacerts.sh
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Raif S. Naffah raif 06/08/03 13:14:29 Modified files: . : ChangeLog Added files: scripts: import-cacerts.sh Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] * scripts/import-cacerts.sh: Batch CA certificates import script. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/scripts/import-cacerts.sh?cvsroot=classpathrev=1.1 http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8307r2=1.8308
[commit-cp] classpath ChangeLog java/lang/StrictMath.java
CVSROOT:/sources/classpath Module name:classpath Changes by: Carsten Neumann neumannc 06/08/03 19:04:58 Modified files: . : ChangeLog java/lang : StrictMath.java Log message: 2006-08-03 Carsten Neumann [EMAIL PROTECTED] * StrictMath.java (cbrt): Return argument if it is a NaN. (cosh): Likewise. (expm1): Likewise. (sinh): Likewise. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8309r2=1.8310 http://cvs.savannah.gnu.org/viewcvs/classpath/java/lang/StrictMath.java?cvsroot=classpathr1=1.14r2=1.15
[commit-cp] classpath ChangeLog java/lang/StrictMath.java
CVSROOT:/sources/classpath Module name:classpath Changes by: Carsten Neumann neumannc 06/08/03 18:42:11 Modified files: . : ChangeLog java/lang : StrictMath.java Log message: 2006-08-03 Carsten Neumann [EMAIL PROTECTED] * java/lang/StrictMath.java (tanh): New method. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8308r2=1.8309 http://cvs.savannah.gnu.org/viewcvs/classpath/java/lang/StrictMath.java?cvsroot=classpathr1=1.13r2=1.14
[commit-cp] classpath ChangeLog javax/management/MBeanAttri... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 20:24:30 Modified files: . : ChangeLog javax/management: MBeanAttributeInfo.java MBeanConstructorInfo.java MBeanFeatureInfo.java MBeanInfo.java MBeanNotificationInfo.java MBeanOperationInfo.java MBeanParameterInfo.java StandardMBean.java Log message: 2006-08-03 Andrew John Hughes [EMAIL PROTECTED] * examples/gnu/classpath/examples/management/TestBeans.java: New file. * javax/management/MBeanAttributeInfo.java: (toString()): Implemented. * javax/management/MBeanConstructorInfo.java: (toString()): Implemented. * javax/management/MBeanFeatureInfo.java: (toString()): Implemented. * javax/management/MBeanInfo.java: (toString()): Implemented. * javax/management/MBeanNotificationInfo.java: (toString()): Implemented. * javax/management/MBeanOperationInfo.java: (toString()): Implemented. * javax/management/MBeanParameterInfo.java: (toString()): Implemented. * javax/management/StandardMBean.java: (getMBeanInfo()): Fix attribute naming. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.9r2=1.8251.2.10 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanAttributeInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.1r2=1.1.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanConstructorInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.2r2=1.2.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanFeatureInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.2.2.1r2=1.2.2.2 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.3r2=1.3.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanNotificationInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.3r2=1.3.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanOperationInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.1r2=1.1.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanParameterInfo.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.1r2=1.1.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/StandardMBean.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.1r2=1.1.2.1
[commit-cp] classpath ChangeLog javax/management/MBeanAttri... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 20:24:48 Modified files: . : ChangeLog javax/management: MBeanAttributeInfo.java MBeanConstructorInfo.java MBeanFeatureInfo.java MBeanInfo.java MBeanNotificationInfo.java MBeanOperationInfo.java MBeanParameterInfo.java StandardMBean.java Log message: 2006-08-03 Andrew John Hughes [EMAIL PROTECTED] * examples/gnu/classpath/examples/management/TestBeans.java: New file. * javax/management/MBeanAttributeInfo.java: (toString()): Implemented. * javax/management/MBeanConstructorInfo.java: (toString()): Implemented. * javax/management/MBeanFeatureInfo.java: (toString()): Implemented. * javax/management/MBeanInfo.java: (toString()): Implemented. * javax/management/MBeanNotificationInfo.java: (toString()): Implemented. * javax/management/MBeanOperationInfo.java: (toString()): Implemented. * javax/management/MBeanParameterInfo.java: (toString()): Implemented. * javax/management/StandardMBean.java: (getMBeanInfo()): Fix attribute naming. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.299r2=1.2386.2.300 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanAttributeInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.4.1r2=1.1.4.2 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanConstructorInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.4.1r2=1.2.4.2 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanFeatureInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.3r2=1.1.2.4 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.3r2=1.1.2.4 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanNotificationInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.2r2=1.1.2.3 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanOperationInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.4.1r2=1.1.4.2 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/MBeanParameterInfo.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.4.1r2=1.1.4.2 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/management/StandardMBean.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.4.1r2=1.1.4.2
[commit-cp] classpath javax/swing/plaf/basic/BasicInternalF...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Roman Kennke rabbit78 06/08/03 20:26:05 Modified files: javax/swing/plaf/basic: BasicInternalFrameUI.java . : ChangeLog Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27637 * javax/swing/plaf/basic/BasicInternalFrameUI.java (ComponentHandler.componentResized): Reimplemented to handle arbitrary parents. (InternalFramePropertyChangeHandler.propertyChange): (Un)install component listener on changed ancestor. (installListeners): Install componentListener. (uninstallListeners): Uninstall componentListener. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicInternalFrameUI.java?cvsroot=classpathr1=1.40r2=1.41 http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8310r2=1.8311
[commit-cp] classpath ChangeLog native/jawt/Makefile.am nat... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 21:04:57 Modified files: . : ChangeLog native/jawt: Makefile.am native/jni/gtk-peer: Makefile.am native/jni/midi-alsa: Makefile.am native/jni/midi-dssi: Makefile.am native/jni/qt-peer: Makefile.am Log message: 2006-08-03 Thomas Fitzsimmons [EMAIL PROTECTED] * native/jawt/Makefile.am (libjawt_la_LDFLAGS): Add -avoid-version. * native/jni/gtk-peer/Makefile.am (libgtkpeer_la_LDFLAGS): Likewise. * native/jni/midi-alsa/Makefile.am (libgjsmalsa_la_LDFLAGS): Likewise. * native/jni/midi-dssi/Makefile.am (libgjsmdssi_la_LDFLAGS): Likewise. 2006-08-03 Thomas Fitzsimmons [EMAIL PROTECTED] * native/jni/qt-peer/Makefile.am (libqtpeer_la_LDFLAGS): Add -avoid-version. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.10r2=1.8251.2.11 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jawt/Makefile.am?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.7r2=1.7.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/gtk-peer/Makefile.am?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.48r2=1.48.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/midi-alsa/Makefile.am?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.3r2=1.3.4.1 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/midi-dssi/Makefile.am?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.6r2=1.6.4.1 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/qt-peer/Makefile.am?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.6r2=1.6.4.1
[commit-cp] classpath ChangeLog native/jawt/Makefile.am nat... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 21:07:42 Modified files: . : ChangeLog native/jawt: Makefile.am native/jni/gtk-peer: Makefile.am native/jni/midi-alsa: Makefile.am native/jni/midi-dssi: Makefile.am native/jni/qt-peer: Makefile.am Log message: 2006-08-03 Thomas Fitzsimmons [EMAIL PROTECTED] * native/jawt/Makefile.am (libjawt_la_LDFLAGS): Add -avoid-version. * native/jni/gtk-peer/Makefile.am (libgtkpeer_la_LDFLAGS): Likewise. * native/jni/midi-alsa/Makefile.am (libgjsmalsa_la_LDFLAGS): Likewise. * native/jni/midi-dssi/Makefile.am (libgjsmdssi_la_LDFLAGS): Likewise. 2006-08-03 Thomas Fitzsimmons [EMAIL PROTECTED] * native/jni/qt-peer/Makefile.am (libqtpeer_la_LDFLAGS): Add -avoid-version. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.300r2=1.2386.2.301 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jawt/Makefile.am?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.5r2=1.2.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/gtk-peer/Makefile.am?cvsroot=classpathonly_with_tag=generics-branchr1=1.12.2.18r2=1.12.2.19 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/midi-alsa/Makefile.am?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.2r2=1.2.2.3 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/midi-dssi/Makefile.am?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.3r2=1.2.2.4 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/qt-peer/Makefile.am?cvsroot=classpathonly_with_tag=generics-branchr1=1.4.2.3r2=1.4.2.4
[commit-cp] classpath ChangeLog java/security/SecureRandom.... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 22:18:49 Modified files: . : ChangeLog java/security : SecureRandom.java Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23899 * java/security/SecureRandom.java (next): Call nextBytes as per specs. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.301r2=1.2386.2.302 http://cvs.savannah.gnu.org/viewcvs/classpath/java/security/SecureRandom.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.14.2.7r2=1.14.2.8
[commit-cp] classpath ChangeLog java/security/SecureRandom.... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 22:19:12 Modified files: . : ChangeLog java/security : SecureRandom.java Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23899 * java/security/SecureRandom.java (next): Call nextBytes as per specs. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.11r2=1.8251.2.12 http://cvs.savannah.gnu.org/viewcvs/classpath/java/security/SecureRandom.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.22r2=1.22.4.1
[commit-cp] classpath ChangeLog gnu/java/security/key/rsa/R... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 22:28:43 Modified files: . : ChangeLog gnu/java/security/key/rsa: RSAKeyPairPKCS8Codec.java Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/28556 * gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java (encodePrivateKey): Updated documentation to clarify that RFC-2459 states that the parameters field of the AlgorithmIdentifier element MUST be NULL if present. Amended the code to reflect the specs. (decodePrivateKey): Handle case of NULL AlgorithmIdentifier.parameters. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.302r2=1.2386.2.303 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.4r2=1.3.2.5
[commit-cp] classpath ChangeLog gnu/java/security/key/rsa/R... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 22:29:00 Modified files: . : ChangeLog gnu/java/security/key/rsa: RSAKeyPairPKCS8Codec.java Log message: 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/28556 * gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java (encodePrivateKey): Updated documentation to clarify that RFC-2459 states that the parameters field of the AlgorithmIdentifier element MUST be NULL if present. Amended the code to reflect the specs. (decodePrivateKey): Handle case of NULL AlgorithmIdentifier.parameters. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.12r2=1.8251.2.13 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/security/key/rsa/RSAKeyPairPKCS8Codec.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.7r2=1.7.2.1
[commit-cp] classpath ChangeLog scripts/Makefile.am
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Mark Wielaard mark06/08/03 22:59:28 Modified files: . : ChangeLog scripts: Makefile.am Log message: * scripts/Makefile.am (EXTRA_DIST): Add import-cacerts.sh. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8312r2=1.8313 http://cvs.savannah.gnu.org/viewcvs/classpath/scripts/Makefile.am?cvsroot=classpathr1=1.2r2=1.3
[commit-cp] classpath ChangeLog scripts/Makefile.am scripts... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 23:04:54 Modified files: . : ChangeLog scripts: Makefile.am Added files: scripts: import-cacerts.sh Log message: 2006-08-03 Mark Wielaard [EMAIL PROTECTED] * scripts/Makefile.am (EXTRA_DIST): Add import-cacerts.sh. 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] * scripts/import-cacerts.sh: Batch CA certificates import script. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.303r2=1.2386.2.304 http://cvs.savannah.gnu.org/viewcvs/classpath/scripts/Makefile.am?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.2r2=1.2.2.3 http://cvs.savannah.gnu.org/viewcvs/classpath/scripts/import-cacerts.sh?cvsroot=classpathonly_with_tag=generics-branchrev=1.1.2.1
[commit-cp] classpath ChangeLog scripts/Makefile.am scripts... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 23:05:32 Modified files: . : ChangeLog scripts: Makefile.am Added files: scripts: import-cacerts.sh Log message: 2006-08-03 Mark Wielaard [EMAIL PROTECTED] * scripts/Makefile.am (EXTRA_DIST): Add import-cacerts.sh. 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] * scripts/import-cacerts.sh: Batch CA certificates import script. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.13r2=1.8251.2.14 http://cvs.savannah.gnu.org/viewcvs/classpath/scripts/Makefile.am?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.2r2=1.2.12.1 http://cvs.savannah.gnu.org/viewcvs/classpath/scripts/import-cacerts.sh?cvsroot=classpathonly_with_tag=classpath-0_92-branchrev=1.1.4.1
[commit-cp] classpath ChangeLog javax/swing/JTree.java java... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 23:14:19 Modified files: . : ChangeLog javax/swing: JTree.java javax/swing/plaf/basic: BasicTreeUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28534 * javax/swing/JTree.java (JTree(TreeModel)): Set cell renderer to null. * javax/swing/plaf/basic/BasicTreeUI.java (setCellRenderer): Finish editing before setting the cell renderer. Refresh the layout. Don't set the currentCellRenderer field here (that's done in updateRenderer). (updateRenderer): Handle createdRenderer field here too. Set renderer to a default handler when the current renderer in the JTree is null. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.304r2=1.2386.2.305 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JTree.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.8.2.21r2=1.8.2.22 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicTreeUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.6.2.21r2=1.6.2.22
[commit-cp] classpath ChangeLog javax/swing/JTree.java java... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 23:15:08 Modified files: . : ChangeLog javax/swing: JTree.java javax/swing/plaf/basic: BasicTreeUI.java Log message: 2006-07-31 Roman Kennke [EMAIL PROTECTED] PR 28534 * javax/swing/JTree.java (JTree(TreeModel)): Set cell renderer to null. * javax/swing/plaf/basic/BasicTreeUI.java (setCellRenderer): Finish editing before setting the cell renderer. Refresh the layout. Don't set the currentCellRenderer field here (that's done in updateRenderer). (updateRenderer): Handle createdRenderer field here too. Set renderer to a default handler when the current renderer in the JTree is null. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.14r2=1.8251.2.15 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JTree.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.70r2=1.70.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicTreeUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.150r2=1.150.2.1
[commit-cp] classpath ChangeLog javax/swing/plaf/basic/Basi... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/03 23:22:43 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicOptionPaneUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Cleanly reinstall components when visual property chanegs. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Uninstall and reinstall component when visual properties change. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.305r2=1.2386.2.306 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicOptionPaneUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.10.2.13r2=1.10.2.14
[commit-cp] classpath ChangeLog javax/swing/plaf/basic/Basi... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/03 23:23:12 Modified files: . : ChangeLog javax/swing/plaf/basic: BasicOptionPaneUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Cleanly reinstall components when visual property chanegs. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 28562 * javax/swing/plaf/basic/BasicOptionPaneUI.java (PropertyChangeHandler.propertyChange): Uninstall and reinstall component when visual properties change. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.15r2=1.8251.2.16 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicOptionPaneUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.33r2=1.33.2.1
[commit-cp] classpath gnu/xml/dom/DomIterator.java ChangeLog
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Robert Schuster rschuster 06/08/04 00:01:54 Modified files: gnu/xml/dom: DomIterator.java . : ChangeLog Log message: 2006-08-04 Robert Schuster [EMAIL PROTECTED] Reported by Henrik Gulbrandsen [EMAIL PROTECTED] Fixes PR27864. * gnu/xml/dom/DomIterator.java: (successor): Added if-statement. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/xml/dom/DomIterator.java?cvsroot=classpathr1=1.5r2=1.6 http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8313r2=1.8314
[commit-cp] classpath/examples/gnu/classpath/examples/manag... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/04 00:23:26 Added files: examples/gnu/classpath/examples/management: TestBeans.java Log message: 2006-08-03 Andrew John Hughes [EMAIL PROTECTED] * examples/gnu/classpath/examples/management/TestBeans.java: New file. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/examples/gnu/classpath/examples/management/TestBeans.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchrev=1.1.2.1
[commit-cp] classpath/examples/gnu/classpath/examples/manag... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/04 00:23:43 Added files: examples/gnu/classpath/examples/management: TestBeans.java Log message: 2006-08-03 Andrew John Hughes [EMAIL PROTECTED] * examples/gnu/classpath/examples/management/TestBeans.java: New file. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/examples/gnu/classpath/examples/management/TestBeans.java?cvsroot=classpathonly_with_tag=generics-branchrev=1.1.4.1
[commit-cp] classpath ChangeLog examples/gnu/classpath/exam... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/04 00:33:23 Modified files: . : ChangeLog Added files: examples/gnu/classpath/examples/icons: badge.png Log message: * examples/gnu/classpath/examples/icons/badge.png: Add file. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.306r2=1.2386.2.307 http://cvs.savannah.gnu.org/viewcvs/classpath/examples/gnu/classpath/examples/icons/badge.png?cvsroot=classpathonly_with_tag=generics-branchrev=1.1.6.1
[commit-cp] classpath ChangeLog javax/swing/JComboBox.java ... [classpath-0_92-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: classpath-0_92-branch Changes by: Mark Wielaard mark06/08/04 00:43:31 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.8251.2.16r2=1.8251.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.33r2=1.33.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.10r2=1.10.10.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.4r2=1.4.4.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.4r2=1.4.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.27r2=1.27.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.59r2=1.59.2.1 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/metal/MetalFileChooserUI.java?cvsroot=classpathonly_with_tag=classpath-0_92-branchr1=1.24r2=1.24.2.1
[commit-cp] classpath ChangeLog javax/swing/JComboBox.java ... [generics-branch]
CVSROOT:/cvsroot/classpath Module name:classpath Branch: generics-branch Changes by: Mark Wielaard mark06/08/04 00:43:45 Modified files: . : ChangeLog javax/swing: JComboBox.java javax/swing/filechooser: FileSystemView.java UnixFileSystemView.java javax/swing/plaf/basic: BasicDirectoryModel.java BasicFileChooserUI.java BasicListUI.java javax/swing/plaf/metal: MetalFileChooserUI.java Log message: 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27606 * javax/swing/plaf/basic/BasicListUI.java (paintCell): Pass row index to cell renderer. * javax/swing/plaf/basic/MetalFileChooserUI.java (DirectoryComboBoxRenderer.indentIcon): New field. (DirectoryComboBoxRenderer.DirectoryComboBoxRenderer): Initialize indentIcon. (DirectoryComboBoxRenderer.getListCellRendererComponent): Fall back to super and removed standard functionality. Handle indentation. (IndentIcon): New class. Wraps and indents another icon. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27605 * javax/swing/JComboBox.java (setSelectedItem): Fire ActionEvent here. * javax/swing/plaf/basic/BasicDirectoryModel.java (directories): Changed to type Vector. (files): New field. (loadThread): New field. (DirectoryLoadThread): New inner class. This loads the contents of directories asynchronously. (getDirectories): Return cached Vector. (getFiles): Return cached Vector. (getSize): Return plain size of contents Vector. (propertyChange): Reread directory also for DIRECTORY_CHANGED, FILE_FILTER_CHANGED, FILE_HIDING_CHANGED and FILE_VIEW_CHANGED. (sort): Don't store sorted list in contents. This must be done asynchronously from the EventThread. (validateFileCache): Rewritten for asynchronous reading of directory contents. * javax/swing/plaf/basic/BasicFileChooserUI.java (installListeners): Install model as PropertyChangeListener. (uninstallListeners): Uninstall model as PropertyChangeListener. (createPropertyChangeListener): Return null just like the RI. 2006-08-03 Roman Kennke [EMAIL PROTECTED] PR 27604 * javax/swing/plaf/basic/BasicChooserUI.java (BasicFileView.getName): Fetch the real name from the file chooser's FileSystemView. * javax/swing/plaf/metal/MetalChooserUI.java (DirectoryComboBoxRenderer.getListCellRendererComponent): Set the text fetched from the JFileChooser.getName(). * javax/swing/FileSystemView.java (createFileObject): When file is a filesystem root, create a filesystem root object first. (getSystemDisplayName): Return the filename. Added specnote about ShellFolder class that is mentioned in the spec. * javax/swing/UnixFileSystemView.java (getSystemDisplayName): Implemented to return the real name of a file, special handling files like '.' or '..'. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathonly_with_tag=generics-branchr1=1.2386.2.307r2=1.2386.2.308 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComboBox.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.8.2.16r2=1.8.2.17 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/FileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.5r2=1.3.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/filechooser/UnixFileSystemView.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.4r2=1.1.2.5 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicDirectoryModel.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.1.2.5r2=1.1.2.6 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.2.2.13r2=1.2.2.14 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/basic/BasicListUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.9.2.15r2=1.9.2.16 http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/plaf/metal/MetalFileChooserUI.java?cvsroot=classpathonly_with_tag=generics-branchr1=1.3.2.8r2=1.3.2.9
