Re: [cp-patches] RFC: JTree and BasicToolBarUI
Hi Tania, The JTree change looks ok. Only some remark about the BasicToolBarUI one: Index: javax/swing/plaf/basic/BasicToolBarUI.java === RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicToolBarUI.java,v retrieving revision 1.28 diff -u -r1.28 BasicToolBarUI.java --- javax/swing/plaf/basic/BasicToolBarUI.java 26 Jul 2006 13:39:39 - 1.28 +++ javax/swing/plaf/basic/BasicToolBarUI.java 21 Aug 2006 18:47:10 - @@ -898,7 +898,10 @@ b.setRolloverEnabled(false); // Save old border in hashtable. -borders.put(b, b.getBorder()); +if (b.getBorder() == null) + borders.put(b, b.getInsets()); +else + borders.put(b, b.getBorder()); b.setBorder(nonRolloverBorder); } I'd not store the insets in the border table. However, we might want to check if it's an UIResource and only store custom borders in the table: Border b = borders.get(b); if (b == null || b instanceof UIResource) borders.put(b, b.getBorder()); And later when putting the border back in place, check if there actually is a border in the table, and only reinstall the border when there's a non-null entry. Dunno if that's the problem. Maybe you could explain a little more what the problem here was. However, storing an Insets object seems confusing and not quite right. The borders table is there to store the original border of toolbar components, and install them back when the components get removed from the toolbar. You can't install an Insets object as Border... /Roman
[cp-patches] FYI: Swing Button/UI optimization
This should improve memory footprint and initialization performance for
JButton and derived classes:
- The listeners in AbstractButton are combined into one class, thus only
one instance needs to be instantiated per button (no sharing possible
unfortunately). The protected ButtonChangeListener class delegates to
this combined handler for compatibility.
- The UI classes are shared between between all button instances. I
thought they were shared before, but obviously weren't.
- The BasicButtonListener is now shared between all buttons. This is
where we are a little different from the RI, which installs a new
BasicButtonListener on each button. However, the implementation of
BasicButtonListener is perfectly suitable for sharing and should be
compatible to the RI still.
- The keyboard actions are now shared between buttons, and updated to
use the InputMap/ActionMap model like I already did for other components.
2006-08-22 Roman Kennke [EMAIL PROTECTED]
* javax/swing/AbstractButton.java
(ButtonChangeListener.stateChanged): Delegate to combined
handler.
(EventHandler): New inner class. Handles all three types
of events on the model.
(eventHandler): New field. Stores the combined event
handler.
(AbstractButton): Moved listener initialization to
setModel().
(createActionListener): Return combined handler.
(createChangeListener): Return combined handler.
(createItemListener): Return combined handler.
(getEventHandler): New helper method for creating the combined
handler.
(setModel): Initialize listeners here.
* javax/swing/plaf/basic/BasicButtonListener.java
(ButtonAction): New class. Implements the keyboard action
for buttons.
(checkOpacity): Implemented.
(createDefaultActionMap): New helper method.
(installKeyboardActions): Rewritten to install InputMap
and ActionMap according to 'new' keyboard input method.
(mouseClicked): Commented as no-op.
(mouseDragged): Commented as no-op.
(mouseMoved): Commented as no-op.
(propertyChange): Check for contentAreaFilled change and
update opacity. Pull handling of HTLM in font and text handler.
(stateChanged): Repaint button.
(uninstallKeyboardActions): Properly uninstall keyboard actions.
* javax/swing/plaf/basic/BasicButtonUI.java
(listener): Removed.
(sharedListener): New static field. Stores the shared listener.
(sharedUI): New static field. Stores the shared UI.
(createButtonListener): Return shared instance here.
(createUI): Return shared instance here.
(getButtonListener): New helper method. Looks for the
BasicButtonListener installed on a button and returns it.
(installDefaults): Correctly install rollover property here.
Fetch defaultTextShiftOffset. Initialize opaqueness correctly.
(installKeyboardActions): Fetch listener with new helper method.
(installListeners): Don't use removed field. Check for null.
(installUI): Added comment about order of method invocations.
(uninstallDefaults): Don't uninstall non-uninstallable properties.
(uninstallKeyboardActions): Fetch listener with new helper method.
(uninstallListeners): Fetch listener with new helper method.
(paintIcon): Paint icon offset when pressed and armed.
* javax/swing/plaf/metal/MetalButtonListener.java: Removed.
* javax/swing/plaf/metal/MetalButtonUI.java
(sharedUI): New field. Stores the shared UI.
(MetalButtonUI): Don't initialize fields here.
(createButtonListener): Removed method. Use super impl.
(createUI): Return shared instance.
(getDisabledTextColor): Update field here.
(getFocusColor): Update field here.
(getSelectColor): Update field here.
(installDefaults): Don't handle rollover property here.
(uninstallDefaults): Don't handle rollover property here.
(paintButtonPressed): Use accessor method to update the
field value.
/Roman
Index: javax/swing/AbstractButton.java
===
RCS file: /cvsroot/classpath/classpath/javax/swing/AbstractButton.java,v
retrieving revision 1.65
diff -u -1 -2 -r1.65 AbstractButton.java
--- javax/swing/AbstractButton.java 11 Jul 2006 15:35:29 - 1.65
+++ javax/swing/AbstractButton.java 22 Aug 2006 11:23:15 -
@@ -178,27 +178,50 @@
ButtonChangeListener()
{
// Nothing to do here.
}
/**
* Notified when the target of the listener changes its state.
*
* @param ev the ChangeEvent describing the change
*/
public void stateChanged(ChangeEvent ev)
{
- AbstractButton.this.fireStateChanged();
+ getEventHandler().stateChanged(ev);
+}
+ }
+
+ /**
+ * The combined
[cp-patches] FYI: JComponent fix
In JComponent we handle pref/min/max size specially. However, since
JDK1.5, we have the same stuff in Component (setBlahSize(),
isBlahSizeSet()). I adjusted the JComponent impl to use the super impl
when appropriate. This should improve memory footprint as it avoids the
doubled space for the pref/min/max size fields.
Note that I removed the isBlahSizeSet() and setBlahSize() methods. They
seems to be spec'ed in JComponent, however, I can't see why they should
do anything else than their super impl. So I took them out for
efficiency. I suppose Sun only left them in for the API docs or so.
2006-08-22 Roman Kennke [EMAIL PROTECTED]
* javax/swing/JComponent.java
(preferredSize): Removed field.
(maximumSize): Removed field.
(minimumSize): Removed field.
(getMaximumSize): Adjusted to delegate to Component, rather
then managing the size in JComponent.
(getMinimumSize): Adjusted to delegate to Component, rather
then managing the size in JComponent.
(getPreferredSize): Adjusted to delegate to Component, rather
then managing the size in JComponent.
(isMaximumSizeSet): Removed.
(isMinimumSizeSet): Removed.
(isPreferredSizeSet): Removed.
(setMaximumSize): Removed.
(setMinimumSize): Removed
(setPreferredSize): Removed.
/Roman
Index: javax/swing/JComponent.java
===
RCS file: /cvsroot/classpath/classpath/javax/swing/JComponent.java,v
retrieving revision 1.143
diff -u -1 -2 -r1.143 JComponent.java
--- javax/swing/JComponent.java 17 Aug 2006 15:11:54 - 1.143
+++ javax/swing/JComponent.java 22 Aug 2006 12:47:59 -
@@ -494,45 +494,24 @@
* codenull/code if the component does not support key bindings.
*
* @return the keybindings associated with this accessible component
*/
public AccessibleKeyBinding getAccessibleKeyBinding()
{
// The reference implementation seems to always return null here,
// independent of the key bindings of the JComponent. So do we.
return null;
}
}
- /**
- * An explicit value for the component's preferred size; if not set by a
- * user, this is calculated on the fly by delegating to the [EMAIL PROTECTED]
- * ComponentUI#getPreferredSize} method on the [EMAIL PROTECTED] #ui} property.
- */
- Dimension preferredSize;
-
- /**
- * An explicit value for the component's minimum size; if not set by a
- * user, this is calculated on the fly by delegating to the [EMAIL PROTECTED]
- * ComponentUI#getMinimumSize} method on the [EMAIL PROTECTED] #ui} property.
- */
- Dimension minimumSize;
-
- /**
- * An explicit value for the component's maximum size; if not set by a
- * user, this is calculated on the fly by delegating to the [EMAIL PROTECTED]
- * ComponentUI#getMaximumSize} method on the [EMAIL PROTECTED] #ui} property.
- */
- Dimension maximumSize;
-
/**
* A value between 0.0 and 1.0 indicating the preferred horizontal
* alignment of the component, relative to its siblings. The values
* [EMAIL PROTECTED] #LEFT_ALIGNMENT}, [EMAIL PROTECTED] #CENTER_ALIGNMENT}, and [EMAIL PROTECTED]
* #RIGHT_ALIGNMENT} can also be used, as synonyms for code0.0/code,
* code0.5/code, and code1.0/code, respectively. Not all layout
* managers use this property.
*
* @see #getAlignmentX
* @see #setAlignmentX
* @see javax.swing.OverlayLayout
* @see javax.swing.BoxLayout
@@ -1261,153 +1240,114 @@
* @return The component's current location
*/
public Point getLocation(Point rv)
{
if (rv == null)
return new Point(getX(), getY());
rv.setLocation(getX(), getY());
return rv;
}
/**
- * Get the component's maximum size. If the [EMAIL PROTECTED] #maximumSize} property
- * has been explicitly set, it is returned. If the [EMAIL PROTECTED] #maximumSize}
+ * Get the component's maximum size. If the codemaximumSize/code property
+ * has been explicitly set, it is returned. If the codemaximumSize/code
* property has not been set but the [EMAIL PROTECTED] #ui} property has been, the
* result of [EMAIL PROTECTED] ComponentUI#getMaximumSize} is returned. If neither
* property has been set, the result of [EMAIL PROTECTED] Container#getMaximumSize}
* is returned.
*
- * @return The maximum size of the component
+ * @return the maximum size of the component
*
- * @see #maximumSize
- * @see #setMaximumSize
+ * @see Component#setMaximumSize
+ * @see Component#getMaximumSize()
+ * @see Component#isMaximumSizeSet()
+ * @see ComponentUI#getMaximumSize(JComponent)
*/
public Dimension getMaximumSize()
{
-if (maximumSize != null)
- return maximumSize;
-
-if (ui != null)
+Dimension size = null;
+if (isMaximumSizeSet())
+ size = super.getMaximumSize();
+else
{
-
[cp-patches] RFA: MenuShortcut.java
Hey,
This patch fixes a failing test in Intel's TestSuite. I have committed
a mauve test for this.
Could someone kindly comment on and/or approve this patch.
Cheers,
Tania
2006-08-22 Tania Bento [EMAIL PROTECTED]
* java/awt/MenuShortcut.java
(MenuShortcut (int, boolean)): Set keyName.
(toString): Modified string output.
(setKeyName): New private method.
Index: java/awt/MenuShortcut.java
===
RCS file: /cvsroot/classpath/classpath/java/awt/MenuShortcut.java,v
retrieving revision 1.6
diff -u -r1.6 MenuShortcut.java
--- java/awt/MenuShortcut.java 2 Jul 2005 20:32:25 - 1.6
+++ java/awt/MenuShortcut.java 22 Aug 2006 19:25:55 -
@@ -38,6 +38,8 @@
package java.awt;
+import java.awt.event.KeyEvent;
+
/**
* This class implements a keyboard accelerator for a menu item.
*
@@ -70,6 +72,8 @@
*/
private boolean usesShift;
+private String keyName;
+
/*/
/**
@@ -99,6 +103,7 @@
{
this.key = key;
this.usesShift = usesShift;
+ setKeyName(key);
}
/*/
@@ -181,7 +186,11 @@
public String
toString()
{
- return(getClass().getName() + [ + paramString () + ]);
+ String temp = Ctrl+;
+ if (usesShift)
+temp = temp + Shift+;
+ temp = temp + keyName;
+ return temp;
}
public int
@@ -204,4 +213,224 @@
return key= + key + ,usesShift= + usesShift;
}
-} // class MenuShortcut
+private void
+setKeyName(int key)
+{
+ if (key == '\n')
+keyName = Enter;
+ else if (key == '\b')
+keyName = Backspace;
+ else if (key == '\t')
+keyName = Tab;
+ else if (key == ' ')
+keyName = Space;
+ else if (key == ',')
+keyName = Comma;
+ else if (key == '.')
+keyName = Period;
+ else if (key == '/')
+keyName = Slash;
+ else if (key == '\\')
+keyName = Back Slash;
+ else if (key == ';')
+keyName = Semicolon;
+ else if (key == '=')
+keyName = Equals;
+ else if (key == '[')
+keyName = Open Bracket;
+ else if (key == ']')
+keyName = Close Bracket;
+ else if (key == '0')
+keyName = 0;
+ else if (key == '1')
+keyName = 1;
+ else if (key == '2')
+keyName = 2;
+ else if (key == '3')
+keyName = 3;
+ else if (key == '4')
+keyName = 4;
+ else if (key == '5')
+keyName = 5;
+ else if (key == '6')
+keyName = 6;
+ else if (key == '7')
+keyName = 7;
+ else if (key == '8')
+keyName = 8;
+ else if (key == '9')
+keyName = 9;
+ else if (key == 'A')
+keyName = A;
+ else if (key == 'B')
+keyName = B;
+ else if (key == 'C')
+keyName = C;
+ else if (key == 'D')
+keyName = D;
+ else if (key == 'E')
+keyName = E;
+ else if (key == 'F')
+keyName = F;
+ else if (key == 'G')
+keyName = G;
+ else if (key == 'H')
+keyName = H;
+ else if (key == 'I')
+keyName = I;
+ else if (key == 'J')
+keyName = J;
+ else if (key == 'K')
+keyName = K;
+ else if (key == 'L')
+keyName = L;
+ else if (key == 'M')
+keyName = M;
+ else if (key == 'N')
+keyName = N;
+ else if (key == 'O')
+keyName = O;
+ else if (key == 'P')
+keyName = P;
+ else if (key == 'Q')
+keyName = Q;
+ else if (key == 'R')
+keyName = R;
+ else if (key == 'S')
+keyName = S;
+ else if (key == 'T')
+keyName = T;
+ else if (key == 'U')
+keyName = U;
+ else if (key == 'V')
+keyName = V;
+ else if (key == 'W')
+keyName = W;
+ else if (key == 'X')
+keyName = X;
+ else if (key == 'Y')
+keyName = Y;
+ else if (key == 'Z')
+keyName = Z;
+ else if (key == 3)
+keyName = Cancel;
+ else if (key == 12)
+keyName = Clear;
+ else if (key == 16)
+keyName = Shift;
+ else if (key == 17)
+keyName = Ctrl;
+ else if (key == 18)
+keyName = Alt;
+ else if (key == 19)
+keyName = Pause;
+ else if (key == 20)
+keyName = Caps Lock;
+ else if (key == 21)
+keyName = Kana;
+ else if (key == 24)
+keyName = Final;
+ else if (key == 25)
+keyName = Kanji;
+ else if (key == 27)
+keyName = Escape;
+ else if (key == 28)
+keyName = Convert;
+ else if (key == 29)
+keyName = No Convert;
+ else if (key == 30)
+keyName = Accept;
+ else if (key == 31)
+keyName = Mode Change;
+ else if (key == 33)
+keyName = Page Up;
+ else if (key == 34)
+keyName = Page Down;
+ else if (key == 35)
+keyName = End;
+ else if (key == 36)
+keyName = Home;
+ else if (key == 37)
+keyName = Left;
+ else if (key == 38)
+keyName = Up;
+ else if (key == 39)
+keyName = Right;
+ else if (key == 40)
+keyName = Down;
+ else if (key == 96)
+keyName = NumPad-0;
+ else if (key == 97)
+keyName = NumPad-1;
+ else if (key == 98)
+keyName = NumPad-2;
+ else if (key == 99)
+keyName = NumPad-3;
+ else if (key == 100)
+keyName = NumPad-4;
+
[cp-testresults] FAIL: gcc build on Tue Aug 22 08:10:22 UTC 2006
/home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/tree.lo -MD -MP -MF javax/swing/tree.deps @javax/swing/tree.list -o javax/swing/tree.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/swing/undo.lo -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list -fPIC -o javax/swing/.libs/undo.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list -o javax/swing/undo.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/transaction.lo -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list -fPIC -o javax/.libs/transaction.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list -o javax/transaction.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/transaction/xa.lo -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list mkdir javax/transaction/.libs /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list -fPIC -o javax/transaction/.libs/xa.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list -o javax/transaction/xa.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib
[cp-testresults] FAIL: gcc build on Tue Aug 22 11:20:04 UTC 2006
/home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/tree.lo -MD -MP -MF javax/swing/tree.deps @javax/swing/tree.list -o javax/swing/tree.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/swing/undo.lo -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list -fPIC -o javax/swing/.libs/undo.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list -o javax/swing/undo.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/transaction.lo -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list -fPIC -o javax/.libs/transaction.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list -o javax/transaction.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/transaction/xa.lo -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list mkdir javax/transaction/.libs /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list -fPIC -o javax/transaction/.libs/xa.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list -o javax/transaction/xa.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib
[cp-testresults] FAIL: gcc build on Tue Aug 22 14:30:38 UTC 2006
/home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/tree.lo -MD -MP -MF javax/swing/tree.deps @javax/swing/tree.list -o javax/swing/tree.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/swing/undo.lo -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list -fPIC -o javax/swing/.libs/undo.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/swing/undo.lo -MD -MP -MF javax/swing/undo.deps @javax/swing/undo.list -o javax/swing/undo.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/transaction.lo -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list -fPIC -o javax/.libs/transaction.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction.lo -MD -MP -MF javax/transaction.deps @javax/transaction.list -o javax/transaction.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -o javax/transaction/xa.lo -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list mkdir javax/transaction/.libs /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list -fPIC -o javax/transaction/.libs/xa.o /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib --encoding=UTF-8 -Wno-deprecated -fbootstrap-classes -g -O2 -c -MT javax/transaction/xa.lo -MD -MP -MF javax/transaction/xa.deps @javax/transaction/xa.list -o javax/transaction/xa.o /dev/null 21 /bin/sh ./libtool --mode=compile /home/cpdev/Nightly/gcc/build/gcc/gcj -B/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/ -B/home/cpdev/Nightly/gcc/build/gcc/ -ffloat-store -fomit-frame-pointer -fclasspath= -fbootclasspath=/home/cpdev/Nightly/gcc/build/i686-pc-linux-gnu/libjava/classpath/lib
[cp-testresults] FAIL: regressions for mauve-jamvm on Tue Aug 22 20:53:44 UTC 2006
Baseline from: Wed Aug 2 19:46:25 UTC 2006 Regressions: FAIL: gnu.javax.crypto.key.srp6.TestOfSRPKeyGeneration FAIL: java.awt.Canvas.PaintTest FAIL: java.text.DecimalFormat.parse FAIL: java.util.Vector.AcuniaVectorTest FAIL: javax.swing.JComboBox.ComboRobot FAIL: javax.swing.JComponent.setMaximumSize FAIL: javax.swing.JFileChooser.addChoosableFileFilter FAIL: javax.swing.JFileChooser.constructors FAIL: javax.swing.JFileChooser.getApproveButtonToolTipText FAIL: javax.swing.JFileChooser.getDialogTitle FAIL: javax.swing.JFileChooser.getFileFilter FAIL: javax.swing.JFileChooser.getFileSystemView FAIL: javax.swing.JFileChooser.getSelectedFiles FAIL: javax.swing.JFileChooser.isFileHidingEnabled FAIL: javax.swing.JFileChooser.removeChoosableFileFilter FAIL: javax.swing.JFileChooser.setApproveButtonText FAIL: javax.swing.JFileChooser.setCurrentDirectory FAIL: javax.swing.JFileChooser.setFileFilter FAIL: javax.swing.JFileChooser.setFileSelectionMode FAIL: javax.swing.JFormattedTextField.JFormattedTextFieldTests FAIL: javax.swing.JFrame.SetSize FAIL: javax.swing.JFrame.paint5 FAIL: javax.swing.JToolTip.setTipText FAIL: javax.swing.plaf.basic.BasicFileChooserUI.getApproveButton FAIL: javax.swing.plaf.basic.BasicFileChooserUI.getApproveButtonText FAIL: javax.swing.plaf.basic.BasicFileChooserUI.getApproveSelectionAction FAIL: javax.swing.plaf.basic.BasicFileChooserUI.getDialogTitle FAIL: javax.swing.plaf.basic.BasicFileChooserUI.getGoHomeAction FAIL: javax.swing.plaf.basic.BasicFileChooserUI.installIcons FAIL: javax.swing.plaf.basic.BasicFileChooserUI.installStrings FAIL: javax.swing.plaf.basic.BasicIconFactory.getCheckBoxIcon FAIL: javax.swing.plaf.metal.MetalFileChooserUI.getApproveButton FAIL: javax.swing.plaf.metal.MetalFileChooserUI.getButtonPanel FAIL: javax.swing.plaf.metal.MetalFileChooserUI.getMaximumSize FAIL: javax.swing.plaf.metal.MetalIconFactory.PaletteCloseIcon.getIconHeight FAIL: javax.swing.text.ElementIterator.ElementIteratorTest FAIL: org.omg.CORBA.ORB.RequestTest FAIL: org.omg.CORBA_2_3.ORB.ValueTypeTest FAIL: org.omg.PortableServer.POAOperations.poa_POA_test Improvements: PASS: java.awt.Checkbox.PaintTest PASS: java.lang.StrictMath.sinh PASS: java.net.DatagramSocket.DatagramSocketTest2 PASS: java.security.cert.pkix.pkits.ValidDSAParameterInheritenceTest5 PASS: javax.swing.JComponent.getInputMap PASS: javax.swing.table.JTableHeader.AccessibleJTableHeader.AccessibleJTableHeaderEntry.getForeground PASS: javax.swing.text.DefaultStyledDocument.ElementBuffer.insert New fails: FAIL: BinaryCompatibility.BinaryCompatibilityTest FAIL: java.awt.dnd.DnDTest FAIL: java.awt.dnd.DragSourceContext.Constructor FAIL: java.awt.dnd.DropTargetDragEvent.Constructors FAIL: java.awt.dnd.DropTargetDropEvent.Constructors FAIL: java.awt.image.AffineTransformOp.createCompatibleDestImage FAIL: java.awt.image.ColorConvertOp.createCompatibleDestImage FAIL: java.awt.image.ColorConvertOp.createCompatibleDestRaster FAIL: java.awt.image.ColorConvertOp.filterImage FAIL: java.awt.image.ColorConvertOp.filterRaster Totals: PASS: 2708 XPASS: 0 FAIL: 226 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: regressions for mauve-cacao on Tue Aug 22 22:07:40 UTC 2006
Baseline from: Wed Aug 2 04:27:22 UTC 2006 Regressions: FAIL: java.awt.Canvas.PaintTest FAIL: java.net.HttpURLConnection.responseCodeTest FAIL: java.net.HttpURLConnection.responseHeadersTest FAIL: java.net.ServerSocket.ServerSocketTest FAIL: java.text.DecimalFormat.parse FAIL: java.util.Vector.AcuniaVectorTest FAIL: java.util.logging.SocketHandler.publish FAIL: javax.swing.JComponent.setMaximumSize FAIL: javax.swing.JToolTip.setTipText FAIL: javax.swing.text.ElementIterator.ElementIteratorTest FAIL: org.omg.CORBA.ORB.DirectTest FAIL: org.omg.CORBA.ORB.NEC_Corporation_RF11 FAIL: org.omg.CORBA.ORB.RequestTest FAIL: org.omg.CORBA.ORB.parallelRunTest FAIL: org.omg.CORBA_2_3.ORB.ValueTypeTest FAIL: org.omg.PortableInterceptor.Interceptor.testInterceptors FAIL: org.omg.PortableServer.POAOperations.poa_POA_test Improvements: PASS: gnu.java.security.jce.TestOfSignature PASS: gnu.java.security.key.rsa.TestOfRSAKeyGeneration PASS: gnu.java.security.sig.dss.TestOfDSSSignature PASS: gnu.java.security.sig.dss.TestOfDSSSignatureCodec PASS: gnu.java.security.sig.rsa.TestOfRSAPKCS1V1_5Signature PASS: gnu.java.security.sig.rsa.TestOfRSAPSSSignature PASS: gnu.java.security.sig.rsa.TestOfRSASignatureCodec PASS: java.awt.Checkbox.PaintTest PASS: java.lang.StrictMath.sinh PASS: java.lang.reflect.AccessibleObject.security PASS: java.math.BigDecimal.divide PASS: java.math.BigDecimal.setScale PASS: java.math.BigInteger.modInverse PASS: java.net.DatagramSocket.DatagramSocketTest2 PASS: java.security.cert.pkix.pkits.ValidDSAParameterInheritenceTest5 PASS: java.security.cert.pkix.pkits.ValidDSASignaturesTest4 PASS: java.util.zip.Deflater.PR27435 PASS: javax.swing.JComboBox.ComboRobot PASS: javax.swing.JComponent.getInputMap PASS: javax.swing.JTable.TableRobot PASS: javax.swing.text.DefaultStyledDocument.ElementBuffer.insert PASS: javax.swing.text.DefaultStyledDocument.Insert New fails: FAIL: BinaryCompatibility.BinaryCompatibilityTest FAIL: java.awt.dnd.DnDTest FAIL: java.awt.dnd.DragSourceContext.Constructor FAIL: java.awt.dnd.DropTargetDragEvent.Constructors FAIL: java.awt.dnd.DropTargetDropEvent.Constructors FAIL: java.awt.image.AffineTransformOp.createCompatibleDestImage FAIL: java.awt.image.ColorConvertOp.createCompatibleDestImage FAIL: java.awt.image.ColorConvertOp.createCompatibleDestRaster FAIL: java.awt.image.ColorConvertOp.filterImage FAIL: java.awt.image.ColorConvertOp.filterRaster FAIL: java.net.HttpURLConnection.reuseConnection Totals: PASS: 2726 XPASS: 0 FAIL: 208 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
Re: Bringing License arguments to Sun
Hi Wes, On Mon, 2006-08-21 at 13:53 -0500, Wes Felter wrote: If One TCK is so important, let me propose a semi-heretical idea: don't open it. Certainly the 400 JVM developers should be able to run the TCK, but it's not clear that they need to distribute modified versions. (Of course, they could still submit bug fixes and such to the TCK maintainers.) I don't think the Linux distros need to distribute the TCK either, so their OSI or die policy doesn't appear to affect the TCK. Of course the Linux distros need it! One of the great strenghts of distributions is their ability to run the testsuite for all packages they build. And to give their users the power to repeat the build process and do their own checking of the results. It is a critical part of quality control. So when you build your deb/rpm/etc (possibly with distro specific patches) you run the testsuite and fail if some tests don't give clean results. That is how GCC for example works. There are even distros that only ship (easily buildable) source code so as to optimize any binary for your personal system. Then it is even more important that the user also gets the testsuites to make sure their special customized build on their own hardware is perfect. And it might very well be that to do that you have to adapt, modify and hack the testsuite to run and build in your particular packaging environment (and run it non-interactively). Don't forget that free software breaks down the artificial barrier between users and developers. Everybody is a core library, runtime, compiler, package, etc hacker now. So everybody should also take the responsibility and run any testsuites. Your users will demand it from you. Cheers, Mark
[commit-cp] classpath javax/swing/JComponent.java ChangeLog
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Roman Kennke rabbit78 06/08/22 13:41:26 Modified files: javax/swing: JComponent.java . : ChangeLog Log message: 2006-08-22 Roman Kennke [EMAIL PROTECTED] * javax/swing/JComponent.java (preferredSize): Removed field. (maximumSize): Removed field. (minimumSize): Removed field. (getMaximumSize): Adjusted to delegate to Component, rather then managing the size in JComponent. (getMinimumSize): Adjusted to delegate to Component, rather then managing the size in JComponent. (getPreferredSize): Adjusted to delegate to Component, rather then managing the size in JComponent. (isMaximumSizeSet): Removed. (isMinimumSizeSet): Removed. (isPreferredSizeSet): Removed. (setMaximumSize): Removed. (setMinimumSize): Removed (setPreferredSize): Removed. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/javax/swing/JComponent.java?cvsroot=classpathr1=1.143r2=1.144 http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.8441r2=1.8442
