Re: [cp-patches] RFC: Double.doubleToLongBits simplified
Dalibor Topic wrote: Hi all, I've implemented doubleToLongBits without requring a VMDouble method of the same name. It would let us remove one method from the VM interface for the next version, and the corresoponding native code. OK to commit? (I'd do the equivalent patch for Float, too). * java/lang/Double.java (doubleToLongBits): Simplified. cheers, dalibor topic Hi, if this life makes things easier for you then its a good thing. The Jikes RVM already does this at the VMDouble level, and just has a doubleAsRawLongBits magic/native method. So, I'm not sure if this change shouldn't be pushed down into VMDouble, or at least if it is done in Double the obsolete doubleToLongBits call in VMDouble should be removed. Thanks, Ian
Re: [cp-patches] RFC: Double.doubleToLongBits simplified
Ian Rogers schrieb: Dalibor Topic wrote: Hi all, I've implemented doubleToLongBits without requring a VMDouble method of the same name. It would let us remove one method from the VM interface for the next version, and the corresoponding native code. OK to commit? (I'd do the equivalent patch for Float, too). * java/lang/Double.java (doubleToLongBits): Simplified. cheers, dalibor topic Hi, if this life makes things easier for you then its a good thing. The Jikes RVM already does this at the VMDouble level, and just has a doubleAsRawLongBits magic/native method. So, I'm not sure if this change shouldn't be pushed down into VMDouble, or at least if it is done in Double the obsolete doubleToLongBits call in VMDouble should be removed. Yeah, I'll do the latter, as there is no point in having this method in the VM interface if we can do it (and the methods its implementation invokes) in Java. Same for Float and the int conversion method. cheers, dalibor topic
Re: [cp-patches] RFC: Double.doubleToLongBits simplified
Christian Thalinger wrote: On Fri, 2008-02-08 at 12:23 +0100, Dalibor Topic wrote: Yeah, I'll do the latter, as there is no point in having this method in the VM interface if we can do it (and the methods its implementation invokes) in Java. Same for Float and the int conversion method. I completely agree. Thanks for the feedback. I've committed the patch, and will send the remaining changes FYI soon, with the native code changes RFC after that. cheers, dalibor topic
[cp-patches] FYI: announce VM interface change
Hi all, this patch completes the update to the VM interface by adding an entry into the NEWS file. cheers, dalibor topic 2008-02-08 Dalibor Topic [EMAIL PROTECTED] * NEWS: Documented removal of floatToIntBits and doubleToLongBits from VM interface. Index: NEWS === RCS file: /sources/classpath/classpath/NEWS,v retrieving revision 1.187 diff -u -r1.187 NEWS --- NEWS 16 Oct 2007 20:28:28 - 1.187 +++ NEWS 8 Feb 2008 18:39:33 - @@ -1,5 +1,9 @@ New in release 0.97 +Runtime interface changes: + +* Removed VMFloat.floatToIntBits amd VMDouble.doubleToLongBits. + New in release 0.96.1 (Oct 16, 2007) * Small compile, configure and build fixes.
[cp-patches] FYI: removed floatToIntBits from vm interface
Hi all,
as discussed in another thread, I've applied the attached patch.
cheers,
dalibor topic
2008-02-08 Dalibor Topic [EMAIL PROTECTED]
* vm/reference/java/lang/VMFloat.java (floatToIntBits): Removed
unused
method.
* native/jni/java-lang/java_lang_VMFloat.c
(Java_java_lang_VMFloat_floatToIntBits): Removed unused function.
* include/java_lang_VMDouble.h: Regenerated.
* doc/cp-vmintegration.texinfo (java.lang.VMFloat): Removed
unused method floatToIntBits. (java.lang.VMDouble): Use similar
text to text used for floatToRawIntBits for doubleToLongBits.
Index: doc/cp-vmintegration.texinfo
===
RCS file: /sources/classpath/classpath/doc/cp-vmintegration.texinfo,v
retrieving revision 1.3
diff -u -p -r1.3 cp-vmintegration.texinfo
--- doc/cp-vmintegration.texinfo 8 Feb 2008 17:42:57 - 1.3
+++ doc/cp-vmintegration.texinfo 8 Feb 2008 18:32:17 -
@@ -526,8 +526,8 @@ compiler, and is specific to the compile
of doubles.
@itemize @bullet
[EMAIL PROTECTED] @code{doubleToRawLongBits(double)} -- Same as the above, but preserves
-NaNs.
[EMAIL PROTECTED] @code{doubleToRawLongBits(double)} -- Converts the double to the IEEE 754
+bit layout, preserving NaNs.
@item @code{longBitsToDouble(long)} -- This is the inverse of the last method,
preserving NaNs so that the output of one can be fed into the other without
data loss.
@@ -550,10 +550,8 @@ implementation optional.
@code{VMFloat} provides native support for the conversion of floats.
@itemize @bullet
[EMAIL PROTECTED] @code{floatToIntBits(float)} -- Converts the float to the IEEE 754
-bit layout, collapsing NaNs to @code{0x7fc0}.
[EMAIL PROTECTED] @code{floatToRawIntBits(float)} -- Same as the above, but preserves
-NaNs.
[EMAIL PROTECTED] @code{floatToRawIntBits(float)} -- Converts the float to the IEEE 754
+bit layout, preserving NaNs.
@item @code{intBitsToFloat(int)} -- This is the inverse of the last method,
preserving NaNs so that the output of one can be fed into the other without
data loss.
Index: include/java_lang_VMFloat.h
===
RCS file: /sources/classpath/classpath/include/java_lang_VMFloat.h,v
retrieving revision 1.2
diff -u -p -r1.2 java_lang_VMFloat.h
--- include/java_lang_VMFloat.h 28 May 2004 17:27:55 - 1.2
+++ include/java_lang_VMFloat.h 8 Feb 2008 18:32:17 -
@@ -1,16 +1,15 @@
/* DO NOT EDIT THIS FILE - it is machine generated */
+#include jni.h
+
#ifndef __java_lang_VMFloat__
#define __java_lang_VMFloat__
-#include jni.h
-
#ifdef __cplusplus
extern C
{
#endif
-JNIEXPORT jint JNICALL Java_java_lang_VMFloat_floatToIntBits (JNIEnv *env, jclass, jfloat);
JNIEXPORT jint JNICALL Java_java_lang_VMFloat_floatToRawIntBits (JNIEnv *env, jclass, jfloat);
JNIEXPORT jfloat JNICALL Java_java_lang_VMFloat_intBitsToFloat (JNIEnv *env, jclass, jint);
Index: native/jni/java-lang/java_lang_VMFloat.c
===
RCS file: /sources/classpath/classpath/native/jni/java-lang/java_lang_VMFloat.c,v
retrieving revision 1.8
diff -u -p -r1.8 java_lang_VMFloat.c
--- native/jni/java-lang/java_lang_VMFloat.c 2 Jul 2005 20:32:55 - 1.8
+++ native/jni/java-lang/java_lang_VMFloat.c 8 Feb 2008 18:32:18 -
@@ -42,28 +42,6 @@ exception statement from your version. *
/*
* Class: java_lang_VMFloat
- * Method:floatToIntBits
- * Signature: (F)I
- */
-JNIEXPORT jint JNICALL
-Java_java_lang_VMFloat_floatToIntBits
- (JNIEnv * env __attribute__ ((__unused__)),
- jclass cls __attribute__ ((__unused__)), jfloat value)
-{
- jvalue u;
- jint e, f;
- u.f = value;
- e = u.i 0x7f80;
- f = u.i 0x007f;
-
- if (e == 0x7f80 f != 0)
-u.i = 0x7fc0;
-
- return u.i;
-}
-
-/*
- * Class: java_lang_VMFloat
* Method:floatToRawIntBits
* Signature: (F)I
*/
Index: vm/reference/java/lang/VMFloat.java
===
RCS file: /sources/classpath/classpath/vm/reference/java/lang/VMFloat.java,v
retrieving revision 1.3
diff -u -p -r1.3 VMFloat.java
--- vm/reference/java/lang/VMFloat.java 11 May 2007 08:07:46 - 1.3
+++ vm/reference/java/lang/VMFloat.java 8 Feb 2008 18:32:18 -
@@ -67,21 +67,6 @@ final class VMFloat
* Convert the float to the IEEE 754 floating-point single format bit
* layout. Bit 31 (the most significant) is the sign bit, bits 30-23
* (masked by 0x7f80) represent the exponent, and bits 22-0
- * (masked by 0x007f) are the mantissa. This function collapses all
- * versions of NaN to 0x7fc0. The result of this function can be used
- * as the argument to codeFloat.intBitsToFloat(int)/code to obtain the
- * original codefloat/code value.
- *
- * @param value the codefloat/code to convert
- * @return the bits of the codefloat/code
- * @see #intBitsToFloat(int)
-
[cp-patches] RFC: remove generated headers from include
I'm going to commit this patch if ok. Thanks, Mario 2008-02-08 Mario Torre [EMAIL PROTECTED] * configure.ac: --enable-regen-header option now enabled by default. * include/gnu_java_awt_dnd_peer_gtk_GtkDragSourceContextPeer.h: Removed. * include/gnu_java_awt_peer_gtk_CairoGraphics2D.h: Removed. * include/gnu_java_awt_peer_gtk_CairoSurface.h: Removed. * include/gnu_java_awt_peer_gtk_ComponentGraphics.h: Removed. * include/gnu_java_awt_peer_gtk_ComponentGraphicsCopy.h: Removed. * include/gnu_java_awt_peer_gtk_FreetypeGlyphVector.h: Removed. * include/gnu_java_awt_peer_gtk_GdkFontPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.h: Removed. * include/gnu_java_awt_peer_gtk_GdkPixbufDecoder.h: Removed. * include/gnu_java_awt_peer_gtk_GdkRobotPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GdkScreenGraphicsDevice.h: Removed. * include/gnu_java_awt_peer_gtk_GtkButtonPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkCanvasPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkCheckboxMenuItemPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkCheckboxPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkChoicePeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkClipboard.h: Removed. * include/gnu_java_awt_peer_gtk_GtkComponentPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkFileDialogPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkFramePeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkGenericPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkImage.h: Removed. * include/gnu_java_awt_peer_gtk_GtkLabelPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkListPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuBarPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuComponentPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuItemPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkPanelPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkPopupMenuPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkScrollbarPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkScrollPanePeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkSelection.h: Removed. * include/gnu_java_awt_peer_gtk_GtkTextAreaPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkTextFieldPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkToolkit.h: Removed. * include/gnu_java_awt_peer_gtk_GtkVolatileImage.h: Removed. * include/gnu_java_awt_peer_gtk_GtkWindowPeer.h: Removed. * include/gnu_java_awt_peer_qt_MainQtThread.h: Removed. * include/gnu_java_awt_peer_qt_QMatrix.h: Removed. * include/gnu_java_awt_peer_qt_QPainterPath.h: Removed. * include/gnu_java_awt_peer_qt_QPen.h: Removed. * include/gnu_java_awt_peer_qt_QtAudioClip.h: Removed. * include/gnu_java_awt_peer_qt_QtButtonPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtCanvasPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtCheckboxPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtChoicePeer.h: Removed. * include/gnu_java_awt_peer_qt_QtComponentPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtDialogPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtEmbeddedWindowPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtFileDialogPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtFontMetrics.h: Removed. * include/gnu_java_awt_peer_qt_QtFontPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtFramePeer.h: Removed. * include/gnu_java_awt_peer_qt_QtGraphics.h: Removed. * include/gnu_java_awt_peer_qt_QtImage.h: Removed. * include/gnu_java_awt_peer_qt_QtLabelPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtListPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuBarPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuComponentPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuItemPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtPanelPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtPopupMenuPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtScreenDevice.h: Removed. * include/gnu_java_awt_peer_qt_QtScrollbarPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtScrollPanePeer.h: Removed. * include/gnu_java_awt_peer_qt_QtTextAreaPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtTextFieldPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtToolkit.h: Removed. * include/gnu_java_awt_peer_qt_QtVolatileImage.h: Removed. *
[cp-patches] FYI: simplified floatToIntBits
Hi all,
as discussed in a previous thread, I've committed the attached patch.
cheers,
dalibor topic
* java/lang/Float.java (floatToIntBits): Simplified.
### Eclipse Workspace Patch 1.0
#P classpath
Index: java/lang/Float.java
===
RCS file: /sources/classpath/classpath/java/lang/Float.java,v
retrieving revision 1.37
diff -u -r1.37 Float.java
--- java/lang/Float.java 12 Oct 2007 08:50:50 - 1.37
+++ java/lang/Float.java 8 Feb 2008 18:14:58 -
@@ -526,7 +526,10 @@
*/
public static int floatToIntBits(float value)
{
-return VMFloat.floatToIntBits(value);
+if (isNaN(value))
+ return 0x7fc0;
+else
+ return VMFloat.floatToRawIntBits(value);
}
/**
Re: [cp-patches] RFC: remove generated headers from include
Mario Torre schrieb: I'm going to commit this patch if ok. Thanks, Mario 2008-02-08 Mario Torre [EMAIL PROTECTED] * configure.ac: --enable-regen-header option now enabled by default. * include/gnu_java_awt_dnd_peer_gtk_GtkDragSourceContextPeer.h: Removed. * include/gnu_java_awt_peer_gtk_CairoGraphics2D.h: Removed. * include/gnu_java_awt_peer_gtk_CairoSurface.h: Removed. * include/gnu_java_awt_peer_gtk_ComponentGraphics.h: Removed. * include/gnu_java_awt_peer_gtk_ComponentGraphicsCopy.h: Removed. * include/gnu_java_awt_peer_gtk_FreetypeGlyphVector.h: Removed. * include/gnu_java_awt_peer_gtk_GdkFontPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.h: Removed. * include/gnu_java_awt_peer_gtk_GdkPixbufDecoder.h: Removed. * include/gnu_java_awt_peer_gtk_GdkRobotPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GdkScreenGraphicsDevice.h: Removed. * include/gnu_java_awt_peer_gtk_GtkButtonPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkCanvasPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkCheckboxMenuItemPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkCheckboxPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkChoicePeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkClipboard.h: Removed. * include/gnu_java_awt_peer_gtk_GtkComponentPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkEmbeddedWindowPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkFileDialogPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkFramePeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkGenericPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkImage.h: Removed. * include/gnu_java_awt_peer_gtk_GtkLabelPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkListPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuBarPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuComponentPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuItemPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkMenuPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkPanelPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkPopupMenuPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkScrollbarPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkScrollPanePeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkSelection.h: Removed. * include/gnu_java_awt_peer_gtk_GtkTextAreaPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkTextFieldPeer.h: Removed. * include/gnu_java_awt_peer_gtk_GtkToolkit.h: Removed. * include/gnu_java_awt_peer_gtk_GtkVolatileImage.h: Removed. * include/gnu_java_awt_peer_gtk_GtkWindowPeer.h: Removed. * include/gnu_java_awt_peer_qt_MainQtThread.h: Removed. * include/gnu_java_awt_peer_qt_QMatrix.h: Removed. * include/gnu_java_awt_peer_qt_QPainterPath.h: Removed. * include/gnu_java_awt_peer_qt_QPen.h: Removed. * include/gnu_java_awt_peer_qt_QtAudioClip.h: Removed. * include/gnu_java_awt_peer_qt_QtButtonPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtCanvasPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtCheckboxPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtChoicePeer.h: Removed. * include/gnu_java_awt_peer_qt_QtComponentPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtDialogPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtEmbeddedWindowPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtFileDialogPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtFontMetrics.h: Removed. * include/gnu_java_awt_peer_qt_QtFontPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtFramePeer.h: Removed. * include/gnu_java_awt_peer_qt_QtGraphics.h: Removed. * include/gnu_java_awt_peer_qt_QtImage.h: Removed. * include/gnu_java_awt_peer_qt_QtLabelPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtListPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuBarPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuComponentPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuItemPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtMenuPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtPanelPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtPopupMenuPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtScreenDevice.h: Removed. * include/gnu_java_awt_peer_qt_QtScrollbarPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtScrollPanePeer.h: Removed. * include/gnu_java_awt_peer_qt_QtTextAreaPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtTextFieldPeer.h: Removed. * include/gnu_java_awt_peer_qt_QtToolkit.h: Removed. * include/gnu_java_awt_peer_qt_QtVolatileImage.h: Removed. *
Re: [cp-patches] RFC: remove generated headers from include
Il giorno ven, 08/02/2008 alle 21.48 +0100, Dalibor Topic ha scritto: Mario Torre schrieb: I'm going to commit this patch if ok. Sounds good as a first step, I'll check in a patch to include/Makefile.am etc. later to make sure the headers are generated in the build dir, and that distcheck passes. Committend, thanks, Mario -- Lima Software - http://www.limasoftware.net/ GNU Classpath Developer - http://www.classpath.org/ Fedora Ambassador - http://fedoraproject.org/wiki/MarioTorre Jabber: [EMAIL PROTECTED] pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa è una parte del messaggio firmata digitalmente
Re: [cp-patches] FYI: GTK peers fixlet
I just realized that I committed some other stuff that I was
experimenting with. This patch reverts this. You haven't seen
anything ;-) This has to be cleaned up and committed later.
2008-02-08 Roman Kennke [EMAIL PROTECTED]
* gnu/java/awt/peer/gtk/GtkComponentPeer.java,
* gnu/java/awt/peer/gtk/GtkToolkit.java: Removed mistakenly
committed code.
/Roman
Am Freitag, den 08.02.2008, 23:22 +0100 schrieb Roman Kennke:
This changes the System.loadLibrary() calls in the GTK peers, so that
they are only called when configured so. This is important for VMs that
can't or don't want to link dynamically, e.g. when creating full static
linked binaries like Jamaica.
2008-02-08 Roman Kennke [EMAIL PROTECTED]
* gnu/java/awt/peer/gtk/CairoGraphics2D.java,
* gnu/java/awt/peer/gtk/GdkFontPeer.java,
* gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java,
* gnu/java/awt/peer/gtk/GdkPixbufDecoder.java,
* gnu/java/awt/peer/gtk/GdkScreenGraphicsDevice.java,
* gnu/java/awt/peer/gtk/GtkComponentPeer.java,
* gnu/java/awt/peer/gtk/GtkToolkit.java: Only call
System.loadLibrary() when configured so.
/Roman
--
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com * Tel: +49-721-663 968-0
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt
Index: gnu/java/awt/peer/gtk/GtkComponentPeer.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GtkComponentPeer.java,v
retrieving revision 1.131
diff -u -1 -0 -r1.131 GtkComponentPeer.java
--- gnu/java/awt/peer/gtk/GtkComponentPeer.java 8 Feb 2008 22:17:40 - 1.131
+++ gnu/java/awt/peer/gtk/GtkComponentPeer.java 8 Feb 2008 22:23:09 -
@@ -73,22 +73,20 @@
import java.awt.image.ImageObserver;
import java.awt.image.ImageProducer;
import java.awt.image.VolatileImage;
import java.awt.peer.ComponentPeer;
import java.awt.peer.ContainerPeer;
import java.awt.peer.LightweightPeer;
import java.awt.peer.WindowPeer;
import java.util.Timer;
import java.util.TimerTask;
-import sun.java2d.pipe.Region;
-
public class GtkComponentPeer extends GtkGenericPeer
implements ComponentPeer
{
VolatileImage backBuffer;
BufferCapabilities caps;
Component awtComponent;
Insets insets;
@@ -913,15 +911,11 @@
public boolean requestFocus(Component lightweightChild, boolean temporary,
boolean focusedWindowChangeAllowed,
long time, sun.awt.CausedFocusEvent.Cause cause)
{
// TODO: Implement this properly and remove the other requestFocus()
// methods.
return true;
}
- public void applyShape(Region shape)
- {
-// TODO: Implement properly.
- }
}
Index: gnu/java/awt/peer/gtk/GtkToolkit.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GtkToolkit.java,v
retrieving revision 1.105
diff -u -1 -0 -r1.105 GtkToolkit.java
--- gnu/java/awt/peer/gtk/GtkToolkit.java 8 Feb 2008 22:17:40 - 1.105
+++ gnu/java/awt/peer/gtk/GtkToolkit.java 8 Feb 2008 22:23:09 -
@@ -60,21 +60,20 @@
import java.awt.Dimension;
import java.awt.EventQueue;
import java.awt.FileDialog;
import java.awt.Font;
import java.awt.FontMetrics;
import java.awt.Frame;
import java.awt.GraphicsDevice;
import java.awt.GraphicsEnvironment;
import java.awt.HeadlessException;
import java.awt.Image;
-import java.awt.KeyboardFocusManager;
import java.awt.Label;
import java.awt.List;
import java.awt.Menu;
import java.awt.MenuBar;
import java.awt.MenuItem;
import java.awt.Panel;
import java.awt.Point;
import java.awt.PopupMenu;
import java.awt.PrintJob;
import java.awt.Rectangle;
@@ -98,21 +97,20 @@
import java.awt.image.ImageProducer;
import java.awt.peer.ButtonPeer;
import java.awt.peer.CanvasPeer;
import java.awt.peer.CheckboxMenuItemPeer;
import java.awt.peer.CheckboxPeer;
import java.awt.peer.ChoicePeer;
import java.awt.peer.DialogPeer;
import java.awt.peer.FileDialogPeer;
import java.awt.peer.FontPeer;
import java.awt.peer.FramePeer;
-import java.awt.peer.KeyboardFocusManagerPeer;
import java.awt.peer.LabelPeer;
import java.awt.peer.ListPeer;
import java.awt.peer.MenuBarPeer;
import java.awt.peer.MenuItemPeer;
import java.awt.peer.MenuPeer;
import java.awt.peer.MouseInfoPeer;
import java.awt.peer.PanelPeer;
import java.awt.peer.PopupMenuPeer;
import java.awt.peer.RobotPeer;
import java.awt.peer.ScrollPanePeer;
@@ -122,31 +120,28 @@
import java.awt.peer.WindowPeer;
import java.io.InputStream;
import java.net.URL;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Properties;
import
Re: [cp-patches] RFC: Double.doubleToLongBits simplified
On Fri, 2008-02-08 at 12:23 +0100, Dalibor Topic wrote: Yeah, I'll do the latter, as there is no point in having this method in the VM interface if we can do it (and the methods its implementation invokes) in Java. Same for Float and the int conversion method. I completely agree. - twisti
[cp-patches] FYI: GTK peers fixlet
This changes the System.loadLibrary() calls in the GTK peers, so that
they are only called when configured so. This is important for VMs that
can't or don't want to link dynamically, e.g. when creating full static
linked binaries like Jamaica.
2008-02-08 Roman Kennke [EMAIL PROTECTED]
* gnu/java/awt/peer/gtk/CairoGraphics2D.java,
* gnu/java/awt/peer/gtk/GdkFontPeer.java,
* gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java,
* gnu/java/awt/peer/gtk/GdkPixbufDecoder.java,
* gnu/java/awt/peer/gtk/GdkScreenGraphicsDevice.java,
* gnu/java/awt/peer/gtk/GtkComponentPeer.java,
* gnu/java/awt/peer/gtk/GtkToolkit.java: Only call
System.loadLibrary() when configured so.
/Roman
--
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com * Tel: +49-721-663 968-0
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt
Index: gnu/java/awt/peer/gtk/CairoGraphics2D.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/CairoGraphics2D.java,v
retrieving revision 1.72
retrieving revision 1.73
diff -u -1 -0 -r1.72 -r1.73
--- gnu/java/awt/peer/gtk/CairoGraphics2D.java 9 Jan 2008 20:42:37 - 1.72
+++ gnu/java/awt/peer/gtk/CairoGraphics2D.java 8 Feb 2008 22:17:39 - 1.73
@@ -31,20 +31,22 @@
independent module, the terms and conditions of the license of that
module. An independent module is a module which is not derived from
or based on this library. If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so. If you do not wish to do so, delete this
exception statement from your version. */
package gnu.java.awt.peer.gtk;
+import gnu.classpath.Configuration;
+
import gnu.java.awt.ClasspathToolkit;
import java.awt.AWTPermission;
import java.awt.AlphaComposite;
import java.awt.BasicStroke;
import java.awt.Color;
import java.awt.Composite;
import java.awt.CompositeContext;
import java.awt.Font;
import java.awt.FontMetrics;
@@ -113,21 +115,24 @@
* Also, dispose() must be overloaded to free any native datastructures
* used by subclass and in addition call super.dispose() to free the
* native cairographics2d structure and cairo_t.
*
* @author Sven de Marothy
*/
public abstract class CairoGraphics2D extends Graphics2D
{
static
{
-System.loadLibrary(gtkpeer);
+if (Configuration.INIT_LOAD_LIBRARY)
+ {
+System.loadLibrary(gtkpeer);
+ }
}
/**
* Important: This is a pointer to the native cairographics2d structure
*
* DO NOT CHANGE WITHOUT CHANGING NATIVE CODE.
*/
long nativePointer;
// Drawing state variables
Index: gnu/java/awt/peer/gtk/GdkFontPeer.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GdkFontPeer.java,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -1 -0 -r1.25 -r1.26
--- gnu/java/awt/peer/gtk/GdkFontPeer.java 25 Jun 2007 11:25:51 - 1.25
+++ gnu/java/awt/peer/gtk/GdkFontPeer.java 8 Feb 2008 22:17:40 - 1.26
@@ -31,20 +31,21 @@
independent module, the terms and conditions of the license of that
module. An independent module is a module which is not derived from
or based on this library. If you modify this library, you may extend
this exception to your version of the library, but you are not
obligated to do so. If you do not wish to do so, delete this
exception statement from your version. */
package gnu.java.awt.peer.gtk;
+import gnu.classpath.Configuration;
import gnu.classpath.Pointer;
import gnu.java.awt.ClasspathToolkit;
import gnu.java.awt.peer.ClasspathFontPeer;
import gnu.java.awt.font.opentype.NameDecoder;
import java.awt.Font;
import java.awt.FontMetrics;
import java.awt.Toolkit;
import java.awt.font.FontRenderContext;
@@ -159,21 +160,24 @@
float maxDescent;
float maxAdvance;
float height;
float underlineOffset;
float underlineThickness;
GdkFontMetrics metrics;
static
{
-System.loadLibrary(gtkpeer);
+if (Configuration.INIT_LOAD_LIBRARY)
+ {
+System.loadLibrary(gtkpeer);
+ }
initStaticState ();
}
private ByteBuffer nameTable = null;
/**
* The pointer to the native font data.
*
Index: gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java
===
RCS file: /cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -1 -0 -r1.18 -r1.19
--- gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java 27 Nov 2007 22:06:58 - 1.18
+++ gnu/java/awt/peer/gtk/GdkGraphicsEnvironment.java
[cp-patches] FYI: removed VMDouble.doubleToLongBits from vm interface
Hi all,
as discussed on the list, I've removed the method.
cheers,
dalibor topic
2008-02-08 Dalibor Topic [EMAIL PROTECTED]
* m4/acinclude.m4 (CLASSPATH_CHECK_JAVAH) [USER_JAVAH]: Check
for gjavah-4.2
and gjavah-4.1.
2008-02-08 Dalibor Topic [EMAIL PROTECTED]
* vm/reference/java/lang/VMDouble.java (doubleToLongBits): Removed
unused method.
* native/jni/java-lang/java_lang_VMDouble.c
(Java_java_lang_VMDouble_doubleToLongBits):
Removed unused function.
* include/java_lang_VMDouble.h: Regenerated.
* doc/cp-vmintegration.texinfo (java.lang.VMDouble): Removed
unused method doubleToLongBits.
Index: doc/cp-vmintegration.texinfo
===
RCS file: /sources/classpath/classpath/doc/cp-vmintegration.texinfo,v
retrieving revision 1.2
diff -u -p -r1.2 cp-vmintegration.texinfo
--- doc/cp-vmintegration.texinfo 19 Feb 2007 14:42:46 - 1.2
+++ doc/cp-vmintegration.texinfo 8 Feb 2008 17:39:49 -
@@ -526,8 +526,6 @@ compiler, and is specific to the compile
of doubles.
@itemize @bullet
[EMAIL PROTECTED] @code{doubleToLongBits(double)} -- Converts the double to the IEEE 754
-bit layout, collapsing NaNs to @code{0x7ff8L}.
@item @code{doubleToRawLongBits(double)} -- Same as the above, but preserves
NaNs.
@item @code{longBitsToDouble(long)} -- This is the inverse of the last method,
Index: include/java_lang_VMDouble.h
===
RCS file: /sources/classpath/classpath/include/java_lang_VMDouble.h,v
retrieving revision 1.3
diff -u -p -r1.3 java_lang_VMDouble.h
--- include/java_lang_VMDouble.h 16 Apr 2005 09:19:54 - 1.3
+++ include/java_lang_VMDouble.h 8 Feb 2008 17:39:50 -
@@ -1,16 +1,15 @@
/* DO NOT EDIT THIS FILE - it is machine generated */
+#include jni.h
+
#ifndef __java_lang_VMDouble__
#define __java_lang_VMDouble__
-#include jni.h
-
#ifdef __cplusplus
extern C
{
#endif
-JNIEXPORT jlong JNICALL Java_java_lang_VMDouble_doubleToLongBits (JNIEnv *env, jclass, jdouble);
JNIEXPORT jlong JNICALL Java_java_lang_VMDouble_doubleToRawLongBits (JNIEnv *env, jclass, jdouble);
JNIEXPORT jdouble JNICALL Java_java_lang_VMDouble_longBitsToDouble (JNIEnv *env, jclass, jlong);
JNIEXPORT jstring JNICALL Java_java_lang_VMDouble_toString (JNIEnv *env, jclass, jdouble, jboolean);
Index: m4/acinclude.m4
===
RCS file: /sources/classpath/classpath/m4/acinclude.m4,v
retrieving revision 1.27
diff -u -p -r1.27 acinclude.m4
--- m4/acinclude.m4 14 Jan 2008 14:36:34 - 1.27
+++ m4/acinclude.m4 8 Feb 2008 17:39:50 -
@@ -221,7 +221,7 @@ AC_DEFUN([CLASSPATH_CHECK_JAVAH],
AC_PATH_PROG(USER_JAVAH, $1)
fi
else
-AC_PATH_PROGS([USER_JAVAH],[gjavah gcjh-wrapper-4.1 gcjh-4.1 gcjh javah])
+AC_PATH_PROGS([USER_JAVAH],[gjavah gjavah-4.2 gjavah-4.1 gcjh-wrapper-4.1 gcjh-4.1 gcjh javah])
fi
if test x${USER_JAVAH} = x; then
Index: native/jni/java-lang/java_lang_VMDouble.c
===
RCS file: /sources/classpath/classpath/native/jni/java-lang/java_lang_VMDouble.c,v
retrieving revision 1.18
diff -u -p -r1.18 java_lang_VMDouble.c
--- native/jni/java-lang/java_lang_VMDouble.c 11 Jan 2008 22:14:31 - 1.18
+++ native/jni/java-lang/java_lang_VMDouble.c 8 Feb 2008 17:39:50 -
@@ -112,16 +112,15 @@ Java_java_lang_VMDouble_initIDs (JNIEnv
/*
* Class: java_lang_VMDouble
- * Method:doubleToLongBits
+ * Method:doubleToRawLongBits
* Signature: (D)J
*/
JNIEXPORT jlong JNICALL
-Java_java_lang_VMDouble_doubleToLongBits
+Java_java_lang_VMDouble_doubleToRawLongBits
(JNIEnv * env __attribute__ ((__unused__)),
jclass cls __attribute__ ((__unused__)), jdouble doubleValue)
{
jvalue val;
- jlong e, f;
val.d = doubleValue;
@@ -135,33 +134,6 @@ Java_java_lang_VMDouble_doubleToLongBits
val.j = SWAP_DOUBLE(val.j);
#endif
- e = val.j 0x7ff0LL;
- f = val.j 0x000fLL;
-
- if (e == 0x7ff0LL f != 0L)
-val.j = 0x7ff8LL;
-
- return val.j;
-}
-
-/*
- * Class: java_lang_VMDouble
- * Method:doubleToRawLongBits
- * Signature: (D)J
- */
-JNIEXPORT jlong JNICALL
-Java_java_lang_VMDouble_doubleToRawLongBits
- (JNIEnv * env __attribute__ ((__unused__)),
- jclass cls __attribute__ ((__unused__)), jdouble doubleValue)
-{
- jvalue val;
-
- val.d = doubleValue;
-
-#if defined(__IEEE_BYTES_LITTLE_ENDIAN)
- val.j = SWAP_DOUBLE(val.j);
-#endif
-
return val.j;
}
Index: vm/reference/java/lang/VMDouble.java
===
RCS file: /sources/classpath/classpath/vm/reference/java/lang/VMDouble.java,v
retrieving revision 1.3
diff -u -p -r1.3 VMDouble.java
--- vm/reference/java/lang/VMDouble.java 2 Jul 2005 20:33:08 - 1.3
+++
[cp-patches] FYI: Some cleanups of configure and cvsignore
Hi, One of the artifacts of a configure check was left behind if the compiler test succeeded, this patch removes it. Also since all JNI headers are now generated they should be listed in cvsignore. 2008-02-08 Mark Wielaard [EMAIL PROTECTED] * m4/acinclude.m4 (CLASSPATH_CHECK_JAVAC): Delete Colour.class. * include/.cvsignore: Add java_* and gnu_*.h. Committed, Mark Index: m4/acinclude.m4 === RCS file: /cvsroot/classpath/classpath/m4/acinclude.m4,v retrieving revision 1.28 diff -u -r1.28 acinclude.m4 --- m4/acinclude.m4 8 Feb 2008 17:42:57 - 1.28 +++ m4/acinclude.m4 8 Feb 2008 23:25:09 - @@ -478,5 +478,5 @@ else AC_MSG_RESULT([javac doesn't support -J]) fi - rm -f Colour.java + rm -f Colour.java Colour.class ]) Index: include/.cvsignore === RCS file: /cvsroot/classpath/classpath/include/.cvsignore,v retrieving revision 1.8 diff -u -r1.8 .cvsignore --- include/.cvsignore 5 Jan 2006 00:56:41 - 1.8 +++ include/.cvsignore 8 Feb 2008 23:25:09 - @@ -7,3 +7,5 @@ jni_md.h stamp-h1 config-int.h +java_*.h +gnu_*.h
[cp-testresults] FAIL: regressions for mauve-cacao on Fri Feb 8 15:32:18 UTC 2008
Baseline from: Mon Oct 8 10:51:02 UTC 2007 Regressions: FAIL: gnu.javax.crypto.key.srp6.TestOfSRPKeyGeneration FAIL: gnu.javax.swing.text.html.parser.support.Parser.ParserEntityResolverTest FAIL: java.awt.Canvas.PaintTest FAIL: java.awt.Choice.PaintTest FAIL: java.awt.Label.PaintTest FAIL: java.awt.Robot.mouseMove FAIL: java.awt.TextField.PaintTest FAIL: java.awt.Window.pack1 FAIL: java.net.URI.ComparisonTest FAIL: javax.swing.JFrame.HeavyweightComponent FAIL: javax.swing.text.DefaultStyledDocument.ElementBuffer.insert Improvements: PASS: java.awt.ScrollPane.ScrollbarPaintTest PASS: java.awt.Scrollbar.ScrollbarPaintTest PASS: java.awt.TextArea.ScrollbarPaintTest PASS: java.awt.dnd.DragGestureRecognizer.resetRecognizer PASS: javax.swing.JTree.getCellRenderer PASS: javax.swing.JTree.setModel PASS: javax.swing.tree.VariableHeightLayoutCache.getBounds New fails: Totals: PASS: 2951 XPASS: 0 FAIL: 195 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: regressions for mauve-jamvm on Fri Feb 8 15:01:41 UTC 2008
Baseline from: Mon Oct 15 17:10:29 UTC 2007 Regressions: FAIL: gnu.javax.swing.text.html.parser.support.Parser.ParserEntityResolverTest FAIL: java.awt.Canvas.PaintTest FAIL: java.awt.Label.PaintTest FAIL: java.awt.Robot.mouseMove FAIL: java.awt.TextField.PaintTest FAIL: java.net.URI.ComparisonTest FAIL: javax.swing.JFrame.HeavyweightComponent FAIL: javax.swing.text.DefaultStyledDocument.ElementBuffer.insert Improvements: PASS: java.awt.ScrollPane.ScrollbarPaintTest PASS: java.awt.Scrollbar.ScrollbarPaintTest PASS: java.awt.TextArea.ScrollbarPaintTest New fails: Totals: PASS: 2937 XPASS: 0 FAIL: 189 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: classpath build with ecj on Fri Feb 8 22:25:01 UTC 2008
The static field ConcurrentSkipListMapK,V.LT should be accessed in a static way -- 35. WARNING in ../../classpath/external/jsr166/java/util/concurrent/ConcurrentSkipListMap.java (at line 2930) return getNearEntry(key, (m.LT|m.EQ)); ^^ The static field ConcurrentSkipListMapK,V.EQ should be accessed in a static way -- 36. WARNING in ../../classpath/external/jsr166/java/util/concurrent/ConcurrentSkipListMap.java (at line 2934) return getNearKey(key, (m.LT|m.EQ)); ^^ The static field ConcurrentSkipListMapK,V.LT should be accessed in a static way -- 37. WARNING in ../../classpath/external/jsr166/java/util/concurrent/ConcurrentSkipListMap.java (at line 2934) return getNearKey(key, (m.LT|m.EQ)); ^^ The static field ConcurrentSkipListMapK,V.EQ should be accessed in a static way -- 38. WARNING in ../../classpath/external/jsr166/java/util/concurrent/ConcurrentSkipListMap.java (at line 2938) return getNearEntry(key, (m.GT)); ^^ The static field ConcurrentSkipListMapK,V.GT should be accessed in a static way -- 39. WARNING in ../../classpath/external/jsr166/java/util/concurrent/ConcurrentSkipListMap.java (at line 2942) return getNearKey(key, (m.GT)); ^^ The static field ConcurrentSkipListMapK,V.GT should be accessed in a static way -- 39 problems (6 errors, 33 warnings)make[1]: *** [compile-classes] Error 255 make[1]: Leaving directory `/home/cpdev/Nightly/classpath/build/lib' make: *** [all-recursive] Error 1 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: ecj built with ecj on jamvm on Fri Feb 8 22:38:07 UTC 2008
xargs: jamvm: No such file or directory ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: japi build on Fri Feb 8 22:38:09 UTC 2008
cd src jikes -d .. -classpath /home/cpdev/Nightly/classpath/install/share/classpath/glibj.zip:/usr/share/ant/lib/ant.jar: net/wuffies/japi/*.java Found 1 system error and issued 1 warning: *** Semantic Warning: I/O warning: No such file or directory while trying to open /home/cpdev/Nightly/classpath/install/share/classpath/glibj.zip. *** Semantic Error: You need to modify your classpath, sourcepath, bootclasspath, and/or extdirs setup. Jikes could not find package java.lang in: /home/cpdev/Nightly/classpath/install/share/classpath/glibj.zip /usr/share/ant/lib/ant.jar . make: *** [classes] Error 1 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: regressions for mauve-gij on Fri Feb 8 17:40:44 UTC 2008
Baseline from: Fri Feb 8 08:50:51 UTC 2008 Regressions: FAIL: javax.net.ssl.SSLEngine.TestHandshake Totals: PASS: 2896 XPASS: 0 FAIL: 249 XFAIL: 0 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: jamvm build on Fri Feb 8 22:36:13 UTC 2008
Making all in sun make[2]: Entering directory `/home/cpdev/Nightly/jamvm/build/lib/sun' Making all in reflect make[3]: Entering directory `/home/cpdev/Nightly/jamvm/build/lib/sun/reflect' Making all in annotation make[4]: Entering directory `/home/cpdev/Nightly/jamvm/build/lib/sun/reflect/annotation' make[4]: Nothing to be done for `all'. make[4]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib/sun/reflect/annotation' make[4]: Entering directory `/home/cpdev/Nightly/jamvm/build/lib/sun/reflect' make[4]: Nothing to be done for `all-am'. make[4]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib/sun/reflect' make[3]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib/sun/reflect' make[3]: Entering directory `/home/cpdev/Nightly/jamvm/build/lib/sun' make[3]: Nothing to be done for `all-am'. make[3]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib/sun' make[2]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib/sun' make[2]: Entering directory `/home/cpdev/Nightly/jamvm/build/lib' mkdir classes ecj -bootclasspath /home/cpdev/Nightly/classpath/install/share/classpath/glibj.zip -d classes ../../jamvm/lib/jamvm/java/lang/JarLauncher.java ../../jamvm/lib/java/lang/VMRuntime.java ../../jamvm/lib/java/lang/VMClassLoader.java ../../jamvm/lib/java/lang/VMString.java ../../jamvm/lib/java/lang/VMThread.java ../../jamvm/lib/java/lang/VMThrowable.java ../../jamvm/lib/java/lang/reflect/Constructor.java ../../jamvm/lib/java/lang/reflect/Field.java ../../jamvm/lib/java/lang/reflect/Method.java ../../jamvm/lib/java/security/VMAccessController.java ../../jamvm/lib/gnu/classpath/VMSystemProperties.java ../../jamvm/lib/sun/reflect/annotation/AnnotationInvocationHandler.java ../../jamvm/lib/gnu/classpath/VMStackWalker.java -- 1. ERROR in ../../jamvm/lib/jamvm/java/lang/JarLauncher.java (at line 1) /* ^ The type java.lang.Object cannot be resolved. It is indirectly referenced from required .class files -- 1 problem (1 error)make[2]: *** [classes.zip] Error 255 make[2]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/cpdev/Nightly/jamvm/build/lib' make: *** [all-recursive] Error 1 ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
[cp-testresults] FAIL: cacao build on Fri Feb 8 22:37:17 UTC 2008
checking whether a program can dlopen itself... yes checking whether a statically linked program can dlopen itself... no checking if libtool supports shared libraries... yes checking whether to build shared libraries... yes checking whether to build static libraries... no configure: creating libtool appending configuration tag CXX to libtool checking for ld used by g++... /usr/bin/ld checking if the linker (/usr/bin/ld) is GNU ld... yes checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes checking for g++ option to produce PIC... -fPIC checking if g++ PIC flag -fPIC works... yes checking if g++ static flag -static works... yes checking if g++ supports -c -o file.o... yes checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes checking dynamic linker characteristics... GNU/Linux ld.so checking how to hardcode library paths into programs... immediate appending configuration tag F77 to libtool checking whether to link CACAO statically... no checking wether to build annotations support... no checking where CACAO's vm.zip is installed... /home/cpdev/Nightly/cacao/install/share/cacao/vm.zip checking which Java core library to use... gnu checking where Java core library is installed... /home/cpdev/Nightly/classpath/install checking where Java core library classes are installed... /home/cpdev/Nightly/classpath/install/share/classpath/glibj.zip checking where Java core library native libraries are installed... /home/cpdev/Nightly/classpath/install/lib checking where Java core library headers are installed... /home/cpdev/Nightly/classpath/install/include checking /home/cpdev/Nightly/classpath/install/include/jni_md.h usability... no checking /home/cpdev/Nightly/classpath/install/include/jni_md.h presence... no checking for /home/cpdev/Nightly/classpath/install/include/jni_md.h... no configure: error: cannot find jni_md.h ___ Classpath-testresults mailing list Classpath-testresults@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-testresults
Re: Classpath's doubleToLongBits (was: Re: [kaffe] cross-compile error)
On Fri, 2008-02-08 at 00:26 +0100, Dalibor Topic wrote: I've looked a bit closer at the 3 ARM OABI errors, in particular at the errors in test/regression/DoubleConst.java . That test fails because we get the bitstreams of the doubles being tested when we call Double.doubleToLongbits with swapped words, i.e. instead of 0x7fef we get 0x7fef. The current GNU Classpath implementation of Java_java_lang_VMDouble_doubleToLongBits ends up swapping the words, whenever __ARMEL__ is defined. That makes the DoubleConst test fail for Cacao, Kaffe, etc. Since twisti said on IRC that he had spent a lot of time trying to get it right on his ARM systems, I didn't want to mess with the corresponding file in fdlibm. So I wrote another implementation of the function, using ieee754.h (part of glibc). Basically, it boils down to shifting the bits from the bitfields to the right places inside the jlong. Easy. Unfortunately, that didn't work on arm OABI debian sid either. It turned out that glibc has a bug in the iee754.h header file, that comes to bite one on arm OABI. Filed as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=464594 with a patch attached. Meanwhile, that still means that those 3 tests fail until glibc is fixed. So ... I'll send in a couple of patches to the classpath patches list to first rewrite the doubleToLongBits in Java (and the same for Float), removing it from the VM interface, and then, I'll send in a patch to add the ieee754.h way of dealing with fetching the bits to the current way. Does that sound useful? That sounds actually very good, if it works on all configurations. I can remember we had a lot of problems to get these functions right on an Arm system with VFP. For more problems see also: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22800 - twisti
Re: Classpath's doubleToLongBits
Christian Thalinger schrieb: On Fri, 2008-02-08 at 00:26 +0100, Dalibor Topic wrote: I've looked a bit closer at the 3 ARM OABI errors, in particular at the errors in test/regression/DoubleConst.java . That test fails because we get the bitstreams of the doubles being tested when we call Double.doubleToLongbits with swapped words, i.e. instead of 0x7fef we get 0x7fef. The current GNU Classpath implementation of Java_java_lang_VMDouble_doubleToLongBits ends up swapping the words, whenever __ARMEL__ is defined. That makes the DoubleConst test fail for Cacao, Kaffe, etc. Since twisti said on IRC that he had spent a lot of time trying to get it right on his ARM systems, I didn't want to mess with the corresponding file in fdlibm. So I wrote another implementation of the function, using ieee754.h (part of glibc). Basically, it boils down to shifting the bits from the bitfields to the right places inside the jlong. Easy. Unfortunately, that didn't work on arm OABI debian sid either. It turned out that glibc has a bug in the iee754.h header file, that comes to bite one on arm OABI. Filed as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=464594 with a patch attached. Meanwhile, that still means that those 3 tests fail until glibc is fixed. So ... I'll send in a couple of patches to the classpath patches list to first rewrite the doubleToLongBits in Java (and the same for Float), removing it from the VM interface, and then, I'll send in a patch to add the ieee754.h way of dealing with fetching the bits to the current way. Does that sound useful? That sounds actually very good, if it works on all configurations. I can remember we had a lot of problems to get these functions right on an Arm system with VFP. For more problems see also: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22800 Yeah, that's why I'd like to go step by step, and first slash the VM interface methods I can slash, and then implement it with ieee754.h as an option, (adding a #define BIG_ENDIAN __BIG_ENDIAN for the broken glibc versions). I'll make sure to post the native patches for comments first, as I don't have access to a VFP box. cheers, dalibor topic
Re: Remove the generated headers from include dir?
Mario Torre wrote: Il giorno ven, 08/02/2008 alle 18.33 +0100, Dalibor Topic ha scritto: Does that sound like a useful build system change? cheers, dalibor topic Is something I also wanted to do, if no one object, I would go. Please go for it. cheers, dalibor topic
[commit-cp] classpath ChangeLog doc/cp-vmintegration.texinf...
CVSROOT:/sources/classpath Module name:classpath Changes by: Dalibor Topic robilad 08/02/08 18:34:55 Modified files: . : ChangeLog doc: cp-vmintegration.texinfo include: java_lang_VMFloat.h native/jni/java-lang: java_lang_VMFloat.c vm/reference/java/lang: VMFloat.java Log message: 2008-02-08 Dalibor Topic [EMAIL PROTECTED] * vm/reference/java/lang/VMFloat.java (floatToIntBits): Removed unused method. * native/jni/java-lang/java_lang_VMFloat.c (Java_java_lang_VMFloat_floatToIntBits): Removed unused function. * include/java_lang_VMDouble.h: Regenerated. * doc/cp-vmintegration.texinfo (java.lang.VMFloat): Removed unused method floatToIntBits. (java.lang.VMDouble): Use similar text to text used for floatToRawIntBits for doubleToLongBits. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9485r2=1.9486 http://cvs.savannah.gnu.org/viewcvs/classpath/doc/cp-vmintegration.texinfo?cvsroot=classpathr1=1.3r2=1.4 http://cvs.savannah.gnu.org/viewcvs/classpath/include/java_lang_VMFloat.h?cvsroot=classpathr1=1.2r2=1.3 http://cvs.savannah.gnu.org/viewcvs/classpath/native/jni/java-lang/java_lang_VMFloat.c?cvsroot=classpathr1=1.8r2=1.9 http://cvs.savannah.gnu.org/viewcvs/classpath/vm/reference/java/lang/VMFloat.java?cvsroot=classpathr1=1.3r2=1.4
Remove the generated headers from include dir?
As I'm running into trouble getting gjavah / gcjh to overwrite the header files in the include dir (which seems to just work with Javah), I'd like to propose that Classpath adopts the JNI header generation model we use in Kaffe: simply always call (g/c/k)javah on the required files and drop the in the include dir in the build dir. There is little point in shipping the headers inside Classpath as now we have gjavah, gcjh, etc. in recent enough versions in the distributions. That would allow us to both simplify the build system a bit, and to remove 100+ generated header files from Classpath's CVS and tarball. Does that sound like a useful build system change? cheers, dalibor topic
[commit-cp] classpath ChangeLog NEWS
CVSROOT:/sources/classpath Module name:classpath Changes by: Dalibor Topic robilad 08/02/08 18:40:49 Modified files: . : ChangeLog NEWS Log message: 2008-02-08 Dalibor Topic [EMAIL PROTECTED] * NEWS: Documented removal of floatToIntBits and doubleToLongBits from VM interface. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9486r2=1.9487 http://cvs.savannah.gnu.org/viewcvs/classpath/NEWS?cvsroot=classpathr1=1.187r2=1.188
Re: Get ready for Fosdem - Free Java Meeting
Il giorno ven, 08/02/2008 alle 21.20 +0100, Mark Wielaard ha scritto: You only have to pay the beer yourself *) But hey, this is also share alike what do you want more? :P Mario -- Lima Software - http://www.limasoftware.net/ GNU Classpath Developer - http://www.classpath.org/ Fedora Ambassador - http://fedoraproject.org/wiki/MarioTorre Jabber: [EMAIL PROTECTED] pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa è una parte del messaggio firmata digitalmente
Get ready for Fosdem - Free Java Meeting
In just two weeks, 22 and 23 February, the Free Java Meeting will take place during Fosdem in Brussels, Belgium. There is a dynamic program with lots of (short) talks and space for discussions on the state of the various free java projects, mobile java, the VM and the Distro Rumble, the free java factory, cool stuff, freedom, compatibility, community and planning all the exciting stuff we are going to do together in the next year. So if you are interested in Debian-java, GNU Classpath, OpenJDK, JikesRVM, Fedora-java, IKVM.NET, JamVM, Jalimo, MobileEmbedded, Kaffe, Gentoo-java, IcedTea, JNode, MIDPath, FBToolkit, Brandweg, Duchess, IcePick, HotSpot, Zero, Ubuntu-java, and much, much more. Then please come and join us. More information on the program, who will be there and other activities at http://fosdem.org/2008/schedule/devroom/freejava and http://wiki.debian.org/Java/DevJam/2008/Fosdem Best of all, it is all free. You only have to pay the beer yourself *) Hope to see you all there! *) FOSDEM '08 is a free and non-commercial event organized by the community, for the community. Its goal is to provide Free Software and Open Source developers a place to meet. http://fosdem.org/
Re: Classpath's doubleToLongBits
On Fri, 2008-02-08 at 12:25 +0100, Dalibor Topic wrote: Yeah, that's why I'd like to go step by step, and first slash the VM interface methods I can slash, and then implement it with ieee754.h as an option, (adding a #define BIG_ENDIAN __BIG_ENDIAN for the broken glibc versions). I'll make sure to post the native patches for comments first, as I don't have access to a VFP box. OK, I hope I still have access to this box, but I'll try to test them. - twisti
Re: Remove the generated headers from include dir?
Il giorno ven, 08/02/2008 alle 18.33 +0100, Dalibor Topic ha scritto: Does that sound like a useful build system change? cheers, dalibor topic Is something I also wanted to do, if no one object, I would go. Cheers, Mario -- Lima Software - http://www.limasoftware.net/ GNU Classpath Developer - http://www.classpath.org/ Fedora Ambassador - http://fedoraproject.org/wiki/MarioTorre Jabber: [EMAIL PROTECTED] pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF Please, support open standards: http://opendocumentfellowship.org/petition/ http://www.nosoftwarepatents.com/ signature.asc Description: Questa è una parte del messaggio firmata digitalmente
[commit-cp] classpath ChangeLog java/lang/Double.java
CVSROOT:/sources/classpath Module name:classpath Changes by: Dalibor Topic robilad 08/02/08 16:39:31 Modified files: . : ChangeLog java/lang : Double.java Log message: 2008-02-08 Dalibor Topic [EMAIL PROTECTED] * java/lang/Double.java (doubleToLongBits): Simplified. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9482r2=1.9483 http://cvs.savannah.gnu.org/viewcvs/classpath/java/lang/Double.java?cvsroot=classpathr1=1.43r2=1.44
[commit-cp] classpath ChangeLog gnu/java/awt/peer/gtk/GtkCo...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Roman Kennke rabbit78 08/02/08 22:24:34 Modified files: . : ChangeLog gnu/java/awt/peer/gtk: GtkComponentPeer.java GtkToolkit.java Log message: 2008-02-08 Roman Kennke [EMAIL PROTECTED] * gnu/java/awt/peer/gtk/GtkComponentPeer.java, * gnu/java/awt/peer/gtk/GtkToolkit.java: Removed mistakenly committed code. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9488r2=1.9489 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/awt/peer/gtk/GtkComponentPeer.java?cvsroot=classpathr1=1.131r2=1.132 http://cvs.savannah.gnu.org/viewcvs/classpath/gnu/java/awt/peer/gtk/GtkToolkit.java?cvsroot=classpathr1=1.105r2=1.106
[commit-cp] classpath ChangeLog m4/acinclude.m4 include/.cv...
CVSROOT:/cvsroot/classpath Module name:classpath Changes by: Mark Wielaard mark08/02/08 23:26:20 Modified files: . : ChangeLog m4 : acinclude.m4 include: .cvsignore Log message: * m4/acinclude.m4 (CLASSPATH_CHECK_JAVAC): Delete Colour.class. * include/.cvsignore: Add java_* and gnu_*.h. CVSWeb URLs: http://cvs.savannah.gnu.org/viewcvs/classpath/ChangeLog?cvsroot=classpathr1=1.9490r2=1.9491 http://cvs.savannah.gnu.org/viewcvs/classpath/m4/acinclude.m4?cvsroot=classpathr1=1.28r2=1.29 http://cvs.savannah.gnu.org/viewcvs/classpath/include/.cvsignore?cvsroot=classpathr1=1.8r2=1.9
[commit-cp] classpath ChangeLog configure.ac include/gnu_ja...
CVSROOT:/sources/classpath Module name:classpath Changes by: Mario Torre neugens 08/02/08 22:26:48 Modified files: . : ChangeLog configure.ac Removed files: include: gnu_java_awt_peer_qt_QtPanelPeer.h gnu_xml_libxmlj_dom_GnomeDocumentBuilder.h gnu_java_awt_peer_qt_QtVolatileImage.h gnu_java_awt_peer_qt_MainQtThread.h gnu_java_awt_peer_gtk_CairoSurface.h gnu_java_awt_peer_qt_QtComponentPeer.h gnu_java_awt_peer_qt_QtAudioClip.h gnu_javax_sound_midi_alsa_AlsaPortDevice.h gnu_java_awt_peer_gtk_GtkToolkit.h gnu_xml_libxmlj_sax_GnomeLocator.h java_nio_VMDirectByteBuffer.h gnu_java_nio_FileChannelImpl.h java_lang_VMFloat.h gnu_java_awt_peer_gtk_CairoGraphics2D.h gnu_javax_sound_midi_alsa_AlsaMidiDeviceProvider.h gnu_java_awt_peer_gtk_GtkGenericPeer.h java_lang_VMSystem.h gnu_java_awt_peer_qt_QtTextFieldPeer.h gnu_java_util_prefs_gconf_GConfNativePeer.h gnu_java_awt_peer_gtk_GdkPixbufDecoder.h gnu_java_awt_peer_qt_QtFontMetrics.h gnu_java_awt_peer_gtk_GtkCheckboxPeer.h gnu_java_awt_dnd_peer_gtk_GtkDragSourceContextPeer.h gnu_java_nio_VMChannel.h gnu_java_awt_peer_gtk_GtkTextFieldPeer.h java_io_VMObjectStreamClass.h gnu_java_awt_peer_qt_QtEmbeddedWindowPeer.h gnu_java_nio_EpollSelectorImpl.h gnu_java_awt_peer_qt_QtGraphics.h gnu_xml_libxmlj_dom_GnomeXPathExpression.h gnu_javax_sound_sampled_gstreamer_lines_GstNativeDataLine.h gnu_java_awt_peer_gtk_GtkMenuPeer.h gnu_java_awt_peer_gtk_GtkMenuBarPeer.h gnu_java_awt_peer_qt_QtImage.h gnu_java_awt_peer_qt_QtPopupMenuPeer.h java_lang_reflect_VMArray.h java_io_VMFile.h gnu_java_nio_VMPipe.h gnu_xml_libxmlj_dom_GnomeXPathNodeList.h gnu_java_awt_peer_qt_QtMenuBarPeer.h java_net_VMURLConnection.h gnu_xml_libxmlj_dom_GnomeDocument.h gnu_xml_libxmlj_dom_GnomeAttr.h gnu_xml_libxmlj_dom_GnomeXPathResult.h gnu_xml_libxmlj_dom_GnomeEntity.h gnu_xml_libxmlj_dom_GnomeNotation.h java_net_VMNetworkInterface.h gnu_java_nio_charset_iconv_IconvDecoder.h gnu_java_awt_peer_qt_QtDialogPeer.h gnu_java_awt_peer_qt_QtToolkit.h gnu_java_awt_peer_qt_QtLabelPeer.h java_lang_VMProcess.h gnu_javax_sound_sampled_gstreamer_io_GstInputStream.h gnu_java_awt_peer_gtk_ComponentGraphicsCopy.h gnu_java_awt_peer_gtk_GtkFileDialogPeer.h gnu_java_awt_peer_gtk_GtkFramePeer.h gnu_java_awt_peer_qt_QtScrollbarPeer.h gnu_java_awt_peer_qt_QPainterPath.h gnu_java_lang_management_VMOperatingSystemMXBeanImpl.h gnu_java_awt_peer_qt_QMatrix.h gnu_java_awt_peer_gtk_GtkPanelPeer.h java_net_VMInetAddress.h gnu_java_awt_peer_qt_QtTextAreaPeer.h gnu_java_awt_peer_gtk_GtkImage.h gnu_java_awt_peer_gtk_GtkLabelPeer.h gnu_java_awt_peer_gtk_GtkCanvasPeer.h gnu_java_net_VMPlainSocketImpl.h gnu_java_awt_peer_gtk_GtkSelection.h gnu_java_awt_peer_gtk_GdkRobotPeer.h gnu_java_awt_peer_gtk_GtkTextAreaPeer.h gnu_java_awt_peer_qt_QtFileDialogPeer.h gnu_java_awt_peer_gtk_GtkScrollPanePeer.h gnu_java_awt_peer_gtk_GtkComponentPeer.h gnu_java_awt_peer_gtk_GtkListPeer.h gnu_xml_libxmlj_dom_GnomeNode.h gnu_java_awt_peer_gtk_GtkCheckboxMenuItemPeer.h
