Re: [RFC/PATCH] Invokedynamic API stubs

2011-02-09 Thread Robert Lougher
On 7 February 2011 20:01, Pekka Enberg  wrote:
> On Mon, 2011-02-07 at 15:24 +0100, Dr Andrew John Hughes wrote:
>> > I guess I could keep it on my Github mirror until I have something
>> > concrete enough to be merged to trunk.
>> >
>> I'd prefer to have it in HEAD as long as it's clearly marked as stubs
>> (the NotImplementedException I mentioned) and there is work actively
>> taking place.
>> Then there's always the (slim) possibility someone else can work on it :-)
>
> That was my original thinking as well. Does the included patch look
> better to you? Mark, what do you think about this?
>
>                        Pekka
>

In case nobody else has noticed :

"The package for JSR 292 is no longer java.dyn. It is java.lang.invoke"

http://blogs.sun.com/jrose/entry/jsr_292_formal_public_review

Rob.

> From 81362427a842e815bfe354036cd4201ee781880a Mon Sep 17 00:00:00 2001
> From: Pekka Enberg 
> Date: Thu, 3 Feb 2011 16:29:15 +0200
> Subject: [PATCH] Invokedynamic API stubs
>
> This patch implements the work-in-progress invokedynamic API stubs described
> here:
>
>  http://download.oracle.com/javase/7/docs/api/java/dyn/package-summary.html
>
> The classes don't do anything useful yet and don't even contain all the
> specified methods.
>
> Signed-off-by: Pekka Enberg 
> ---
>  java/dyn/BootstrapMethod.java             |   52 
>  java/dyn/CallSite.java                    |   60 
>  java/dyn/ClassValue.java                  |   45 +
>  java/dyn/ConstantCallSite.java            |   46 +
>  java/dyn/InvokeDynamic.java               |   49 +++
>  java/dyn/InvokeDynamicBootstrapError.java |   47 ++
>  java/dyn/Linkage.java                     |   45 +
>  java/dyn/LinkagePermission.java           |   56 ++
>  java/dyn/MethodHandle.java                |   62 
> +
>  java/dyn/MethodHandleProvider.java        |   52 
>  java/dyn/MethodHandles.java               |   52 
>  java/dyn/MethodType.java                  |   50 +++
>  java/dyn/NoAccessException.java           |   47 ++
>  java/dyn/WrongMethodTypeException.java    |   47 ++



Re: [RFC/PATCH] Invokedynamic API stubs

2011-02-09 Thread Mark Wielaard
On Tue, 2011-02-08 at 21:52 +, Dr Andrew John Hughes wrote:
> I assume by Mercurial 'branching', you mean what we do with IcedTea6 HEAD
> and the releases at present, not the in-tree support?  Because that's worse
> than CVS IME.

I don't know yet. The in-tree support was bad pre-1.0. But that was
years ago. Are you sure it is still not workable?
I'll try and figure out what savannah supports soon.

> > > This patch implements the work-in-progress invokedynamic API stubs 
> > > described
> > > here:
> > > 
> > >   
> > > http://download.oracle.com/javase/7/docs/api/java/dyn/package-summary.html
> > > 
> > > The classes don't do anything useful yet and don't even contain all the
> > > specified methods.
> > 
> > Might be better to find some other reference to point people at. This
> > screams it isn't finished yet, might move. I don't have a good
> > suggestion though. The java doc in OpenJDK is distributed under the GPL
> > though, but doesn't seem to be online yet.
> 
> Is there anything stopping us having the docs generated by IcedTea online?
> Maybe the builder could produce them?

The builder does already produce them, it just doesn't publish them
anywhere yet :) I'll look into pushing them public somewhere. Probably
to the main icedtea server.

And as Robert just pointed out John Rose has been keeping a GPL derived
version of the spec/javadoc here:
http://cr.openjdk.java.net/~jrose/pres/indy-javadoc-mlvm/

Cheers,

Mark




Re: [RFC/PATCH] Invokedynamic API stubs

2011-02-09 Thread Dr Andrew John Hughes
On 9 February 2011 14:24, Mark Wielaard  wrote:
> On Tue, 2011-02-08 at 21:52 +, Dr Andrew John Hughes wrote:
>> I assume by Mercurial 'branching', you mean what we do with IcedTea6 HEAD
>> and the releases at present, not the in-tree support?  Because that's worse
>> than CVS IME.
>
> I don't know yet. The in-tree support was bad pre-1.0. But that was
> years ago. Are you sure it is still not workable?
> I'll try and figure out what savannah supports soon.
>

No, but I don't really have time to look into it either.  Let's just
keep with what we know for now.

>> > > This patch implements the work-in-progress invokedynamic API stubs 
>> > > described
>> > > here:
>> > >
>> > >   
>> > > http://download.oracle.com/javase/7/docs/api/java/dyn/package-summary.html
>> > >
>> > > The classes don't do anything useful yet and don't even contain all the
>> > > specified methods.
>> >
>> > Might be better to find some other reference to point people at. This
>> > screams it isn't finished yet, might move. I don't have a good
>> > suggestion though. The java doc in OpenJDK is distributed under the GPL
>> > though, but doesn't seem to be online yet.
>>
>> Is there anything stopping us having the docs generated by IcedTea online?
>> Maybe the builder could produce them?
>
> The builder does already produce them, it just doesn't publish them
> anywhere yet :) I'll look into pushing them public somewhere. Probably
> to the main icedtea server.
>
> And as Robert just pointed out John Rose has been keeping a GPL derived
> version of the spec/javadoc here:
> http://cr.openjdk.java.net/~jrose/pres/indy-javadoc-mlvm/

I think we need public ones from both IcedTea 6 & 7 so we know what
they are based on.

> Cheers,
>
> Mark
>
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8