Re: Weirdness in native/jni/java-io/java_io_VMConsole.c

2012-03-29 Thread Pekka Enberg 
On Thu, Mar 29, 2012 at 12:47 PM, Andrew Haley  wrote:
> There's a very odd comment in this file: it clearly refers to some
> method in another file.  But what was it for, anyway?  Surely the
> name of a method and its signature is contained in the code.  I'd just
> delete it.
>
> /*
>  * Class:     java_io_VMConsole
>  * Method:    echo
>  * Signature: (Z)Z
>  */
> JNIEXPORT jstring JNICALL
> Java_java_io_VMConsole_readPassword (JNIEnv * env,
>                                     jclass clazz
>                                     __attribute__ ((__unused__)),
>                                     jobject con)
> {

It's a copy-paste goof by me and I'm fine with dropping it. I only
added it to follow existing style.

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Pekka Enberg 
On Thu, Mar 29, 2012 at 6:40 PM, Andrew Haley  wrote:
> zebedee:classpath $ git push ssh://git.savannah.gnu.org/cgit/classpath.git/
> fatal: '/cgit/classpath.git' does not appear to be a git repository
> fatal: The remote end hung up unexpectedly
>
> Any idea what git wants to do the push?

Git wants the remote name. For example, I have:

penberg@jaguar:~/src/classpath$ git remote -v
icedtea git://icedtea.classpath.org/mirror/git/classpath/classpath (fetch)
icedtea git://icedtea.classpath.org/mirror/git/classpath/classpath (push)
origin  g...@github.com:penberg/classpath.git (fetch)
origin  g...@github.com:penberg/classpath.git (push)
savannahssh://git.sv.gnu.org/srv/git/classpath.git (fetch)
savannahssh://git.sv.gnu.org/srv/git/classpath.git (push)

so I use

  git push savannah master

You can add a new remote with

  git remote add savannah ssh://git.sv.gnu.org/srv/git/classpath.git

HTH

Pekka

Re: [cp-patches] [commit-cp] classpath ChangeLog native/jni/java-io/java_io_...

2012-03-29 Thread Andrew Haley 
On 03/29/2012 03:52 PM, Andrew Hughes wrote:
> The CVS repository is obsolete.  Current development takes place in git:
> 
> http://git.savannah.gnu.org/cgit/classpath.git
> 
> See this thread: 
> http://developer.classpath.org/pipermail/classpath/2012-March/003181.html
> -- 

zebedee:classpath $ git push ssh://git.savannah.gnu.org/cgit/classpath.git/
fatal: '/cgit/classpath.git' does not appear to be a git repository
fatal: The remote end hung up unexpectedly

Any idea what git wants to do the push?

Andrew.

Weirdness in native/jni/java-io/java_io_VMConsole.c

2012-03-29 Thread Andrew Haley 
There's a very odd comment in this file: it clearly refers to some
method in another file.  But what was it for, anyway?  Surely the
name of a method and its signature is contained in the code.  I'd just
delete it.

/*
 * Class: java_io_VMConsole
 * Method:echo
 * Signature: (Z)Z
 */
JNIEXPORT jstring JNICALL
Java_java_io_VMConsole_readPassword (JNIEnv * env,
 jclass clazz
 __attribute__ ((__unused__)),
 jobject con)
{

Andrew.