Re: Support for installation of glibj.zip and separate class files

2004-04-10 Thread Mark Wielaard
Hi,

On Sat, 2004-04-10 at 15:46, Thomas Zander wrote:
> CVS is your friend; just type a cvs diff..
> something like:
> cvs diff -D "08 apr 2004" -D "09 apr 2004" | less
> in the root.

Yes, but then I only see what changed, not what Michael intended to
change. That is why patches should be send to the mailinglist before
committing. The patch was munged in with another nio changes in the CVS
commit.

Anyway, I talked to Michael on irc. He is working on a fix. In the
meantime you have to explicitly give --enable-glibj and/or
--enable-class-install to your configure command.

You also need to revert Jeroen his patch to FileChannelImpl.java when
you need the native JNI implementation to work again.

Cheers,

Mark


signature.asc
Description: This is a digitally signed message part
___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Re: Support for installation of glibj.zip and separate class files

2004-04-10 Thread Thomas Zander
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

CVS is your friend; just type a cvs diff..
something like:
cvs diff -D "08 apr 2004" -D "09 apr 2004" | less
in the root.

On Saturday 10 April 2004 14:40, Mark Wielaard wrote:
> Hi Michael,
>
> On Thu, 2004-04-08 at 22:36, Michael Koch wrote:
> > With my big NIO commit I accidently commited the first part (the parts
> > in configure.ac) for this patch and so I decided to commit it fully.
>
> Could you post the exact patch you committed?
> java source files aren't compiled any more and/or glibj isn't created
> correctly on my system and I am trying figure out what changed.
>
> The only ChangeLog entry I see is:
>
> 2004-04-08  Michael Koch  <[EMAIL PROTECTED]>
>
> * ChangeLog, acinclude.m4, lib/Makefile.am:
> Added support for building and installing glibj.zip and separate
> class files.
>
> Which doesn't describe at all what changes were actually made.
>
> Thanks,
>
> Mark

- -- 
Thomas
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAd/qsCojCW6H2z/QRAqXUAJ9ohapE79h2u4eE5Wq+mUtjQvV0vQCdHtJz
qO+0N3k4ltd0Wv00IJR66cU=
=8f3H
-END PGP SIGNATURE-


___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Re: Support for installation of glibj.zip and separate class files

2004-04-10 Thread Mark Wielaard
Hi Michael,

On Thu, 2004-04-08 at 22:36, Michael Koch wrote:
> With my big NIO commit I accidently commited the first part (the parts 
> in configure.ac) for this patch and so I decided to commit it fully.

Could you post the exact patch you committed?
java source files aren't compiled any more and/or glibj isn't created
correctly on my system and I am trying figure out what changed.

The only ChangeLog entry I see is:

2004-04-08  Michael Koch  <[EMAIL PROTECTED]>

* ChangeLog, acinclude.m4, lib/Makefile.am:
Added support for building and installing glibj.zip and separate
class files.

Which doesn't describe at all what changes were actually made.

Thanks,

Mark


signature.asc
Description: This is a digitally signed message part
___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Re: Support for installation of glibj.zip and separate class files

2004-04-10 Thread Michael Koch
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am Freitag, 9. April 2004 23:44 schrieb C. Brian Jones:
> On Thu, 2004-04-08 at 16:36, Michael Koch wrote:
> > Hi all,
> >
> >
> >
> > With my big NIO commit I accidently commited the first part (the
> > parts in configure.ac) for this patch and so I decided to commit
> > it fully. We now have two options for installing our classes
> >
> > --enable-glibj
> > installs glibj.zip (enabled by default)
> >
> > --enable-class-install
> > installs all classes as separate files as needed by jamvm and
> > sablevm (disabled by default)
> >
> > Both options are indepedently from each other. You can even
> > disable both options but this does not make really sense.
> >
> > I'm not really satisfied with the name "--enable-class-install".
> > If someone finds a better name please shout at me.
>
> Michael I thought this logic was already in lib/Makefile.am anyway
> without the extra config option?  Maybe that was an old version I
> was thinking about.

Yeah, and it was never really working when I tried it. Its 
implementation in lib/Makefile.am was very weird. So I decided to 
make it more easy to understand and maintain


Michael
- -- 
Homepage: http://www.worldforge.org/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAd7G6WSOgCCdjSDsRAvRuAJ4wTMuIDxAPNoqRdnFBYijl1H5glwCgm+pE
lmDNN5vYkJVd7RDfa2uxK1E=
=hsUa
-END PGP SIGNATURE-



___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Re: Support for installation of glibj.zip and separate class files

2004-04-09 Thread Robert Lougher
Brian,

I think you're thinking of --without-zip?  This option still exists, but it 
hasn't seemed to work since classpath 0.05...

Rob.

Original Message Follows
From: "C. Brian Jones" <[EMAIL PROTECTED]>
Reply-To: [EMAIL PROTECTED]
To: Michael Koch <[EMAIL PROTECTED]>
CC: [EMAIL PROTECTED]
Subject: Re: Support for installation of glibj.zip and separate class files
Date: Fri, 09 Apr 2004 17:44:34 -0400
On Thu, 2004-04-08 at 16:36, Michael Koch wrote:
> Hi all,
>
>
>
> With my big NIO commit I accidently commited the first part (the parts
> in configure.ac) for this patch and so I decided to commit it fully.
> We now have two options for installing our classes
>
> --enable-glibj
> installs glibj.zip (enabled by default)
>
> --enable-class-install
> installs all classes as separate files as needed by jamvm and sablevm
> (disabled by default)
>
> Both options are indepedently from each other. You can even disable both
> options but this does not make really sense.
>
> I'm not really satisfied with the name "--enable-class-install". If
> someone finds a better name please shout at me.
Michael I thought this logic was already in lib/Makefile.am anyway
without the extra config option?  Maybe that was an old version I was
thinking about.
Brian
<< signature.asc >>
___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath
_
Find a cheaper internet access deal - choose one to suit you. 
http://www.msn.co.uk/internetaccess



___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Re: Support for installation of glibj.zip and separate class files

2004-04-09 Thread C. Brian Jones
On Thu, 2004-04-08 at 16:36, Michael Koch wrote:
> Hi all, 
> 
> 
> 
> With my big NIO commit I accidently commited the first part (the parts 
> in configure.ac) for this patch and so I decided to commit it fully.
> We now have two options for installing our classes
> 
> --enable-glibj
> installs glibj.zip (enabled by default)
> 
> --enable-class-install
> installs all classes as separate files as needed by jamvm and sablevm 
> (disabled by default)
> 
> Both options are indepedently from each other. You can even disable both 
> options but this does not make really sense.
> 
> I'm not really satisfied with the name "--enable-class-install". If 
> someone finds a better name please shout at me.

Michael I thought this logic was already in lib/Makefile.am anyway
without the extra config option?  Maybe that was an old version I was
thinking about.

Brian


signature.asc
Description: This is a digitally signed message part
___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Re: Support for installation of glibj.zip and separate class files

2004-04-09 Thread Thomas
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Perhaps a better interface (more intuitive) would be something like this:
- --enable-install=[both|classes|zip]



On Thursday 08 April 2004 22:36, Michael Koch wrote:
> Hi all,
>
>
>
> With my big NIO commit I accidently commited the first part (the parts
> in configure.ac) for this patch and so I decided to commit it fully.
> We now have two options for installing our classes
>
> --enable-glibj
> installs glibj.zip (enabled by default)
>
> --enable-class-install
> installs all classes as separate files as needed by jamvm and sablevm
> (disabled by default)
>
> Both options are indepedently from each other. You can even disable both
> options but this does not make really sense.
>
> I'm not really satisfied with the name "--enable-class-install". If
> someone finds a better name please shout at me.
>
>
> Michael
>
>
>
> ___
> Classpath mailing list
> [EMAIL PROTECTED]
> http://mail.gnu.org/mailman/listinfo/classpath

- -- 
Regards
Thomas
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQFAdkvMCojCW6H2z/QRAmqSAJ4tYJtHMT+pXXaO5Orm7QWBeKoLQQCgtcWu
K56xK+ssGRlT2ONCqXur0fA=
=YVXS
-END PGP SIGNATURE-


___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath


Support for installation of glibj.zip and separate class files

2004-04-08 Thread Michael Koch
Hi all, 



With my big NIO commit I accidently commited the first part (the parts 
in configure.ac) for this patch and so I decided to commit it fully.
We now have two options for installing our classes

--enable-glibj
installs glibj.zip (enabled by default)

--enable-class-install
installs all classes as separate files as needed by jamvm and sablevm 
(disabled by default)

Both options are indepedently from each other. You can even disable both 
options but this does not make really sense.

I'm not really satisfied with the name "--enable-class-install". If 
someone finds a better name please shout at me.


Michael



___
Classpath mailing list
[EMAIL PROTECTED]
http://mail.gnu.org/mailman/listinfo/classpath