[cp-patches] FYI: reversal of reversed

[Dalibor Topic]

Hi all,

as discussed on IRC with tromey, I've applied the attached patch.

cheers,
dalibor topic

2008-01-25  Dalibor Topic  [EMAIL PROTECTED]

* tools/gnu/classpath/tools/native2ascii/Native2ASCII.java
(createParser): Removed unused reversed misspelling. Use
Native2ASCII.ReverseHelp instead of Native2ASCII.ReversedHelp.

* resource/gnu/classpath/tools/native2ascii/messages.properties
(Native2ASCII.ReverseHelp): New, renamed from ...
(Native2ASCII.ReversedHelp): Removed.
(Native2ASCII.ReversedHelpCompat): Removed.
Index: resource/gnu/classpath/tools/native2ascii/messages.properties
===
RCS file: /sources/classpath/classpath/resource/gnu/classpath/tools/native2ascii/messages.properties,v
retrieving revision 1.2
diff -u -p -r1.2 messages.properties
--- resource/gnu/classpath/tools/native2ascii/messages.properties	24 Jan 2008 18:28:42 -	1.2
+++ resource/gnu/classpath/tools/native2ascii/messages.properties	25 Jan 2008 19:17:23 -
@@ -40,5 +40,5 @@ Native2ASCII.Usage=Usage: native2ascii [
 Native2ASCII.EncodingHelp=encoding to use
 Native2ASCII.EncodingArgName=NAME
 Native2ASCII.EncodingSpecified=encoding already specified
-Native2ASCII.ReversedHelp=convert from encoding to native
-Native2ASCII.ReversedHelpCompat=alias for -reverse (deprecated)
+Native2ASCII.ReverseHelp=convert from encoding to native
+
Index: tools/gnu/classpath/tools/native2ascii/Native2ASCII.java
===
RCS file: /sources/classpath/classpath/tools/gnu/classpath/tools/native2ascii/Native2ASCII.java,v
retrieving revision 1.6
diff -u -p -r1.6 Native2ASCII.java
--- tools/gnu/classpath/tools/native2ascii/Native2ASCII.java	24 Jan 2008 18:28:42 -	1.6
+++ tools/gnu/classpath/tools/native2ascii/Native2ASCII.java	25 Jan 2008 19:17:23 -
@@ -101,17 +101,7 @@ public class Native2ASCII
 encoding = argument;
   }
 });
-result.add(new Option(reverse, Messages.getString(Native2ASCII.ReversedHelp)) //$NON-NLS-1$ //$NON-NLS-2$
-{
-  public void parsed(String argument) throws OptionException
-  {
-reversed = true;
-  }
-});
-
-// We mistakenly added the extra d in reversed; now we don't
-// want to remove it, for backward compatibility.
-result.add(new Option(reversed, Messages.getString(Native2ASCII.ReversedHelpCompat)) //$NON-NLS-1$ //$NON-NLS-2$
+result.add(new Option(reverse, Messages.getString(Native2ASCII.ReverseHelp)) //$NON-NLS-1$ //$NON-NLS-2$
 {
   public void parsed(String argument) throws OptionException
   {

Re: [cp-patches] RFC: adding -reverse to gnative2ascii

[Mario Torre]

Il giorno ven, 25/01/2008 alle 15.06 -0700, Tom Tromey ha scritto:
  Mario == Mario Torre [EMAIL PROTECTED] writes:
 
 Mario This patch adds the -reverse option to gnative2ascii as described here:
 Mario http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=103
 
 Mario Mark told me that Tom Tromey is already working on it too, so feel free
 Mario to ignore this one.
 
 Sorry about this overlap btw -- I didn't realize you were doing it,
 and I'd emailed before reading the list.
 
 Tom

Oh, no!!

My fault. I was reading the bugzilla lists, and fixed this as I thought
it was a one minute job, then I asked to Mark on IRC if he was working
on this one, and he said that you probably were doing it already... I
decide to post on list just in case. :)

Cheers,
Mario
-- 
Lima Software - http://www.limasoftware.net/
GNU Classpath Developer - http://www.classpath.org/
Fedora Ambassador - http://fedoraproject.org/wiki/MarioTorre
Jabber: [EMAIL PROTECTED]
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

Please, support open standards:
http://opendocumentfellowship.org/petition/
http://www.nosoftwarepatents.com/


signature.asc
Description: Questa è una parte del messaggio	firmata digitalmente

Re: [cp-patches] RFC: adding -reverse to gnative2ascii

[Tom Tromey]

 Mario == Mario Torre [EMAIL PROTECTED] writes:

Mario This patch adds the -reverse option to gnative2ascii as described here:
Mario http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=103

Mario Mark told me that Tom Tromey is already working on it too, so feel free
Mario to ignore this one.

Sorry about this overlap btw -- I didn't realize you were doing it,
and I'd emailed before reading the list.

Tom