Re: [cp-patches] RFC: add generated serialUID

2006-03-09 Thread Arnaud Vandyck
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Mark Wielaard wrote:
> Hi Arnaud,

Hi Mark,

> On Wed, 2006-03-08 at 13:46 +0100, Arnaud Vandyck wrote:
> 
>>While playing with Eclipse and Classpath, I added some generated
>>serialUID (warnings: 3586 -> 3543). Here is the changelog:
>>
>>2006-03-08  Arnaud Vandyck  <[EMAIL PROTECTED]>
>>
>>  * examples/gnu/classpath/examples/awt/Demo.java,
[...]
>>  added generated (by Eclipse) serial version UID.
> 
> I am not sure this actually helps much. This makes the examples
> serializable between different versions (since they now have a fixed
> serialVersionUID). But that means we should track the serialization
> representation between versions and I am not sure we actually want that.

I did it as a test on the Demo classes. But I can:
1° make a (very huge) patch to add serialUID to all the classes that
need it;

2° make a one line patch to the .classpath Eclipse configuration file so
Eclipse will just ignore the +-500 serialUID warnings.

Cheers,

- --
 Arnaud Vandyck
  ,= ,-_-. =.
 ((_/)o o(\_))
  `-'(. .)`-'
  \_/
Java Trap: http://www.gnu.org/philosophy/java-trap.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEEEH84vzFZu62tMIRAnElAJ45vJIAUZGp47y4HSdrrqoORsK81ACgk/kE
50sZ6x+5UVQsyYW2uSySfTs=
=/ERq
-END PGP SIGNATURE-



[cp-patches] RFC: eclipse configuration patch: exclude some resources from source folders

2006-03-09 Thread Arnaud Vandyck
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

This patch remove 27 warnings for me:

2006-03-09  Arnaud Vandyck  <[EMAIL PROTECTED]>

* .classpath: added exclude pattern on source folders
(Makefiles, README and .cvsignore)

- --
 Arnaud Vandyck
  ,= ,-_-. =.
 ((_/)o o(\_))
  `-'(. .)`-'
  \_/
Java Trap: http://www.gnu.org/philosophy/java-trap.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFEECw24vzFZu62tMIRAns8AKCTVAf/HJz2LhT5VyoWbuxX1Ol4pQCgiFoX
VKZz3Gi2YihDf/BMCc0wmL0=
=DnYj
-END PGP SIGNATURE-
Index: ChangeLog
===
RCS file: /sources/classpath/classpath/ChangeLog,v
retrieving revision 1.6661
diff -u -r1.6661 ChangeLog
--- ChangeLog	8 Mar 2006 23:05:25 -	1.6661
+++ ChangeLog	9 Mar 2006 13:21:21 -
@@ -1,3 +1,8 @@
+2006-03-09  Arnaud Vandyck  <[EMAIL PROTECTED]>
+
+	* .classpath: added exclude pattern on source folders
+	(Makefiles, README and .cvsignore)
+
 2006-03-08  Keith Seitz  <[EMAIL PROTECTED]>
 
 	* vm/reference/gnu/classpath/jdwp/VMMethod.java: New file.
Index: .classpath
===
RCS file: /sources/classpath/classpath/.classpath,v
retrieving revision 1.12
diff -u -r1.12 .classpath
--- .classpath	13 Feb 2006 20:36:38 -	1.12
+++ .classpath	9 Mar 2006 13:19:13 -
@@ -1,12 +1,12 @@
 
 
 	
-	
-	
-	
-	
-	
-	
-	
+	
+	
+	
+	
+	
+	
+	
 	
 


[cp-patches] RFC: add generated serialUID

2006-03-08 Thread Arnaud Vandyck
Hi all,

While playing with Eclipse and Classpath, I added some generated
serialUID (warnings: 3586 -> 3543). Here is the changelog:

2006-03-08  Arnaud Vandyck  <[EMAIL PROTECTED]>

* examples/gnu/classpath/examples/awt/Demo.java,
examples/gnu/classpath/examples/datatransfer/Demo.java,
examples/gnu/classpath/examples/jawt/DemoJAWT.java,
examples/gnu/classpath/examples/midi/Demo.java,
examples/gnu/classpath/examples/swing/TextFieldDemo.java,
examples/gnu/classpath/examples/swing/TextAreaDemo.java,
examples/gnu/classpath/examples/swing/Demo.java,
examples/gnu/classpath/examples/swing/TableDemo.java,
examples/gnu/classpath/examples/swing/SpinnerDemo.java,
examples/gnu/classpath/examples/swing/SliderDemo.java,
examples/gnu/classpath/examples/swing/ScrollBarDemo.java,
examples/gnu/classpath/examples/swing/ProgressBarDemo.java,
examples/gnu/classpath/examples/swing/MiniDemo.java,
examples/gnu/classpath/examples/swing/GNULookAndFeel.java,
examples/gnu/classpath/examples/swing/FileChooserDemo.java,
examples/gnu/classpath/examples/swing/ComboBoxDemo.java,
examples/gnu/classpath/examples/swing/ButtonDemo.java:
added generated (by Eclipse) serial version UID.

Do I do this on other classes?

-- 
 Arnaud Vandyck
  ,= ,-_-. =.
 ((_/)o o(\_))
  `-'(. .)`-'
  \_/
Java Trap: http://www.gnu.org/philosophy/java-trap.html
Index: ChangeLog
===
RCS file: /sources/classpath/classpath/ChangeLog,v
retrieving revision 1.6654
diff -u -r1.6654 ChangeLog
--- ChangeLog	8 Mar 2006 08:06:18 -	1.6654
+++ ChangeLog	8 Mar 2006 12:43:21 -
@@ -1,3 +1,24 @@
+2006-03-08  Arnaud Vandyck  <[EMAIL PROTECTED]>
+
+	* examples/gnu/classpath/examples/awt/Demo.java, 
+	examples/gnu/classpath/examples/datatransfer/Demo.java, 
+	examples/gnu/classpath/examples/jawt/DemoJAWT.java, 
+	examples/gnu/classpath/examples/midi/Demo.java, 
+	examples/gnu/classpath/examples/swing/TextFieldDemo.java, 
+	examples/gnu/classpath/examples/swing/TextAreaDemo.java, 
+	examples/gnu/classpath/examples/swing/Demo.java, 
+	examples/gnu/classpath/examples/swing/TableDemo.java, 
+	examples/gnu/classpath/examples/swing/SpinnerDemo.java, 
+	examples/gnu/classpath/examples/swing/SliderDemo.java, 
+	examples/gnu/classpath/examples/swing/ScrollBarDemo.java, 
+	examples/gnu/classpath/examples/swing/ProgressBarDemo.java, 
+	examples/gnu/classpath/examples/swing/MiniDemo.java, 
+	examples/gnu/classpath/examples/swing/GNULookAndFeel.java, 
+	examples/gnu/classpath/examples/swing/FileChooserDemo.java, 
+	examples/gnu/classpath/examples/swing/ComboBoxDemo.java, 
+	examples/gnu/classpath/examples/swing/ButtonDemo.java:
+	added generated (by Eclipse) serial version UID.
+
 2006-03-08  Michael Koch  <[EMAIL PROTECTED]>
 
 	* java/net/InetSocketAddress.java
Index: gnu/classpath/examples/awt/Demo.java
===
RCS file: /sources/classpath/classpath/examples/gnu/classpath/examples/awt/Demo.java,v
retrieving revision 1.4
diff -u -r1.4 Demo.java
--- gnu/classpath/examples/awt/Demo.java	13 Jul 2005 23:22:30 -	1.4
+++ gnu/classpath/examples/awt/Demo.java	8 Mar 2006 12:41:49 -
@@ -41,6 +41,8 @@
   
   static class PrettyPanel extends Panel
   {
+private static final long serialVersionUID = 3054931828195882771L;
+
 Insets myInsets;
 
 public PrettyPanel ()
@@ -85,6 +87,8 @@
 
   static class MainWindow extends PrettyFrame implements ActionListener 
   {
+private static final long serialVersionUID = - 5997452577015233740L;
+
 Button closeButton;
 
 Hashtable windows;
@@ -199,6 +203,8 @@
   
   static class ButtonsWindow extends SubFrame implements ActionListener
   {
+private static final long serialVersionUID = - 6924389825168515514L;
+
 Button b[] = new Button [9];
 
 public void init ()
@@ -257,6 +263,7 @@
   
   static class DialogWindow extends Dialog implements SubWindow
   {
+private static final long serialVersionUID = 4790577114506953621L;
 Label text;
 Frame parent;
 boolean initted = false;
@@ -348,6 +355,7 @@
   
   static class CursorsWindow extends SubFrame implements ItemListener
   {
+private static final long serialVersionUID = 3710112649320693411L;
 Choice cursorChoice;
 Canvas cursorCanvas;
 
@@ -375,7 +383,9 @@
   
   cursorCanvas = new Canvas () 
 	{ 
-	  public void paint (Graphics g) 
+private static final long serialVersionUID = - 4705111784504603742L;
+
+public void paint (Graphics g) 
 	  {
 	Dimension d = this.getSize();
 	g.setColor(Color.white);
@@ -413,6 +423,7 @@
   
   static class TextFieldWindow extends SubFrame implements ItemListener
   {
+private static final long serialVersionUID = 3711337364602449661L;
 Checkbox editable, visible,

Re: [cp-patches] RFC: Datatypes library

2006-02-02 Thread Arnaud Vandyck
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Chris Burdess wrote:
> This patch adds the RELAX NG pluggable datatypes library to  Classpath.
> This API, and an implementation of it, will be used by the  W3C XML
> Schema and RELAX NG JAXP validators currently in development.
[...]
> Please let me know how you feel about this.

I feel supergood :-D thanks Chris ;-)

- --
 Arnaud Vandyck
  ,= ,-_-. =.
 ((_/)o o(\_))
  `-'(. .)`-'
  \_/
Java Trap: http://www.gnu.org/philosophy/java-trap.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFD4gSA4vzFZu62tMIRAtTUAJ9BT4H9x/8vSdWcdT5nLr518vnVIwCgoXxm
RC8lqdaJbxOjLyYAgnxFw/Y=
=7ljt
-END PGP SIGNATURE-



Re: [cp-patches] Jumbo XSLT patch for 0.20

2006-01-12 Thread Arnaud Vandyck
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Chris Burdess wrote:
> I'm committing the following patch which resolves a number of XSLT  and
> XPath processing issues.
[...]
> This raises our XSLT conformance against the OASIS tests from 68.9%  to
> 74.8%.

Excellent! With the new xml patches, what is the score of the xml tests?

Great job, many thanks Chris!

- --
 Arnaud Vandyck
  ,= ,-_-. =.
 ((_/)o o(\_))
  `-'(. .)`-'
  \_/
Java Trap: http://www.gnu.org/philosophy/java-trap.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDxk0r4vzFZu62tMIRAph9AJ9tdsZ4ywG8rgs7HCHIiG0LO2YZhwCfd3vM
A1hAOEYr0GRkhWaDf1gq9q4=
=6p4L
-END PGP SIGNATURE-


___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches