Re: [cp-patches] [RFC/PATCH] Check for gettext m4 macros in autogen.sh
On Tue, 2013-03-12 at 22:27 -0400, Brian Jones wrote: I'm sorry I'm not a good one to review this. They changed the auto* tools quite a bit since I used to mess with them. Is autogen.sh something auto* creates, just wondering if it is okay to modify... Yes it is fine. We provide autogen.sh. These days for a new project one would probably use autoreconf provided by autoconf. But that didn't exist when we introduced our own autogen.sh script. Cheers, Mark
Re: [cp-patches] [RFC/PATCH] Check for gettext m4 macros in autogen.sh
- Original Message - On Tue, 2013-03-12 at 22:27 -0400, Brian Jones wrote: I'm sorry I'm not a good one to review this. They changed the auto* tools quite a bit since I used to mess with them. Is autogen.sh something auto* creates, just wondering if it is okay to modify... Yes it is fine. We provide autogen.sh. These days for a new project one would probably use autoreconf provided by autoconf. But that didn't exist when we introduced our own autogen.sh script. Our script does use autoreconf among other things. It's for developers working with the repository to generate the necessary autotools files that would be included in a distribution tarball. The change looks fine, Pekka. Cheers, Mark -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
[cp-patches] [RFC/PATCH] Check for gettext m4 macros in autogen.sh
If gettext-devel package is not installed on Fedora, autogen.sh fails as follows: [penberg@tux classpath]$ sh autogen.sh configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... Make the script more user fiendly by explicitly checking for the presence of gettext.m4 in the system. Cc: Andrew John Hughes gnu_and...@member.fsf.org Cc: Brian Jones cbjon...@gmail.com Signed-off-by: Pekka Enberg penb...@kernel.org --- ChangeLog |5 + autogen.sh |7 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 289a979..e26f627 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-03-12 Pekka Enberg penb...@kernel.org + + * autogen.sh: + Check that gettext.m4 is installed. + 2013-03-09 Pekka Enberg penb...@kernel.org * .gitignore: Exclude autogen-generated files. diff --git a/autogen.sh b/autogen.sh index adb8f0c..df0095f 100755 --- a/autogen.sh +++ b/autogen.sh @@ -34,6 +34,13 @@ if $have_libtool ; then : ; else DIE=1 fi +if [ ! -e $(aclocal --print-ac-dir)/gettext.m4 ] ; then + echo + echo You must have gettext package and, if applicable to your + echo system, gettext-devel package installed to compile $PROJECT. + DIE=1 +fi + if test $DIE -eq 1; then exit 1 fi -- 1.7.7.6
Re: [cp-patches] [RFC/PATCH] Check for gettext m4 macros in autogen.sh
I'm sorry I'm not a good one to review this. They changed the auto* tools quite a bit since I used to mess with them. Is autogen.sh something auto* creates, just wondering if it is okay to modify... On Tue, Mar 12, 2013 at 2:47 PM, Pekka Enberg penb...@kernel.org wrote: If gettext-devel package is not installed on Fedora, autogen.sh fails as follows: [penberg@tux classpath]$ sh autogen.sh configure.ac:505: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd m4/iconv.m4:11: AM_ICONV_LINKFLAGS_BODY is expanded from... m4/iconv.m4:22: AM_ICONV_LINK is expanded from... m4/iconv.m4:77: AM_ICONV is expanded from... Make the script more user fiendly by explicitly checking for the presence of gettext.m4 in the system. Cc: Andrew John Hughes gnu_and...@member.fsf.org Cc: Brian Jones cbjon...@gmail.com Signed-off-by: Pekka Enberg penb...@kernel.org --- ChangeLog |5 + autogen.sh |7 +++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 289a979..e26f627 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2013-03-12 Pekka Enberg penb...@kernel.org + + * autogen.sh: + Check that gettext.m4 is installed. + 2013-03-09 Pekka Enberg penb...@kernel.org * .gitignore: Exclude autogen-generated files. diff --git a/autogen.sh b/autogen.sh index adb8f0c..df0095f 100755 --- a/autogen.sh +++ b/autogen.sh @@ -34,6 +34,13 @@ if $have_libtool ; then : ; else DIE=1 fi +if [ ! -e $(aclocal --print-ac-dir)/gettext.m4 ] ; then + echo + echo You must have gettext package and, if applicable to your + echo system, gettext-devel package installed to compile $PROJECT. + DIE=1 +fi + if test $DIE -eq 1; then exit 1 fi -- 1.7.7.6
