Re: [cp-patches] Cleanup: const correctnes in native code

[Andrew John Hughes]

On 09/01/2008, Stefan Huehner <[EMAIL PROTECTED]> wrote:
> Remove some casts which discard the const from strings when not needed.
> Found by compiling with -Wwrite-strings and -Wcast-qual
>
> 2008-01-09  Stefan Huehner 
>
> native/jni/java-io/java_io_VMObjectStreamClass.c,
> native/jni/java-lang/java_lang_VMDouble.c,
> native/jni/java-net/java_net_VMInetAddress.c:
> don't discard const by casting (const char *) to
> (char *) when it's not needed.
>
>

Committed.
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

Re: [cp-patches] Cleanup: const correctnes in native code

[Dalibor Topic]

Stefan Huehner schrieb:

Remove some casts which discard the const from strings when not needed.
Found by compiling with -Wwrite-strings and -Wcast-qual

2008-01-09  Stefan Huehner   


native/jni/java-io/java_io_VMObjectStreamClass.c,
native/jni/java-lang/java_lang_VMDouble.c,
native/jni/java-net/java_net_VMInetAddress.c:
don't discard const by casting (const char *) to
(char *) when it's not needed.
  

looks fine to me, too.

cheers,
dalibor topic

[cp-patches] Cleanup: const correctnes in native code

[Stefan Huehner]

Remove some casts which discard the const from strings when not needed.
Found by compiling with -Wwrite-strings and -Wcast-qual

2008-01-09  Stefan Huehner   


native/jni/java-io/java_io_VMObjectStreamClass.c,
native/jni/java-lang/java_lang_VMDouble.c,
native/jni/java-net/java_net_VMInetAddress.c:
don't discard const by casting (const char *) to
(char *) when it's not needed.
Index: native/jni/java-io/java_io_VMObjectStreamClass.c
===
RCS file: /sources/classpath/classpath/native/jni/java-io/java_io_VMObjectStreamClass.c,v
retrieving revision 1.13
diff -u -r1.13 java_io_VMObjectStreamClass.c
--- native/jni/java-io/java_io_VMObjectStreamClass.c	25 Jan 2006 10:40:12 -	1.13
+++ native/jni/java-io/java_io_VMObjectStreamClass.c	9 Jan 2008 20:46:46 -
@@ -175,7 +175,7 @@
* If it isn't an array class then the actual field type descriptor
* starts with 'L', ends with ';' and has '/' instead of '.'.
*/
-  type_len = strlen ((char *) type_name);
+  type_len = strlen (type_name);
   if (type_name[0] != '[')
 	{
 	  /* XXX - FIXME - should not use dynamic allocation in core lib. */
Index: native/jni/java-lang/java_lang_VMDouble.c
===
RCS file: /sources/classpath/classpath/native/jni/java-lang/java_lang_VMDouble.c,v
retrieving revision 1.17
diff -u -r1.17 java_lang_VMDouble.c
--- native/jni/java-lang/java_lang_VMDouble.c	5 Apr 2007 12:41:34 -	1.17
+++ native/jni/java-lang/java_lang_VMDouble.c	9 Jan 2008 20:46:47 -
@@ -468,7 +468,7 @@
   return val;
 }
 
-  buf = (char *) (*env)->GetStringUTFChars (env, str, &isCopy);
+  buf = (*env)->GetStringUTFChars (env, str, &isCopy);
   if (buf == NULL)
 {
   /* OutOfMemoryError already thrown */
Index: native/jni/java-net/java_net_VMInetAddress.c
===
RCS file: /sources/classpath/classpath/native/jni/java-net/java_net_VMInetAddress.c,v
retrieving revision 1.10
diff -u -r1.10 java_net_VMInetAddress.c
--- native/jni/java-net/java_net_VMInetAddress.c	25 Jun 2007 00:05:33 -	1.10
+++ native/jni/java-net/java_net_VMInetAddress.c	9 Jan 2008 20:46:47 -
@@ -225,7 +225,7 @@
   result = cpnet_getHostByName (env, hostname, &addresses, &addresses_count);
   if (result != CPNATIVE_OK || addresses_count == 0)
 {
-  JCL_ThrowException (env, UNKNOWN_HOST_EXCEPTION, (char *) hostname);
+  JCL_ThrowException (env, UNKNOWN_HOST_EXCEPTION, hostname);
   return (jobjectArray) NULL;
 }
   (*env)->ReleaseStringUTFChars (env, host, hostname);