Re: [cp-patches] RFA: Eclipse cleanup

2006-11-27 Thread Tom Tromey
 Francis == Francis Kung [EMAIL PROTECTED] writes:

Francis I'd like to make the following two changes to the Eclipse settings
Francis files:

I didn't see a response to this.
I think it is ok.

Tom



[cp-patches] RFA: Eclipse cleanup

2006-11-02 Thread Francis Kung
Hi,

I'd like to make the following two changes to the Eclipse settings
files:

1) change default compiler compliance to 1.4, to ensure that we don't
break the build unintentionally (it's happened a few times, where code
acceptable in 1.5 is an error in 1.4... especially with the clone()
method)

2) add sun.* classes into the jar (this is in the makefile so it already
happens when compiling from command-line, but not from eclipse).

Is this OK?

Thanks,
Francis

Index: .settings/org.eclipse.jdt.core.prefs
===
RCS file: /cvsroot/classpath/classpath/.settings/org.eclipse.jdt.core.prefs,v
retrieving revision 1.7
diff -u -r1.7 org.eclipse.jdt.core.prefs
--- .settings/org.eclipse.jdt.core.prefs	15 Mar 2006 21:33:58 -	1.7
+++ .settings/org.eclipse.jdt.core.prefs	2 Nov 2006 21:20:01 -
@@ -1,9 +1,9 @@
-#Wed Mar 15 14:23:07 MST 2006
+#Wed Sep 13 11:41:02 EDT 2006
 eclipse.preferences.version=1
 org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
 org.eclipse.jdt.core.compiler.codegen.targetPlatform=1.4
 org.eclipse.jdt.core.compiler.codegen.unusedLocal=preserve
-org.eclipse.jdt.core.compiler.compliance=1.5
+org.eclipse.jdt.core.compiler.compliance=1.4
 org.eclipse.jdt.core.compiler.debug.lineNumber=generate
 org.eclipse.jdt.core.compiler.debug.localVariable=generate
 org.eclipse.jdt.core.compiler.debug.sourceFile=generate
Index: .externalToolBuilders/ClasspathJar.launch
===
RCS file: /cvsroot/classpath/classpath/.externalToolBuilders/ClasspathJar.launch,v
retrieving revision 1.1
diff -u -r1.1 ClasspathJar.launch
--- .externalToolBuilders/ClasspathJar.launch	22 Dec 2005 19:23:19 -	1.1
+++ .externalToolBuilders/ClasspathJar.launch	2 Nov 2006 21:20:01 -
@@ -1,8 +1,8 @@
 ?xml version=1.0 encoding=UTF-8?
 launchConfiguration type=org.eclipse.ui.externaltools.ProgramBuilderLaunchConfigurationType
 booleanAttribute key=org.eclipse.debug.ui.ATTR_LAUNCH_IN_BACKGROUND value=true/
-stringAttribute key=org.eclipse.ui.externaltools.ATTR_BUILD_SCOPE value=${working_set:lt;?xml version=quot;1.0quot; encoding=quot;UTF-8quot;?gt;#10;lt;launchConfigurationWorkingSet factoryID=quot;org.eclipse.ui.internal.WorkingSetFactoryquot; name=quot;workingSetquot;gt;#10;lt;item factoryID=quot;org.eclipse.ui.internal.model.ResourceFactoryquot; path=quot;/classpath/install/share/classpathquot; type=quot;2quot;/gt;#10;lt;/launchConfigurationWorkingSetgt;}/
-stringAttribute key=org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS value=-cf glibj.zip META-INF java gnu org javax vm/
+stringAttribute key=org.eclipse.ui.externaltools.ATTR_BUILD_SCOPE value=${working_set:lt;?xml version=quot;1.0quot; encoding=quot;UTF-8quot;?gt;#10;lt;launchConfigurationWorkingSet editPageId=quot;org.eclipse.ui.resourceWorkingSetPagequot; factoryID=quot;org.eclipse.ui.internal.WorkingSetFactoryquot; label=quot;workingSetquot; name=quot;workingSetquot;gt;#10;lt;item factoryID=quot;org.eclipse.ui.internal.model.ResourceFactoryquot; path=quot;/classpath/install/share/classpathquot; type=quot;2quot;/gt;#10;lt;/launchConfigurationWorkingSetgt;}/
+stringAttribute key=org.eclipse.ui.externaltools.ATTR_TOOL_ARGUMENTS value=-cf glibj.zip META-INF java gnu org javax vm sun/
 stringAttribute key=org.eclipse.ui.externaltools.ATTR_RUN_BUILD_KINDS value=full,incremental,auto,/
 stringAttribute key=org.eclipse.ui.externaltools.ATTR_WORKING_DIRECTORY value=${build_project:install/share/classpath}/
 stringAttribute key=org.eclipse.ui.externaltools.ATTR_LOCATION value=${system_path:jar}/