Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-26 Thread Mark Wielaard
[This message also never made it to the list.
 Sorry for the duplicate Christian.]

Hi Christian,

On Thu, 2005-11-24 at 13:11 +0100, Christian Thalinger wrote:
 Found this one with statcvs, ok?

 2005-11-24  Christian Thalinger  [EMAIL PROTECTED]
 
 * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c 
 (save_to_stream): Added missing DeleteLocalRef call.

Yes, please.

Thanks,

Mark



___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches


Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-25 Thread Christian Thalinger
On Thu, 2005-11-24 at 17:31 +0100, Mark Wielaard wrote:
 Yes, please.

Commited.

TWISTI



___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches


Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-24 Thread Christian Thalinger
Hi!

Found this one with statcvs, ok?

TWISTI


2005-11-24  Christian Thalinger  [EMAIL PROTECTED]

* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c 
(save_to_stream): Added missing DeleteLocalRef call.


Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
===
RCS file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c,v
retrieving revision 1.20
diff -u -3 -p -r1.20 gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c22 Nov 
2005 20:41:06 -  1.20
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c24 Nov 
2005 12:09:52 -
@@ -378,6 +378,7 @@ save_to_stream(const gchar *buf,
   (*(ssr-env))-ReleaseByteArrayElements ((ssr-env), jbuf, cbuf, 0);
   (*(ssr-env))-CallVoidMethod ((ssr-env), *(ssr-stream), 
 dataOutputWriteID, jbuf);  
+  (*(ssr-env))-DeleteLocalRef((ssr-env), jbuf);
 
   gdk_threads_enter ();
 




___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches


Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Christian Thalinger
This one i found with jaha
(http://www.cs.helsinki.fi/u/abrax/HACK/JAVA/JAHA.html).

TWISTI


Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
===
RCS file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c,v
retrieving revision 1.19
diff -u -3 -p -r1.19 gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c18 Aug 
2005 01:22:00 -  1.19
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c22 Nov 
2005 00:16:51 -
@@ -270,6 +270,8 @@ query_formats (JNIEnv *env, jclass clazz
  (*env)-DeleteLocalRef(env, string);
  ++ch;
}
+
+  (*env)-DeleteLocalRef(env, jformat);
 }
   
   g_slist_free(formats);  




___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches


Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Mark Wielaard
Hi Christian,

On Tue, 2005-11-22 at 11:14 +0100, Christian Thalinger wrote:
 This one i found with jaha
 (http://www.cs.helsinki.fi/u/abrax/HACK/JAVA/JAHA.html).

 --- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c18 
 Aug 2005 01:22:00 -  1.19
 +++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c22 
 Nov 2005 00:16:51 -
 @@ -270,6 +270,8 @@ query_formats (JNIEnv *env, jclass clazz
   (*env)-DeleteLocalRef(env, string);
   ++ch;
 }
 +
 +  (*env)-DeleteLocalRef(env, jformat);
  }

Also looks fine to me.

Thanks,

Mark


signature.asc
Description: This is a digitally signed message part
___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches


Re: [cp-patches] RFC: some missing DeleteLocalRef patches

2005-11-22 Thread Christian Thalinger
Ok, next time i'll send immediately a changelog.  These are commited.

TWISTI


2005-11-22  Christian Thalinger  [EMAIL PROTECTED]

* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c
(nativeGetFontFamilies): Added missing DeleteLocalRef calls.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
(query_formats): Likewise.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c 
(append): Likewise.
* native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c 
(append): Likewise.
* native/jni/qt-peer/qtmenupeer.cpp (runEvent): Likewise.


Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c
===
RCS file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c,v
retrieving revision 1.4
diff -u -3 -p -r1.4 gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c
11 Jul 2005 23:27:43 -  1.4
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkGraphicsEnvironment.c
21 Nov 2005 23:13:17 -
@@ -71,6 +71,7 @@ Java_gnu_java_awt_peer_gtk_GdkGraphicsEn
   const char *name_tmp =  pango_font_family_get_name
(families[idx]);
   jstring name = (*env)-NewStringUTF (env, name_tmp);
   (*env)-SetObjectArrayElement (env, family_name, idx, name);
+  (*env)-DeleteLocalRef(env, name);
 }
   g_free (families);
 
Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c
===
RCS
file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c,v
retrieving revision 1.19
diff -u -3 -p -r1.19 gnu_java_awt_peer_gtk_GtkChoicePeer.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c   25 Aug
2005 02:26:50 -  1.19
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkChoicePeer.c   21 Nov
2005 23:13:17 -
@@ -121,6 +121,7 @@ Java_gnu_java_awt_peer_gtk_GtkChoicePeer
   gtk_combo_box_append_text (GTK_COMBO_BOX (ptr), label);
 
   (*env)-ReleaseStringUTFChars (env, item, label);
+  (*env)-DeleteLocalRef(env, item);
 }
 
   gdk_threads_leave ();
Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c
===
RCS
file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c,v
retrieving revision 1.22
diff -u -3 -p -r1.22 gnu_java_awt_peer_gtk_GtkListPeer.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c 18 Aug
2005 03:15:15 -  1.22
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkListPeer.c 21 Nov
2005 23:13:17 -
@@ -239,6 +239,7 @@ Java_gnu_java_awt_peer_gtk_GtkListPeer_a
   COLUMN_STRING, text,
   -1);
   (*env)-ReleaseStringUTFChars (env, item, text);
+  (*env)-DeleteLocalRef(env, item);
 }
 
   gdk_threads_leave ();
Index: native/jni/qt-peer/qtmenupeer.cpp
===
RCS
file: /cvsroot/classpath/classpath/native/jni/qt-peer/qtmenupeer.cpp,v
retrieving revision 1.4
diff -u -3 -p -r1.4 qtmenupeer.cpp
--- native/jni/qt-peer/qtmenupeer.cpp   23 Aug 2005 02:13:48 -
1.4
+++ native/jni/qt-peer/qtmenupeer.cpp   21 Nov 2005 23:13:41 -
@@ -125,6 +125,7 @@ public:
 
 jclass menuCls = env-GetObjectClass( menuPeer );
 jmethodID mid = env-GetMethodID(menuCls, add, (J)V);
+env-DeleteLocalRef(menuCls);
 env-CallVoidMethod( menuPeer, mid, (jlong)newAction );
 
 env-DeleteGlobalRef( menuPeer );
Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
===
RCS
file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c,v
retrieving revision 1.19
diff -u -3 -p -r1.19 gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
18 Aug 2005 01:22:00 -  1.19
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GdkPixbufDecoder.c
22 Nov 2005 00:16:51 -
@@ -270,6 +270,8 @@ query_formats (JNIEnv *env, jclass clazz
  (*env)-DeleteLocalRef(env, string);
  ++ch;
}
+
+  (*env)-DeleteLocalRef(env, jformat);
 }
   
   g_slist_free(formats);  




___
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches