Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored [v3]
On Thu, 16 May 2024 04:27:25 GMT, Sergey Bylokhov wrote: >> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and >> verify that the cmm id of the icc profile is properly reported. Before >> JDK-8321489 we always report 'lcms' as a cmm id. > > Sergey Bylokhov has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8331746 > - Update CustomCMMID.java > - Update CustomCMMID.java > - 8331746: Create a test to verify that the cmm id is not ignored Marked as reviewed by dmarkov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19110#pullrequestreview-2061429810
Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored [v3]
On Thu, 16 May 2024 04:27:25 GMT, Sergey Bylokhov wrote: >> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and >> verify that the cmm id of the icc profile is properly reported. Before >> JDK-8321489 we always report 'lcms' as a cmm id. > > Sergey Bylokhov has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8331746 > - Update CustomCMMID.java > - Update CustomCMMID.java > - 8331746: Create a test to verify that the cmm id is not ignored Marked as reviewed by aivanov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19110#pullrequestreview-2060639298
Re: RFR: 8331746: Create a test to verify that the cmm id is not ignored [v3]
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and > verify that the cmm id of the icc profile is properly reported. Before > JDK-8321489 we always report 'lcms' as a cmm id. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8331746 - Update CustomCMMID.java - Update CustomCMMID.java - 8331746: Create a test to verify that the cmm id is not ignored - Changes: - all: https://git.openjdk.org/jdk/pull/19110/files - new: https://git.openjdk.org/jdk/pull/19110/files/6bfb2cb8..c6109b3d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=19110=02 - incr: https://webrevs.openjdk.org/?repo=jdk=19110=01-02 Stats: 24165 lines in 537 files changed: 13082 ins; 7446 del; 3637 mod Patch: https://git.openjdk.org/jdk/pull/19110.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19110/head:pull/19110 PR: https://git.openjdk.org/jdk/pull/19110
